firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable an inaccurate test assertion that will be fixed by an engine roll (#119653)

Browse Source 
https://skia-review.googlesource.com/c/skia/+/619838 fixes a bug in
SkParagraph.  One of the selectable region tests relies on the old
behavior.

After that Skia change rolls into the framework, the update to the test
in https://github.com/flutter/flutter/pull/118902 should be landed.
This commit is contained in:
Jason Simmons 2023-01-31 14:17:43 -08:00 committed by GitHub
parent 60c1f293dc
commit fbe9ff33e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/flutter/test/widgets/selectable_region_test.dart
View File

@ -842,7 +842,8 @@ void main() {
// Add a little offset to cross the boundary between paragraph 2 and 3. // Add a little offset to cross the boundary between paragraph 2 and 3.
await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1)); await gesture.moveTo(textOffsetToPosition(paragraph3, 6) + const Offset(0, 1));
expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12)); expect(paragraph1.selections[0], const TextSelection(baseOffset: 2, extentOffset: 12));
expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8)); // TODO(jsimmons): reenable this with updated expectations after https://skia-review.googlesource.com/c/skia/+/619838 lands
//expect(paragraph2.selections[0], const TextSelection(baseOffset: 0, extentOffset: 8));
expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6)); expect(paragraph3.selections[0], const TextSelection(baseOffset: 0, extentOffset: 6));
await gesture.up(); await gesture.up();