Pass --no-dds to some integration tests driven by flutter drive (#152898)
As in https://github.com/flutter/flutter/pull/152696, It's not clear that DDS initialization is necessary for any of these tests. In particular, from the comments on the tool flag: ``` 'It may be necessary to disable this when attaching to an application with ' 'an existing DDS instance (e.g., attaching to an application currently ' 'connected to by "flutter run"), or when running certain tests.\n' 'Disabling this feature may degrade IDE functionality if a DDS instance is ' 'not already connected to the target application.' ``` These tests are unlikely to need IDE functionality. I have initially modified the Linux_android_emu tests in the ci.yaml so that they run in presubmit to verify that this change is safe. Many other postsubmit-only tests that will now be passed `--no-dds` require physical devices, and if there is an issue in post-submit, this change will need to be reverted.
This commit is contained in:
parent
3612ba1fce
commit
fc465348b9
@ -478,6 +478,10 @@ List<String> _flutterCommandArgs(String command, List<String> options) {
|
|||||||
'5',
|
'5',
|
||||||
],
|
],
|
||||||
|
|
||||||
|
// DDS should be disabled for flutter drive in CI.
|
||||||
|
// See https://github.com/flutter/flutter/issues/152684.
|
||||||
|
if (command == 'drive') '--no-dds',
|
||||||
|
|
||||||
if (command == 'drive' && hostAgent.dumpDirectory != null) ...<String>[
|
if (command == 'drive' && hostAgent.dumpDirectory != null) ...<String>[
|
||||||
'--screenshot',
|
'--screenshot',
|
||||||
hostAgent.dumpDirectory!.path,
|
hostAgent.dumpDirectory!.path,
|
||||||
|
@ -134,7 +134,6 @@ class GalleryTransitionTest {
|
|||||||
: '${testFile}_test');
|
: '${testFile}_test');
|
||||||
section('DRIVE START');
|
section('DRIVE START');
|
||||||
await flutter('drive', options: <String>[
|
await flutter('drive', options: <String>[
|
||||||
'--no-dds',
|
|
||||||
'--profile',
|
'--profile',
|
||||||
if (enableImpeller != null && enableImpeller!) '--enable-impeller',
|
if (enableImpeller != null && enableImpeller!) '--enable-impeller',
|
||||||
if (enableImpeller != null && !enableImpeller!) '--no-enable-impeller',
|
if (enableImpeller != null && !enableImpeller!) '--no-enable-impeller',
|
||||||
|
@ -1395,7 +1395,6 @@ class PerfTest {
|
|||||||
'--local-engine-src-path',
|
'--local-engine-src-path',
|
||||||
localEngineSrcPath
|
localEngineSrcPath
|
||||||
],
|
],
|
||||||
'--no-dds',
|
|
||||||
'--no-android-gradle-daemon',
|
'--no-android-gradle-daemon',
|
||||||
'-v',
|
'-v',
|
||||||
'--verbose-system-logs',
|
'--verbose-system-logs',
|
||||||
|
Loading…
x
Reference in New Issue
Block a user