firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove LSAN supressions for Linux embedder (flutter/engine#56913)

Browse Source 
Fixes https://github.com/flutter/flutter/issues/90155
This commit is contained in:
Robert Ancell 2024-12-05 11:44:08 +13:00 committed by GitHub
parent 111ba5aae9
commit fd12f3489c
3 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
engine/src/flutter/shell/platform/linux/fl_basic_message_channel_test.cc
View File

@ -43,7 +43,7 @@ TEST(FlBasicMessageChannelTest, SendMessageWithoutResponse) {
g_bytes_new(message->message, message->message_size);
g_autoptr(FlStandardMessageCodec) codec =
fl_standard_message_codec_new();
FlValue* message_value = fl_message_codec_decode_message(
g_autoptr(FlValue) message_value = fl_message_codec_decode_message(
FL_MESSAGE_CODEC(codec), message_bytes, nullptr);
EXPECT_EQ(fl_value_get_type(message_value), FL_VALUE_TYPE_STRING);
EXPECT_STREQ(fl_value_get_string(message_value), "Hello World!");

4
engine/src/flutter/shell/platform/linux/fl_key_event_channel.cc
View File

@ -109,13 +109,13 @@ gboolean fl_key_event_channel_send_finish(GObject* object,
GAsyncResult* result,
gboolean* handled,
GError** error) {
FlValue* message = fl_basic_message_channel_send_finish(
g_autoptr(FlValue) message = fl_basic_message_channel_send_finish(
FL_BASIC_MESSAGE_CHANNEL(object), result, error);
if (message == nullptr) {
return FALSE;
}
g_autoptr(FlValue) handled_value = fl_value_lookup_string(message, "handled");
FlValue* handled_value = fl_value_lookup_string(message, "handled");
*handled = fl_value_get_bool(handled_value);
return TRUE;

6
engine/src/flutter/testing/lsan_suppressions.txt
View File

@ -50,12 +50,6 @@ leak:RefCountedTest_DebugChecks_Test::TestBody
# and allow some tests to inspect contents.
leak:*flutter/shell/platform/linux/testing/mock_engine.cc
# TODO(bdero): Fix FL leaks: https://github.com/flutter/flutter/issues/90155
leak:*flutter/shell/platform/linux/fl_keyboard_handler_test.cc*
leak:*flutter/shell/platform/linux/fl_key_channel_responder_test.cc*
leak:*flutter/shell/platform/linux/fl_basic_message_channel_test.cc*
leak:fl_message_codec_decode_message
# TODO(bdero): https://github.com/flutter/flutter/issues/90156
# Unfortunately, realloc calls originating from g_realloc effectively obscure
# the trace of the original allocation. Deeper investigation is required to