firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix sign (#51679)

Browse Source
This commit is contained in:
LongCatIsLooong 2020-03-02 09:54:02 -08:00 committed by GitHub
parent 96003f91d6
commit fe0a669cc9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/flutter/lib/src/rendering/sliver.dart
View File

@ -859,7 +859,7 @@ class SliverHitTestResult extends HitTestResult {
assert(crossAxisPosition != null);
assert(hitTest != null);
if (paintOffset != null) {
pushTransform(Matrix4.translationValues(paintOffset.dx, paintOffset.dy, 0));
pushTransform(Matrix4.translationValues(-paintOffset.dx, -paintOffset.dy, 0));
}
final bool isHit = hitTest(
this,

30
packages/flutter/test/rendering/slivers_test.dart
View File

@ -921,6 +921,36 @@ void main() {
mainAxisPositions.clear();
crossAxisPositions.clear();
});
test('addWithAxisOffset with non zero paintOffset', () {
final SliverHitTestResult result = SliverHitTestResult();
double recordedMainAxisPosition;
double recordedCrossAxisPosition;
final HitTestEntry entry = HitTestEntry(_DummyHitTestTarget());
const Offset paintOffset = Offset(7, 11);
final bool isHit = result.addWithAxisOffset(
paintOffset: paintOffset,
mainAxisOffset: 5.0,
crossAxisOffset: 6.0,
mainAxisPosition: 10.0,
crossAxisPosition: 20.0,
hitTest: (SliverHitTestResult result, { double mainAxisPosition, double crossAxisPosition }) {
expect(result, isNotNull);
recordedMainAxisPosition = mainAxisPosition;
recordedCrossAxisPosition = crossAxisPosition;
result.add(entry);
return true;
},
);
expect(isHit, isTrue);
expect(recordedMainAxisPosition, 10.0 - 5.0);
expect(recordedCrossAxisPosition, 20.0 - 6.0);
expect(
entry.transform..translate(paintOffset.dx, paintOffset.dy),
Matrix4.identity(),
);
});
});
test('SliverConstraints check for NaN on all double properties', () {