firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add page delays to the fullscreen versions of the textfield perf benchmarks (#107746)

Browse Source
This commit is contained in:
Jim Graham 2022-08-11 12:11:06 -07:00 committed by GitHub
parent 924490da62
commit fe70a2b0f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dev/benchmarks/macrobenchmarks/test/fullscreen_textfield_perf_e2e.dart
View File

@ -12,11 +12,7 @@ void main() {
macroPerfTestE2E( macroPerfTestE2E(
'fullscreen_textfield_perf', 'fullscreen_textfield_perf',
kFullscreenTextRouteName, kFullscreenTextRouteName,
// The driver version doesn't have this delay because the delay caused pageDelay: const Duration(seconds: 1),
// by the communication between the host and the test device is long enough
// for the driver test, but there isn't such delay in this host independent
// test.
pageDelay: const Duration(milliseconds: 50),
body: (WidgetController controller) async { body: (WidgetController controller) async {
final Finder textfield = find.byKey(const ValueKey<String>('fullscreen-textfield')); final Finder textfield = find.byKey(const ValueKey<String>('fullscreen-textfield'));
controller.tap(textfield); controller.tap(textfield);

2
dev/benchmarks/macrobenchmarks/test_driver/fullscreen_textfield_perf_test.dart
View File

@ -11,7 +11,7 @@ void main() {
macroPerfTest( macroPerfTest(
'fullscreen_textfield_perf', 'fullscreen_textfield_perf',
kFullscreenTextRouteName, kFullscreenTextRouteName,
pageDelay: const Duration(milliseconds: 50), pageDelay: const Duration(seconds: 1),
driverOps: (FlutterDriver driver) async { driverOps: (FlutterDriver driver) async {
final SerializableFinder textfield = find.byValueKey('fullscreen-textfield'); final SerializableFinder textfield = find.byValueKey('fullscreen-textfield');
driver.tap(textfield); driver.tap(textfield);