firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[flutter_tools] timeline_test.dart flaky (#116667)

Browse Source 
* contains name instead of remove last

* fix expect

* remove and expect on elements

* delete unused code
This commit is contained in:
Jesús S Guerrero 2023-01-03 14:44:53 -06:00 committed by GitHub
parent 64e733647f
commit fe8dcf6631
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/flutter_tools/test/integration.shard/timeline_test.dart
View File

@ -96,7 +96,15 @@ void main() {
// The downloaded part of the timeline may contain an end event whose // The downloaded part of the timeline may contain an end event whose
// corresponding begin event happened before the start of the timeline. // corresponding begin event happened before the start of the timeline.
if (stack.isNotEmpty) { if (stack.isNotEmpty) {
expect(stack.removeLast(), name); bool pass = false;
while (stack.isNotEmpty) {
final String value = stack.removeLast();
if (value == name) {
pass = true;
break;
}
}
expect(pass, true);
} }
} }
} }