firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

separatorBuilder can't return null (#119566)

Browse Source 
...so remove the assert
This commit is contained in:
Ian Hickson 2023-01-31 12:23:02 -08:00 committed by GitHub
parent 0e22aca785
commit ff22813b77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/flutter/lib/src/widgets/scroll_view.dart
View File

@ -1257,26 +1257,17 @@ class ListView extends BoxScrollView {
childrenDelegate = SliverChildBuilderDelegate( childrenDelegate = SliverChildBuilderDelegate(
(BuildContext context, int index) { (BuildContext context, int index) {
final int itemIndex = index ~/ 2; final int itemIndex = index ~/ 2;
final Widget? widget;
if (index.isEven) { if (index.isEven) {
widget = itemBuilder(context, itemIndex); return itemBuilder(context, itemIndex);
} else {
widget = separatorBuilder(context, itemIndex);
assert(() {
if (widget == null) {
throw FlutterError('separatorBuilder cannot return null.');
} }
return true; return separatorBuilder(context, itemIndex);
}());
}
return widget;
}, },
findChildIndexCallback: findChildIndexCallback, findChildIndexCallback: findChildIndexCallback,
childCount: _computeActualChildCount(itemCount), childCount: _computeActualChildCount(itemCount),
addAutomaticKeepAlives: addAutomaticKeepAlives, addAutomaticKeepAlives: addAutomaticKeepAlives,
addRepaintBoundaries: addRepaintBoundaries, addRepaintBoundaries: addRepaintBoundaries,
addSemanticIndexes: addSemanticIndexes, addSemanticIndexes: addSemanticIndexes,
semanticIndexCallback: (Widget _, int index) { semanticIndexCallback: (Widget widget, int index) {
return index.isEven ? index ~/ 2 : null; return index.isEven ? index ~/ 2 : null;
}, },
), ),