From ff45d50655735142e5f7990dd8a954fba4ba9b41 Mon Sep 17 00:00:00 2001 From: Todd Volkert Date: Sun, 24 Sep 2017 13:21:28 -0700 Subject: [PATCH] Remove explicit width in ListTile trailing element (#12221) It was incorrectly added in #11858 --- packages/flutter/lib/src/material/list_tile.dart | 1 - packages/flutter/test/material/list_tile_test.dart | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/flutter/lib/src/material/list_tile.dart b/packages/flutter/lib/src/material/list_tile.dart index 8360490a2b..0389559bfd 100644 --- a/packages/flutter/lib/src/material/list_tile.dart +++ b/packages/flutter/lib/src/material/list_tile.dart @@ -432,7 +432,6 @@ class ListTile extends StatelessWidget { data: iconThemeData, child: new Container( margin: const EdgeInsetsDirectional.only(start: 16.0), - width: 40.0, alignment: FractionalOffsetDirectional.centerEnd, child: trailing, ), diff --git a/packages/flutter/test/material/list_tile_test.dart b/packages/flutter/test/material/list_tile_test.dart index 312e7eccbb..b868dd4325 100644 --- a/packages/flutter/test/material/list_tile_test.dart +++ b/packages/flutter/test/material/list_tile_test.dart @@ -77,6 +77,8 @@ void main() { double right(String text) => tester.getTopRight(find.text(text)).dx; double top(String text) => tester.getTopLeft(find.text(text)).dy; double bottom(String text) => tester.getBottomLeft(find.text(text)).dy; + double width(String text) => tester.getSize(find.text(text)).width; + double height(String text) => tester.getSize(find.text(text)).height; // 16.0 padding to the left and right of the leading and trailing widgets void testHorizontalGeometry() { @@ -86,12 +88,14 @@ void main() { expect(left('subtitle'), 72.0); expect(left('title'), right('leading') + 16.0); expect(right('trailing'), 800.0 - 16.0); + expect(width('trailing'), 112.0); } void testVerticalGeometry(double expectedHeight) { expect(tester.getSize(find.byType(ListTile)), new Size(800.0, expectedHeight)); if (hasSubtitle) expect(top('subtitle'), bottom('title')); + expect(height('trailing'), 14.0); // Fits on one line (doesn't wrap) } await tester.pumpWidget(buildFrame());