83696 Commits

Author SHA1 Message Date
45a611daef Build in parallel
All checks were successful
firka/flutter/pipeline/head This commit looks good
2025-07-17 14:15:57 +00:00
606542f88a Build arm64 and x64
Some checks reported errors
firka/flutter/pipeline/head Something is wrong with the build of this commit
2025-07-17 13:50:41 +00:00
2c1397e095 Use .flutter-path in build_release.sh
All checks were successful
firka/flutter/pipeline/head This commit looks good
2025-07-17 10:18:22 +00:00
285e5f4db4 Add build scripts
Some checks reported errors
firka/flutter/pipeline/head Something is wrong with the build of this commit
2025-07-17 10:05:41 +00:00
2d297f9d95 Move standard.gclient to .gclient 2025-07-17 09:19:32 +00:00
Matan Lurey
d7b523b356
[3.32] Update engine.version/CHANGELOG.md (#172192)
Prepares to publish `3.32.7`.
2025-07-16 00:03:46 +00:00
flutteractionsbot
39d6d6e699
[CP-stable]Started querying the app state for the gpu disabled sync switch (#172121)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/166668

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

For Flutter users on iOS, this fixes a case where images can fail to load and present themselves as magenta boxes when the Flutter app is created in the background state (example: responding to notifications).

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Images present themselves as magenta boxes.

### Workaround:
Is there a workaround for this issue?

No.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

\* Caveat, the typical workflow is well tested.  The problematic workflow that this fixes is not.

### Validation Steps:
What are the steps to validate that this fix works?

The reproduction steps are quite involved and require manipulation of the operating system.  Slava was able to reproduce the problem and verify manually that this change fixes it.
2025-07-15 22:39:12 +00:00
Camille Simon
47c02c8b8f
Update 3.32.6 CHANGELOG based on edits in master (#171975)
Updates `CHANGELOG` notes for 3.32.6 to match those in `master` based on edits made in https://github.com/flutter/flutter/pull/171891.
2025-07-10 17:54:09 +00:00
Camille Simon
077b4a4ce1
Update engine.version for 3.32.6 stable hotfix release (#171791)
Updates `engine.version` for 3.32.6 stable hotfix release to the last cherry-pick SHA with an engine change: 72f2b18bb0
2025-07-08 20:31:08 +00:00
Camille Simon
194ab59536
Update CHANGELOG for 3.32.6 stable hotfix (#171793)
Updates `CHANGELOG` to reference the cherry-picks included in the 3.32.6 stable hotfix release:
https://github.com/flutter/flutter/pull/171106
https://github.com/flutter/flutter/pull/171239
https://github.com/flutter/flutter/pull/171737
2025-07-08 20:18:56 +00:00
Gray Mackall
72f2b18bb0
[stable] [android] release background image readers on <= Android 14 (#171737)
CP of https://github.com/flutter/flutter/pull/171193. 

Template:

- Impacted Users (Approximately who will hit this issue, ex. all Flutter devs, Windows developers, all end-customers, apps using X framework feature).

All end users on Android 10-13 (inclusive) using an app with platform views.

- Impact Description (What is the impact? ex. visual jank on Samsung phones, app crash, cannot ship an iOS app. Does it impact development? ex. flutter doctor crashes when Android Studio is installed. Or shipping a production app? ex. the app crashes on launch).

Full app crash when backgrounding and then bringing the app back up.

- Workaround (Is there a workaround for this issue?)

No workaround.

- Risk (What is the risk level of this cherry-pick?)

Medium

- Test Coverage (Are you confident that your fix is well-tested by automated tests?)

No

- Validation Steps (What are the steps to validate that this fix works?)

Launch an app with platform views on these api levels and background them, and then bring the app back up.
2025-07-08 17:33:53 +00:00
flutteractionsbot
331c569830
[CP-stable][Impeller] Make ContextVK hash values globally unique (#171239)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/170141

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes an issue in the Impeller Vulkan back end that can cause crashes when transitioning between different Android activities that use Flutter.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Potential crash in apps with multiple Android activities running Flutter with Impeller/Vulkan.

### Workaround:
Is there a workaround for this issue?

Disable Impeller

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

The `appShortcutLaunchActivityAfterStarting` test for the `quick_actions_android` plugin will no longer crash on Firebase Test Lab after this fix is applied.  I don't know of a simpler way to manually verify the fix.
2025-07-07 22:00:17 +00:00
flutteractionsbot
d779fc779d
[CP-stable]Make _layoutBoundary a boolean 2 (#171106)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/168936.

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes a "Null check operator used on a null value" crash when a scroll view contains a `LayoutBuilder`.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

The app may crash if there a `LayoutBuilder` child inside of a `RenderSliverMultiBoxAdaptor` (which `SliverList` uses), and that child suddenly becomes offstage and kept-alive.

One example is when you have a TextField inside of a LayoutBuilder which is part of a `SliverList`. The app crashes ("Null check operator used on a null value") even in release mode when the user drags so that the text field becomes offscreen. All 3 are popular widgets so I think this combination will not be that uncommon.

### Workaround:
Is there a workaround for this issue?

There's no known workaround for this issue. You can increase the cache extent to prevent the child from becoming kept-alive but this is not really feasible for long / infinite list as it will go OOM fast.

### Risk:
What is the risk level of this cherry-pick?

This should be a relatively safe fix. 

Despite changing an important flag in RenderObject from `RenderObject?` to `bool?`, there's only one change in behavior:

in `RenderObject.dropChild`: https://github.com/flutter/flutter/pull/169958/files#diff-4c298197a8aa7831a26eece096c8b8b07773ba1f5376d848ea4ef2924b606e9fL2052
which originally set the flag to `null` for the entire subtree until a new relayout boundary is reached, now it only sets the flag to `null` for the root of the subtree.
In release mode, the only place the framework cares about whether the flag is null is [here](https://github.com/flutter/flutter/pull/169958/files#diff-4c298197a8aa7831a26eece096c8b8b07773ba1f5376d848ea4ef2924b606e9fR2342) (everywhere else `null` just means `false`), and that won't actually introduce any correctness issues because if the node originally enters the `if` block in line 2343 it will still enter the `if` block after the patch.

Also, the fix was merged a couple weeks ago and I haven't seen bug reports associated with the fix yet.

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

follow the repro steps in https://github.com/flutter/flutter/issues/168936, or 
run the test (already checked in in `master`)

```dart  
testWidgets('LayoutBuilder does not crash when it becomes kept-alive', (
    WidgetTester tester,
  ) async {
    final FocusNode focusNode = FocusNode();
    final TextEditingController controller = TextEditingController();
    addTearDown(focusNode.dispose);
    addTearDown(controller.dispose);
    final Widget layoutBuilderWithParent = SizedBox(
      key: GlobalKey(),
      child: LayoutBuilder(
        builder: (BuildContext _, BoxConstraints _) {
          // The text field keeps the widget alive in the SliverList.
          return EditableText(
            focusNode: focusNode,
            backgroundCursorColor: const Color(0xFFFFFFFF),
            cursorColor: const Color(0xFFFFFFFF),
            style: const TextStyle(),
            controller: controller,
          );
        },
      ),
    );

    await tester.pumpWidget(
      Directionality(
        textDirection: TextDirection.ltr,
        child: CustomScrollView(
          slivers: <Widget>[
            SliverList.list(
              addRepaintBoundaries: false,
              addSemanticIndexes: false,
              children: <Widget>[const SizedBox(height: 60), layoutBuilderWithParent],
            ),
          ],
        ),
      ),
    );
    focusNode.requestFocus();
    await tester.pumpWidget(
      Directionality(
        textDirection: TextDirection.ltr,
        child: CustomScrollView(
          slivers: <Widget>[
            SliverList.list(
              addRepaintBoundaries: false,
              addSemanticIndexes: false,
              children: <Widget>[const SizedBox(height: 6000), layoutBuilderWithParent],
            ),
          ],
        ),
      ),
    );
  });
```
2025-07-07 21:56:25 +00:00
Jackson Gardner
fcf2c11572
Update changelog for 3.32.5 (#171098) 2025-06-24 18:44:07 +00:00
Jackson Gardner
e1d8d64b3e
Bump engine version for 3.32.5 release. (#171079) 2025-06-24 17:24:43 +00:00
flutteractionsbot
dd93de6fb1
[CP-stable][Windows] Use ANGLE blit extension on GLES 2.0 (#170924)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)

### Issue Link:
https://github.com/flutter/flutter/issues/169178

### Changelog Description:

Fix Flutter Windows on devices that only support OpenGL ES 2, like computers with Intel graphics cards.

### Impact Description:

Flutter Windows 3.29.0 and higher crashed immediately on startup on computers using Intel HD Graphics graphics cards.

### Workaround:
None, other than downgrading your Flutter SDK to 3.27.4 or lower.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:

This bug does not reproduce on Flutter's infrastructure. The fix was manually tested on several Windows devices, including affected devices that use Intel HD Graphics graphics cards.
2025-06-24 14:39:37 +00:00
Victoria Ashworth
f3eca332f3
[CP] Include dev_dependencies in all builds for iOS and macOS (#171015) (#171034)
Impacted Users: iOS and macOS Flutter developers
Impact Description: iOS/macOS workflows may not behave as expected due to missing dev dependencies.
Workaround: Yes, run in debug mode, such as `flutter build ios --debug --config-only`
Risk: low
Test Coverage: yes
Validation Steps: Run `flutter build ios` on a project with dev dependencies and should see them in the GeneratedPluginRegistrant
2025-06-23 20:44:10 +00:00
Ben Konyi
fdefa52cef
[ CP-stable] [ Tool ] Roll DDS 5.0.3 (#170880) (#171002)
### Issue Link:
https://github.com/dart-lang/sdk/issues/60851

### Changelog Description:

Fixes unhandled exception on application shutdown in the debug adapter used by IDEs.

### Impact Description:

The Debug Adapter (DAP) could crash if it is waiting on specific RPCs from a target application while the application is shutting down.

### Workaround:
None.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:

This bug is extremely hard to reproduce reliably. Catching `RPCError` and checking for the correct error code related to the VM service disappearing is simple and low risk.
2025-06-23 20:11:18 +00:00
Jonah Williams
82f2933347
[CP] Fix pink images when returning from background on iOS (#170846)
Includes:
  * https://github.com/flutter/flutter/pull/169596
  * https://github.com/flutter/flutter/pull/169378
  
 Fix image decode errors on iOS that could occur if a push notification triggered image decoding while the app is backgrounded.
2025-06-23 17:38:02 +00:00
Matan Lurey
6fba2447e9
Update engine.version (#170560)
Workaround for https://github.com/flutter/flutter/issues/170536.
2025-06-13 02:03:56 +00:00
Matan Lurey
8cd19e509d
Trigger a new engine build from HEAD in 3.32 (#170558)
Workaround for https://github.com/flutter/flutter/issues/170536.
2025-06-12 16:30:12 -07:00
Matan Lurey
5c1433509f
Prepare to publish 3.32.3, update changelog+engine.version. (#170470) 2025-06-11 20:12:24 +00:00
flutteractionsbot
b02643b7d9
[CP-stable]fix: add the missing type of debug metadata (#170003)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/169252

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes a build failure on Android for app bundles when setting debug symbol level to `FULL` and using release mode.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Flutter fails to build an AAB in release mode.

### Workaround:
Is there a workaround for this issue?

No, besides not using this symbol level.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

This linked issue has easy to follow repro steps for the original issue, which also function as validation steps that the issue is fixed.
2025-06-05 15:53:20 +00:00
flutteractionsbot
31c4875c7a
[CP-stable][Impeller] Maintain a global map of each context's currently active thread-local command pools (#170013)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/169208

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes a memory leak in the Impeller Vulkan back end.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

The memory usage of apps using Impeller/Vulkan will increase as frames are rendered.  Memory consumption will grow until the Android activity enters the stopped state.

### Workaround:
Is there a workaround for this issue?

Disabling Impeller

### Risk:
What is the risk level of this cherry-pick?

  - [ x ] Medium

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

  - [ x ] Yes

### Validation Steps:
What are the steps to validate that this fix works?

Start an app using Impeller/Vulkan that renders frames nonstop (for example, video playback).  Leave it running for several minutes.  Check memory metrics with a tool like `adb shell dumpsys meminfo` and verify that memory usage is stable.
2025-06-05 15:39:10 +00:00
flutteractionsbot
46a4c05ace
[CP-stable]Revert "Fix NavigationBar indicator overlay color (#164484)" (#170052)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/169249
https://github.com/flutter/flutter/issues/169436

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

NavigationBar active indicator animation gets stucked.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Visual glitch visible by users. In several scenarios, the active indicator for NavigationBar and NavigationDrawer is not properly painted (animation stucked half way or active color not reflecting the current state).

### Workaround:
Is there a workaround for this issue?

No

### Risk:
What is the risk level of this cherry-pick?

  - [ x ] Low

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

  - [ x ] Yes

### Validation Steps:
What are the steps to validate that this fix works?

Run the code sample from https://github.com/flutter/flutter/issues/169249.
This fix is a revert to a PR which landed in the current stable.
2025-06-05 15:39:08 +00:00
Camille Simon
8defaa71a7
Re-update engine.version for 3.32.2 stable hotfix release to the last SHA with engine change (#170005)
Corrects `engine.version` for 3.32.2 stable hotfix release to the last cherry-pick SHA with an engine change: 
1091508939
2025-06-04 18:02:51 +00:00
Camille Simon
fa17ad1002
Update engine.version for 3.32.2 stable hotfix release (#169952)
Updates `engine.version` for 3.32.2 stable hotfix release to the last cherry-pick SHA: d88a6751a8

I think this is required because there were engine changes in a previous cherry-pick (https://github.com/flutter/flutter/pull/169772)  not included in the 3.32.1 stable hotfix release.
2025-06-03 22:16:03 +00:00
flutteractionsbot
d88a6751a8
[CP-stable] Split Linux docs_publish into Linux docs_generate_release (#169912)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/168913

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A - This is an internal infrastructure change.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

No user impact, could negatively impact how API docs are published.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

View post-submits when a stable release is published and verify API docs were published.
2025-06-03 18:08:00 +00:00
flutteractionsbot
04f9ead567
[CP-stable]🐛 Use consist slashes when generating dep files (#169630)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/163591

### Changelog Description:

Normalizes file paths in every depfile, especially on Windows. It eliminates the inconsistency that can occur when other codes find the file paths are different and produce unexpected results.

### Impact Description:

The most noticeable impact so far is that people are unable to build flavored Android packages on Windows repeatedly until the next clean.

### Workaround:
Is there a workaround for this issue?

The workaround is to manually patch the project's gradle script: https://github.com/flutter/flutter/issues/163591#issuecomment-2887039609
From my experience, the patch is not always working and is hard to maintain.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Follow the *steps to reproduce* section in https://github.com/flutter/flutter/issues/163591#issue-2862606263.
2025-05-30 22:11:06 +00:00
Matan Lurey
1091508939
[CP-Stable] Use Linux windows_*_engine orchestrators (#169772)
Cherry-picks https://github.com/flutter/flutter/pull/168941.

This is a pure infra change so release builds do not use a valuable Windows release builder just to spawn other builds.
2025-05-30 19:17:36 +00:00
Jackson Gardner
b25305a883
Update engine.version and changelog for upcoming stable release 3.32.1 (#169619)
Update engine.version and changelog for upcoming stable release 3.32.1
2025-05-29 17:40:06 +00:00
flutteractionsbot
0a159b315d
[CP-stable]Roll forward: "Initialize default-app-flavor" (#169298) (#169623)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/pull/169602

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes a bug where `appFlavor` is `null` when being run with `flutter test` or being hot-restarted.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Cannot reliably use `appFlavor` without rebuilding the app from scratch.

### Workaround:
Is there a workaround for this issue?

Do not use hot restart, do not use `flutter test`.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Automated test coverage.
2025-05-29 16:23:50 +00:00
Matan Lurey
637479460d
Update engine.version to 1425e5e9ec5eeb4f225c401d8db69b860e0fde9a. (#169675)
```sh
git log -1 --pretty=format:%H -- "$(git rev-parse --show-toplevel)/DEPS" "$(git rev-parse --show-toplevel)/engine"
```
2025-05-29 15:54:51 +00:00
Jackson Gardner
1425e5e9ec
Update dart revision (3.8.1) for 3.32.1 release (#169601)
This updated the dart revision for the upcoming flutter stable release, 3.32.1
2025-05-28 21:26:27 +00:00
flutteractionsbot
7d3efe4643
[CP-stable]Fixes tab semantics gets dropped if the child produce a semantics node (#169362)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/169175

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixed unexpected crash when using Tab and TabBar widgets. 

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

app crash

### Workaround:
Is there a workaround for this issue?

Wrap the Tab widget with a MergeSemantics widget will mitigate the issue.

### Risk:
What is the risk level of this cherry-pick?

  - [O] Low

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

  - [O] Yes

### Validation Steps:
What are the steps to validate that this fix works?

create a TabBar that has a Tab with image widget
```dart
TabBar(
  tabs: <Widget>[
      Tab(icon: Image.network('https://some-url')),
      Tab(icon: Icon(Icons.beach_access_sharp)),
      Tab(icon: Icon(Icons.brightness_5_sharp)),
  ],
),
```
2025-05-28 16:39:01 +00:00
Jason Simmons
c56879b5f5
Roll Skia to the flutter/3.32 branch (#169531)
That branch includes a cherry pick of a fix for https://github.com/flutter/flutter/issues/168849
2025-05-28 16:18:18 +00:00
Ben Konyi
80f085c97d
[stable] Roll package:dds to 5.0.2 (#169471) (#169515)
Fixes https://github.com/flutter/flutter/issues/156793

### Issue Link:

https://github.com/flutter/flutter/issues/156793

### Changelog Description:

Fix flaky crash when targeting web applications via IDEs using the DAP.

### Impact Description:

The `flutter debug-adapter` process started by IDEs can crash when requesting isolate information from a Flutter web application that has disposed its isolate (i.e., at shutdown or due to a hot restart).

This is the top crasher for `flutter_tools`, accounting for ~66% of all crashes for 3.32.0.

### Workaround:
Is there a workaround for this issue?

No.

### Risk:

This CP is low risk as only additional exception handling was added to the DAP logic in `package:dds` (see https://dart-review.googlesource.com/c/sdk/+/431060) to handle the specific case outlined in the issue.

### Test Coverage:

This issue is difficult to reproduce without injecting test-only code via custom VM service RPCs across multiple repositories. Testing was done manually with this approach, but the testing code is not committed.

### Validation Steps:

IDE extensions don't crash when interacting with Flutter Web applications during hot restart / application shutdown.
2025-05-27 19:55:08 +00:00
flutteractionsbot
9057717ebc
[CP-stable]Use .flutter-plugins-dependencies for crash reporting. (#169484)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/pull/169319

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixed a bug where the `flutter` tool crash reporting did not include what plugins were being used by the current project.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Tool crash reports are missing plugins in use.

### Workaround:
Is there a workaround for this issue?

Yes, `flutter config --no-explicit-package-dependencies`, but that has other project impact, or copying and pasting the plugins manually.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

See unit tests.
2025-05-27 01:01:40 +00:00
flutteractionsbot
6e07e1f4bd
[CP-stable]Skip running Linux fuchsia_test on non-master channel. (#169380)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/169101

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Reduces the cost of running the (sometimes flaky) `Linux fuchsia_test` on release branches.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

N/A - CI infra optimization.

### Workaround:
Is there a workaround for this issue?

N/A - CI infra optimization

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A - CI infra optimization
2025-05-23 20:43:22 +00:00
flutteractionsbot
44b32ecbb7
[CP-stable][reland] Fix regression in NDK version checking (#169289)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

There was no associated issue, but the problem is that https://github.com/flutter/flutter/pull/166727 broke Flutter Android builds on apps that use plugins with AGP versions less than 8.2.

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Fixes Flutter Android builds for apps which use plugins with old Android Gradle Plugin versions.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

The impact is a crash in the build process.

### Workaround:
Is there a workaround for this issue?

No

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Build an app that uses AGP < 8.2.
2025-05-23 16:56:15 +00:00
Elliott Brooks
673806fbc1
[CP: 3.32] [Widget Inspector] Update on-device inspector button to generic unicode icon (#169092)
### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/168846

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

This cherry pick fixes an issue where some users would see a question mark instead of the appropriate icon in the widget inspector button which toggles select-mode on/off.

### Impact Description:
Users who don't have `cupertino_icons` as a dependency in their pubspec will see a question mark in one of the widget inspector buttons. 
<img width="169" alt="Screenshot 2025-05-19 at 12 50 15 PM" src="https://github.com/user-attachments/assets/40cd01c9-f8a6-407d-9d1b-303bc1516d62" />

### Workaround:
Is there a workaround for this issue?

Yes, add `cupertino_icons` package to user's pubspec.

### Risk:
What is the risk level of this cherry-pick?

Low

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

This was tested manually, there are no screenshot tests for this. However, this is only a UI change and not a behavior change.

### Validation Steps:
What are the steps to validate that this fix works?

1. Run an app that doesn't have `cupertino_icons` in its pubspec
2. Open Flutter DevTools > Inspector
3. Enable select widget mode
4. Should not see a ? on any of the buttons
2025-05-20 16:52:05 +00:00
Matan Lurey
be698c48a6
[3.32] Set engine.version to 18818009497c581ede5d8a3b8b833b81d00cebb7. (#169082)
Sets to 18818009497c581ede5d8a3b8b833b81d00cebb7, the last git SHA.
2025-05-19 19:59:14 +00:00
flutteractionsbot
1881800949
[CP-beta][Impeller] separate immutable sampler descriptors. (#169074)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

#168114

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

This cherry pick fixes an issue with video flickering after a user scroll event in the package video_player on devices using Vulkan for rendering. 

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Visual jank on devices using Vulkan rendering and the video_player package.

### Workaround:
Is there a workaround for this issue?

No.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

pixel diffing is difficult to do without being flakey, video rendering pixel diffing is even harder. Was tested manually in the initial pr.  

### Validation Steps:
What are the steps to validate that this fix works?

Using a device that utilizes Vulkan rendering, start the video_player example app, press play on the video, then scroll up or down - the visual flickering should be evident.
2025-05-19 17:54:07 +00:00
Matan Lurey
2e6bde0946
Stage the CHANGELOG for 3.32 so that a stable publish is 1-step. (#169010)
This will not require an `engine.version` revision, so the last step will just be a publish step.
2025-05-16 20:36:23 +00:00
Matan Lurey
48ea72a87d
[3.32] Update bin/internal/engine.version to latest SHA. (#168979) 2025-05-16 16:00:06 +00:00
Reid Baker
3e54f90f1a
update dart hash to stable 3.32 (#168927)
Align stable with stable dart hash. 

I did run gclient sync then engine/src/tools/dart/create_updated_flutter_deps.py but nothing changed.
2025-05-15 21:50:14 +00:00
Matan Lurey
0fe9c10cc5
[3.32] Revert: "Run flutter_packaging builders on release candidates (#168918)
This reverts commit aed4bfd318f189d648e595b89442fc19e3147b47.

`flutter_packaging` builders only should run on `stable` or `beta`, the original definition was correct.
2025-05-15 17:12:37 +00:00
flutteractionsbot
aed4bfd318
[CP-beta]Run {Platform} flutter_packaging builders on release candidates. (#168825)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/168745

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A - Internal CI infra change.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Allows removing legacy logic in the `flutter_release_builder` recipe.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Merge on the candidate branch and observe post-submits.
2025-05-14 16:26:00 +00:00
flutteractionsbot
c4f885d2a4
[CP-beta]Remove docs_deploy_beta, fix docs_publish, add comments. (#168824)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

Closes https://github.com/flutter/flutter/issues/168709.

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A (CI Infra Change)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Not user facing - this fixes API doc generation for release candidate branches, which was accidentally broken in https://github.com/flutter/flutter/pull/162557.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Merge a commit to `flutter-3.32-candidate.0` and observe the post-submits.
2025-05-14 16:25:57 +00:00
Camille Simon
dbc3660e84
Update engine.version (#168601)
Rolls up to last commit on this branch: 38e19d01dc.
2025-05-09 20:35:12 +00:00