12070 Commits

Author SHA1 Message Date
xster
133c98a85b
Fine-tune iOS's scroll start feel (#16721)
* Fine-tune iOS's scroll start feel

* remove negations in doc

* Our own dart-side gesture arena also contributes to the 'jerk'. Make sure that snap is accounted as well.

* Added more code comments from review.
2018-04-19 16:17:44 -07:00
Michael Goderbauer
1ba99b94f2
SliverList works with changing children that are keyed (#16724)
Fixes #14590.
2018-04-19 16:05:41 -07:00
Chris Bracken
cf5778810b
Move script snapshot argumtents to Snapshotter (#16722)
This moves --vm_snapshot_data and --isolate_snapshot_data argument
hardcoding from GenSnapshot (a minimal wrapper around gen_snapshot
invocations) to Snapshotter.buildScriptSnapshot(). These arguments are
present in both AOT and script snapshots, but differ semantically: for
script snapshots they're inputs from the host engine artifacts
directory, for AOT snapshots they're outputs to the build directory.
2018-04-19 16:03:07 -07:00
Greg Spencer
0b389fc92e
Change CircleAvatar to use BoxFit.cover for images (#16649)
This is a PR giving some love to the abandoned PR #16263 by @harrisonturton

I've added a test, and formatted it to be readable.

Currently the CircleAvatar does not set a fit property on the DecorationImage it uses to paint images. This causes non-square images to not fully cover the circle, which looks pretty bad. This PR sets it to BoxFix.cover.

Fixes #13478.
2018-04-19 15:52:40 -07:00
Todd Volkert
9da0ec2736
Add a few timeouts to FlutterDriver.connect() (#16762)
We're seeing occasional test timeouts trying to call `FlutterDriver.connect()`.
Unfortunately, when the test is timed out at the test runner level, you don't
get a meaningful test failure or stack trace of where the timeout occurrred.
Your test harness also doesn't get to clean up, which can include things like
saving the device logs to see what was going on in the device.

Thus, this change adds timeouts in the places where we've most
commonly observed hangs during tests.
2018-04-19 15:09:07 -07:00
Chinmay Garde
07e5056b4e Roll Flutter Engine to 637e921. (#16761)
This roll includes the following commits.

* flutter/engine@637e921d6: Use the raster cache when rendering screenshots as bitmaps (#5050)
* flutter/engine@a23fa923c: Look for an assets path specification in the Info.plist. (#5049)
2018-04-19 14:59:05 -07:00
Devon Carew
c058c6a6d7
revert an older workaround for a pub/vm failure (#16749) 2018-04-19 13:11:42 -07:00
Chinmay Garde
48ab8648bf
On simulators, don't pass file paths to the engine that done exist. (#16756) 2018-04-19 12:42:56 -07:00
Jonah Williams
eb1fd78601
Roll engine to 3405e23a32af4ea3655e5d1a78955066b2573331 (#16755)
* update engine version, ignore scopesRoute and namesRoute flags until framework support is added
2018-04-19 12:35:24 -07:00
Todd Volkert
7b163c7c0b
Roll engine to 3cc8d82895eaaddc52df166ceb0e5d7c3cc40588 (#16728)
This contains the following commits:

flutter/engine@3cc8d82 Fix more Linux unittest targets.
flutter/engine@b6ba69b libtxt: add boxes representing empty lines in GetRectsForRange
flutter/engine@388f019 Enable downscale of very large images when uploading on IO thread
flutter/engine@22e1381 Allow runtime unit-test to perform dynamic symbol resolution for Dart snapshots.
flutter/engine@59d1366 Don’t build the host shell on target builds.
flutter/engine@7a6b779 Remove the weak pointer factory from the service isolate's DartIsolate object
flutter/engine@d4729ab Update the embedder GN target to use a source set instead of a complete static library.
flutter/engine@8973c73 Implement Scene::toImage for creating a raster image representation of a scene.
flutter/engine@572c584 Configure kernel paths in the embedder if the asset directory contains the kernel assets
flutter/engine@8ed932c Roll src/third_party/skia/ 1cd6098d5..1ccaa6e05 (20 commits)
flutter/engine@a0804f3 Simplify weak pointer factories and allow vending weak pointers on multiple threads.
2018-04-18 20:31:45 -07:00
Jacob Richman
044dfdb446
Tweak theme_test so it passes when --track-widget-creation is used. (#16717) 2018-04-18 17:46:20 -07:00
Todd Volkert
ec7b46e30b
Add stack trace to exception logs in flutter_platform (#16715) 2018-04-18 12:09:16 -07:00
Greg Spencer
e6b62a3a30
Adding some tests for onTapDown and onTapCancel (#16682)
Adding some tests for onTapDown and onTapCancel for the InkWell, as suggested in post-submission comments by @Hixie in #16190.

Also, added those to the diagnostic output.
2018-04-18 11:27:55 -07:00
Alexander Aprelev
6bd6897014
Run tests in dart2 mode. (#16675)
* Run tests in dart2 mode.

* Fix type check

* Drop --checked, leave --preview-dart-2

* Remove debugging leftovers.
2018-04-18 11:24:54 -07:00
Todd Volkert
3a0aabc37b
Add docs to VMService.onEvent() (#16711) 2018-04-18 09:24:52 -07:00
Jacob Richman
928c41e9a7
Support summary-details tree view (#16638)
Support summary-details tree view.
2018-04-18 09:09:34 -07:00
Mikkel Nygaard Ravn
1080c29832
Roll engine to c73be7ada2e1066e2a6f04f0541406409c2bfa6b (#16707) 2018-04-18 13:51:58 +02:00
Alexander Aprelev
09ca3c187d Fix the way how stream event subscription is handled. (#16698) 2018-04-18 10:21:33 +02:00
Todd Volkert
eaf3a6648d
Roll engine to 5822b6e578de7b6c6c0d802dd2b5b9d363e48c14 (#16686)
This contains the following commits:

flutter/engine@5822b6e Clear the canvas when attempting to render to the surface.
flutter/engine@d8eb659 Make the rasterizer own the compositor context.
flutter/engine@387945c Correct ninja command instruction
flutter/engine@00911b2 Don't send platform messages to isolates that are not running.
flutter/engine@5c857ee Set the start timestamp in the contructor of the first shell.
2018-04-17 21:13:58 -07:00
Chinmay Garde
9a0b562524
When parsing logs, filter away lines that are irrelevant to the microbenchmark. (#16678) 2018-04-17 16:57:47 -07:00
Todd Volkert
ec26a7baca
Fail with better error message in microbenchmarks (#16676) 2018-04-17 14:34:09 -07:00
Chinmay Garde
e9177ba3d1 Roll engine to 0c09bf03d. (#16668)
This roll includes the following engine commits:

* flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (#5028)
* flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (#5026)
* flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (#5016)
* flutter/engine@3393c179: Fix Android platform channels (#5025)
* flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (#5024)
* flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (#5023)
* flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (#5022)
* flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (#5009)
* flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (#5020)
* flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (#5006)
* flutter/engine@d6d4eec2: Fix broken Linux build (#5019)
* flutter/engine@d15dc76e: Fix broken Chromebot build (#5018)
* flutter/engine@c17a6290: Breadcrumbs to the wiki (#5017)
* flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (#5008)
* flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (#5014)
* flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (#5012)
* flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (#5007)
* flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (#5004)
* flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (#4979)
* flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (#5005)
* flutter/engine@0b9cef5a: Minor update to README (#5003)
* flutter/engine@c386418f: Promote line height in text style created from paragraph style (#4995)
* flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (#5002)
* flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (#4932)" (#4998)
* flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (#4994)
* flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (#4990)
* flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (#4988)
* flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (#4987)
* flutter/engine@b6d2dde9: [fuchsia] Fix build (#4986)
* flutter/engine@1dd12649: [async] Adapt to libasync API changes. (#4980)
2018-04-17 13:41:18 -07:00
Greg Spencer
824b806bfc
Add missing docs to public function. (#16651)
Adding missing docs to the forceRebuild function in the widget inspector.
2018-04-17 12:19:15 -07:00
Todd Volkert
58d3493445
Add a timeout to bot tests. (#16666)
This will catch the case where tests hang -- and it will
force them to fail so that we see the output from the test.
2018-04-17 10:00:06 -07:00
Todd Volkert
c7df2619d7
Run test harness finalizers in reverse order. (#16664)
Finalizers handle the restoration of state. In order to restore
the state correctly, they shouyld be run in LIFO order.

Fixes #16657
2018-04-17 07:38:30 -07:00
Mikkel Nygaard Ravn
10cf0cedad
Revert "Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 (#16643)" (#16661) 2018-04-17 12:40:02 +02:00
Todd Volkert
dd32d1b179 Roll engine to 1bc0e1bb9a8db882a21086096cc2b1e0854312b7 (#16643)
* Roll engine to d6d4eec24c38bb06a9b1aef4e70c321d447ba762

Contains the following engine commits:

flutter/engine@1bc0e1b On windows, refer to Dart snapshot directly executable.
flutter/engine@cf6ca32 Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79"
flutter/engine@4b45a53 Only make ERROR and FATAL log levels visible by default.
flutter/engine@98f6c2d Fix shell launcher test (dart2 compliant and stop polling)
flutter/engine@75851f0 Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79
flutter/engine@9495a52 On iOS, try to use ES3, then fall back to ES2.
flutter/engine@d6d4eec Fix broken Linux build
flutter/engine@d15dc76 Fix broken Chromebot build
flutter/engine@c17a629 Breadcrumbs to the wiki
flutter/engine@4eaf2c2 Return raw (unencoded) bytes in Image.toByteData()
flutter/engine@d812a61 Roll src/third_party/skia/ e669bdfad..276886160 (9 commits)
flutter/engine@62aeab7 Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain.
flutter/engine@f4ebb18 Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits)
flutter/engine@0b7d6be Re-land "do not pause rendering when android view loses focus"
flutter/engine@91dee59 If the rasterizer has a valid surface context, use that to create a snapshotting render target.
flutter/engine@570231b Specify the packages file path when running engine dart tests.
flutter/engine@0b9cef5 Minor update to README
flutter/engine@c386418 Promote line height in text style created from paragraph style
flutter/engine@4e0fbb6 If the test specifies a .dill file, dont make the engine interpret is as source.
flutter/engine@58e84c8 Re-land "Support multiple shells in a single process.
flutter/engine@37e5df0 Remove only use of SkPaint::kGenA8FromLCD
flutter/engine@b7358b3 libtxt: cache font families that are remapped to the default font family
flutter/engine@a530035 libtxt: fix leaks in Skia object reference counting
flutter/engine@0c74fc9 [fuchsia] Fix use-after-free
flutter/engine@b6d2dde [fuchsia] Fix build
flutter/engine@1dd1264 [async] Adapt to libasync API changes.

* Run test platform finalizers in reverse order to ensure that shell is shutdown before trying to delete any temporary files or directories. This fixes "Access Denied" error on Windows (see #16657).
2018-04-17 11:52:00 +02:00
Todd Volkert
c83d24d547
Always add a DevFS asset entry for the font manifest (#16650)
The engine expects it to always be there.
2018-04-16 21:48:21 -07:00
Alexander Aprelev
9e0a6107fa
Support local-engine option for flutter_tester on Windows. (#16648) 2018-04-16 20:40:52 -07:00
Michael Goderbauer
f049f436c8
Update AppBar docs to analyze sample code (#16634) 2018-04-16 14:17:55 -07:00
Jonah Williams
b1ecf1ea9a
Add localizations for navigation menu, popup menu, dialog, and alert (#16633)
* add localizations for navigation menu, popup menu, dialog, and alert
2018-04-16 14:09:20 -07:00
jcollins-g
85be28d36b
Add catch for SocketException and tests for exception handling on fetchUrl. (#16569) 2018-04-16 14:02:07 -07:00
Alexandre Ardhuin
c103fd0c02
disable avoid_private_typedef_functions lint (#16495) 2018-04-16 22:43:47 +02:00
Jacob Richman
ab9ba3f909
Support exposing the InspectorService over the Flutterservice extension protocol as well as the observatory protocol. (#15876)
* Support exposing the InspectorService over the Flutter
service extension protocol as well as the observatory protocol.

We will probably remove most of the observatory protocol support once a
couple versions of the Flutter IntelliJ plugin have shipped that use the
Flutter service extension protocol. The only reason to continue supporting
the observatory protocol is it will allow using the inspector when paused
at a breakpoint.
2018-04-16 10:04:40 -07:00
Siva
7dd166fac5
Revert "Turn support for sync-async on in Flutter. (#16543)" (#16626)
This reverts commit b0b2c0077a56e313cb00a9c5285e4bf4fb43f3b0.
2018-04-16 09:54:47 -07:00
Siva
b0b2c0077a
Turn support for sync-async on in Flutter. (#16543)
* Turn support for sync-async on in Flutter. With this feature
execution of async functions starts immediately instead of it
being delayed by one microtask tick.

* Address review comments.

* Adjust some stack trace expectations which are slightly different with
--sync-async turned on.
2018-04-16 08:44:38 -07:00
Greg Spencer
6c049ec286
Rename AnimatedChildSwitcher to AnimatedSwitcher (#16551)
We don't really like the name AnimatedChildSwitcher, and we think that AnimatedSwitcher might be better (since the Child part is redundant). We also considered AnimatedChild, AnimatedTransition and AnimatedReplacement (among others).

Nothing in here besides a rename.
2018-04-15 19:24:49 -07:00
Alexander Aprelev
ea30c95dc9
Report RpcException error thrown by _reloadSource vmservice rpc. (#16417)
* Don't return null, just rethrow RpcException error when vmservice responds with error.
2018-04-13 17:02:14 -07:00
Hans Muller
fb0ab99d6f
Remove Number.tryParse() straggler (#16570) 2018-04-13 11:15:33 -07:00
Hans Muller
e7154bee1a
Remove the rest of the uses of Number.tryParse() (#16568) 2018-04-13 09:39:01 -07:00
Ian Hickson
1c3f6a851f
Fix formatting of Flex error message (#16498) 2018-04-12 21:16:39 -07:00
Hans Muller
0260642fc5
Revert some uses of Number.tryParse() (#16546)
Revert some uses of Number.tryParse(), ignore deprecation warnings for Number.parse()
2018-04-12 19:16:44 -07:00
Konstantin Scheglov
2c183f235f
Build once in FlutterTesterDevice. (#16457) 2018-04-12 19:01:55 -07:00
Alexander Aprelev
e0cd42e4ad Roll engine to 76cb311d9c33720dcd19274228b39ecdbad8d9af (with rolled dart) (#16518)
* Handle error count reported by frontend.

Extend compilation result from single string to a structure(string filename and integer error count).

* Use ?.

* Include engine roll with dart sdk roll.

* parse(onError) -> tryParse

* Make '?? throw' more readable and avoid issue with analyzer

* Fix test so it mocks compiler output including errors count
2018-04-12 16:28:01 -07:00
Greg Spencer
c73b8a7cf6
Fix a bug in the AnimatedChildSwitcher, add builders. (#16250)
This fixes a rendering problem in the AnimatedChildSwitcher where it would add a new "previous" child each time it rebuilt, and if you did it fast enough, all of them would disappear from the page.

It also expands the API for AnimatedChildSwitcher to allow you to specify your own transition and/or layout builder for the transition.

Fixes #16226
2018-04-12 16:17:26 -07:00
Greg Spencer
7a78741920
Revert "Changing the slider thumb size." (#16541)
This reverts commit 6494ab23f6a063c689441f55c3aba1b3c8e26b5b.
2018-04-12 16:11:43 -07:00
Devon Carew
a561722b2b
fix a test flake on appveyor (#16479)
* fix a test flake on appveyor

* only catch FileSystemExceptions
2018-04-12 15:07:51 -07:00
Alexander Aprelev
910417cca4
Roll engine to pre-dart engine roll (#16531) 2018-04-12 15:03:12 -07:00
Siva
dbddcf26b5
Turn off unused changes report during hot reload (#16520)
* A new UI is being designed to make the unused reload messaging clearer,
the UI will use the coverage data to highlight lines in the UI that were not executed during a reload.

In lieu of that we are turning off the unused reload messages experiment.

There were some issues in Dart2 also with this functionality
- source fingerprinting is not implemented in Dart2
- some additional synthetic functions are generated for invocation argument checking that are not appropriately filtered out.
2018-04-12 14:24:10 -07:00
Greg Spencer
5129d8ffa6
Rename Rail to Track, per UX guideline (#16519) 2018-04-12 12:32:30 -07:00