Zachary Anderson
8a8616f913
Handle FormatException from SkiaGoldClient ( #143755 )
...
Seen in
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20Framework%20Smoke%20Tests/17183/overview
closing the engine tree.
2024-02-20 09:57:23 -08:00
engine-flutter-autoroll
6200026a6d
Roll Packages from 84ff11d7ee5a to 8bba41b0c046 (2 revisions) ( #143757 )
...
84ff11d7ee...8bba41b0c0engine-flutter-autoroll@skia.org Roll Flutter from 064c340baf0e to 5129806e6c63 (9 revisions) (flutter/packages#6164 )
2024-02-20 stuartmorgan@google.com [flutter_markdown] Replace deprecated API (flutter/packages#6134 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 17:07:12 +00:00
engine-flutter-autoroll
096c917efc
Roll Flutter Engine from 781f308c6555 to a41da3701923 (1 revision) ( #143756 )
...
781f308c65...a41da37019skia-flutter-autoroll@skia.org Roll Skia from a76b083ac4cc to 2f9bb1517740 (1 revision) (flutter/engine#50781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 16:53:17 +00:00
engine-flutter-autoroll
5129806e6c
Roll Flutter Engine from 0abe2b9d6c7c to 781f308c6555 (1 revision) ( #143750 )
...
0abe2b9d6c...781f308c65skia-flutter-autoroll@skia.org Roll Dart SDK from 8bb8ff24aea3 to f344e2266468 (1 revision) (flutter/engine#50780 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 15:36:09 +00:00
engine-flutter-autoroll
1a7a0618a7
Roll Flutter Engine from 92aad0d0fcee to 0abe2b9d6c7c (1 revision) ( #143745 )
...
92aad0d0fc...0abe2b9d6cskia-flutter-autoroll@skia.org Roll Skia from d448ca514a56 to a76b083ac4cc (1 revision) (flutter/engine#50778 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 11:41:28 +00:00
engine-flutter-autoroll
c56d4d112a
Roll Flutter Engine from 2335115f08d3 to 92aad0d0fcee (2 revisions) ( #143736 )
...
2335115f08...92aad0d0fcskia-flutter-autoroll@skia.org Roll Dart SDK from 475e710429ee to 8bb8ff24aea3 (1 revision) (flutter/engine#50775 )
2024-02-20 skia-flutter-autoroll@skia.org Roll Skia from ff602d384586 to d448ca514a56 (4 revisions) (flutter/engine#50776 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 08:37:48 +00:00
engine-flutter-autoroll
dd2447471e
Roll Flutter Engine from e96c18b6c5ee to 2335115f08d3 (1 revision) ( #143731 )
...
e96c18b6c5...2335115f08skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from HFmcvzkR3TYeHa_0U... to gKg6HlBeR52y-cMhu... (flutter/engine#50771 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from HFmcvzkR3TYe to gKg6HlBeR52y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-20 06:25:26 +00:00
Greg Price
2d422a3261
Small fixes in TextEditingController docs ( #143717 )
...
This follows up on #143452 , to slightly further address #95978 .
The double- rather than triple-slash on the blank line caused it to be ignored by dartdoc, so that the two paragraphs it's intended to separate were getting joined as one paragraph instead.
Also expand this constructor's summary line slightly to mention its distinctive feature compared with the other constructor, and make other small fixes that I noticed in other docs on this class.
2024-02-20 05:49:05 +00:00
engine-flutter-autoroll
f2eea969f7
Roll Flutter Engine from b41494f009f4 to e96c18b6c5ee (1 revision) ( #143722 )
...
b41494f009...e96c18b6c5flar@google.com [Impeller] Run stroke benchmarks on unclosed paths (flutter/engine#50765 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 22:41:24 +00:00
engine-flutter-autoroll
3b5b462aba
Roll Flutter Engine from 714215d42e57 to b41494f009f4 (1 revision) ( #143713 )
...
714215d42e...b41494f009skia-flutter-autoroll@skia.org Roll Dart SDK from 6d659f880394 to 475e710429ee (1 revision) (flutter/engine#50763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 19:38:37 +00:00
Gustl22
9620e3f69c
Reland (2): "Fix how Gradle resolves Android plugin" ( #142498 )
...
Previous PR: #137115 ,
Revert: #142464
Fixes #141940
Closes #142487
2024-02-19 18:07:33 +00:00
engine-flutter-autoroll
05daee3d91
Roll Packages from 0af905d779d5 to 84ff11d7ee5a (1 revision) ( #143710 )
...
0af905d779...84ff11d7eeengine-flutter-autoroll@skia.org Roll Flutter from d7867ca7d635 to 064c340baf0e (33 revisions) (flutter/packages#6161 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 17:53:16 +00:00
engine-flutter-autoroll
064c340baf
Roll Flutter Engine from f71b7eee2266 to 714215d42e57 (1 revision) ( #143708 )
...
f71b7eee22...714215d42eskia-flutter-autoroll@skia.org Roll Skia from 6eaa7cf6d013 to ff602d384586 (1 revision) (flutter/engine#50762 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 16:30:24 +00:00
engine-flutter-autoroll
d2e7414a92
Roll Flutter Engine from 07c73b0c8413 to f71b7eee2266 (2 revisions) ( #143694 )
...
07c73b0c84...f71b7eee22tessertaha@gmail.com Revert "Fix iOS password autofill prompt dismissal causes layout to resize (#50364 )" (flutter/engine#50760 )
2024-02-19 skia-flutter-autoroll@skia.org Roll Skia from a4ff02094bbd to 6eaa7cf6d013 (4 revisions) (flutter/engine#50759 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 11:48:37 +00:00
engine-flutter-autoroll
74e054f04a
Roll Flutter Engine from 80d6745c6fd6 to 07c73b0c8413 (1 revision) ( #143682 )
...
80d6745c6f...07c73b0c84skia-flutter-autoroll@skia.org Roll Skia from b0680ba29971 to a4ff02094bbd (1 revision) (flutter/engine#50756 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 06:23:24 +00:00
engine-flutter-autoroll
4c8e30cc7f
Roll Flutter Engine from 67abf6eb36a1 to 80d6745c6fd6 (1 revision) ( #143676 )
...
67abf6eb36...80d6745c6fskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uSZ0te7RWVq4IFpjb... to HFmcvzkR3TYeHa_0U... (flutter/engine#50752 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uSZ0te7RWVq4 to HFmcvzkR3TYe
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-19 00:58:28 +00:00
engine-flutter-autoroll
043faccecf
Roll Flutter Engine from 8ae232196fc9 to 67abf6eb36a1 (1 revision) ( #143673 )
...
8ae232196f...67abf6eb36matanlurey@users.noreply.github.com Write `adb logcat` results and screenshots to `FLUTTER_LOGS_DIR` if able. (flutter/engine#50722 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-18 22:02:24 +00:00
engine-flutter-autoroll
3578e75ef2
Roll Flutter Engine from f636f9635438 to 8ae232196fc9 (1 revision) ( #143659 )
...
f636f96354...8ae232196fskia-flutter-autoroll@skia.org Roll Skia from 0d2dbf53aef6 to b0680ba29971 (1 revision) (flutter/engine#50748 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-18 02:55:28 +00:00
yim
bce848ebf9
Fixed the issue of incorrect item position when prototypeItem is set in SliverReorderableList. ( #142880 )
...
Fixes #142708
2024-02-18 02:30:18 +00:00
yim
73c26a1c0b
ShowCaretOnScreen is correctly scheduled within a SliverMainAxisGroup ( #141671 )
...
Fixes #141577
Fixes #135407
2024-02-18 02:28:22 +00:00
engine-flutter-autoroll
deaf53ef7e
Roll Flutter Engine from 0ebd580cb8a7 to f636f9635438 (1 revision) ( #143657 )
...
0ebd580cb8...f636f96354bdero@google.com [Impeller] Fix golden flake due to rand use. (flutter/engine#50743 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-18 01:14:24 +00:00
engine-flutter-autoroll
fe4ab13cf4
Roll Flutter Engine from c807aeaab89c to 0ebd580cb8a7 (1 revision) ( #143655 )
...
c807aeaab8...0ebd580cb8skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from YN5KCfom7Ax0Z69s_... to uSZ0te7RWVq4IFpjb... (flutter/engine#50746 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from YN5KCfom7Ax0 to uSZ0te7RWVq4
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-17 23:00:19 +00:00
engine-flutter-autoroll
b9030461ca
Roll Flutter Engine from e51d4f1e285a to c807aeaab89c (4 revisions) ( #143652 )
...
e51d4f1e28...c807aeaab8skia-flutter-autoroll@skia.org Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (flutter/engine#50744 )
2024-02-17 jonahwilliams@google.com [Impeller] add additional setup method that caches more pipelines, warms internal shader code (flutter/engine#50521 )
2024-02-17 bdero@google.com [Impeller] Assign subpass depth on restore rather than creation. (flutter/engine#50626 )
2024-02-17 skia-flutter-autoroll@skia.org Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (flutter/engine#50739 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-17 21:52:33 +00:00
Jason Simmons
2d48ab757c
Manual roll Packages from c56c12dd51ef to 0af905d779d5 ( #143651 )
...
0af905d77 [flutter_migrate] Implement lineTerminator in the MemoryStdout fake (flutter/packages#6152 )
f865bafd8 Raise gradle wrapper version of legacy project (flutter/packages#6132 )
b4d8ad719 Bump github/codeql-action from 3.24.1 to 3.24.3 (flutter/packages#6142 )
cc34b78a0 [ci/various] Update for 3.19 stable (flutter/packages#6147 )
10a8b76ad Roll Flutter (stable) from 41456452f29d to bae5e49bc2a8 (1550 revisions) (flutter/packages#6145 )
a36071b5e Roll Flutter from a628814ebd25 to d7867ca7d635 (66 revisions) (flutter/packages#6146 )
2024-02-17 20:18:25 +00:00
Jason Simmons
8036488776
Add an override annotation to the lineTerminator setter in the MemoryStdout fake class ( #143646 )
...
This is required by a new API recently added to Dart.
See https://github.com/flutter/flutter/issues/143614
2024-02-17 16:41:27 +00:00
Bruno Leroux
8a5efa53d8
InputDecorator M3 tests migration - Step3 ( #143520 )
...
## Description
This PR is the third step for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
This PR moves some tests out of the 'Material2' group (the ones that are ok on M3).
@justinmc The diff is almost unreadable, I moved the tests as carefully as possible and I checked that before and after the number of tests is exactly the same.
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
## Tests
Move some tests from 'Material2' group to main().
2024-02-17 07:34:35 +00:00
Bruno Leroux
13ed551e19
Update InputDecoration.contentPadding documentation ( #143519 )
...
## Description
This PR updates the `InputDecoration.contentPadding` documentation to detail both Material 3 and Material 2 default values.
## Related Issue
Follow-up to https://github.com/flutter/flutter/pull/142981 .
## Tests
Documentation only.
2024-02-17 07:24:34 +00:00
Jonah Williams
ae1488cfe8
[Impeller] skip selectable text goldens for instability. ( #143627 )
...
Similar to other issues, appears that text goldens are really unstable with Impeller.
Part of https://github.com/flutter/flutter/issues/143616
2024-02-17 04:21:17 +00:00
engine-flutter-autoroll
789acb324d
Roll Flutter Engine from 2ed159a786ef to e51d4f1e285a (2 revisions) ( #143624 )
...
2ed159a786...e51d4f1e28robert.ancell@canonical.com Connect signals in swapped form. (flutter/engine#50705 )
2024-02-17 jason-simmons@users.noreply.github.com Restore use of the API 34 device in the Firebase Test Lab script and handle FTL infrastructure errors in the script (flutter/engine#50735 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-17 02:21:28 +00:00
Jonah Williams
4e27f3472c
[Impeller] skip perspective transformed text goldens. ( #143623 )
...
Part of https://github.com/flutter/flutter/issues/143616
The perspective transformed text goldens are super unstable, possibly for the same reason they are in flutter/engine.
2024-02-17 02:13:22 +00:00
Jonah Williams
bb1c7a6ccb
[framework] Skip 5 failing framework tests. ( #143618 )
...
Part of https://github.com/flutter/flutter/issues/143616
2024-02-17 01:18:33 +00:00
engine-flutter-autoroll
e0f126a45e
Roll Flutter Engine from afb270929a6c to 2ed159a786ef (1 revision) ( #143622 )
...
afb270929a...2ed159a786skia-flutter-autoroll@skia.org Roll Skia from e4e234d412ee to bb61c2b4614e (4 revisions) (flutter/engine#50736 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-17 01:04:06 +00:00
engine-flutter-autoroll
bf1d3dfa8c
Roll Flutter Engine from c4fe6f01e0f5 to afb270929a6c (1 revision) ( #143619 )
...
c4fe6f01e0...afb270929askia-flutter-autoroll@skia.org Roll Skia from 6ae5032133d0 to e4e234d412ee (1 revision) (flutter/engine#50733 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-17 00:22:11 +00:00
Brian Quinlan
e8dcf1909e
Implement lineTerminator in MemoryStdout Fake ( #143608 )
...
https://dart-review.googlesource.com/c/sdk/+/326761/24/sdk/lib/io/stdio.dart#380
added a `lineTerminator` field to `Stdout`.
Add that field to the fake in packages/test.
Fixes https://github.com/flutter/flutter/issues/143614
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-02-16 15:46:01 -08:00
engine-flutter-autoroll
e953a9a097
Roll Flutter Engine from 2eed3fbb293a to c4fe6f01e0f5 (3 revisions) ( #143615 )
...
2eed3fbb29...c4fe6f01e030870216+gaaclarke@users.noreply.github.com Pulled out dir contents golden tool (flutter/engine#50703 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 21b9ee6f0a52 to fa66195a3814 (3 revisions) (flutter/engine#50732 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 2919d86cad12 to 6ae5032133d0 (8 revisions) (flutter/engine#50729 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 23:44:25 +00:00
LongCatIsLooong
c61b9501e3
Don't paint the cursor for an invalid selection ( #143533 )
...
Fixes https://github.com/flutter/flutter/issues/79495
This is basically a reland of https://github.com/flutter/flutter/pull/79607 .
Currently when the cursor is invalid, arrow key navigation / typing / backspacing doesn't work since the cursor position is unknown.
Showing the cursor when the selection is invalid gives the user the wrong information about the current insert point in the text.
This is going to break internal golden tests.
2024-02-16 23:40:26 +00:00
engine-flutter-autoroll
df4205e104
Roll Flutter Engine from 13dc857bf2ef to 2eed3fbb293a (2 revisions) ( #143609 )
...
13dc857bf2...2eed3fbb29jacksongardner@google.com Temporarily disable goldens for Safari. (flutter/engine#50724 )
2024-02-16 kustermann@google.com [web] Remove unused `allowInterop` usage in flutter web code (flutter/engine#50718 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 23:06:28 +00:00
Michael Goderbauer
546bdec7ef
Fix implementation imports outside of lib ( #143594 )
...
Work towards https://github.com/dart-lang/linter/issues/4859
There are libraries outside a `lib/` directory, which violate `implementation_imports`.
Supersedes https://github.com/flutter/flutter/pull/143560 .
2024-02-16 22:38:10 +00:00
Andrew Kolos
3a18473bd6
add parsing of assets transformer declarations in pubspec.yaml ( #143557 )
...
In service of https://github.com/flutter/flutter/issues/143348 .
This PR enables parsing of the pubspec yaml schemes for assets with transformations as described in #143348 .
2024-02-16 22:24:59 +00:00
engine-flutter-autoroll
848aa5080b
Roll Flutter Engine from 5fd5ccf32d08 to 13dc857bf2ef (6 revisions) ( #143607 )
...
5fd5ccf32d...13dc857bf2jonahwilliams@google.com [Impeller] use fewer threads for shader bootstrap workers on low core machines. (flutter/engine#50726 )
2024-02-16 goderbauer@google.com Fix implementation imports outside of lib (flutter/engine#50727 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 87e8e9c8f42b to 2919d86cad12 (8 revisions) (flutter/engine#50723 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Dart SDK from 947c8c487e28 to 21b9ee6f0a52 (2 revisions) (flutter/engine#50717 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from c89a4cd72308 to 87e8e9c8f42b (3 revisions) (flutter/engine#50716 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from fXqP_YC4zTp9G2hA5... to YN5KCfom7Ax0Z69s_... (flutter/engine#50719 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from fXqP_YC4zTp9 to YN5KCfom7Ax0
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 22:24:56 +00:00
Michael Goderbauer
50862bc04a
Fix SemanticsFinder for multi-view ( #143485 )
...
Fixes https://github.com/flutter/flutter/issues/143405 .
It was counter-intuitive that a SemanticsFinder without specifying a FlutterView would only search the nodes in the default view. This change makes it so that when no view is specified the semantics trees of all known FlutterViews are searched.
2024-02-16 22:24:55 +00:00
Andrew Kolos
9a6bda87d9
rebuild the asset bundle if a file has been modified between flutter test runs ( #143569 )
...
Fixes https://github.com/flutter/flutter/issues/143513
Should be cherry-picked to beta.
2024-02-16 22:21:08 +00:00
Tirth
1b8742b9dc
Added Missing Field Name in Doc Comment in SnackBarThemeData ( #143588 )
...
Added Missing Field Name in Doc Comment in SnackBarThemeData.
2024-02-16 20:50:07 +00:00
Nate
944cd11d87
Implementing switch expressions [refactoring flutter/lib/src/] ( #143496 )
...
This PR is the 8áµÊ° step in the journey to solve issue #136139 and make the entire Flutter repo more readable.
(previous pull requests: #139048 , #139882 , #141591 , #142279 , #142634 , #142793 , #143293 )
I did a pass through all of `packages/flutter/lib/src/` and found a whole bunch of `switch` statements to improve: most of them were really simple, but many involved some thorough refactoring.
This pull request is just the complicated stuff. ð I'll make comments to describe the changes, and then in the future there will be another PR (and it'll be much easier to review than this one).
2024-02-16 20:19:34 +00:00
engine-flutter-autoroll
383067fc93
Roll Flutter Engine from dd530f1556df to 5fd5ccf32d08 (3 revisions) ( #143593 )
...
dd530f1556...5fd5ccf32djason-simmons@users.noreply.github.com Use the Pixel 7/API 33 device in the Firebase test lab script (flutter/engine#50721 )
2024-02-16 leroux_bruno@yahoo.fr [Web] Ignore invalid keyboard events related to autofill (flutter/engine#50590 )
2024-02-16 jason-simmons@users.noreply.github.com Add the web package to the set of Dart third_party packages in DEPS (flutter/engine#50714 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 19:12:23 +00:00
engine-flutter-autoroll
d7867ca7d6
Roll Packages from ef349bec8ee9 to c56c12dd51ef (5 revisions) ( #143581 )
...
ef349bec8e...c56c12dd5110687576+bparrishMines@users.noreply.github.com [tool] Add support for using a Kotlin test runner file (flutter/packages#6131 )
2024-02-16 louisehsu@google.com [in_app_purchase] fix skerror nullability (flutter/packages#6139 )
2024-02-15 jacksongardner@google.com Explicitly pass the web renderer into the tests. (flutter/packages#6140 )
2024-02-15 stuartmorgan@google.com [google_sign_in] Clean up pre-Pigeon code (flutter/packages#6141 )
2024-02-15 stuartmorgan@google.com [local_auth] Add compatibility with latest `intl` (flutter/packages#6138 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 15:45:23 +00:00
Taha Tesser
a603a17875
Update MaterialStatesController docs for calling setState in a listener ( #143453 )
...
fixes [Calling `setState` in a `MaterialStatesController` listener and `MaterialStateController.update` causes Exception](https://github.com/flutter/flutter/issues/138986 )
### Description
`MaterialStatesController` listener calls `setState` during build when `MaterialStatesController.update` listener calls `notifyListeners`.
I tried fixing this issue by putting `notifyListeners` in a post-frame callback. However, this breaks existing customer tests (particularly super editor tests).
A safer approach would be to document that the listener's `setState` call should be in a post-frame callback to delay it and not call this during the build phase triggered by the `MaterialStatesController.update` in the widgets such as InkWell or buttons.
2024-02-16 07:43:50 +00:00
Taha Tesser
8129797045
Update DataTable docs for disabled DataRow ink well ( #143450 )
...
fixes [[`DataTable`] Data row does not respond to `MaterialState.hovered`](https://github.com/flutter/flutter/issues/138968 )
2024-02-16 06:56:59 +00:00
engine-flutter-autoroll
6ee7e24bfe
Roll Flutter Engine from b7103bc8b374 to dd530f1556df (17 revisions) ( #143565 )
...
b7103bc8b3...dd530f1556skia-flutter-autoroll@skia.org Roll Dart SDK from 9bbac4d40725 to 947c8c487e28 (1 revision) (flutter/engine#50709 )
2024-02-16 skia-flutter-autoroll@skia.org Roll Skia from 3cbb5d6a71fe to c89a4cd72308 (2 revisions) (flutter/engine#50708 )
2024-02-16 737941+loic-sharma@users.noreply.github.com [Windows] Improve `FlutterWindow` unit tests (flutter/engine#50676 )
2024-02-16 zanderso@users.noreply.github.com [et] Adds a logger (flutter/engine#50693 )
2024-02-15 matanlurey@users.noreply.github.com Update README.md (flutter/engine#50702 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 078b316e0563 to 3cbb5d6a71fe (2 revisions) (flutter/engine#50704 )
2024-02-15 tugorez@users.noreply.github.com Move the accesibility placeholder to the platform dispatcher. (flutter/engine#50608 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699 )
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677 )
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696 )
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657 )
2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694 )
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687 )
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-16 05:51:06 +00:00
Jason Simmons
6f6950b12b
Manual roll Flutter Engine from b7103bc8b374 to 7de84271eb65 ( #143564 )
...
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from a8e4db1afac5 to 078b316e0563 (4 revisions) (flutter/engine#50700 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Dart SDK from 5e442dc80903 to 9bbac4d40725 (2 revisions) (flutter/engine#50699 )
2024-02-15 26625149+0xZOne@users.noreply.github.com [Android] Remove the unnecessary parent interface. (flutter/engine#50677 )
2024-02-15 bdero@google.com [Impeller] Add an error message when failing to write golden screenshot. (flutter/engine#50698 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 6ee2b5f61ae5 to a8e4db1afac5 (5 revisions) (flutter/engine#50696 )
2024-02-15 68449066+zijiehe-google-com@users.noreply.github.com [Fuchsia] Run arm64 tests on terminal.qemu-arm64 on x64 hosts (flutter/engine#50657 ) 2024-02-15 30870216+gaaclarke@users.noreply.github.com [Impeller] Updated benchmarks (flutter/engine#50694 )
2024-02-15 godofredoc@google.com Documentation for test timeouts. (flutter/engine#50687 )
2024-02-15 zanderso@users.noreply.github.com Shift some Linux builders from Goma to RBE (flutter/engine#50653 )
2024-02-15 skia-flutter-autoroll@skia.org Roll Skia from 12d0b7fac4c3 to 6ee2b5f61ae5 (1 revision) (flutter/engine#50691 )
2024-02-16 04:35:36 +00:00
