firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
36,598 Commits 1 Branch 0 Tags
Commit Graph

74 Commits

Author SHA1 Message Date
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing (#33688)" (#36094) 
This reverts commit eb0b17902876f1a75eb7180c0b9f3571efb312b8.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
 2019-07-12 13:35:36 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing (#33688) 
* Fresh PR for Gold integration.

* Nits

* WIP

* Artifacts from merge

* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.

* Updating for CI implementation

* Write out service account

* Writing to skip out

* WIP

* ++

* Fixing depot tools deps

* Windows depot_tools

* Fixing setup scripts

* ++

* depot tools

* ++

* WIP

* Tracing depot_tools clone

* WIP

* ++

* analyzer

* WIP

* chrome typo

* copy artifact

* Working on tests

* Code cleanup

* ++

* Code cleanup, updated tests

* ++ review feedback

* Review

* Analyzer

* Review feedback

* Nits from review

* PRogress

* ++

* Fixing tests

* ++

* Testing repo route

* Just needing documention around new structures.

* cleanup

* Analyzer

* Documentation updates

* Documentation updates

* Cirrus updates

* cirrus nit

* Review feedback

* Review feedback

* Fixing skip comparator

* Fix base directory for Skia Gold case

* ++

* Feedback

* ++

* Fixed uri assertion

* Made GoldensClient abstract, altered SkiaGoldClient constructor

* Analyzer
 2019-07-12 12:23:04 -07:00
Kate Lovett
829bdeb426
Fixing accidental merge from WIP branch. (#32520) 
Revert "Merge branch 'master' into master"

This reverts commit e3a03c04c4530b06e77383fd73d2c43644dc832a, reversing
changes made to 64749826498123e795c77f9bec8cea804a40a051.
 2019-05-10 15:53:41 -07:00
Kate Lovett
fdd554fb46 Anaalyzer fixes. 2019-04-25 15:59:48 -07:00
Kate Lovett
8861e9f3dc Cleanup 2019-04-25 14:51:59 -07:00
Kate Lovett
e332ab859a Changed implementation to incorpoarate new init feature for goldctl. Reduces redundant work as well. 2019-04-25 12:18:56 -07:00
Kate Lovett
1fcd1b02de Changes for uploading baseline images. 2019-04-24 13:38:49 -07:00
Kate Lovett
beebd5c4a7 Progress. 2019-04-19 15:00:13 -07:00
Kate Lovett
7e542fc334 Committing progress. 2019-04-19 14:33:49 -07:00
Kate Lovett
9e3e44ee3d Committing test progress. 2019-04-19 11:32:16 -07:00
Kate Lovett
4f29c31048 Updating inline documentation 2019-04-19 10:19:31 -07:00
Kate Lovett
b6a2efb7ab Committing progress. Documentation and testing incomplete/in progress. Code cleanup needed as well. 2019-04-18 16:08:09 -07:00
Jonah Williams
70c6fb1fbb
Remove package:collection dependency usage from flutter_goldens (#24218) 2018-11-11 10:57:41 -08:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138) 
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
 2018-09-12 08:29:29 +02:00
Amir Hardon
592731f220 Clone goldens as part of flutter update-packages. 
flutter_tools cannot depend on flutter_goldens (as flutter_goldens
depdends on the Flutter sdk), so this commit splits client.dart from
flutter_goldens to a pure-dart flutter_goldens_client package.
 2018-08-20 14:29:26 -07:00
amirh
ed533e9033
Split GoldensClient out of flutter_goldens.dart (#20102) 
This enables using GoldensClient from the flutter driver file for the
embedded Android views test.

flutter_goldens.dart has a transitive dependency on dart:ui so it cannot
be included in non Flutter apps. Splitting it out allows us to use it
from driver tests.

This also removes the visibleForTesting annotation from GoldensClient.
 2018-08-01 17:03:47 -07:00
Leaf Petersen
32f94443cc
Remove uses of deprecated constants and change int.parse to int.tryParse (#19575) 
* Remove uses of deprecated constants
* Change int.parse to int.tryParse where appropriate
 2018-07-20 15:07:24 -07:00
Alexandre Ardhuin
09276bea25
enable lint prefer_equal_for_default_values (#18156) 2018-06-05 08:50:40 +02:00
Ian Hickson
ca94bfdfc6 Factor our common Paint-building code used with BoxShadow (#17363) 2018-05-09 22:42:38 -07:00
xster
372ac6d5d4
Let goldens push via ssh by default (#17369) 2018-05-07 21:52:50 -07:00
Todd Volkert
d820e5f3b1
Use deprecated io constants (#17278) 
The new values are not ready for use yet inside Google
 2018-05-03 22:27:29 -07:00
Yegor
b2c98f9a4e
Roll engine to e976be13c51448f89107d082ec81e2b6731671fa (#17266) 
* Roll engine to e976be13c51448f89107d082ec81e2b6731671fa

* move away from deprecated constants
 2018-05-03 19:24:48 -07:00
Todd Volkert
c8908ff0e2
Follow-on work to goldens (#17267) 
* Exclude flutter_goldens package from dartdoc because it's for internal
  use only
* Document why flutter_tools doesn' tneed to be excluded from the list of
  packages to document
* Performance optimization in the flutter comparator, and associated
  test updates.
 2018-05-03 17:47:50 -07:00
Todd Volkert
65079ad5f2
Add Flutter-repo-specific golden comparator (#17205) 
In order to avoid checking binaries into flutter/flutter,
this comparator can be used to retrieve golden files from
a sibling flutter/goldens repository.

https://github.com/flutter/flutter/issues/16859
 2018-05-03 07:39:41 -07:00