12213 Commits

Author SHA1 Message Date
liyuqian
b65d3bceaa
2a22019a8d...7dc6b3a8ee (#22441)
git log 2a22019a8dd8..7dc6b3a8eeef --no-merges --oneline
7dc6b3a8e Skip non-existing libflutters for symbol check (flutter/engine#6374)
0cd9ee372 Add more debug loging to symbol verification script (flutter/engine#6372)
fcb3c519b Roll src/third_party/skia b726c89ff8a8..d004e0b55c4a (1 commits) (flutter/engine#6373)
5e3d786d0 Use nm from buildtools (flutter/engine#6371)
2018-09-28 13:19:55 -07:00
liyuqian
783c028f2c
Don't push offset to leaf layers (#21619)
For retained rendering, we don't want to push the offset down to each leaf layer. Otherwise, changing an offset layer on the very high level could cascade the change to too many leaves, which means that we can't retain them.

To not push the offset downwards, we simply push a TransformLayer when there's an offset. Skia has a fast path for concatenating scale/translation-only matrix so this operation should be fast (no performance regression is measured on Moto G4).

This is our first step towards https://github.com/flutter/flutter/issues/21756
2018-09-28 12:21:43 -07:00
Andrew Davies
1c2f478e9e
[frdp][connection] Exception checks in _getDartVm (#22386)
Through some integration testing checks, it looks like it's possible
that connecting to a new instance of the Dart VM may fail even after the
Dart VM instance has been discovered.

This means that _getDartVm should be checked in more than just one
place.  This changes the function to return a null value in the event of
a 'well-known' exception (`HttpException` or `TimeoutException`
specifically).

As a result, code now calling _getDartVm checks for null and handles it
as appropriate, and the DartVm RPC calls are all updated with
consistent timeout params.
2018-09-28 11:40:36 -07:00
shrike69
fd8a9603ac
Remove waitForViews() during hot reload (#22371) 2018-09-28 11:35:38 -07:00
liyuqian
5f739a1ed2
2a22019a8d...9ae1c14c35 (#22434)
git log 2a22019a8dd8..9ae1c14c3515 --no-merges --oneline
9ae1c14c3 Update observatory-port default behavior description. (flutter/engine#6365)
5550fdbc2 Remove cull_rects_ from SceneBuilder (flutter/engine#6352)
75e404f39 Roll src/third_party/skia 656cefe65d62..b726c89ff8a8 (8 commits) (flutter/engine#6370)
2018-09-28 11:24:41 -07:00
liyuqian
598ef49051
Put opacity image source inside "Sample code" (#22385)
See https://github.com/flutter/flutter/pull/22278#pullrequestreview-159230244
2018-09-28 11:10:11 -07:00
liyuqian
a0944bb228
Revert "Roll engine 2a22019a8dd8..51de09c7e0e1 (10 commits) (#22426)" (#22433)
This reverts commit 7b2d34621df04e413334b724cd2f4aaef82627aa.
2018-09-28 10:23:07 -07:00
engine-flutter-autoroll
7b2d34621d Roll engine 2a22019a8dd8..51de09c7e0e1 (10 commits) (#22426)
2a22019a8d...51de09c7e0

git log 2a22019a8dd8..51de09c7e0e1 --no-merges --oneline
51de09c7e Roll src/third_party/skia 10d12834c8db..f88f49d2a52e (1 commits) (flutter/engine#6377)
c0b44bc20 Roll src/third_party/skia d004e0b55c4a..10d12834c8db (1 commits) (flutter/engine#6376)
77c30cadd make sure we dont set live regionin api level < 18 (flutter/engine#6375)
7dc6b3a8e Skip non-existing libflutters for symbol check (flutter/engine#6374)
0cd9ee372 Add more debug loging to symbol verification script (flutter/engine#6372)
fcb3c519b Roll src/third_party/skia b726c89ff8a8..d004e0b55c4a (1 commits) (flutter/engine#6373)
5e3d786d0 Use nm from buildtools (flutter/engine#6371)
9ae1c14c3 Update observatory-port default behavior description. (flutter/engine#6365)
5550fdbc2 Remove cull_rects_ from SceneBuilder (flutter/engine#6352)
75e404f39 Roll src/third_party/skia 656cefe65d62..b726c89ff8a8 (8 commits) (flutter/engine#6370)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-28 09:58:37 -07:00
Dan Field
8081336966
Fix red tree (#22432)
* fix race in devicelab concurrent hot reload

* only complete future once!
2018-09-28 09:43:42 -07:00
Dan Field
2c61067387
fix race in devicelab concurrent hot reload (#22403) 2018-09-28 09:01:39 -07:00
Siva
11ed8aa164
Roll engine version to 2a22019a8dd8d8f6666af55f9d5f15c4c709e3b8 (#22398)
This roll contains the following changes
2a22019a8 Roll Dart to version 7f9a9feae181573cca609fd1b8760d7992176699 (#6366)
0fa159a26 Add debug info to figure out why the bots are unhappy (#6369)
e031ccef7 Add missing binding for pushOffset (#6367)
2018-09-27 21:38:17 -07:00
engine-flutter-autoroll
4b1717a2c1
Roll engine d80c1de7b53a..8176f4d3c467 (3 commits) (#22390)
d80c1de7b5...8176f4d3c4

git log d80c1de7b53a..8176f4d3c467 --no-merges --oneline
8176f4d3c Roll buildroot to 96d2493887daabe6877142caa8504a2f964b0e7e (flutter/engine#6364)
27f77cbef Document that all MethodChannel callbacks must be called on the main thread. (flutter/engine#6245)
e6c173392 Script to verify exported symbols on release binaries (flutter/engine#6363)


The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.
2018-09-27 21:26:32 -04:00
jslavitz
657a41ed8c
Vertical divider (#22377)
* Add vertical divider option.

* added vertical divider

* restored hello world

* final changes

* a few changes

* comment fixes

* added VerticalDivider

* few changes

* comment changes:

* ultra nits
2018-09-27 16:37:33 -07:00
asiva
556568ffe6 Fix quotes. 2018-09-27 15:17:03 -07:00
asiva
5024871a05 Fix error message. 2018-09-27 15:17:03 -07:00
asiva
aef9804784 Roll engine to version d80c1de7b53af81a0b4385eb3f13de1ef77f0d2d
Contains the following changes:

d80c1de7b (HEAD -> master, upstream/master) Roll src/third_party/skia ab3144c3abb9..656cefe65d62 (11 commits) (#6362)
edf6249e0 Add pushOffset to SceneBuilder (#6349)
3a01f3956 Change log level from ERROR to WARNING (#6361)
5ae470845 Roll src/third_party/skia 227d4e10276c..ab3144c3abb9 (11 commits) (#6360)
763627fff Do not export libdart symbols (#6337)
3052dbd79 SystemNavigator.pop can pop w/o UINavigationController (#6341)
0c096f798 Roll src/third_party/skia b3e48afc936d..227d4e10276c (1 commits) (#6359)
b8c2a17a1 Roll src/third_party/skia cfe1264d7465..b3e48afc936d (3 commits) (#6356)
c589b312a Expose push/popRoute on FlutterViewController (#6347)
075b3fcca Roll src/third_party/skia 5ea41fc89b26..cfe1264d7465 (1 commits) (#6355)
2dd9b99aa Roll Dart to version 808ed6238b9262660e31ea826f7aea6cfa3a3493 (#6354)
5b799381f Dont make any binaries specify an X11 dependency. (#6353)
309ac4e1b V0.8.2 fix compile problem with xcode10 (#6339)
26fdd1e4f Roll src/third_party/skia 5767fc042834..5ea41fc89b26 (3 commits) (#6351)
cc44ca5d0 Perform persistent cache stores on the IO thread outside the frame workload. (#6350)
f2a3df97e Wire up the Skia persistent GPU related artifacts cache. (#6278)
2018-09-27 15:17:03 -07:00
xster
6cdf953241 Revert "remove code signing special casing for Googlers (#22287)" (#22376)
This reverts commit 1eb38abdb74e49287dcb18ab818e1a5a687ea4ba.
2018-09-27 14:43:54 -07:00
xster
1eb38abdb7
remove code signing special casing for Googlers (#22287) 2018-09-27 14:03:52 -07:00
James D. Lin
f6c154c39c
Improve Swift usage in platform_channel_swift some more (#22318)
Improve Swift usage in platform_channel_swift some more

Make a bunch of changes that willlarche requested in
https://github.com/flutter/flutter/pull/21712:

* Use `static let` within `enum` namespaces for String constants.
* Use `guard` for early exits and to avoid forced unwrapping.
* Explicitly qualify a selector.
* Fix a retain cycle by using a weak reference.
2018-09-27 13:44:16 -07:00
Jacob Richman
5225f3d235
Revert "Only register WidgetInspectorService extension in debug builds." (#22366)
This reverts commit 11350fed7f9d2088232354a131ca35a6e0aa6307.
2018-09-27 13:39:44 -07:00
MH Johnson
1ad9f01255
Remove extra space in widget_inspector dart doc (#22359) 2018-09-27 15:20:03 -04:00
xster
79dae000c8
Support activeIcon in CupertinoTabBar (#22323) 2018-09-27 11:17:00 -07:00
liyuqian
d5b21997f4
Roll engine 38a646e14cc2..9d4b80a60cb5 (13 commits) (#22358)
38a646e14c...9d4b80a60c

git log 38a646e14cc2..9d4b80a60cb5 --no-merges --oneline
9d4b80a60 Roll src/third_party/skia 17282da3aa94..5767fc042834 (8 commits) (flutter/engine#6348)
ef98dcb11 Add support for counter timeline traces from the engine. (flutter/engine#6315)
a961e96d1 Roll buildroot to pick up updated vs toolchain. (flutter/engine#6346)
d6bb59978 Fixed IsolateNameServer documentation (flutter/engine#6344)
0c854ac01 Roll src/third_party/skia bdf1431686c2..17282da3aa94 (4 commits) (flutter/engine#6345)
e394ea1dd Roll src/third_party/skia c05302bc84da..bdf1431686c2 (1 commits) (flutter/engine#6343)
bcdfc2312 Roll src/third_party/skia 5457141b011e..c05302bc84da (1 commits) (flutter/engine#6342)
a861f37f7 Pass on the new unsafe-package-serialization option (flutter/engine#6331)
5e77a1e46 Roll src/third_party/skia bd03b54cb98d..5457141b011e (1 commits) (flutter/engine#6340)
6332db875 Roll src/third_party/skia f18c297cfb74..bd03b54cb98d (1 commits) (flutter/engine#6338)
a08bc52e8 Roll src/third_party/skia 7ffa40cedbc4..f18c297cfb74 (6 commits) (flutter/engine#6336)
8247ce26b Implement restore functions on Android and iOS (flutter/engine#6322)
2ead5c06c Roll src/third_party/skia 4ef464cd3c2e..7ffa40cedbc4 (10 commits) (flutter/engine#6334)
2018-09-27 10:49:31 -07:00
Peter Zagoranski
acbef6aac4 Added elevation to BottomSheet (#21998) 2018-09-27 10:08:33 -07:00
Derek Hannah
fafd615a81 updated Flutter Doctor grammar (#19676)
* updated Flutter Doctor grammar

* updated messaging based on a suggestion by Greg Spencer

* grammar update
2018-09-27 09:47:36 -07:00
James D. Lin
1dc3e98af0 Fix a retain cycle in the Objective-C platform_channel example (#22321) 2018-09-27 09:45:50 -07:00
Yasutaka Kawamoto
7d47f04ddc Removed then (#22346) 2018-09-27 18:20:11 +02:00
Øystein K
35e9a84c0e Added more cupertino icons (#22347)
Microphone, clock, time, padlock and eye icons added (both outlined and solid)
2018-09-27 09:16:13 -07:00
Michael Klimushyn
020fd590b0
Prevent dropdown menu's scroll offset from going negative (#22235)
In long lists this resulted in the dropdown scrolling to the very last
item in its list. Now clamping the value at `0.0`. Added a test to
verify that the selected item aligns with the button to test the offset.

Fixes flutter/flutter#15346
2018-09-26 14:28:26 -07:00
Jonah Williams
63f2fb9f5d
Add coverage directory to fuchsia coverage script (#22236) 2018-09-26 13:17:20 -07:00
liyuqian
84c61ad640
Add doc for transparent image inside Opacity (#22278) 2018-09-26 13:03:26 -07:00
James D. Lin
960d669897
Make platform_channels_swift use more idiomatic Swift (#21712)
Make platform_channels_swift use more idiomatic Swift

* Remove semicolons.
* `if (condition)` => `if condition`.
* `Class.init(...)` => `Class(...)`.
* Remove `break` statements from `switch` cases.
* Remove some unnecessary uses of `self`.
2018-09-26 11:13:10 -07:00
MH Johnson
a2dbc20b77
[Documentation] Replaced lerp dart docs with macro (#22309) 2018-09-26 13:12:18 -04:00
Greg Spencer
306bcbde8a Fixes terse doctor output when no devices available. (#22108) 2018-09-26 09:33:08 -07:00
Yegor
f16d005d66
remove _ListenerMixin, which provides dubious value (#22268)
* remove _ListenerMixin, which provides dubious value

* remove trailing whitespace
2018-09-26 09:30:45 -07:00
xster
6b94e6b168 Fix picker demo safe area layout (#22244) 2018-09-26 09:28:27 -07:00
Hans Muller
63efe4c4ac
Fix some TabBarTheme mergeOs (#22285) 2018-09-26 09:11:18 -07:00
Mikkel Nygaard Ravn
52697ef962 Fixes to support add2app on iOS (#22277)
* Fix xcode_backend.sh script to support add2app

* Fix ios deployment target. Too old for new Xcode.

* Fix ios host app

* Register plugins with Flutter view
2018-09-26 01:57:05 -04:00
Michael Goderbauer
eda228404c
Strip debug symbols from App.framework for non-debug builds (#22245)
A dSYM file is created for the stripped `App.framework` and placed at `build/aot/App.dSYM`.

Reduces `App.framework` for Flutter Gallery by 6MB uncompressed, minus 23%.
Reduces `App.framework` for Hello World by 1.6MB uncompressed, minus 22%.

Fixes #4287.
Fixes #18693.
Helps with #21813.
See also #12012.

This change depends on https://dart-review.googlesource.com/c/sdk/+/76306.
2018-09-26 00:57:39 +02:00
Aart Bik
f330e27dbd
Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133 (#22271)
* Roll Dart to 4cf2d3990bac1f1df2f524899e1560a3683f3133

Included CLs:

4cf2d3990b [VM runtime] Store Smi instance type in type test cache when using the interpreter.
a6b1a99f4c Make mixins abstract by default
ab305f2f26 Recover from duplicated declarations
4e32a356e0 Ignore synthetic elements created by the parser
fc04f56430 [infra] Remove deleted Dart 1 builders (app/precomp) from the test matrix
8477dc2131 Update status after 570fd5a7884
1652850381 Compute static types during impact computation
b4341f02db Remove unneeded method rti need
570fd5a788 Error on re-export, export and import of libraries with same name.
4b312b2b8c Support multiple superclasses in the mixin `on` clause.
8debb4e9db [fuchsia] Add zx_vmo_replace_as_executable calls
d34337aa2d Ignore noSuchMethod() for the purpose of searching concrete member implementations.
b6284b41e3 Revert "[VM] Dart_Initialize no longer crashes after Dart_Cleanup"
94481adbd4 [vm] Only include debugger/profiler slots in RawCode in product mode.
519ee905f9 [VM] Dart_Initialize no longer crashes after Dart_Cleanup
53497549ab [vm] Specialize 'new List()' on kernel AST
afd4cc9d1a [vm/tfa] Infer concrete class of int literals in TFA
a4d48f49e7 [vm/tfa] Infer concrete class of string literals in TFA
9106228a55 [vm, dwarf] Set default_is_stmt to true for compatability with dsymutil.
6ce0dc0006 dartfix stub implementation
e4eb2437b8 Look into superclassConstraints while searching for a member in interfaces.
95d37b0921 Revert "Implement inheritance/override checks from the spec."
355c73d4ee [VM] Remove support for option --no-preview-dart-2
95b8a19a20 Mixin declarations don't have supertype, fix isMoreSpecificThan().
e9586a5d14 [vm] Update workaround for Android Kernel bug (b089d4f).
ef7d144bc7 Add regression test for issue 34392.
56f6c52d58 large_class_declaration_test is slow now.
0ac3b8fff9 [fuchsia] Add missing vm:entry-point annotation
19e844ed5b [dart/fuzzing] Use current directory as SDK top (by default)
58e44c1400 Don't use ClassElementImpl for now in override checking.
62d154f6a3 [vm/bytecode] Record null-initialized fields in bytecode
70cc34df21 Custom format errors and exceptions to show traces
95831136b4 Fix NPE when accessing superclass
836a1d7a88 Implement inheritance/override checks from the spec.
d07039782a Remove redundant resolution
dba8b37d38 [vm] Benchmark for reading kernel bytecode

* Move one revision later.

Rationale:
Relatively harmless change, but at least has
builds (force builds on the older revision
will take a while again).
2018-09-25 15:54:50 -07:00
MH Johnson
f37c235c32
[Material] Add TabBarTheme (#22012)
* Add tab bar theme.

* Add tab bar theme.

* Add tests, pass context to getters.

* update goldens from linux box

* update goldens from linux box

* Added new golden test, addressed comments

* override hashCode and == in TabBarTheme

* Fix comment typos

* Addressed Hans' comments.

* Formatting changes

* [TabBarTheme] Fixed spacing

* [TabBarTheme] Update goldens version to latest commit
2018-09-25 17:45:40 -04:00
Hans Muller
6c00bf98ee
Fix overscroll_demo in the a11y contrast test (#22276) 2018-09-25 14:38:25 -07:00
Kathy Walrath
387c458a98
Really fix the flutter dartdoc link (#22266)
It turns out that #21888 didn't really fix the link, because *this* is the README used by dartdoc for flutter.
2018-09-25 14:35:08 -07:00
Mikkel Nygaard Ravn
a600fe7f13 Support materializing Flutter module host app on iOS (#21276)
* Prototype

* Fix paths to Flutter library resources

* Invoke pod install as necessary for materialized modules

* Add devicelab test for module use on iOS

* Remove debug output

* Rebase, reame materialize editable

* Add devicelab test editable iOS host app

* Removed add2app test section
2018-09-25 15:21:13 -04:00
Dan Field
5c07e6dff7
fix analyzer (#22273) 2018-09-25 14:29:09 -04:00
Dan Field
ea5435c2ef
Widgets app refactor (#22269)
* Refactor of cupertino/material/widgets app

* update docs 

* Update tests for const
2018-09-25 13:57:12 -04:00
Hans Muller
582f35dfb1
PageTransitionsTheme, new MountainView page transition (#21715)
MaterialPageRoute transitions are now defined by the Theme. Added (optional) support for Android P style page transitions.
2018-09-25 10:56:29 -07:00
Greg Spencer
eadd59a9ec
Swap out the moon emoji used for progress spinner for a single-cell character. (#22243)
Swap out the moon emoji used for progress spinner for a single-cell character.

The moon emoji looked cool, but couldn't be used because of bugs in xterm.js, used for VSCode's terminal, among others. The moon emoji is two character cells wide, but xterm.js doesn't advance by two cells when it adds the emoji, but does go back by two when it backspaces.

This changes us to a different character animation (dots) that is only one cell wide, and so doesn't have this problem.
2018-09-25 10:55:41 -07:00
Dan Field
a52bd81560
Revert "Refactor of cupertino/material/widgets app (#22161)" (#22249)
This reverts commit 61cf946ba8c55c73c9119a203d07b8c025b6aa92.
2018-09-25 00:25:50 -04:00
Dan Field
61cf946ba8
Refactor of cupertino/material/widgets app (#22161)
* Make CupertinoApp and MaterialApp both use WidgetsApp for Navigator

* Make CupertinoApp and MaterialApp const constructors

* Make WidgetsApp routes aware

* Update tests
2018-09-24 23:55:03 -04:00