Ian Hickson
11a9cb7029
Make tests more resilient to Skia gold failures and refactor flutter_goldens for extensive technical debt removal ( #139549 )
...
* Remove all use of global variables.
* Always pass in all dependencies, only create them in main or in tests.
* Pass in the "print" primitive.
* Make all network traffic retry (except when run locally, when it just auto-passes).
* Enable tests to be run in random order.
2023-12-13 04:09:13 +00:00
dependabot[bot]
3da9bc1698
Bump github/codeql-action from 2.22.9 to 2.22.10 ( #140003 )
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 2.22.9 to 2.22.10.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md ">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<p>See the <a href="https://github.com/github/codeql-action/releases ">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<h2>2.22.10 - 12 Dec 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.4. <a href="https://redirect.github.com/github/codeql-action/pull/2016 ">#2016</a></li>
</ul>
<h2>2.22.9 - 07 Dec 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.8 - 23 Nov 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.3. <a href="https://redirect.github.com/github/codeql-action/pull/2001 ">#2001</a></li>
</ul>
<h2>2.22.7 - 16 Nov 2023</h2>
<ul>
<li>Add a deprecation warning for customers using CodeQL version 2.11.5 and earlier. These versions of CodeQL were discontinued on 8 November 2023 alongside GitHub Enterprise Server 3.7, and will be unsupported by CodeQL Action v2.23.0 and later. <a href="https://redirect.github.com/github/codeql-action/pull/1993 ">#1993</a>
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.11.6 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.10.5 and 2.11.5, you can replace <code>github/codeql-action/*@v2</code> by <code>github/codeql-action/*@v2.22.7</code> in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
</ul>
<h2>2.22.6 - 14 Nov 2023</h2>
<ul>
<li>Customers running Python analysis on macOS using version 2.14.6 or earlier of the CodeQL CLI should upgrade to CodeQL CLI version 2.15.0 or later. If you do not wish to upgrade the CodeQL CLI, ensure that you are using Python version 3.11 or earlier, as CodeQL version 2.14.6 and earlier do not support Python 3.12. You can achieve this by adding a <a href="https://github.com/actions/setup-python "><code>setup-python</code></a> step to your code scanning workflow before the step that invokes <code>github/codeql-action/init</code>.</li>
<li>Update default CodeQL bundle version to 2.15.2. <a href="https://redirect.github.com/github/codeql-action/pull/1978 ">#1978</a></li>
</ul>
<h2>2.22.5 - 27 Oct 2023</h2>
<p>No user facing changes.</p>
<h2>2.22.4 - 20 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.1. <a href="https://redirect.github.com/github/codeql-action/pull/1953 ">#1953</a></li>
<li>Users will begin to see warnings on Node.js 16 deprecation in their Actions logs on code scanning runs starting October 23, 2023.
<ul>
<li>All code scanning workflows should continue to succeed regardless of the warning.</li>
<li>The team at GitHub maintaining the CodeQL Action is aware of the deprecation timeline and actively working on creating another version of the CodeQL Action, v3, that will bump us to Node 20.</li>
<li>For more information, and to communicate with the maintaining team, please use <a href="https://redirect.github.com/github/codeql-action/issues/1959 ">this issue</a>.</li>
</ul>
</li>
</ul>
<h2>2.22.3 - 13 Oct 2023</h2>
<ul>
<li>Provide an authentication token when downloading the CodeQL Bundle from the API of a GitHub Enterprise Server instance. <a href="https://redirect.github.com/github/codeql-action/pull/1945 ">#1945</a></li>
</ul>
<h2>2.22.2 - 12 Oct 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.15.0. <a href="https://redirect.github.com/github/codeql-action/pull/1938 ">#1938</a></li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="305f654631https://redirect.github.com/github/codeql-action/issues/2028 ">#2028</a> from github/update-v2.22.10-fe23b5a3e</li>
<li><a href="31e94d8cb1fe23b5a3e1https://redirect.github.com/github/codeql-action/issues/2016 ">#2016</a> from github/update-bundle/codeql-bundle-v2.15.4</li>
<li><a href="183559cea8382a50a028https://redirect.github.com/github/codeql-action/issues/2021 ">#2021</a> from github/mergeback/v2.22.9-to-main-c0d1daa7</li>
<li><a href="458b4226ad5e0f9dbc48b6dc4ba94b1c3b8c867bc0d1daa7f7...305f654631https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.22.9&new-version=2.22.10 )](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
2023-12-12 21:59:10 +00:00
Gray Mackall
9a72e1c699
Allow plugins to use compileSdkPreview ( #131901 )
...
Fixes https://github.com/flutter/flutter/issues/124748
Based (heavily) off https://github.com/flutter/flutter/pull/104662
2023-12-12 20:06:04 +00:00
flutter-pub-roller-bot
eb0890c9da
Roll pub packages ( #139995 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-12 20:06:00 +00:00
Victoria Ashworth
410af14fd8
Select simulator runtime for tests based on Xcode's preferred runtime build ( #139919 )
...
When creating a simulator for a test, select the runtime based on the selected Xcode's preferred build. This is to prevent it from using a runtime greater than its greatest supported version.
Fixes https://github.com/flutter/flutter/issues/139917 .
Example test with both iOS 16 and 17 available: https://chromium-swarm.appspot.com/task?id=6672aca184395a10
2023-12-12 20:05:58 +00:00
engine-flutter-autoroll
da20262276
Roll Flutter Engine from 0c527aa1a215 to 9039ac78cf03 (1 revision) ( #139992 )
...
0c527aa1a2...9039ac78cfskia-flutter-autoroll@skia.org Roll Skia from 053490edfa70 to 7685acfb6221 (1 revision) (flutter/engine#48929 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 18:59:25 +00:00
Tirth
87b8bf646f
[Docs] Added missing CupertinoApp.showSemanticsDebugger ( #139913 )
...
Added missing reference to `CupertinoApp.showSemanticsDebugger`.
Fixes #139897
2023-12-12 17:39:31 +00:00
engine-flutter-autoroll
64c098c3c2
Roll Flutter Engine from 444281eb5c7c to 0c527aa1a215 (2 revisions) ( #139985 )
...
444281eb5c...0c527aa1a2skia-flutter-autoroll@skia.org Roll Skia from e1b4c6d9bc8d to 053490edfa70 (1 revision) (flutter/engine#48925 )
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from fe04635b125f to e1b4c6d9bc8d (1 revision) (flutter/engine#48922 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 17:03:07 +00:00
Jason Simmons
da891d64c0
Update Gallery lockfiles for the new version of the video_player plugin ( #139832 )
...
The video_player plugin was rolled in https://github.com/flutter/flutter/pull/139203 and the lockfiles need to be updated to match
2023-12-12 16:17:24 +00:00
engine-flutter-autoroll
2ff8f795e0
Roll Packages from cb6dbcdd2305 to 80aa46a5a73d (5 revisions) ( #139982 )
...
cb6dbcdd23...80aa46a5a7engine-flutter-autoroll@skia.org Manual roll Flutter from c642f4e012f4 to 97190973d6f5 (25 revisions) (flutter/packages#5648 )
2023-12-12 43759233+kenzieschmoll@users.noreply.github.com [web_benchmarks] Add support for analyzing benchmark results (flutter/packages#5630 )
2023-12-11 louisehsu@google.com [pointer_interceptor] Fully publish pointer_interceptor package (flutter/packages#5640 )
2023-12-11 43054281+camsim99@users.noreply.github.com Manually roll Flutter (stable) from db7ef5bf9f59 to b0366e0a3f08 (8 revisions) (flutter/packages#5632 )
2023-12-11 43054281+camsim99@users.noreply.github.com Manually roll Flutter from f35d049e0d8e to c642f4e012f4 (92 revisions) (flutter/packages#5631 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 15:45:07 +00:00
engine-flutter-autoroll
872f375b00
Roll Flutter Engine from 3b77b1b7b42f to 444281eb5c7c (1 revision) ( #139979 )
...
3b77b1b7b4...444281eb5cskia-flutter-autoroll@skia.org Roll Skia from 3bbb159b476f to fe04635b125f (1 revision) (flutter/engine#48920 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 12:53:27 +00:00
engine-flutter-autoroll
31abc0a46e
Roll Flutter Engine from f8e87ed193f5 to 3b77b1b7b42f (1 revision) ( #139977 )
...
f8e87ed193...3b77b1b7b4skia-flutter-autoroll@skia.org Roll Skia from 9ee61bf39374 to 3bbb159b476f (1 revision) (flutter/engine#48917 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 12:16:54 +00:00
flutter-pub-roller-bot
e278279a48
Roll pub packages ( #139969 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-12 10:12:26 +00:00
engine-flutter-autoroll
27eabd61e9
Roll Flutter Engine from 4102c7daf1d3 to f8e87ed193f5 (3 revisions) ( #139963 )
...
4102c7daf1...f8e87ed193flutter/engine#48916 )
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 0b3bebcd0907 to 9ee61bf39374 (1 revision) (flutter/engine#48915 )
2023-12-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 9113869cad5f to 82c4571bb2de (1 revision) (flutter/engine#48914 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 08:40:26 +00:00
engine-flutter-autoroll
bf660493a0
Roll Flutter Engine from 95dfb1d4ac75 to 4102c7daf1d3 (1 revision) ( #139961 )
...
95dfb1d4ac...4102c7daf1skia-flutter-autoroll@skia.org Roll Skia from f436b5ea0e62 to 0b3bebcd0907 (1 revision) (flutter/engine#48912 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 07:17:21 +00:00
engine-flutter-autoroll
2edb08b05c
Roll Flutter Engine from 40bfd2dc1519 to 95dfb1d4ac75 (1 revision) ( #139959 )
...
40bfd2dc15...95dfb1d4acskia-flutter-autoroll@skia.org Roll Skia from 6e3dca50f506 to f436b5ea0e62 (5 revisions) (flutter/engine#48911 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 06:07:22 +00:00
engine-flutter-autoroll
3640b21bdd
Roll Flutter Engine from 061ae7023f10 to 40bfd2dc1519 (2 revisions) ( #139958 )
...
061ae7023f...40bfd2dc15skia-flutter-autoroll@skia.org Roll Skia from 3b1f4839952f to 6e3dca50f506 (3 revisions) (flutter/engine#48910 )
2023-12-12 skia-flutter-autoroll@skia.org Roll Skia from 50346ff52bbb to 3b1f4839952f (1 revision) (flutter/engine#48908 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 05:18:22 +00:00
engine-flutter-autoroll
2b55ae3b1a
Roll Flutter Engine from 75cfb050cd9a to 061ae7023f10 (1 revision) ( #139955 )
...
75cfb050cd...061ae7023fskia-flutter-autoroll@skia.org Roll Dart SDK from 53dfedb82222 to 9113869cad5f (1 revision) (flutter/engine#48905 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 04:29:29 +00:00
engine-flutter-autoroll
887048004b
Roll Flutter Engine from 362d0cb3ab27 to 75cfb050cd9a (1 revision) ( #139954 )
...
362d0cb3ab...75cfb050cdskia-flutter-autoroll@skia.org Roll Skia from 461256aac224 to 50346ff52bbb (1 revision) (flutter/engine#48900 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 02:29:25 +00:00
Greg Spencer
49be0586fb
Fix dayPeriodColor handling of non-MaterialStateColors ( #139845 )
...
## Description
This fixes the handling of `dayPeriodColor` on the `TimePicker` so that if it's a non-`MaterialStateColor`, it only applies the color to the selected state, but otherwise uses the given `MaterialStateColor` to get custom behavior.
## Related Issues
- Fixes https://github.com/flutter/flutter/issues/139445
## Tests
- Added tests for both non-`MaterialStateColor` and `MaterialStateColor` cases.
2023-12-12 01:51:13 +00:00
engine-flutter-autoroll
8a96fb33f5
Roll Flutter Engine from ea1a3069e057 to 362d0cb3ab27 (1 revision) ( #139951 )
...
ea1a3069e0...362d0cb3abjonahwilliams@google.com [Impeller] recycle glyph atlas texture more aggressively. (flutter/engine#48888 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 01:42:01 +00:00
Xilai Zhang
32c7c310db
[github actions] Automate Flutter Chery Picks ( #139524 )
...
**design doc: go/easy-cp**
umbrella design doc: go/flutter-actions
umbrella bug: https://github.com/flutter/flutter/issues/139604
**Sample Results**:
1. If cherry pick succeeds, a pull request with cherry pick template and label is created.
https://github.com/flutter/flutter/pull/139523
2. If cherry pick fails, a comment is added under the original Pull Request.
https://github.com/flutter/cocoon/pull/3305
In tests, [7d9010](7d9010c357cf71a55f7dhttps://github.com/XilaiZhang/miscellaneous-side-project/blob/master/.github/workflows/template/cherrypick.md , which is adapted from the [web form cherry pick issue template](https://cs.opensource.google/flutter/flutter/+/master:.github/ISSUE_TEMPLATE/7_cherry_pick.yml ).
This PR template should be reviewed and added to be under the .github path in framework repository.
**Decisions Taken**
1. place of source code
I put the source code under the framework repository. Acknowledges the risk of duplication of code, in favor of not needing to package and publish our own actions to market place.
more details in [open discussions section of design doc](https://docs.google.com/document/d/1EUyJ9NCAltxJq3P3pIzIRVF2ArPUO4cj_eqIUvzl8cw/edit#heading=h.e3zrsz9gwxmp )
2. Resolution strategy
No resolution strategy is applied at all during the cherry pick process. [more details](https://docs.google.com/document/d/1EUyJ9NCAltxJq3P3pIzIRVF2ArPUO4cj_eqIUvzl8cw/edit#heading=h.3za1b9qx6pi2 )
**Future Work**
A PAT token is needed for authorization to create branch and add comment. We would need to create a new bot and update its credentials in the secrets section of flutter/flutter repository.
2023-12-12 01:41:58 +00:00
engine-flutter-autoroll
4444bdf1e5
Roll Flutter Engine from d001419b436e to ea1a3069e057 (5 revisions) ( #139948 )
...
d001419b43...ea1a3069e0skia-flutter-autoroll@skia.org Roll Skia from bd5941d727be to 461256aac224 (1 revision) (flutter/engine#48897 )
2023-12-11 matanlurey@users.noreply.github.com Move `third_party/yapf` to `flutter/third_party/yapf`. (flutter/engine#48847 )
2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from 17bd70326a49 to bd5941d727be (1 revision) (flutter/engine#48896 )
2023-12-11 barpac02@gmail.com SemanticsUpdateBuilder migration: introduce `identifier` (flutter/engine#48882 )
2023-12-11 barpac02@gmail.com Add support for exposing accessibility identifier as accessibilityIdentifier on iOS (flutter/engine#48858 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-12 00:47:35 +00:00
Christopher Fujino
fac41dde7f
[flutter_tools] catch SocketException writing to ios-deploy stdin ( #139784 )
...
Fixes https://github.com/flutter/flutter/issues/139709
This adds a static helper method `ProcessUtils.writelnToStdinGuarded()`, which will asynchronously write to a sub-process's STDIN `IOSink` and catch errors.
In talking with Brian, it sounds like this is the best and most reliable way to catch `SocketException`s during these writes *to sub-process file descriptors* specifically (with a "real" hard drive file, the future returned by `.flush()` should complete with the write error).
Also, as I note in the dartdoc to `writelnToStdinGuarded()`, the behavior seems to be different between macOS and linux.
Moving forward, in any place where we want to catch exceptions writing to STDIN, we will want to use this new helper.
2023-12-12 00:32:18 +00:00
Casey Hillers
815dc96e9b
[ci.yaml] Add missing ci.yaml to runIf of android hot reload tests ( #139932 )
...
https://github.com/flutter/cocoon/pull/3333
2023-12-11 23:55:52 +00:00
Christopher Fujino
03575d7af0
make the tar c command in prepare_package.dart verbose ( #139687 )
...
Help debug https://github.com/flutter/flutter/issues/139597
2023-12-11 23:48:59 +00:00
engine-flutter-autoroll
98e7ed1322
Roll Flutter Engine from 5c1f13e1e535 to d001419b436e (4 revisions) ( #139941 )
...
5c1f13e1e5...d001419b43flutter/engine#48895 )
2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 611fca7f0c20 to 53dfedb82222 (1 revision) (flutter/engine#48891 )
2023-12-11 skia-flutter-autoroll@skia.org Roll Skia from e55567fceb5f to 17bd70326a49 (22 revisions) (flutter/engine#48890 )
2023-12-11 43054281+camsim99@users.noreply.github.com [Android] Add target to have linux_android_emulator_tests run on AVDs with Android 33 & 34 (flutter/engine#48811 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 23:39:07 +00:00
Tim Maffett
2b3a16b459
fix typo of 'not' instead of 'now' for useInheritedMediaQuery ( #139940 )
...
The doc comment for `useInheritedMediaQuery` has a typo of 'not' instead of 'now' and it is confusing at the `@Deprecated()` message clearly states it is *now* ignored.
(and indeed checking the code you can verify that it *is* indeed ignored)
existing code before PR:
```dart
/// {@template flutter.widgets.widgetsApp.useInheritedMediaQuery}
/// Deprecated. This setting is not ignored.
/// ^^^
/// The widget never introduces its own [MediaQuery]; the [View] widget takes
/// care of that.
/// {@endtemplate}
@Deprecated(
'This setting is now ignored. '
'WidgetsApp never introduces its own MediaQuery; the View widget takes care of that. '
'This feature was deprecated after v3.7.0-29.0.pre.'
)
final bool useInheritedMediaQuery;
```
- [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
2023-12-11 23:11:10 +00:00
engine-flutter-autoroll
0f7ac293f7
Roll Flutter Engine from 4c309195b79d to 5c1f13e1e535 (2 revisions) ( #139939 )
...
4c309195b7...5c1f13e1e5matanlurey@users.noreply.github.com Move `third_party/stb` to `flutter/third_party`. (flutter/engine#48845 )
2023-12-11 chillers@google.com [ci.yaml] Add DEPS to emulator tests runIf (flutter/engine#48885 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 22:56:06 +00:00
Nate
140f5eef4c
Implement switch expressions in examples/ and animation/ ( #139882 )
...
Thanks so much for approving the previous PR (#139048 ) a couple weeks ago!
This one is the same, except it's covering files in `examples/` and `packages/flutter/lib/src/animation/`.
(solving issue #136139 )
2023-12-11 22:56:04 +00:00
Tirth
6a61e878a6
Renamed appbar to app_bar directory in API Examples Tests ( #139922 )
...
Tests for `app_bar.0`, `app_bar.1`, `app_bar.2`, `app_bar.3`, `sliver_app_bar.1` and `sliver_app_bar.4` were already present. But directory name was `appbar` rather than `app_bar`. I've renamed the directory to `app_bar` since example files uses that only.
Part of #130459
2023-12-11 22:54:13 +00:00
Greg Spencer
a33dec1a27
Deprecate RawKeyEvent, RawKeyboard, et al. ( #136677 )
...
## Description
This starts the deprecation of the `RawKeyEvent`/`RawKeyboard` event system that has been replaced by the `KeyEvent`/`HardwareKeyboard` event system.
Migration guide is available here: https://docs.flutter.dev/release/breaking-changes/key-event-migration
## Related Issues
- https://github.com/flutter/flutter/issues/136419
## Related PRs
- https://github.com/flutter/website/pull/9889
2023-12-11 22:19:18 +00:00
engine-flutter-autoroll
97190973d6
Roll Flutter Engine from 5587d26aa2d4 to 4c309195b79d (1 revision) ( #139936 )
...
5587d26aa2...4c309195b7mdebbar@google.com [web] PointerBinding per view (flutter/engine#48248 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 21:53:26 +00:00
Renzo Olivares
f60e54b24c
Fix SelectionArea select-word edge cases ( #136920 )
...
This change fixes issues with screen order comparison logic when rects are encompassed within each other. This was causing issues when trying to select text that includes inline `WidgetSpan`s inside of a `SelectionArea`.
* Adds `boundingBoxes` to `Selectable` for a more precise hit testing region.
Fixes #132821
Fixes updating selection edge by word boundary when widget spans are involved.
Fixes crash when sending select word selection event to an unselectable element.
2023-12-11 21:32:55 +00:00
engine-flutter-autoroll
67edaef9b4
Roll Flutter Engine from 9b85b76db0de to 5587d26aa2d4 (3 revisions) ( #139933 )
...
9b85b76db0...5587d26aa2zanderso@users.noreply.github.com Fix _availability_version_check for iOS 11 and 12 (flutter/engine#48624 )
2023-12-11 jonahwilliams@google.com [Impeller] remove trace events that have outlived their usefulness. (flutter/engine#48856 )
2023-12-11 15619084+vashworth@users.noreply.github.com Fix css changes with macOS 13 and Safari (flutter/engine#48807 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 21:13:24 +00:00
engine-flutter-autoroll
6d323e14aa
Roll Flutter Engine from 7eb6b7cab60c to 9b85b76db0de (2 revisions) ( #139931 )
...
7eb6b7cab6...9b85b76db030870216+gaaclarke@users.noreply.github.com [Impeller] made the blur entity test able to use the new blur (flutter/engine#48881 )
2023-12-11 skia-flutter-autoroll@skia.org Roll Dart SDK from cc0067095755 to 611fca7f0c20 (1 revision) (flutter/engine#48880 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 20:29:19 +00:00
LongCatIsLooong
aa609127e7
Use dart analyze package for num.clamp ( #139867 )
...
Extacted from #130101 , dropped the `@_debugAssert` stuff from that PR so it's easier to review.
2023-12-11 20:25:26 +00:00
flutter-pub-roller-bot
44beb843aa
Roll pub packages ( #139926 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-11 18:35:25 +00:00
hangyu
35c52e7bee
Handle the case when _CupertinoBackGestureDetector is disposed during the drag. ( #139585 )
...
Fix #137033
This happens when go_router updates the navigator pages during a user
gesture.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
2023-12-11 10:21:32 -08:00
Bartek Pacia
948523b80c
Add accessibility identifier to SemanticsProperties ( #138331 )
...
This PR adds `String? identifier` to `Semantics` and `SemanticsProperties`. The `identifier` will be exposed on Android as `resource-id` and on iOS as `accessibilityIdentifier`.
Mainly targeted at #17988
Initial Engine PR with Android support: https://github.com/flutter/engine/pull/47961
iOS Engine PR: https://github.com/flutter/engine/pull/48858
### Migration
This change breaks the SemanticsUpdateBuilder API which is on the Framework<-->Engine border. For more details see [engine PR](https://github.com/flutter/engine/pull/47961 ).
Steps:
part 1: [engine] add `SemanticsUpdateBuilderNew` https://github.com/flutter/engine/pull/47961
**part 2: [flutter] use `SemanticsUpdateBuilderNew`** <-- we are here
part 3: [engine] update `SemanticsUpdateBuilder` to be the same as `SemanticsUpdateBuilderNew`*
part 4: [flutter] use (now updated) `SemanticsUpdateBuilder` again.
part 5: [engine] remove `SemanticsBuilderNew`
2023-12-11 18:03:07 +00:00
hgraceb
4252aa0fff
Improve slider's value indicator display test ( #139198 )
...
The previous test for #128137 does not effectively regress and verify #123313 because the issue is specific to desktop platforms.
2023-12-11 17:34:21 +00:00
Mateus Felipe C. C. Pinto
72aafe8619
Add enabled property to ExpansionTile ( #139519 )
...
Adds an `enabled` property to `ExpansionTile` that allows the user to disable the internal `ListTile`, so that we can prevent user interaction.
Fixes #135770 .
2023-12-11 16:03:13 +00:00
engine-flutter-autoroll
935d12cc74
Roll Packages from 6cd0657c4500 to cb6dbcdd2305 (9 revisions) ( #139911 )
...
6cd0657c45...cb6dbcdd23stuartmorgan@google.com [multicast_dns] Adjust README (flutter/packages#5529 )
2023-12-09 stuartmorgan@google.com [tool] Use ^ for Dart SDK (flutter/packages#5623 )
2023-12-09 ditman@gmail.com [google_sign_in_web] Migrate to pkg:web. (flutter/packages#5612 )
2023-12-08 stuartmorgan@google.com [google_maps_flutter] Disable failing iOS tests (flutter/packages#5629 )
2023-12-08 43759233+kenzieschmoll@users.noreply.github.com Add `parse` constructors for the `BenchmarkResults` and `BenchmarkScore` classes (flutter/packages#5614 )
2023-12-08 43054281+camsim99@users.noreply.github.com [path_provider_android] Disable `getExternalStorageDirectories (type: ...)` test (flutter/packages#5619 )
2023-12-08 stuartmorgan@google.com [ci] Fix indentation in labeler.yml (flutter/packages#5625 )
2023-12-08 102626803+drewroengoogle@users.noreply.github.com Update labeler to 5.0.0, fix yml format (flutter/packages#5580 )
2023-12-08 me@nils.re [url_launcher] Adds documentation that a launch needs to be triggered by a user action (flutter/packages#5143 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 15:53:35 +00:00
engine-flutter-autoroll
a9ae39df67
Roll Flutter Engine from bc0222b64c96 to 7eb6b7cab60c (1 revision) ( #139891 )
...
bc0222b64c...7eb6b7cab6skia-flutter-autoroll@skia.org Roll Dart SDK from 79cdacec8bb3 to cc0067095755 (1 revision) (flutter/engine#48874 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-11 06:17:19 +00:00
engine-flutter-autoroll
c0a481e31d
Roll Flutter Engine from fb80aafd259b to bc0222b64c96 (1 revision) ( #139885 )
...
fb80aafd25...bc0222b64cskia-flutter-autoroll@skia.org Roll Dart SDK from ad72e1a31a83 to 79cdacec8bb3 (1 revision) (flutter/engine#48872 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-10 22:46:24 +00:00
flutter-pub-roller-bot
10a31934f2
Roll pub packages ( #139864 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-12-09 15:35:26 +00:00
engine-flutter-autoroll
d90e1e3fb6
Roll Flutter Engine from b75960a5820a to fb80aafd259b (1 revision) ( #139863 )
...
b75960a582...fb80aafd25skia-flutter-autoroll@skia.org Roll Dart SDK from e349db99706d to ad72e1a31a83 (1 revision) (flutter/engine#48867 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-09 14:36:33 +00:00
engine-flutter-autoroll
7c5481caa8
Roll Flutter Engine from e80c090d09c6 to b75960a5820a (1 revision) ( #139853 )
...
e80c090d09...b75960a582skia-flutter-autoroll@skia.org Roll Dart SDK from 9acc6e29b779 to e349db99706d (2 revisions) (flutter/engine#48864 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-09 07:13:14 +00:00
engine-flutter-autoroll
65ad26a162
Roll Flutter Engine from 101396fd3b82 to e80c090d09c6 (2 revisions) ( #139851 )
...
101396fd3b...e80c090d0930870216+gaaclarke@users.noreply.github.com [Impeller] Clamp new blur sigma (flutter/engine#48813 )
2023-12-09 matanlurey@users.noreply.github.com Move `//third_party/tinygltf` to `//flutter/third_party/tinygltf` (flutter/engine#48852 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-09 05:37:09 +00:00
engine-flutter-autoroll
3fc5d264b9
Roll Flutter Engine from 503584615fd7 to 101396fd3b82 (2 revisions) ( #139847 )
...
503584615f...101396fd3bmatanlurey@users.noreply.github.com Roll `buildroot`, deleting `colorama`. (flutter/engine#48854 )
2023-12-08 skia-flutter-autoroll@skia.org Roll Dart SDK from feb35ba49cd7 to 9acc6e29b779 (1 revision) (flutter/engine#48853 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-12-09 01:59:37 +00:00
