17564 Commits

Author SHA1 Message Date
Dan Field
0299398d59
Revert "install goldctl in docker build (#46640)" (#50088)
This reverts commit 7a13d8a0cef7be5fae366fe35fd4cfc3fa05e78a.
2020-02-04 00:00:37 -08:00
Michael Goderbauer
39d13a038f
Allow long filenames setting for customer tests (#50060) 2020-02-03 22:44:45 -08:00
Mehmet Fidanboylu
0c5ae7d656
Use the FlutterVersion defined in context (#50040) 2020-02-03 20:43:02 -08:00
Chris Bracken
b236465bed
Revert "Track lastKnownRemoteTextEditingValue separately from received data (#49406)" (#50082)
This change broke some internal tests that set the text editing value to
the same thing (the empty string) twice in a row. Note that in that
case, the developer had subclassed EditableTextState and overridden the
updateEditingValue method, which may or may not be relevant to the
failure.

This reverts commit 83d4d63a716ec8551f0d59f852a40925ddd73d8a.
2020-02-03 20:40:10 -08:00
Dan Field
26619b3c35
Reland #49925 (#50071)
* Reland "Fix custom Elements that wants to decorate State.build (#49925)" (#50068)"

This reverts commit 62fdcb031945c23dacb481bd464cbea8ec9037d4.

Updates stack filtering for new frames in stateful element
2020-02-03 20:39:49 -08:00
Jonah Williams
50eeda2495
[flutter_tools] fix frontend server generated entrypoint (#50036) 2020-02-03 20:38:03 -08:00
engine-flutter-autoroll
5039e259b7
Roll engine 0816c040fbba..810b9b91e299 (21 commits) (#50083)
0816c040fb...810b9b91e2

git log 0816c040fbba..810b9b91e299 --first-parent --oneline
2020-02-03 anna_gringauze@hotmail.com supporting changes for evaluation in web debugger (flutter/engine#16309)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia f1e316ff39e7..af99f3ee6017 (13 commits) (flutter/engine#16335)
2020-02-03 chinmaygarde@google.com Update buildroot to 02b77827fd4ac639f1c048c6340262cdb4c2a3ab. (flutter/engine#16339)
2020-02-03 chinmaygarde@google.com Disable flaky MessageLoop tests on Fuchsia. (flutter/engine#16340)
2020-02-03 iska.kaushik@gmail.com [fuchsia] Add additional contributing instructions for Googlers (flutter/engine#16337)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/dart ed441e48d055..c8ed304e979a (1 commits) (flutter/engine#16328)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from AtXwP... to Tszo5... (flutter/engine#16334)
2020-02-03 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3d05192abedf..f1e316ff39e7 (3 commits) (flutter/engine#16329)
2020-02-03 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jtwQF... to 6h3IH... (flutter/engine#16332)
2020-02-03 dnfield@google.com Change NSLog to FML_DLOG (flutter/engine#16331)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5d92ae2b56df..3d05192abedf (1 commits) (flutter/engine#16326)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 776293dceefd..5d92ae2b56df (1 commits) (flutter/engine#16325)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1b80c357926b..776293dceefd (2 commits) (flutter/engine#16324)
2020-02-01 dnfield@google.com use echo to test whether host is up (flutter/engine#16322)
2020-02-01 dnfield@google.com Revert "Modifies accessibility bridge to populate new node fields in semantic… (#15116)" (flutter/engine#16323)
2020-02-01 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from x6sVj... to jtwQF... (flutter/engine#16320)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 91a3ea89c8e4..ed441e48d055 (4 commits) (flutter/engine#16319)
2020-02-01 chinmaygarde@google.com Remove all uses of the redundant flutter_root variable. (flutter/engine#16311)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/skia 4513cdde4912..1b80c357926b (1 commits) (flutter/engine#16318)
2020-02-01 skia-flutter-autoroll@skia.org Roll src/third_party/dart 5ae5aff6406a..91a3ea89c8e4 (22 commits) (flutter/engine#16310)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from VMcGV... to AtXwP... (flutter/engine#16308)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-02-03 23:37:41 -05:00
Kaushik Iska
acabf9d589
[fuchsia] Runs stocks driver test on Fuchsia NUCs in devicelab
Also pushes tiles which is needed to host the flutter application on Fuchsia.
2020-02-03 17:55:45 -08:00
Jenn Magder
62fdcb0319
Revert "Fix custom Elements that wants to decorate State.build (#49925)" (#50068)
This reverts commit a1143d174f0e97b1fb831bcf87f438d07f2351d7.
2020-02-03 16:42:47 -08:00
Zachary Anderson
ef62d53222
[flutter_tools] Fix crash on null Android apiVersion (#50029) 2020-02-03 14:48:02 -08:00
creativecreatorormaybenot
abf4e1617d
Docs (RenderObject): minor fix and link to more information (#49992) 2020-02-03 14:43:02 -08:00
Remi Rousselet
a1143d174f
Fix custom Elements that wants to decorate State.build (#49925) 2020-02-03 14:38:07 -08:00
Bogdan Lukin
9e9e741672
fix cupertino selection handle paint with transparent color (#49910) 2020-02-03 14:38:04 -08:00
Jonah Williams
b24bca1383
[flutter_tools] add missing period to end of filter (#50038) 2020-02-03 14:33:08 -08:00
Zachary Anderson
390ed1cd81
[flutter_tools] Move homeDirPath to FileSystemUtils (#49909) 2020-02-03 14:33:03 -08:00
engine-flutter-autoroll
3bee190308
Roll engine e625e174c5df..0816c040fbba (6 commits) (#49927)
e625e174c5...0816c040fb

git log e625e174c5df..0816c040fbba --first-parent --oneline
2020-01-31 mklim@google.com Deprecated FlutterView v1 points to FlutterView v2 (flutter/engine#16304)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 0ee16f689843..4513cdde4912 (13 commits) (flutter/engine#16307)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from 93K0d... to VMcGV... (flutter/engine#16267)
2020-01-31 chinmaygarde@google.com Isolate and move common portable ELF loading from fixtures into //flutter/testing. (flutter/engine#16305)
2020-01-31 jason-simmons@users.noreply.github.com Ensure that Android embedding initialization always uses an application context (flutter/engine#16204)
2020-01-31 chinmaygarde@google.com Fix runtime_unittest in AOT mode by loading AOT symbols from ELF loader. (flutter/engine#16283)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-02-03 17:29:40 -05:00
Jonah Williams
068fa84c5b
[flutter_driver] document caveats with driver method (#50017) 2020-02-03 10:57:28 -08:00
Shi-Hao Hong
e10df3c1a6
Step 1.5 of 3: AboutDialog uses scrollable AlertDialog (#49913) 2020-01-31 19:23:01 -08:00
Dan Field
8600d2305e
Image provider fix (#49920)
* Fix image provider missing early return

* test

* comments

* whitespace, another comment
2020-01-31 19:19:48 -08:00
Dan Field
a1aa3c5b3d
Reland elide long tree walks (#49891) 2020-01-31 19:18:03 -08:00
engine-flutter-autoroll
f98433e79c
Roll engine 6b8c150639b5..e625e174c5df (3 commits) (#49916)
6b8c150639...e625e174c5

git log 6b8c150639b5..e625e174c5df --first-parent --oneline
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/dart 162d6c5634a0..5ae5aff6406a (28 commits) (flutter/engine#16303)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 6305b2f8342a..0ee16f689843 (2 commits) (flutter/engine#16286)
2020-01-31 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from yissX... to x6sVj... (flutter/engine#16288)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 22:15:41 -05:00
Yegor
ff7eb778f6
Respect CHROME_EXECUTABLE in web benchmarks (#49911) 2020-01-31 18:31:08 -08:00
Cristian Zazo
306c23fd36
[web] Fix typo apple-mobile-web-app-status-bar-style (#49894) 2020-01-31 15:38:02 -08:00
engine-flutter-autoroll
d2941340ab
Roll engine 804dca62a17c..6b8c150639b5 (3 commits) (#49908)
804dca62a1...6b8c150639

git log 804dca62a17c..6b8c150639b5 --first-parent --oneline
2020-01-31 gw280@google.com Use static constexpr for iphone_xs_times (flutter/engine#16264)
2020-01-31 30870216+gaaclarke@users.noreply.github.com Started coalescing updates to viewport metrics after foregrounding the app. (flutter/engine#16270)
2020-01-31 chinmaygarde@google.com Remove superfluous INFO logs from //flutter/runtime. (flutter/engine#16280)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 18:34:41 -05:00
Hans Muller
bf4cde74e1
Clarified AppBar toolbar layout API docs (#49583) 2020-01-31 15:33:01 -08:00
Emmanuel Garcia
e03f439145
Reland: Skia gold driver test (#49905) 2020-01-31 14:50:50 -08:00
Alexandre Ardhuin
8061894f05
update template for gen_keycodes (#49884) 2020-01-31 21:58:51 +01:00
Kate Lovett
8b600032ee
Fixing constraints.precedingScrollExtent passed to SliverPadding child (#49433) 2020-01-31 12:58:03 -08:00
Kate Lovett
bc8bfb10f8
Exposing inner controller of NestedScrollView (#49004) 2020-01-31 12:53:03 -08:00
chunhtai
2dc71a343f
reland Refactors global key duplication detection (#49896)
* reland "Refactors global key duplication detection (#46183)"

This reverts commit d2b66dbfcfdad68473fc4366e3042cd2e17706ac.

* fix test
2020-01-31 12:51:42 -08:00
Zachary Anderson
2c51efef29
[flutter_tools] Make Config context-free (#49834) 2020-01-31 12:51:20 -08:00
Emmanuel Garcia
1eb5bb653c
Revert "Use skia golden files in driver test (#49750)" (#49900) 2020-01-31 12:14:08 -08:00
Emmanuel Garcia
a50743f658
Use skia golden files in driver test (#49750) 2020-01-31 11:05:29 -08:00
Prerak Mann
688948b778
switching channel prompts to run flutter upgrade (#49511) 2020-01-31 09:33:29 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations (#49622) 2020-01-31 18:30:21 +01:00
Bogdan Lukin
275ec45ec4
fix material selection handle paint with transparent textSelectionHandleColor (#49830) 2020-01-31 09:28:17 -08:00
Dan Field
b2a27c109c
Be clearer about when and why we override HttpClient in tests (#49844) 2020-01-31 09:22:30 -08:00
Shi-Hao Hong
effc019054
Revert "Elide tree walks (#48413)" (#49886)
This reverts commit 46ccd086745bb9ade53f2457f3bb91942b2af970.
2020-02-01 00:20:04 +08:00
Dan Field
46ccd08674
Elide tree walks (#48413) 2020-01-31 07:09:44 -08:00
engine-flutter-autoroll
aab7bd74c7
Roll engine 74d07b5f6b4f..804dca62a17c (13 commits) (#49873)
74d07b5f6b...804dca62a1

git log 74d07b5f6b4f..804dca62a17c --first-parent --oneline
2020-01-31 yjbanov@google.com Use bundled Roboto in all tests (flutter/engine#16218)
2020-01-31 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#16277)
2020-01-31 skia-flutter-autoroll@skia.org Roll src/third_party/skia 36c0521d57de..6305b2f8342a (8 commits) (flutter/engine#16272)
2020-01-31 jason-simmons@users.noreply.github.com Revert "[web] Correct getPositionForOffset for multi-line paragraphs (#16206)" (flutter/engine#16268)
2020-01-30 stuartmorgan@google.com Fix Windows file checks of unicode paths (flutter/engine#16105)
2020-01-30 iska.kaushik@gmail.com [fuchsia] Fix the import for dart_api.h (flutter/engine#16269)
2020-01-30 iska.kaushik@gmail.com [fuchsia] SceneHostBindings are no longer thread locals (flutter/engine#16262)
2020-01-30 gw280@google.com Pass through invoker.resources in fuchsia_test_archive (flutter/engine#16265)
2020-01-30 matthew-carroll@users.noreply.github.com Notify PlatformViewsController within FlutterEngine when a hot restart occurs. (#48518) (flutter/engine#16230)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/dart fc3af737c759..162d6c5634a0 (209 commits) (flutter/engine#16261)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia d1be5d64f8a7..36c0521d57de (13 commits) (flutter/engine#16260)
2020-01-30 mouad.debbar@gmail.com [web] Correct getPositionForOffset for multi-line paragraphs (flutter/engine#16206)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (flutter/engine#16257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-31 06:01:41 -05:00
Alexandre Ardhuin
5a8de59a66
refactor generateString to emit simpler dart code (#49334) 2020-01-31 11:57:54 +01:00
Alexandre Ardhuin
94210a6632
Revert "Roll engine 74d07b5f6b4f..e5209202fb00 (4 commits) (#49835)" (#49869)
This reverts commit 25f798a1aaaa292c1e30d25b7a6cc54fed38ab45.
2020-01-31 11:10:14 +01:00
Gary Qian
83d4d63a71
Track lastKnownRemoteTextEditingValue separately from received data (#49406) 2020-01-30 18:10:36 -08:00
engine-flutter-autoroll
25f798a1aa
Roll engine 74d07b5f6b4f..e5209202fb00 (4 commits) (#49835)
74d07b5f6b...e5209202fb

git log 74d07b5f6b4f..e5209202fb00 --first-parent --oneline
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/dart fc3af737c759..162d6c5634a0 (209 commits) (flutter/engine#16261)
2020-01-30 skia-flutter-autoroll@skia.org Roll src/third_party/skia d1be5d64f8a7..36c0521d57de (13 commits) (flutter/engine#16260)
2020-01-30 mouad.debbar@gmail.com [web] Correct getPositionForOffset for multi-line paragraphs (flutter/engine#16206)
2020-01-30 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from -mGIA... to 93K0d... (flutter/engine#16257)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC cbracken@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
2020-01-30 21:07:41 -05:00
Jonah Williams
d2b66dbfcf
Revert "Refactors global key duplication detection (#46183)" (#49847)
This reverts commit 340b193f20e85f2cfbebf84fe315112985a38a13.
2020-01-30 17:02:16 -08:00
chunhtai
340b193f20
Refactors global key duplication detection (#46183) 2020-01-30 14:23:02 -08:00
Yegor
423459da18
Initial web benchmark harness and 3 benchmarks (#49460)
Initial web benchmark harness and 3 benchmarks
2020-01-30 14:19:17 -08:00
Greg Spencer
e7baef08a1
Use DiagnosticableMixin instead of Diagnosticable for some conditionals. (#49726)
This PR fixes #49647 by changing DiagnosticableMixin.toDiagnosticsNode and other things to accept DiagnosticableMixin instead of requiring Diagnosticable.
2020-01-30 14:18:09 -08:00
Greg Spencer
6ee8b6546b
Revert "Always use new plugin schema for plugin template (#48258)" (#49827)
This reverts commit 9d4a35b because it appears to break

the gradle_non_android_plugin_test.
2020-01-30 12:46:12 -08:00
ZichangG
0be9127dfd
add preserveHeaderCase for classes extends HttpHeaders (#49766) 2020-01-30 11:43:02 -08:00