Rexios
cc6ee0cc32
Add constraint options to SearchAnchor suggestions builder ( #148856 )
...
Refactors the `SearchAnchor` suggestions builder to not take up the whole screen
https://github.com/flutter/flutter/issues/148852
2024-11-14 01:19:09 +00:00
Mairramer
dec763979c
Adjusts the Hindi TimeOfDayFormat to display in a LTR orientation in localizations. ( #157998 )
...
Fixes https://github.com/flutter/flutter/issues/156565
This update corrects the `TimeOfDayFormat` mapping for the Hindi language. Previously, the format was incorrectly set to `a_space_h_colon_mm` - (a h:mm), but it should be `h_colon_mm_space_a` - (h:mm a) since Hindi is a LTR language.
2024-11-14 00:10:14 +00:00
hgraceb
5f0f18d739
Fix update order of SliverAppBar ( #158159 )
...
Fixes #158158
Similar to 154484, but addressing more fundamental causes. We should call the child's `didUpdateWidget` before the child's `build` when states change.
1. Remove redundant code but keep the old test because we don't need it after this fix.
2. Add getters of `lastShrinkOffset` and `lastOverlapsContent` that are needed when `SliverAppBar.update`.
3. Add a test with a custom TabBar to avoid breaking when some changes to the default TabBar.
2024-11-14 00:08:22 +00:00
Srivats Venkataraman
1a31e396db
#154792 - CupertinoActionSheetAction cursor doesn't change to clickable on desktop ( #158470 )
...
This PR is for issue #154792
The Video recording shows the before and after
The first button with the text "Go" uses the default cursor
The second button with the text "With Cursor" uses a custom cursor that has been passed in the parameters
https://github.com/user-attachments/assets/e82ecd42-42b1-42c9-aa30-a6f3daddb436
Here is the code for the second button
```dart
CupertinoButton(
onPressed: () {
showCupertinoModalPopup<void>(
context: context,
builder: (BuildContext context) {
return CupertinoActionSheet(
title: const Text('The title'),
message: const Text('Message'),
actions: <Widget>[
CupertinoActionSheetAction(
cursor: SystemMouseCursors.forbidden,
child: const Text('One'),
onPressed: () {},
),
],
);
},
);
},
child: const Text('With Cursor'),
),
```
Fixes https://github.com/flutter/flutter/issues/154792
2024-11-13 23:34:08 +00:00
Mitchell Goodwin
5f93a7f7ea
Adds a skip message for analyzer ( #158890 )
...
#158880 causes the linux analyzer to complain for not having a skip
message.
2024-11-13 14:38:56 -08:00
auto-submit[bot]
3a075deede
Reverts "Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be flaky ( #158242 )" ( #158891 )
...
Reverts: flutter/flutter#158242
Initiated by: LouiseHsu
Reason for reverting: Flake rate is low, and the arm64 macs in the staging pools are having difficulties
Original PR Author: fluttergithubbot
Reviewed By: {LouiseHsu}
This change reverts the following previous change:
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158241
2024-11-13 22:38:17 +00:00
Loïc Sharma
8a55c941cf
[SwiftPM] Move the logic for SwiftPM enablement to the platform project ( #158213 )
...
In the future, it will be possible for Swift Package Manager to be enabled on one but not all platforms (see https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279 ).
This moves the `usesSwiftPackageManager` property from the platform-agnostic `Project` to the platform-specific `IosProject` and `MacOSProject`.
This will allow the `IosProject` and `MacOSProject` to return different values for `usesSwiftPackageManager` in the future. For now, both of these projects will always return the same value.
Part of https://github.com/flutter/flutter/issues/151567
2024-11-13 21:45:07 +00:00
Matan Lurey
5a9c2b4dd1
Temporarily skip flutter build apk for native_assets tests. ( #158880 )
...
Work around for https://github.com/flutter/flutter/issues/158560 .
2024-11-13 20:57:13 +00:00
Alejandro Santiago
d7e1f03ee0
docs: include Human Interface haptic information in HapticFeedback ( #158587 )
...
## Description
Adding reference to the Human Interface documentation about Haptics in the `HapticFeedback` docs.
The Human Haptic Guidelines documentation are excellent since they provide visualizations that show how these different haptics actually are with some interactive demos, for example with Impact haptics (see image below). Such helps developers decide what haptic to go for and understand when they should be used.
<img width="675" alt="Screenshot 2024-11-13 at 15 13 10" src="https://github.com/user-attachments/assets/909240d3-1981-4e25-9bed-b3b52154e662 ">
2024-11-13 20:37:22 +00:00
engine-flutter-autoroll
cae3f9acd0
Roll Flutter Engine from db3e5af2ca22 to 82940a9aa714 (2 revisions) ( #158799 )
...
db3e5af2ca...82940a9aa7skia-flutter-autoroll@skia.org Roll Dart SDK from e5c2c502c890 to 66ab1774bfe9 (1 revision) (flutter/engine#56558 )
2024-11-13 skia-flutter-autoroll@skia.org Roll Dart SDK from c7d140d18895 to e5c2c502c890 (1 revision) (flutter/engine#56555 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 19:05:03 +00:00
Matan Lurey
7374452eca
Stream the output of flutter build for debugging. ( #158757 )
...
Towards https://github.com/flutter/flutter/issues/158560 .
2024-11-13 18:55:47 +00:00
Nate Wilson
e77093bba4
"Fix failing checks" wiki page for new contributors ( #154629 )
...
Resolves https://github.com/flutter/flutter/issues/154628
<br>
As a contributor, I would expect resources related to testing to be located in the [/docs/contributing/testing](https://github.com/flutter/flutter/tree/master/docs/contributing/testing ) directory. This PR adds a page to that directory geared toward helping new contributors.
<br>
I've noticed that in `team-framework` triage meetings, comments along the lines of "could you take a look at the failing checks?" are a regular occurrence.
I believe we could save quite a bit of effort by changing this:
> [**Understanding a LUCI build failure**](a5ca16ea94/docs/infra/Understanding-a-LUCI-build-failure.mdhttps://github.com/nate-thegrate/flutter/blob/fix-checks-wiki-page/docs/contributing/testing/Fix-failing-checks.md )
2024-11-13 18:52:27 +00:00
Matan Lurey
ed553d10cf
Avoid using platform ProcessInfo.maxRss in test. ( #158526 )
...
Closes https://github.com/flutter/flutter/issues/157629 .
Avoids failures in the style:
```txt
00:37 +4597 ~3 -1: /Users/matanl/Developer/flutter/packages/flutter_tools/test/commands.shard/permeable/build_appbundle_test.dart: analytics logs success [E]
Expected: contains Event:<{"eventName":"flutter_command_result","eventData":{"commandPath":"create","result":"success","commandHasTerminal":false,"maxRss":147013632}}>
Actual: [
Event:{"eventName":"command_usage_values","eventData":{"workflow":"create","commandHasTerminal":false,"createProjectType":"app","createAndroidLanguage":"kotlin","createIosLanguage":"swift"}},
Event:{"eventName":"flutter_command_result","eventData":{"commandPath":"create","result":"success","commandHasTerminal":false,"maxRss":143261696}},
Event:{"eventName":"timing","eventData":{"workflow":"flutter","variableName":"create","elapsedMilliseconds":527,"label":"success"}},
Event:{"eventName":"command_usage_values","eventData":{"workflow":"appbundle","commandHasTerminal":false,"buildAppBundleTargetPlatform":"android-arm,android-arm64,android-x64","buildAppBundleBuildMode":"release"}},
Event:{"eventName":"flutter_command_result","eventData":{"commandPath":"appbundle","result":"success","commandHasTerminal":false,"maxRss":147013632}},
Event:{"eventName":"timing","eventData":{"workflow":"flutter","variableName":"appbundle","elapsedMilliseconds":10,"label":"success"}}
]
Which: does not contain Event:<{"eventName":"flutter_command_result","eventData":{"commandPath":"create","result":"success","commandHasTerminal":false,"maxRss":147013632}}>
```
I am guessing <https://api.flutter.dev/flutter/dart-io/ProcessInfo/maxRss.html > is not guaranteed to be stable while running, and as a result is not. This stabilizes the value for a test that I believe does not care about getting the "real" value anyway.
2024-11-13 18:03:58 +00:00
engine-flutter-autoroll
364901da54
Roll Packages from 72356fda4684 to 26e123a6ce03 (19 revisions) ( #158626 )
...
72356fda46...26e123a6cedasyad00@gmail.com [camera_windows] Set device media type for video preview explicitly (flutter/packages#7447 )
2024-11-13 39979207+ThangVuNguyenViet@users.noreply.github.com [go_router] Add support for relative routes (flutter/packages#6825 )
2024-11-13 pq@users.noreply.github.com [vector_graphics_compiler] fix a renamed method parameter lint (flutter/packages#8070 )
2024-11-12 feinstein@users.noreply.github.com [in_app_purchase] Add expiration date to Transaction (flutter/packages#8030 )
2024-11-12 stuartmorgan@google.com [various] Clean up contributing guides (flutter/packages#8032 )
2024-11-12 ditman@gmail.com [ci] Remove web renderer option from tools. (flutter/packages#8055 )
2024-11-12 stuartmorgan@google.com [url_launcher] Update Pigeon version for Linux (flutter/packages#8065 )
2024-11-12 tobias@leafnode.se [go_router] Add support for preloading branches of StatefulShellRoute (revised solution) (flutter/packages#6467 )
2024-11-12 stuartmorgan@google.com [pigeon] Make Linux type declarations public (flutter/packages#8040 )
2024-11-11 engine-flutter-autoroll@skia.org Roll Flutter from 73546b3b71a7 to c8510f29ccc2 (30 revisions) (flutter/packages#8042 )
2024-11-11 magder@google.com Use dependabot multi-directory configuration for Android package updates (flutter/packages#8048 )
2024-11-11 stuartmorgan@google.com [tools] Run `pub get` before `format` (flutter/packages#8052 )
2024-11-11 stuartmorgan@google.com [file_selector] Fix Linux cancel regression (flutter/packages#8051 )
2024-11-09 stuartmorgan@google.com [shared_preferences] Fix confusing language in README (flutter/packages#8049 )
2024-11-08 magder@google.com Use dependabot multi-directory configuration for Android example gradle updates (flutter/packages#8036 )
2024-11-08 43054281+camsim99@users.noreply.github.com [animations] Remove `.flutter-plugins` reference from example app (flutter/packages#8002 )
2024-11-08 magder@google.com Group dependabot github-action update PRs, delete dead docker updates (flutter/packages#8044 )
2024-11-08 37028599+EArminjon@users.noreply.github.com [vector_graphics_compiler] fix-null-exception (flutter/packages#8006 )
2024-11-08 stuartmorgan@google.com [tools] Format Dart per-package (flutter/packages#8043 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 18:03:56 +00:00
Matan Lurey
2d1a3efc38
Move dart pub deps call to <Pub>.deps and use it accordingly ( #158524 )
...
Closes https://github.com/flutter/flutter/issues/158396 , closes https://github.com/flutter/flutter/pull/158370 .
2024-11-13 18:03:53 +00:00
engine-flutter-autoroll
4de32b8702
Roll Flutter Engine from 05c14d8b4cd7 to db3e5af2ca22 (1 revision) ( #158553 )
...
05c14d8b4c...db3e5af2caskia-flutter-autoroll@skia.org Roll Skia from 02dd72c2fbc2 to ca10bc19c67e (2 revisions) (flutter/engine#56554 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 08:16:33 +00:00
engine-flutter-autoroll
4b5f6e2785
Roll Flutter Engine from ef760d6e1f13 to 05c14d8b4cd7 (3 revisions) ( #158551 )
...
ef760d6e1f...05c14d8b4cskia-flutter-autoroll@skia.org Roll Dart SDK from 5f42ef8f15d5 to c7d140d18895 (2 revisions) (flutter/engine#56552 )
2024-11-13 jonahwilliams@google.com [engine] force semantics action to post a task. (flutter/engine#56514 )
2024-11-13 chinmaygarde@google.com [Impeller] Wrap provided FBO instead of defaulting to FBO0 and cleanup/document the texture API. (flutter/engine#56543 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 04:57:36 +00:00
engine-flutter-autoroll
a058b3c220
Roll Flutter Engine from 08348c9eebcc to ef760d6e1f13 (1 revision) ( #158545 )
...
08348c9eeb...ef760d6e1fskia-flutter-autoroll@skia.org Roll Skia from 7d5c206fc873 to 02dd72c2fbc2 (4 revisions) (flutter/engine#56547 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 02:35:17 +00:00
Flutter GitHub Bot
a6d81aa8f1
Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be flaky ( #158242 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158241
2024-11-13 02:29:25 +00:00
engine-flutter-autoroll
90074a8b32
Roll Flutter Engine from 877abb9ad6ff to 08348c9eebcc (8 revisions) ( #158541 )
...
877abb9ad6...08348c9eebjason-simmons@users.noreply.github.com [Linux] Configure depth and stencil framebuffer attachments needed for Impeller (flutter/engine#56516 )
2024-11-12 chris@bracken.jp macOS: ARC bridge casts for FlutterMetalTexture.user_data (flutter/engine#56518 )
2024-11-12 jonahwilliams@google.com [Impeller] prevent no-op backend from throwing exceptions during image decoding (flutter/engine#56522 )
2024-11-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 69170fac244c to 5f42ef8f15d5 (4 revisions) (flutter/engine#56539 )
2024-11-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from BajfrJuYeyWvnBhuM... to z-cm2nR0aJ4lXfwZ0... (flutter/engine#56538 )
2024-11-12 skia-flutter-autoroll@skia.org Roll Skia from aa099ff91e2f to 7d5c206fc873 (6 revisions) (flutter/engine#56541 )
2024-11-12 jason-simmons@users.noreply.github.com [Impeller] In canvas_unittests, only create an MSAA offscreen texture if the platform supports MSAA (flutter/engine#56542 )
2024-11-12 bruno.leroux@gmail.com [iOS] Fix slider semantics node answer to accessibility activate (flutter/engine#56427 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from BajfrJuYeyWv to z-cm2nR0aJ4l
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-13 01:08:13 +00:00
Matan Lurey
a0f2154419
Allow devDependencies to be omitted and not cause a tool crash. ( #158518 )
...
Closes https://github.com/flutter/flutter/issues/158441 .
2024-11-13 01:04:01 +00:00
Matan Lurey
72fc9b4b37
Explain how to use flutter channel. ( #158533 )
...
Closes https://github.com/flutter/flutter/issues/152274 .
I ran into https://github.com/flutter/flutter/issues/152274 myself, so seemed like an easy fix.
2024-11-13 00:42:00 +00:00
Jenn Magder
ee586d45ad
Clean up dependabot config, add github-action group ( #158408 )
...
1. Delete bundler and docker, these directories no longer exist and we have no Docker or Gemfiles any more.
2. Update outdated reviewer list which was blocking any reviewers from being added. https://github.com/flutter/flutter/pull/157473#issuecomment-2433542624
3. Change github action update from daily to weekly
4. Add a `group` so all github action dependencies are updated in the same PR, instead of one-per-dependency. The PR will look like:
__________
<img width="400" alt="Screenshot 2024-11-08 at 11 08 52â¯AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52 ">
__________
See also https://github.com/flutter/packages/pull/8044
2024-11-13 00:38:16 +00:00
Reid Baker
638331b133
Update test to include more complete instructions for how to run tests locally, add example to andoid 11 tests as well ( #158528 )
...
Follow @matanlurey's example and include how to run a test at the top of the test file.
2024-11-12 22:07:55 +00:00
Christopher Fujino
8e5bd5af86
force Linux plugin_test to run on Ubuntu 20.04 ( #158529 )
...
Work around propagation from https://github.com/flutter/flutter/issues/158521
2024-11-12 21:22:56 +00:00
Hannah Jin
9992e9bc5c
Support materialTapTargetSize in PopupMenuButton ( #158357 )
...
fix https://github.com/flutter/flutter/issues/128697
PopupMenuButton can take customized child, in that case if `
widgt.style.tapTargetSize` is set to `padded`, PopupMenuButton should
support it.
if child is null, default child is an iconButton, which is already
48x48.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2024-11-12 12:19:46 -08:00
Loïc Sharma
003135e2d0
[SwiftPM] Update .flutter-plugin-dependencies format ( #158138 )
...
In the future, it will be possible for Swift Package Manager to be enabled on one but not all platforms (see https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279 ).
This updates the `.flutter-plugin-dependencies` file format to separate iOS's and macOS's SwiftPM enablement. For now, these platforms will always have the same value.
This `.flutter-plugin-dependencies` file is read by our CocoaPods scripts to determine whether we should use CocoaPods or not to inject plugins.
Part of https://github.com/flutter/flutter/issues/151567
2024-11-12 20:01:26 +00:00
Andrew Kolos
37d80ce25f
add filesystem error handling to systemTempDirectory ( #158481 )
...
Fixes https://github.com/flutter/flutter/issues/153777 .
To summarize that issue, `ErrorHandlingFileSystem.systemTempDirectory` calls [`LocalFileSystem.systemTempDirectory`](45c8881eb2/packages/flutter_tools/lib/src/base/file_system.dart (L229)
2024-11-12 18:14:45 +00:00
Jiten Patel
9a2e249025
Made Cupertino dialog more like a native dialog in dark mode ( #157218 )
...
This PR addresses an issue where the `CupertinoAlertDialog` was not fully visible in dark mode. The dialog now adapts better to dark mode themes, ensuring proper contrast and readability across different UI elements.
Fixes : #80921
2024-11-12 17:59:48 +00:00
engine-flutter-autoroll
19411b638b
Roll Flutter Engine from b0a4ca92c49e to 877abb9ad6ff (2 revisions) ( #158506 )
...
b0a4ca92c4...877abb9ad6skia-flutter-autoroll@skia.org Roll Skia from 75230dbc93e6 to aa099ff91e2f (3 revisions) (flutter/engine#56525 )
2024-11-12 chinmaygarde@google.com [Impeller] Add OpenGL debugging utilities. (flutter/engine#56515 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-12 16:36:54 +00:00
Taha Tesser
148be5f894
Fix NavigationBar label style customization on the widget level ( #158510 )
...
Fixes [`NavigationBar` only allows `labelTextStyle` from `NavigationBarTheme` ](https://github.com/flutter/flutter/issues/158508 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
const TextStyle selectedTextStyle =
TextStyle(fontSize: 15, color: Color(0xFF00FF00));
const TextStyle unselectedTextStyle =
TextStyle(fontSize: 15, color: Color(0xFF0000FF));
const TextStyle disabledTextStyle =
TextStyle(fontSize: 16, color: Color(0xFFFF0000));
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
navigationBarTheme: NavigationBarThemeData(
labelTextStyle: WidgetStatePropertyAll(
TextStyle(
fontSize: 14,
fontWeight: FontWeight.bold,
color: Theme.of(context).colorScheme.primary,
),
),
)),
home: Scaffold(
appBar: AppBar(
title: const Text('NavigationBar Sample'),
),
body: Center(
child: Padding(
padding: const EdgeInsets.all(16.0),
child: Text(
"NavigationBar labels are customized using NavigationBar.labelTextStyle",
style: Theme.of(context).textTheme.headlineSmall,
textAlign: TextAlign.center,
),
),
),
bottomNavigationBar: NavigationBar(
labelTextStyle: const WidgetStateProperty<TextStyle?>.fromMap(
<WidgetStatesConstraint, TextStyle?>{
WidgetState.disabled: disabledTextStyle,
WidgetState.selected: selectedTextStyle,
WidgetState.any: unselectedTextStyle,
},
),
onDestinationSelected: null,
destinations: const <Widget>[
NavigationDestination(
icon: Icon(Icons.home),
label: 'Home',
),
NavigationDestination(
icon: Icon(Icons.favorite_rounded),
label: 'Favorites',
),
NavigationDestination(
enabled: false,
icon: Icon(Icons.settings),
label: 'Settings',
),
],
),
),
);
}
}
```
</details>
### Preview
<img width="719" alt="Screenshot 2024-11-12 at 17 18 00" src="https://github.com/user-attachments/assets/2b489bfa-78a3-4766-bc22-9273d76eadcd ">
2024-11-12 16:33:51 +00:00
auto-submit[bot]
423aa2ac74
Reverts "Add test for dynamic_content_color.0.dart ( #158309 )" ( #158511 )
...
Reverts: flutter/flutter#158309
Initiated by: bleroux
Reason for reverting: added test is failing on CI
Original PR Author: ValentinVignal
Reviewed By: {bleroux}
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`
2024-11-12 16:05:17 +00:00
Valentin Vignal
95a9b97f88
Add test for dynamic_content_color.0.dart ( #158309 )
...
Fixes https://github.com/flutter/flutter/issues/130459
It adds a test for
- `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`
2024-11-12 11:49:24 +00:00
engine-flutter-autoroll
3770a10180
Roll Flutter Engine from a672f971c659 to b0a4ca92c49e (2 revisions) ( #158488 )
...
a672f971c6...b0a4ca92c4robert.ancell@canonical.com Add FlPointerManager to process pointer events from GTK in a form suitable for Flutter. (flutter/engine#56443 )
2024-11-12 skia-flutter-autoroll@skia.org Roll Skia from 11046fd10394 to 75230dbc93e6 (1 revision) (flutter/engine#56517 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-12 03:16:33 +00:00
engine-flutter-autoroll
9ba6e944d2
Roll Flutter Engine from 35041f118744 to a672f971c659 (1 revision) ( #158487 )
...
35041f1187...a672f971c6magder@google.com Add dependabot github-actions group (flutter/engine#56468 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-12 02:13:10 +00:00
engine-flutter-autoroll
722c395dcb
Roll Flutter Engine from 7b3eacd20eb6 to 35041f118744 (9 revisions) ( #158485 )
...
7b3eacd20e...35041f1187skia-flutter-autoroll@skia.org Roll Dart SDK from a393f3ed040a to 69170fac244c (1 revision) (flutter/engine#56513 )
2024-11-11 chris@bracken.jp iOS,macOS: Refactor TestMetalContext for ARC (flutter/engine#56510 )
2024-11-11 jonahwilliams@google.com [Impeller] geometry changes to support line/point style. (flutter/engine#56340 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from af6a4f9a85ee to 11046fd10394 (9 revisions) (flutter/engine#56508 )
2024-11-11 jonahwilliams@google.com [Impeller] dont unnecessarily copy point data out of display list. (flutter/engine#56492 )
2024-11-11 jonahwilliams@google.com [Impeller] fix line/polygon depth and GLES scissor state. (flutter/engine#56494 )
2024-11-11 jason-simmons@users.noreply.github.com Do not stop flutter_tester if microtasks are still pending (flutter/engine#56432 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 261316c10484 to af6a4f9a85ee (5 revisions) (flutter/engine#56505 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ea43aa234a4 to a393f3ed040a (1 revision) (flutter/engine#56506 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-12 01:16:42 +00:00
Loïc Sharma
563fb0c743
[SwiftPM] Simplify logic that determines if CocoaPods is used ( #158409 )
...
This is a refactoring with no semantic changes. I will get a text exemption.
Part of https://github.com/flutter/flutter/issues/151567
2024-11-11 21:03:30 +00:00
Taha Tesser
68fa653e59
Fix Chip draws InkWell.hoverColor is drawn on top of the provided background color with hovered state ( #158454 )
...
Fixes [Setting hoverColor on ThemeData breaks Chip hover functionality](https://github.com/flutter/flutter/issues/157622 )
### Description
The bug is caused by `InkWell.hoverColor`. When `ThemeData.hoverColor` is provided, its drawn on top. To fix this, we can override `InkWell.hoverColor` when Chip state color is provided.
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
hoverColor: const Color(0xFFFF0000),
),
home: Scaffold(
body: Center(
child: RawChip(
color: WidgetStateProperty.resolveWith((states) {
if (states.contains(WidgetState.hovered)) {
return const Color(0xFF00fF00);
}
return const Color(0xFF0000FF);
}),
label: const Text('RawChip'),
onPressed: () {},
)),
),
);
}
}
```
</details>
### Before
https://github.com/user-attachments/assets/f8974af6-5af3-4d7d-9dbe-65bf170d5fa3
### After
https://github.com/user-attachments/assets/89a5315c-c7bd-4456-8594-e2092e43952d
2024-11-11 19:48:32 +00:00
engine-flutter-autoroll
c36ad608da
Roll Flutter Engine from 3cb6f4de89b6 to 7b3eacd20eb6 (1 revision) ( #158464 )
...
3cb6f4de89...7b3eacd20erobert.ancell@canonical.com Remove unused FlMockTextInputHandler (flutter/engine#56495 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 19:16:23 +00:00
engine-flutter-autoroll
14e0e580b4
Roll Packages from bb5a25815cae to 72356fda4684 (8 revisions) ( #158378 )
...
bb5a25815c...72356fda46stuartmorgan@google.com [various] Update example app minSdkVersions (flutter/packages#8035 )
2024-11-07 32538273+ValentinVignal@users.noreply.github.com [go_router] Activate leak testing (flutter/packages#7546 )
2024-11-07 louisehsu@google.com [in_app_purchase_storekit] Add restore purchases and receipts (flutter/packages#7964 )
2024-11-07 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native `BaseManager` (flutter/packages#7943 )
2024-11-07 58529443+srujzs@users.noreply.github.com [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter/packages#8029 )
2024-11-07 alex@mariuti.com [flutter_svg] wasm compatibility (flutter/packages#8014 )
2024-11-06 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter/packages#8019 )
2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter from 29d40f7f6826 to 73546b3b71a7 (20 revisions) (flutter/packages#8028 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 18:44:16 +00:00
engine-flutter-autoroll
4152ca43c2
Roll Flutter Engine from e9a44820f302 to 3cb6f4de89b6 (3 revisions) ( #158456 )
...
e9a44820f3...3cb6f4de89mdebbar@google.com [web] Bump Firefox version to 132.0 (flutter/engine#56435 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from cde0e0dc084a to 4ea43aa234a4 (1 revision) (flutter/engine#56502 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 676b3b1a41be to 261316c10484 (1 revision) (flutter/engine#56503 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 16:45:30 +00:00
Ben Konyi
d89e65d516
Replace custom RPCErrorCodes with RPCErrorKind from package:vm_service ( #158379 )
...
Removes duplicated constants and ensures consistency by using package:vm_service as a source of truth for RPC error codes for requests made with package:vm_service.
2024-11-11 15:18:09 +00:00
engine-flutter-autoroll
232706616a
Roll Flutter Engine from d90e9f4718b8 to e9a44820f302 (1 revision) ( #158453 )
...
d90e9f4718...e9a44820f3skia-flutter-autoroll@skia.org Roll Dart SDK from ed9a5b1110ae to cde0e0dc084a (6 revisions) (flutter/engine#56500 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 14:36:26 +00:00
engine-flutter-autoroll
461ad0d3e0
Roll Flutter Engine from 01c76e42c20f to d90e9f4718b8 (1 revision) ( #158443 )
...
01c76e42c2...d90e9f4718skia-flutter-autoroll@skia.org Roll Skia from 3333292a62c1 to 676b3b1a41be (2 revisions) (flutter/engine#56499 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 09:44:04 +00:00
engine-flutter-autoroll
5fd650f68b
Roll Flutter Engine from 9b4c3b3d5518 to 01c76e42c20f (3 revisions) ( #158438 )
...
9b4c3b3d55...01c76e42c2skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TZVo85tD5mpzhcafg... to BajfrJuYeyWvnBhuM... (flutter/engine#56497 )
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 778b21720a61 to 3333292a62c1 (7 revisions) (flutter/engine#56496 )
2024-11-10 chris@bracken.jp fml: Improve CFTest.SupportsCustomRetainRelease test (flutter/engine#56480 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TZVo85tD5mpz to BajfrJuYeyWv
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-11 04:02:25 +00:00
Younghan Kim
18071ec0a8
Remove block and line comments when detecting '.flutter-plugins' in settings.gradle(.kts) ( #155488 )
...
**PR Title:**
Remove block and line comments when detecting `'.flutter-plugins'` in `settings.gradle`
---
**Description:**
This PR modifies the `configureLegacyPluginEachProjects` function to remove block (`/* ... */`) and line (`// ...`) comments from the `settings.gradle` or `settings.gradle.kts` file content before checking for the presence of the `'.flutter-plugins'` string. This ensures that only uncommented, meaningful code is considered during the detection, preventing false positives when the string appears within comments.
**Why is this change necessary?**
In some cases, the `'.flutter-plugins'` string may be present inside comments in the `settings.gradle` file. The existing implementation does not account for this and may incorrectly detect the string even when it's commented out. This can lead to unintended behavior, such as configuring plugin projects when it is not necessary.
By removing comments before performing the check, we prevent false positives and ensure that the detection logic is accurate, only acting when the `'.flutter-plugins'` string is present in active code.
**Changes Made:**
- **Added comment removal logic:**
- Removed block comments (`/* ... */`) using the regular expression `/(?s)\/\*.*?\*\//`.
- The `(?s)` flag enables dot-all mode, allowing `.` to match newline characters.
- Removed line comments (`// ...`) using the regular expression `/(?m)\/\/.*$`.
- The `(?m)` flag enables multi-line mode, so `^` and `$` match the start and end of each line.
- Combined both comment removal steps into a single chain for efficiency.
- **Updated the string detection:**
- The check for `'.flutter-plugins'` is now performed on the uncommented content of the `settings.gradle` file.
- This ensures that only meaningful, uncommented code is considered during detection.
**Issue Fixed:**
- Fixes [#155484 ](https://github.com/flutter/flutter/issues/155484 )
---
---
If you need any further assistance or have questions, feel free to reach out!
---
**Links:**
- [Contributor Guide]
- [Tree Hygiene]
- [Flutter Style Guide]
- [Features we expect every widget to implement]
- [CLA]
- [flutter/tests]
- [breaking change policy]
- [Discord]
- [Data Driven Fixes]
2024-11-11 02:47:32 +00:00
Nate Wilson
1eaf1f9525
Add SafeArea DartPad sample ( #158019 )
...
Follow-up from #157228
2024-11-11 01:00:21 +00:00
Flutter GitHub Bot
f04b0f4b9e
Marks Linux analyzer_benchmark to be flaky ( #158244 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux analyzer_benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158243
2024-11-10 22:30:39 +00:00
Andrew Kolos
c9eb4ae9cc
remove bringup status for recently re-subsharded targets ( #158217 )
...
Cleans up https://github.com/flutter/flutter/pull/158196 and https://github.com/flutter/flutter/pull/158146
<details>
<summary> Pre-launch checklist </summary>
</details>
2024-11-10 21:49:24 +00:00
engine-flutter-autoroll
286eb1303c
Roll Flutter Engine from 690cdfd09beb to 9b4c3b3d5518 (1 revision) ( #158418 )
...
690cdfd09b...9b4c3b3d55jason-simmons@users.noreply.github.com Remove the unsafe_html analysis rule (flutter/engine#56479 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com ,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-11-09 22:03:26 +00:00
