12948 Commits

Author SHA1 Message Date
Ian Hickson
c5ad1067b7
Handle errors in compute() by propagating them to the Future. (#24848) 2018-12-23 15:20:45 -08:00
Ian Hickson
273364e2bc
Fix merge conflict. (#25718) 2018-12-23 11:13:53 -08:00
Ian Hickson
c0b20a76de
Some minor tweaks to InputDecoration (mainly docs). (#24643) 2018-12-23 10:12:42 -08:00
Gary Qian
2e2f19d3e9
Expose font fallback API in TextStyle, Roll engine 54a3577c0139..215ca1560088 (8 commits) (#25585) 2018-12-21 19:07:01 -08:00
Hans Muller
4857267e65
Updated Shrine demo (#25674) 2018-12-21 17:47:25 -08:00
Amir Hardon
8d60ed04c9
Pin the goldens repo to a specific commit in the android_views test. (#25678) 2018-12-21 14:17:12 -08:00
Stanislav Baranov
6d6ada14a0
Friendlier flags for Dart compilation training. (#25645)
* Renamed --save-compilation-trace to flutter run --train.
* Renamed --precompile=<file> to --compilation-trace-file=<file>.
* In dynamic mode, made JIT snapshot the default, instead of kernel file.
2018-12-21 12:27:59 -08:00
Stanislav Baranov
10ce692089
Revert dependency upgrade to see if it helps with build times and APK size (#25642) 2018-12-21 10:55:04 -08:00
Amir Hardon
1d5833d99f
Depend on the goldens repo through git. (#25479)
It's easier to run the android_views integration test this way, without
needing to worry if we have a local clone of the goldens repo or not.
2018-12-21 10:38:39 -08:00
Alexandre Ardhuin
19ce65eec9
no period after an alone link in see also section (#25604) 2018-12-21 19:23:42 +01:00
Ian Hickson
fb88a7bfd1
Update links for China help (#25238)
We have a page on the Web page now.
2018-12-21 10:12:49 -08:00
engine-flutter-autoroll
273495b754
Roll engine 6a9041853c4b..54a3577c0139 (23 commits) (#25649)
6a9041853c...54a3577c01

git log 6a9041853c4b..54a3577c0139 --no-merges --oneline
54a3577c0 Roll src/third_party/skia b03e024a4034..bdfe3a3ee9c3 (14 commits) (flutter/engine#7277)
ead76a4db Remove unused native function dumpCopmpilationTrace(). (flutter/engine#7276)
eaffc462a [License] Enable avoid_positional_boolean_parameters lint (flutter/engine#7275)
b07753bad [License] Sync analysis_options.yaml from framework (flutter/engine#7273)
233c100b6 [License] Enable always_require_non_null_named_parameters
f4b348f77 [License] Enable flutter_style_todos lint
48be433ce [License] Enable prefer_is_empty lint
bd648bad6 [License] Enable prefer_const_constructors lint
2b207a51c [License] Enable unnecessary_parenthesis lint
97ae27164 [License] Enable prefer_initializing_formals lint
c8f83fbea [License] Enable prefer_collection_literals lint
d120e15af [License] Enable prefer_void_to_null lint
e2ab3780a [License] Enable directives_ordering lint
5f2e6cd41 [License] Enable unnecessary_overrides lint
bd955d78a [License] Enable avoid_function_literals_in_foreach_calls lint
392df65f6 [License] Enable prefer_const_declarations lint
06e35912d [License] Enable prefer_final_fields lint
32423ef38 [License] Enable prefer_asserts_in_initializer_lists lint
4703a7f10 [License] Enable prefer_equal_for_default_values lint
1d7285bea [License] Enable empty_catches lint
68fadca0e [License] Enable unnecessary_this lint
c6f5e67cb [License] Enable prefer_single_quotes lint
cc51731d8 Clarify TextAffinity docs (flutter/engine#7238)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-21 11:41:40 -05:00
engine-flutter-autoroll
6f0f0c4b60
Roll engine e859296b71de..6a9041853c4b (4 commits) (#25643)
e859296b71...6a9041853c

git log e859296b71de..6a9041853c4b --no-merges --oneline
6a9041853 [License] Assert license filename is non-null, non-empty (flutter/engine#7270)
72aa37842 [License] Eliminate duplicate case in switch (flutter/engine#7269)
74af4429a Mark all unreassigned locals final in license tool (flutter/engine#7267)
0310e910d Roll src/third_party/skia 44539be30ef8..b03e024a4034 (7 commits) (flutter/engine#7268)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-21 02:03:28 -05:00
Pranay Airan
368cd7da8b
Adding support for android app bundle - Issue #17829 (#24440)
* adding support for android app bundle.

* removing the debug statement.

* fixing formatting and code review changes.

* Revert "fixing formatting and code review changes."

This reverts commit 2041d459f335242555a0b75e445343134c245494.

* Fixing code formatting issues.

* updating review comments fixing comments and spacing.

* changing and to & to rerun the CI and tests.

* updating the comment to re-run the test

updating the comment to re-run the test

* fixing the formatting.

* updating comments to re-trigger build

updating comments to re-trigger build
2018-12-20 22:18:53 -08:00
Ian Hickson
8426910a19
Revert "[O] Remove many timeouts. (#23531)" (#25646)
This reverts commit 76f70810e457b7a3a39fd59f59a930b5e93c6066.
2018-12-20 18:46:36 -08:00
Ian Hickson
76f70810e4
[O] Remove many timeouts. (#23531)
* Remove many timeouts.

These are essentially self-inflicted race conditions. Instead of timeouts we're going to try a more verbose logging mechanism that points out when things are taking a long time.

* Get the attach tests to pass.

* Apply review comments from Todd

* More review comment fixes

* Put back the extended timeouts here now that I know why we have them...
2018-12-20 17:10:40 -08:00
xster
b3b764c9d3
Revise Android and iOS gestures on Material TextField (#24457) 2018-12-20 16:54:19 -08:00
Stanislav Baranov
eb7a59b6d7
Switch over to the new name for compilation trace native function (#25594)
* Switch over to the new name for compilation trace native function.

Also see: https://github.com/flutter/engine/pull/7256

* rename

* roll the engine
2018-12-20 16:07:36 -08:00
xster
b6248e26b3
Fix material reference in CupertinoPicker doc (#25584) 2018-12-20 16:07:12 -08:00
xster
d1ec126a3c
Let CupertinoTabScaffold handle keyboard insets too (#25593) 2018-12-20 15:02:53 -08:00
Dan Field
7a88fbc5fd
Default baseline build options (#25631)
* fix crash

* default baseline
2018-12-20 11:38:07 -08:00
Justin McCandless
ca8ba58b02
Right aligned backspace bug (#25229)
* Fix bug in calculation of downstream text distance when aligned: right

* After having affinity explained to me, match getOffset and tests to
expected behavior

* Clean up test formatting and fix analyze errors

* Improve test comments and reorganize a bit

* Specify logical pixels
2018-12-20 11:03:51 -08:00
engine-flutter-autoroll
f2b919e57e
Roll engine 5ec8ef850934..dbdb5e6f8c9f (7 commits) (#25628)
5ec8ef8509...dbdb5e6f8c

git log 5ec8ef850934..dbdb5e6f8c9f --no-merges --oneline
dbdb5e6f8 Roll src/third_party/skia 428ec1e55c05..44539be30ef8 (1 commits) (flutter/engine#7265)
cf11d86bf Roll src/third_party/skia 21ee517391bc..428ec1e55c05 (3 commits) (flutter/engine#7264)
2d2b9d753 Re-run license tool on all source when it changes (flutter/engine#7260)
5fa1d5980 Roll src/third_party/skia 7757bba636d8..21ee517391bc (1 commits) (flutter/engine#7263)
6a1f01724 Roll src/third_party/skia ce9a901a76eb..7757bba636d8 (4 commits) (flutter/engine#7262)
079d60452 Add a system message channel for controlling the Skia resource cache size (flutter/engine#7257)
41222d055 Update usage of some Android APIs that are deprecated in API level 28 (flutter/engine#7261)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-20 14:02:28 -05:00
Stanislav Baranov
41fd7a2b9d
Don't parse APK unless explicitly requested (#25595) 2018-12-20 10:08:05 -08:00
Hans Muller
ee3571c946
Update DayPicker,DatePicker doc "see also" sections (#25573) 2018-12-20 08:18:54 -08:00
jslavitz
3d8aec2b99
Adds force press gesture detector and recognizer (#24554)
* adds Force Press gesture detector and recognizer
2018-12-19 20:09:07 -08:00
engine-flutter-autoroll
bbddade17f
Roll engine 9edb4f72b914..5ec8ef850934 (2 commits) (#25590)
9edb4f72b9...5ec8ef8509

git log 9edb4f72b914..5ec8ef850934 --no-merges --oneline
5ec8ef850 Remove unused GrContext in AndroidSurfaceGL (flutter/engine#7258)
c08a80ada Roll src/third_party/skia 8d23a584fc43..ce9a901a76eb (10 commits) (flutter/engine#7259)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-19 21:22:28 -05:00
Stanislav Baranov
55f3da7afc
Flutter tool support for building dynamic updates (#25576) 2018-12-19 16:27:47 -08:00
Gary Qian
a282058d69
Use full textspan tree instead of top level textspan (#25574) 2018-12-19 15:43:53 -08:00
xster
b17feefc9e
Remove code signing special casing for Googlers round 2 (#24580) 2018-12-19 14:41:21 -08:00
Stanislav Baranov
7f1f39385b
Add missing dependency to fix the build (#25582) 2018-12-19 14:31:30 -08:00
engine-flutter-autoroll
2789ffa6c2
Roll engine 526e0e3afb2c..9edb4f72b914 (9 commits) (#25578)
526e0e3afb...9edb4f72b9

git log 526e0e3afb2c..9edb4f72b914 --no-merges --oneline
9edb4f72b Update dynamic patching terminilogy to match that of the flutter tool (flutter/engine#7248)
2c9fc872d Roll src/third_party/skia 1a237195b527..8d23a584fc43 (8 commits) (flutter/engine#7255)
8b73b9d42 Fix javadoc for Android-28 (flutter/engine#7254)
2e4a02719 Roll src/third_party/skia 192d66440910..1a237195b527 (1 commits) (flutter/engine#7253)
ccaac1af3 Roll src/third_party/skia b933285ebb4e..192d66440910 (3 commits) (flutter/engine#7252)
8939e2abe Fix a misspelling (flutter/engine#7234)
ada6748d0 Extract function to collect licenses for component (flutter/engine#7250)
9f10b10a0 Roll src/third_party/skia 67761eb35f97..b933285ebb4e (1 commits) (flutter/engine#7251)
cfbc94864 Roll buildroot to support Android SDK 28 (flutter/engine#7245)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-19 17:22:28 -05:00
Stanislav Baranov
da599cfc59
Update examples to match the new version of generated build.gradle (#25483) (#25569)
This version honors flutter tool's --build-number/--build-name flags.
2018-12-19 12:16:30 -08:00
Alexandre Ardhuin
316d74f62d
fix indentation in doc comments (#25521) 2018-12-19 21:12:49 +01:00
engine-flutter-autoroll
b5df920681 Roll engine 08465e800035..526e0e3afb2c (10 commits) (#25529)
* 8190e939f Simplify conversion of numeric types in the message codec on iOS (flutter/engine#7097)

* 42c62a944 Fix destruction of the child object list in the iOS accessibility bridge (flutter/engine#7108)

* 951edf3e1 Simplify nested try-with-resources statements (flutter/engine#7239)

* f79f7f631 Allow inferred types using diamond syntax (flutter/engine#7237)

* 5c63303c2 Revert spelling correction in licence matcher (flutter/engine#7242)

* fbce2bf14 Fix linter errors in ResourceUpdater (flutter/engine#7240)

* ba117366e Compute cull_rect and optimize in Layer::Preroll (flutter/engine#6923)

* e8f4968d6 Update iOS unit test for the removal of hex string encoding of uint64 data (flutter/engine#7246)

* 370cc67d9 Roll src/third_party/skia e6f635476da3..4b75254560d4 (61 commits) (flutter/engine#7247)

* 526e0e3af Roll src/third_party/skia 4b75254560d4..67761eb35f97 (6 commits) (flutter/engine#7249)
2018-12-19 11:04:42 -08:00
MH Johnson
6e15572867
[Material] Theme-able TextStyles for AlertDialog (#25339)
* Themable elevation on dialogs.

* AlertDialogs Title/Content text styles

* Themable elevation on dialogs.

AlertDialogs Title/Content text styles

* finish merging change

* fixing tests

* Docs fixes

* Change const to final to fix analyzer errors

* Fix analyzer errors

* Remove dart:ui import

* Hans Comments
2018-12-19 13:52:10 -05:00
tonyzhao1
f8ab72657e Flutter doctor error message lookup (#23889) 2018-12-19 10:10:08 -08:00
Stanislav Baranov
29bab6c023
Fix the build (#25568) 2018-12-19 10:05:00 -08:00
liyuqian
3cf40b436d
Revert "Update examples to match the new version of generated build.gradle (#25483)" (#25563)
This reverts commit 8acc058cf198cca10a51d31fb743c7ab126a796e.

Reverts #25483

Reason for revert: it seems to break the flutter_gallery_instrumentation_test post-submit test.

TBR: @sbaranov
2018-12-19 09:14:41 -08:00
xster
b8a035a3d4
Adds CupertinoTheme (#23759) 2018-12-18 20:36:35 -08:00
Hans Muller
8b34a12d45
Video demo instrumentation (#25489)
* Video Demo instrumentation

* Video Demo instrumentation

* Updated per review

* Fixed a typo
2018-12-18 14:46:45 -08:00
engine-flutter-autoroll
49e67e2ed0
Roll engine 5af435098d34..08465e800035 (3 commits) (#25522)
5af435098d...08465e8000

git log 5af435098d34..08465e800035 --no-merges --oneline
08465e800 Verify RunConfiguration is valid before running (flutter/engine#6922)
f986a12e2 Correct spelling in doc comments (flutter/engine#7179)
67cd7d4d3 Compile embedder unit test Dart to kernel (flutter/engine#7231)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop
the roller if necessary.
2018-12-18 17:46:28 -05:00
Stanislav Baranov
8acc058cf1
Update examples to match the new version of generated build.gradle (#25483)
This version honors flutter tool's --build-number/--build-name flags.
2018-12-18 14:39:12 -08:00
Stanislav Baranov
693fb6560e
Fix flutter tool to actually honor --build-number/--build-name flags. (#25520) 2018-12-18 12:54:26 -08:00
Stanislav Baranov
0d4f279fb8
Read correct cached VM snapshot in dynamic mode (PRODUCT vs RELEASE) (#25472) 2018-12-18 12:53:30 -08:00
Alexandre Ardhuin
e41f1463cd
make see also sections uniform (#25513) 2018-12-18 21:45:20 +01:00
Hans Muller
324f275981
TransitionRoute.canTransitionFrom,To() doc update (#25477) 2018-12-18 11:38:16 -08:00
Stanislav Baranov
f6c1476fbb
Fix gradle local.properties tests that were never excersized. (#25484)
These tests were actually failing, but were silently ignored due overly broad exception catching logic.
2018-12-18 10:39:27 -08:00
Gary Qian
a3dd2eee98
Fix typo (#25237) 2018-12-18 10:25:11 -08:00
Gary Qian
f8964ae250
Iterate through potential grapheme cluster lengths in text painter (#24797) 2018-12-18 10:21:04 -08:00