323 Commits

Author SHA1 Message Date
Anna Gringauze
d7466d8963
Update dwds and other packages (#94634) 2021-12-07 14:29:07 -08:00
Danny Tuppeny
99e85b1c5f
Disable pause-on-exceptions for (outgoing) isolates during hot restart (#93411) 2021-11-18 22:23:09 -08:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart (#92861) 2021-11-01 17:18:03 -07:00
Gary Qian
0407aa4480
Reland "Add multidex flag and automatic multidex support (#90944)" (#92049) 2021-10-19 02:20:39 -07:00
Zachary Anderson
a9c31eca48
Revert "Add multidex flag and automatic multidex support (#90944)" (#91791)
This reverts commit 1d9edde0793b824142f8b3647fb181224fa9965d.
2021-10-13 23:09:50 -07:00
Gary Qian
1d9edde079
Add multidex flag and automatic multidex support (#90944) 2021-10-13 17:48:04 -07:00
Ian Hickson
61a0add286
Enable avoid_redundant_argument_values lint (#91409) (#91462) 2021-10-08 09:25:14 -07:00
Zachary Anderson
b9d2177da0
Revert "Enable avoid_redundant_argument_values lint (#91409)" (#91461)
This reverts commit 5fd259be244244e14ff87fee9b6a721625f952cd.
2021-10-07 21:11:07 -07:00
Ian Hickson
5fd259be24
Enable avoid_redundant_argument_values lint (#91409) 2021-10-07 20:13:02 -07:00
stuartmorgan
97fb8c0560
Fix Dart plugin registrant interaction with 'flutter test' (#90288)
Building an application for a desktop platform that transitively included any Dart-based plugins (such as path_provider) broke `flutter test`, because its compilation was overriding the provided main (in this case, the test main) with `generated_main.dart` if it was present. This PR:
- Changes the `flutter test` compilation path to update `generated_main.dart`, so that the tests will work, and will include any registered Dart plugins.
- Makes using `generated_main.dart` during recompile opt-in, to try to reduce the chance of a similar bug happening with other codepaths in the future.

Fixes https://github.com/flutter/flutter/issues/88794
2021-09-30 20:25:13 -07:00
Jonah Williams
fa0782b696
reassign jonahwilliams todos (#88707) 2021-08-23 12:27:07 -07:00
Lau Ching Jun
95217eb72a
Add new hook for setupHotReload and after updating devFS is complete (#87532)
* Add new hook for setupHotReload and after updating devFS is complete

* Handle the case where updateDevFS failed
2021-08-03 21:09:56 -07:00
Lau Ching Jun
af42e7d730
Only set assets directory after assets are uploaded onto devfs. (#85418) 2021-06-28 13:16:04 -07:00
Greg Spencer
88f3811055
Turn on avoid_dynamic_calls lint, except packages/flutter tests, make appropriate changes. (#84476)
This adds avoid_dynamic_calls to the list of lints, and fixes all instances where it was violated.

Importantly, this lint is NOT turned on for flutter/packages/test, because those changes are happening in another PR: #84478
2021-06-14 14:16:57 -07:00
Lau Ching Jun
89a3c353e6
Add more analytics for hot reload in flutter_tools. (#83972) 2021-06-07 18:51:47 -07:00
Lau Ching Jun
27a6796233
Fix benchmark regression from #83427 (#83437) 2021-05-26 17:59:02 -07:00
Lau Ching Jun
fdb1fb184d
Add MultiRootFileSystem to better support using --filesystem-root. (#82991) 2021-05-24 22:04:02 -07:00
Emmanuel Garcia
b0a63c4ffe
Reland the Dart plugin registry (#79669) 2021-04-23 15:34:04 -07:00
Ian Hickson
598737adf2
Clean up the command line tool interactive help output. (#80903) 2021-04-22 19:34:02 -07:00
Jason Simmons
f94fa27802
Stop the DevTools child process if the runner terminates unexpectedly (#80602) 2021-04-18 09:34:03 -07:00
Jonah Williams
9904a7f472
Refactor core resident runner logic (#80462) 2021-04-16 17:27:35 -07:00
Jenn Magder
16c73829a6
Migrate reporting library to null safety (#80320) 2021-04-15 17:01:34 -07:00
Zachary Anderson
5efc7169eb
Reverts "Implement dartPluginClass support for plugins #74469" (#78623)
* Revert "Enable dart_plugin_registry_test (#76645)"

This reverts commit 109e0bb9f55ed6e9884547843356d16897eaf6a9.

* Revert "Apply changes caused by https://github.com/flutter/flutter/pull/76662 (#77093)"

This reverts commit cdca6485f05287bb12b1acebbbae2ba107d6c1be.

* Revert "Disable clang format in the plugin registrants (#76662)"

This reverts commit dadbd47d097f5cce868832fa8b4d03439a5c8402.

* Revert "Disable warnings for the dart plugin registrant (#76561)"

This reverts commit 098ece522d41f25370d19f5ec09d93ce2e727019.

* Revert "Remove dart_plugin_registry_test timeouts (#76838)"

This reverts commit 1610a2747654dec3cabbd1d81d0bc5885b2067a2.

* Revert "Implement dartPluginClass support for plugins (#74469)"

This reverts commit b7d4806243a4e906bf061f79a0e314ba28111aa6.

Kick.
2021-03-23 14:28:11 -07:00
Jonah Williams
d20ec4c7d8
[flutter_tools] read expression compilation results into memory before starting next compilation (#77867) 2021-03-11 22:18:51 -08:00
Jonah Williams
a3b14c58ae
[flutter_tools] replace vm_service extension methods with wrapper class (#76721) 2021-02-24 15:40:33 -08:00
Emmanuel Garcia
b7d4806243
Implement dartPluginClass support for plugins (#74469) 2021-02-19 09:22:45 -08:00
Jonah Williams
7ab8517f7e
[flutter_tools] refactor devtools handler to expose single method for run/attach and restart (#75807) 2021-02-10 17:04:47 -08:00
Jonah Williams
3aece33534
[flutter_tools] refactor devtools handler into its own class (#75444) 2021-02-09 15:31:39 -08:00
Ian Hickson
8acac060bf
Remove the timeout when launching DevTools (#74859) 2021-02-01 16:06:02 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. (#74832)
* opt out the flutter tool

* oops EOF

* fix import

* Update tool_backend.dart

* Update daemon_client.dart

* fix more
2021-01-27 15:17:53 -08:00
Kenzie Schmoll
c89d649847
Add connectedVmServiceUri service extension and set from flutter_tools (#74534)
* Add connectedVmServiceUri service extension and set from flutter_tools
2021-01-25 10:40:14 -08:00
Kenzie Schmoll
75dc45aba3
Fix bugs with ext.flutter.activeDevToolsServerAddress (#74423) 2021-01-21 11:51:02 -08:00
Kenzie Schmoll
b45088c0cf
Print DevTools inspector links in RenderFlex Overflow errors (#74251) 2021-01-21 02:59:04 -08:00
Jenn Magder
912c3ab171
Revert "Revert "[flutter_tools] Serve DevTools at app start (#73366)" (#73896)" (#73903)
This reverts commit 388dcd2478d511f5c5dececb94c654d3086c1944.
2021-01-13 15:36:43 -08:00
Jenn Magder
388dcd2478
Revert "[flutter_tools] Serve DevTools at app start (#73366)" (#73896)
This reverts commit 1cb0a24a466fb1d1cf8ad95b15c9857ab9817293.
2021-01-13 13:57:09 -08:00
Kenzie Schmoll
1cb0a24a46
[flutter_tools] Serve DevTools at app start (#73366)
* [flutter_tools] Serve DevTools at app start
2021-01-12 21:39:27 -08:00
Jonah Williams
50dfd137ef
[flutter_tools] prevent hot reload/restart if device has not finished devFS initialization (#73420) 2021-01-06 15:54:04 -08:00
Ben Konyi
89ef88c64f
Ensure attaching to an application with an existing DDS instance is not treated as a fatal error (#70847) 2020-12-04 17:16:30 -08:00
Jonah Williams
613a959878
only use code single path for verification of target file existence (#70962) 2020-11-20 14:17:11 -08:00
Jonah Williams
1efb36035e
[flutter_tools] display message for current null safety mode (#70718) 2020-11-20 11:53:02 -08:00
Jonah Williams
0a73ecf6df
[flutter_tools] use initially parsed package config for language version, sound mode determination (#70323) 2020-11-13 09:41:11 -08:00
Jonah Williams
a40ee8a3fb
[flutter_tools] migrate .packages to package_config, partial (#70200) 2020-11-11 13:50:41 -08:00
Jonah Williams
0bbd9020ed
[flutter_tools] remove experiment tracking analytics for null safety (#70183) 2020-11-10 12:49:50 -08:00
Jonah Williams
4c511fbde2
[flutter_tools] remove workaround for caching sound dill (#70014) 2020-11-09 11:53:56 -08:00
Jonah Williams
0ddb1ae713
fix hot reload benchmark data (#69798) 2020-11-04 11:43:24 -08:00
Jonah Williams
6cec03c7c1
[flutter_tools] do not reload sources if no sources changed (#69450)
If no source files were changed by a hot reload, do not send the reload sources RPC. This slightly speeds up the no-op reloads and gives users a faster way to force a re-render.
2020-11-04 11:15:30 -08:00
Jonah Williams
3300a1bd68
[flutter_tools] eagerly set asset directory path, cache flutter views, simplify error handling (#68978)
Performs some small cleanup on the hot reload code path.

- Combines nested try/catch into single try catch, update on clause now that package:vm_service is used and Map does not need to be caught.
- Cache FlutterViews for the lifetime of the hot reload method handler
- Set asset directory path once during startup and remove conditional set during hot reload
2020-10-27 09:20:05 -07:00
Jonah Williams
0f28edac65
[flutter_tools] null safety mode is used for dill naming (#68898)
* [flutter_tools] null safety mode is used for dill naming

* add bad test case
2020-10-23 15:39:58 -07:00
Jonah Williams
9e70180f63
[flutter_tools] do not measure progress timeout (#67959)
Remove "This is taking a long time" progress timeout and TimeoutConfiguration.
2020-10-13 13:05:47 -07:00
Jonah Williams
5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00