Jesse
f8a06f6418
Refactor realm_checker ( #145905 )
...
Refactor realm_checker suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing realm_checker tests
Part of https://github.com/flutter/flutter/issues/145482
*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-04-01 21:49:19 +00:00
Kallen Tu
9fd9f042fc
Add info strings to code blocks. ( #146085 )
...
In preparation to add the lint
`missing_code_block_language_in_doc_comment`, added info strings to a
bunch of fenced code blocks.
Related to issue: https://github.com/dart-lang/linter/issues/4904
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes
2024-04-01 14:05:16 -07:00
Kostia Sokolovskyi
5850651d60
Add test for animated_container.0.dart API example. ( #145995 )
...
This PR contributes to https://github.com/flutter/flutter/issues/130459
### Description
- Adds test for `examples/api/test/widgets/implicit_animations/animated_container.0_test.dart`
2024-04-01 20:25:40 +00:00
engine-flutter-autoroll
1e20714e78
Roll Flutter Engine from 8dff6b833fe2 to e6f19409b613 (2 revisions) ( #146093 )
...
8dff6b833f...e6f19409b6skia-flutter-autoroll@skia.org Roll Skia from dacd62255b8d to 40c436a785fa (3 revisions) (flutter/engine#51817 )
2024-04-01 matanlurey@users.noreply.github.com Remove unused and untested timeline data branch for `scenario_app` (flutter/engine#51816 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 20:25:38 +00:00
engine-flutter-autoroll
8c3575d610
Roll Flutter Engine from d33666d90916 to 8dff6b833fe2 (3 revisions) ( #146087 )
...
d33666d909...8dff6b833fjason-simmons@users.noreply.github.com Use the stripped Vulkan validation library in Android engine builds by default (flutter/engine#51628 )
2024-04-01 jason-simmons@users.noreply.github.com [Impeller] Set RGBA8888 as the default Vulkan color format before the app acquires a surface (flutter/engine#51770 )
2024-04-01 matanlurey@users.noreply.github.com Never panic in `finally { ... }`, check output logs on success only. (flutter/engine#51814 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 19:13:39 +00:00
Kate Lovett
6d7922f3f5
Fix SliverMainAxisGroup layout in reverse ( #145572 )
...
Fixes https://github.com/flutter/flutter/issues/145068
The original tests for SliverMainAxisGroup did not actually check where the child was painted (#126596 ).
Followed the same pattern in RenderSliverMultiBoxAdaptor:
11c034f037/packages/flutter/lib/src/rendering/sliver_multi_box_adaptor.dart (L666)
2024-04-01 19:06:07 +00:00
engine-flutter-autoroll
bd909542a3
Roll Flutter Engine from dd4f5cd5c9d5 to d33666d90916 (3 revisions) ( #146083 )
...
dd4f5cd5c9...d33666d909skia-flutter-autoroll@skia.org Roll Skia from da4cd3390be9 to dacd62255b8d (1 revision) (flutter/engine#51813 )
2024-04-01 zanderso@users.noreply.github.com Roll buildroot to dcd71b5b237e1e58f2ad8a7e51bead0c2a3755a9 (flutter/engine#51812 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Dart SDK from b735974580e7 to aa6544b48523 (1 revision) (flutter/engine#51810 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 18:25:50 +00:00
engine-flutter-autoroll
181b69b06e
Roll Packages from 51faaa156b61 to d5aff1980bc8 (3 revisions) ( #146081 )
...
51faaa156b...d5aff1980bengine-flutter-autoroll@skia.org Roll Flutter from 85288818b59e to d12ba5c270d8 (21 revisions) (flutter/packages#6440 )
2024-03-29 engine-flutter-autoroll@skia.org Roll Flutter from 89ea49204b37 to 85288818b59e (11 revisions) (flutter/packages#6436 )
2024-03-29 katelovett@google.com [two_dimensional_scrollables] Infinite TableView (flutter/packages#6411 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 18:05:13 +00:00
Dimil Kalathiya
a187cc7255
Fixes some gesture recognizers are not disposed. ( #146072 )
2024-04-01 09:50:59 -07:00
Bartek Pacia
ec82f0d895
Flutter Gradle Plugin: add versionName and versionCode to FlutterExtension ( #146044 )
...
This PR is a follow-up of a previous PR of mine:
https://github.com/flutter/flutter/pull/141417 . It was unfinished, i.e.
I only implemented it and used it in `examples/hello_world`. No "flutter
create" templates were modified.
This change is theoretically breaking, but in practice, I am pretty sure
nobody uses this. It was not accounced anywhere, the only app using it
is `examples/hello_world`. I did not do that (that=update docs and
templates) because I wanted a solution that is idiomatic in both Gradle
and Kotlin, and only now I found time to do this.
### Without this change
```groovy
defaultConfig {
applicationId = "io.flutter.examples.hello_world"
minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode()
versionName = flutter.versionName()
}
```
### With this change
```groovy
defaultConfig {
applicationId = "io.flutter.examples.hello_world"
minSdk = flutter.minSdkVersion
targetSdk = flutter.targetSdkVersion
versionCode = flutter.versionCode
versionName = flutter.versionName
}
```
Idiomatic getter - yay! It's consistent between assignment of all four
props.
### Issue
fixes https://github.com/flutter/flutter/issues/146067
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
---------
Co-authored-by: Reid Baker <reidbaker@google.com>
2024-04-01 18:09:13 +02:00
engine-flutter-autoroll
888cf95cfe
Roll Flutter Engine from bf348cd73d49 to dd4f5cd5c9d5 (1 revision) ( #146071 )
...
bf348cd73d...dd4f5cd5c9skia-flutter-autoroll@skia.org Roll Skia from 3093d7c90fb2 to da4cd3390be9 (1 revision) (flutter/engine#51811 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 15:56:17 +00:00
engine-flutter-autoroll
5537688dca
Roll Flutter Engine from 984a78b04671 to bf348cd73d49 (1 revision) ( #146065 )
...
984a78b046...bf348cd73dskia-flutter-autoroll@skia.org Roll Skia from 45e4d2cbdd4f to 3093d7c90fb2 (1 revision) (flutter/engine#51807 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 14:15:41 +00:00
Taha Tesser
e85340e1e4
Deprecate ButtonBar, ButtonBarThemeData, and ThemeData.buttonBarTheme ( #145523 )
...
fixes [Deprecate `ButtonBar`](https://github.com/flutter/flutter/issues/127955 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
theme: ThemeData(
buttonBarTheme: const ButtonBarThemeData(
alignment: MainAxisAlignment.spaceEvenly,
),
),
home: Scaffold(
body: ButtonBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
}
}
```
</details>
## Data driven fix
### Before executing `dart fix --apply`
```dart
return MaterialApp(
theme: ThemeData(
buttonBarTheme: const ButtonBarThemeData(
alignment: MainAxisAlignment.spaceEvenly,
),
),
home: Scaffold(
body: ButtonBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
```
### After executing `dart fix --apply`
```dart
return MaterialApp(
theme: ThemeData(
),
home: Scaffold(
body: OverflowBar(
alignment: MainAxisAlignment.spaceEvenly,
children: <Widget>[
TextButton(
onPressed: () {},
child: const Text('Button 1'),
),
TextButton(
onPressed: () {},
child: const Text('Button 2'),
),
TextButton(
onPressed: () {},
child: const Text('Button 3'),
),
],
),
),
);
```
2024-04-01 11:39:48 +00:00
Taha Tesser
40dda2b4bb
Add DataColumn.headingRowAlignment for DataTable ( #144006 )
...
fixes [[`DataTable`] Unable to center the label of a DataColumn without side effects](https://github.com/flutter/flutter/issues/143340 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
home: MaterialApp(
home: Material(
child: DataTable(
columns: <DataColumn>[
DataColumn(
headingRowAlignment: MainAxisAlignment.center,
onSort: (int columnIndex, bool ascending) {},
label: const Text('Header'),
),
],
sortColumnIndex: 0,
rows: const <DataRow>[
DataRow(
cells: <DataCell>[
DataCell(Center(child: Text('Data'))),
],
),
],
),
),
),
);
}
}
```
</details>
### Center `DataColumn.mainAxisAlignment` without sort arrow
### Center `DataColumn.mainAxisAlignment` with sort arrow
2024-04-01 09:42:51 +00:00
engine-flutter-autoroll
984c69a86f
Roll Flutter Engine from e9d35f8bfbe2 to 984a78b04671 (2 revisions) ( #146062 )
...
e9d35f8bfb...984a78b046skia-flutter-autoroll@skia.org Roll Skia from b9d078716d40 to 45e4d2cbdd4f (2 revisions) (flutter/engine#51806 )
2024-04-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TXxMINUq7JduIRX8K... to 5W6KVvHCGwWHBjm2m... (flutter/engine#51805 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from TXxMINUq7Jdu to 5W6KVvHCGwWH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 08:54:18 +00:00
engine-flutter-autoroll
0753f22353
Roll Flutter Engine from 4f6b832c8e33 to e9d35f8bfbe2 (1 revision) ( #146060 )
...
4f6b832c8e...e9d35f8bfbskia-flutter-autoroll@skia.org Roll Skia from c61843470d89 to b9d078716d40 (1 revision) (flutter/engine#51804 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-01 07:50:49 +00:00
engine-flutter-autoroll
fd8561a917
Roll Flutter Engine from 9689390986b7 to 4f6b832c8e33 (1 revision) ( #146055 )
...
9689390986...4f6b832c8ezanderso@users.noreply.github.com Prefix non-local build config names with ci/ (flutter/engine#51474 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 21:12:24 +00:00
engine-flutter-autoroll
b1cdd0f99b
Roll Flutter Engine from 34081fea4d59 to 9689390986b7 (1 revision) ( #146053 )
...
34081fea4d...9689390986matanlurey@users.noreply.github.com Finish clangd testing. (flutter/engine#51786 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 18:52:23 +00:00
engine-flutter-autoroll
9d32f07e34
Roll Flutter Engine from 2decefb00d1e to 34081fea4d59 (1 revision) ( #146048 )
...
2decefb00d...34081fea4dskia-flutter-autoroll@skia.org Roll Skia from 0970776d543a to c61843470d89 (1 revision) (flutter/engine#51802 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 09:17:33 +00:00
engine-flutter-autoroll
2c7749f6a8
Roll Flutter Engine from 3588d31a98f6 to 2decefb00d1e (1 revision) ( #146047 )
...
3588d31a98...2decefb00dskia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from wrbGDfD0BEOBXEGMK... to TXxMINUq7JduIRX8K... (flutter/engine#51801 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from wrbGDfD0BEOB to TXxMINUq7Jdu
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-31 07:38:23 +00:00
LongCatIsLooong
ff284c51bd
Implement computeDryBaseline for cupertino RenderBoxes ( #145951 )
...
The `_debugVerifyDryBaselines` method verifies that dry baseline implementation is consistent with the wet baseline method at the current constraints.
2024-03-30 21:38:24 +00:00
engine-flutter-autoroll
d12ba5c270
Roll Flutter Engine from 08eb5ad6e498 to 3588d31a98f6 (1 revision) ( #146031 )
...
08eb5ad6e4...3588d31a98skia-flutter-autoroll@skia.org Roll Dart SDK from 572de60e008a to b735974580e7 (2 revisions) (flutter/engine#51799 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 08:22:23 +00:00
engine-flutter-autoroll
57a711fce5
Roll Flutter Engine from df581c316485 to 08eb5ad6e498 (2 revisions) ( #146028 )
...
df581c3164...08eb5ad6e4skia-flutter-autoroll@skia.org Roll Skia from 7dc399e01f98 to 0970776d543a (1 revision) (flutter/engine#51796 )
2024-03-30 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3vgfbp1vjXkdMZ09m... to wrbGDfD0BEOBXEGMK... (flutter/engine#51797 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 3vgfbp1vjXkd to wrbGDfD0BEOB
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 06:12:25 +00:00
engine-flutter-autoroll
664393f897
Roll Flutter Engine from 5df1042cd927 to df581c316485 (1 revision) ( #146025 )
...
5df1042cd9...df581c3164skia-flutter-autoroll@skia.org Roll Skia from ab0f4a038cec to 7dc399e01f98 (2 revisions) (flutter/engine#51795 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 04:21:14 +00:00
engine-flutter-autoroll
423f985e6d
Roll Flutter Engine from dce6ce366c74 to 5df1042cd927 (2 revisions) ( #146024 )
...
dce6ce366c...5df1042cd9skia-flutter-autoroll@skia.org Roll Dart SDK from 52b05146758e to 572de60e008a (1 revision) (flutter/engine#51794 )
2024-03-30 matanlurey@users.noreply.github.com Add more Java and Dart logging to `scenario_app` (for now) (flutter/engine#51789 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 03:30:03 +00:00
engine-flutter-autoroll
bdc0bab824
Roll Flutter Engine from 221b49ae4a82 to dce6ce366c74 (1 revision) ( #146023 )
...
221b49ae4a...dce6ce366cskia-flutter-autoroll@skia.org Roll Skia from 7338f5521e05 to ab0f4a038cec (1 revision) (flutter/engine#51793 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 02:38:23 +00:00
engine-flutter-autoroll
c831350544
Roll Flutter Engine from 0a751669e722 to 221b49ae4a82 (1 revision) ( #146022 )
...
0a751669e7...221b49ae4askia-flutter-autoroll@skia.org Roll Skia from df005a80da32 to 7338f5521e05 (11 revisions) (flutter/engine#51791 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 01:11:05 +00:00
engine-flutter-autoroll
e8fdeff28b
Roll Flutter Engine from 8ec35b6d63ba to 0a751669e722 (2 revisions) ( #146020 )
...
8ec35b6d63...0a751669e7skia-flutter-autoroll@skia.org Roll Skia from a12e40efacea to df005a80da32 (1 revision) (flutter/engine#51777 )
2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Fix EGL surface destruction race (flutter/engine#51781 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-30 00:14:27 +00:00
engine-flutter-autoroll
d48d19733b
Roll Flutter Engine from 4b6836f8ef00 to 8ec35b6d63ba (3 revisions) ( #146014 )
...
4b6836f8ef...8ec35b6d6330870216+gaaclarke@users.noreply.github.com [Impeller] removed old blur detritus (flutter/engine#51779 )
2024-03-29 matanlurey@users.noreply.github.com Implement `Paint.from(other)` for `dart:ui`. (flutter/engine#51110 )
2024-03-29 skia-flutter-autoroll@skia.org Roll Dart SDK from bb65648e20e2 to 52b05146758e (3 revisions) (flutter/engine#51783 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 23:35:09 +00:00
engine-flutter-autoroll
a844de5cfd
Roll Flutter Engine from 4c079a6ff502 to 4b6836f8ef00 (3 revisions) ( #146010 )
...
4c079a6ff5...4b6836f8efmatanlurey@users.noreply.github.com Rename `Mac clangd` to `Linux mac_clangd` (flutter/engine#51785 )
2024-03-29 matanlurey@users.noreply.github.com Fix the `clangd` builders, and make Linux non-bringup. (flutter/engine#51765 )
2024-03-29 magder@google.com Remove _dartobservatory._tcp legacy DNS registration type (flutter/engine#51635 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 22:40:21 +00:00
Nate
a17d4b34f0
Implementing switch expressions in flutter_tools/ ( #145632 )
...
This pull request is step 12 in the journey to make this entire repository more readable.
(previous PRs: #139048 , #139882 , #141591 , #142279 , #142634 , #142793 , #143293 , #143496 , #143634 , #143812 , #144580 )
We're getting close to the end! ð
2024-03-29 22:31:19 +00:00
godofredoc
7f6685658c
Generate test metrics consistently. ( #145943 )
...
Starts creating metric files consistently for web, dart and flutter runners. It also starts creating the files in the temp folder instead of the checkout one.
Bug: https://github.com/flutter/flutter/issues/145793
2024-03-29 22:18:20 +00:00
engine-flutter-autoroll
caddea09a2
Roll Flutter Engine from 32c9dab552f0 to 4c079a6ff502 (3 revisions) ( #146007 )
...
32c9dab552...4c079a6ff5matanlurey@users.noreply.github.com Remove the tests for `rotate` and `crop` from the Android `scenario_app`. (flutter/engine#51769 )
2024-03-29 30870216+gaaclarke@users.noreply.github.com [Impeller] split out aiks blend tests (flutter/engine#51780 )
2024-03-29 dkwingsmt@users.noreply.github.com [macOS] Move to new present callback (flutter/engine#51436 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 21:56:24 +00:00
Ian Hickson
887bdcfb6b
Add flutter_goldens README ( #145278 )
...
This is part 5 of a broken down version of the #140101 refactor.
This PR adds a README to flutter_goldens with breadcrumbs to other sources of documentation.
2024-03-29 21:20:58 +00:00
Ian Hickson
16ec1a8434
Remove state shared across tests ( #145281 )
...
This is part 6 of a broken down version of the #140101 refactor.
This change tries to be as minimal as possible to make review as easy as possible. We can further simplify this file in future PRs. This change allows us to re-enable test order randomization for these tests.
2024-03-29 21:19:47 +00:00
engine-flutter-autoroll
1c0eb6804b
Roll Flutter Engine from 8480145cc39d to 32c9dab552f0 (1 revision) ( #146005 )
...
8480145cc3...32c9dab55231859944+LongCatIsLooong@users.noreply.github.com Turn struct half leading in canvaskit kitchensink test back on (flutter/engine#50707 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 21:15:44 +00:00
Bruno Leroux
49183c256c
InputDecorator M3 tests migration - Step7 - container ( #145583 )
...
## Description
This PRs adds a test group for the input decorator container, this group is organised similarly to the M3 spec, see https://m3.material.io/components/text-fields/specs .
It is step 7 for the M3 test migration for `InputDecorator`.
Step 1: https://github.com/flutter/flutter/pull/142981
Step 2: https://github.com/flutter/flutter/pull/143369
Step 3: https://github.com/flutter/flutter/pull/143520
Step 4: https://github.com/flutter/flutter/pull/144169
Step 5: https://github.com/flutter/flutter/pull/144932
Step 6: https://github.com/flutter/flutter/pull/145213
## Related Issue
Related to https://github.com/flutter/flutter/issues/139076
@justinmc The diff is not very readable. The tests added by this PR are from line 298 to line 975. Other changes are due to moving some existing tests to this new 'container' group.
2024-03-29 20:48:49 +00:00
engine-flutter-autoroll
0bc7464711
Roll Flutter Engine from 7176173ea303 to 8480145cc39d (3 revisions) ( #146001 )
...
7176173ea3...8480145cc3matanlurey@users.noreply.github.com Add a minimal example of using `package:test`. (flutter/engine#51726 )
2024-03-29 matanlurey@users.noreply.github.com Implement `.engine-release.version` files for engine Skia Gold tests (flutter/engine#51739 )
2024-03-29 mdebbar@google.com [web] Use viewId for text editing (flutter/engine#51099 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 20:30:09 +00:00
engine-flutter-autoroll
6fb281fa73
Roll Flutter Engine from b16c0f136cdd to 7176173ea303 (1 revision) ( #145994 )
...
b16c0f136c...7176173ea3jonahwilliams@google.com [Impeller] generate mip level N from N-1 in Vulkan backend. (flutter/engine#51749 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 19:46:05 +00:00
Polina Cherkasova
bca1d6ad1f
Upgrade leak_tracker. ( #145997 )
2024-03-29 12:31:52 -07:00
engine-flutter-autoroll
9d6b4f1c03
Roll Flutter Engine from 68aa9ba386e1 to b16c0f136cdd (10 revisions) ( #145990 )
...
68aa9ba386...b16c0f136cskia-flutter-autoroll@skia.org Roll Skia from 94c0af1297ae to a12e40efacea (3 revisions) (flutter/engine#51776 )
2024-03-29 skia-flutter-autoroll@skia.org Roll Skia from b2a01ae03cdf to 94c0af1297ae (1 revision) (flutter/engine#51773 )
2024-03-29 skia-flutter-autoroll@skia.org Roll Skia from 6042ad386bcf to b2a01ae03cdf (4 revisions) (flutter/engine#51772 )
2024-03-29 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uzI3wnbEGlZ_dtO0Z... to 3vgfbp1vjXkdMZ09m... (flutter/engine#51767 )
2024-03-29 jacksongardner@google.com [skwasm] Fix `toString` methods on Paint and ImageFilter/ColorFilter (flutter/engine#51766 )
2024-03-29 john@johnmccutchan.com Reland https://github.com/flutter/engine/pull/51391 (flutter/engine#51764 )
2024-03-29 737941+loic-sharma@users.noreply.github.com Add completion callback to `Shell::AddView` (flutter/engine#51659 )
2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Move keyboard initialization (flutter/engine#51758 )
2024-03-29 737941+loic-sharma@users.noreply.github.com [Windows] Don't always stop engine on view destruction (flutter/engine#51681 )
2024-03-28 dkwingsmt@users.noreply.github.com [macOS] Group per-view information in `FlutterCompositor` into a class (flutter/engine#51738 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from uzI3wnbEGlZ_ to 3vgfbp1vjXkd
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 17:25:24 +00:00
engine-flutter-autoroll
660761ee4b
Roll Packages from 924c7e6e899d to 51faaa156b61 (8 revisions) ( #145986 )
...
924c7e6e89...51faaa156bkrupikivan@gmail.com [shared_preferences] Update mockito to the new version available 5.2.0 (flutter/packages#6332 )
2024-03-29 engine-flutter-autoroll@skia.org Manual roll Flutter (stable) from 68bfaea22488 to 300451adae58 (2 revisions) (flutter/packages#6433 )
2024-03-28 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.exifinterface:exifinterface from 1.3.6 to 1.3.7 in /packages/image_picker/image_picker_android/android (flutter/packages#5705 )
2024-03-28 engine-flutter-autoroll@skia.org Manual roll Flutter from dbdcead93225 to 89ea49204b37 (54 revisions) (flutter/packages#6431 )
2024-03-28 ditman@gmail.com [ci] Adds sleep 60s to release action. (flutter/packages#6405 )
2024-03-28 112062427+anisovdev@users.noreply.github.com [go_router]: fix GoRouter.optionURLReflectsImperativeAPIs flag works with new imperative APIs (flutter/packages#6236 )
2024-03-28 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Reland "Creates and adds the interactive_media_ads plugin #6060 " (flutter/packages#6425 )
2024-03-28 ditman@gmail.com [google_sign_in_ios] Pins GoogleSignIn to 7.0.0 in podspec. (flutter/packages#6430 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 16:44:06 +00:00
Gray Mackall
85288818b5
Remove trailing commas in android dependency version checking gradle plugin ( #145718 )
...
Apparently old versions of kotlin (pre 1.4) don't allow trailing commas.
Example logs: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8752506486861217537/+/u/Run_package_tests/build_all_packages_for_Android_-_legacy_version/stdout
2024-03-29 16:31:06 +00:00
Polina Cherkasova
1a2f34ab5b
Upgrade leak_tracker. ( #145940 )
2024-03-29 02:39:17 +00:00
engine-flutter-autoroll
0c4ef23313
Roll Flutter Engine from 8b893cb3b607 to 68aa9ba386e1 (2 revisions) ( #145946 )
...
8b893cb3b6...68aa9ba386jonahwilliams@google.com [Impeller] dont clamp mipmap level to 0 with Vulkan textures. (flutter/engine#51761 )
2024-03-28 john@johnmccutchan.com Add `et query tests` and `et test` commands (flutter/engine#51605 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 01:10:24 +00:00
Jesse
93b071e727
Refactor flutter_plugins ( #145870 )
...
Refactor flutter_plugins suite in order to reduce testing logic in test.dart and allow for later implementing package:test onto the existing flutter_plugins tests
Also update the test_test invocation of getFlutterPackagesVersion
Part of https://github.com/flutter/flutter/issues/145482
2024-03-29 00:59:30 +00:00
Gray Mackall
0984a7f04b
Point kotlin message in gradle_errors.dart towards new place where templates define the kotlin version ( #145936 )
...
Fixes https://github.com/flutter/flutter/issues/144454
For reference, after formatting it looks like:
```
ââ Flutter Fix âââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
â [!] Your project requires a newer version of the Kotlin Gradle plugin. â
â Find the latest version on https://kotlinlang.org/docs/releases.html#release-details , then update the â
â version number of the plugin with id "org.jetbrains.kotlin.android" in the plugins block of â
â /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/settings.gradle. â
â â
â Alternatively (if your project was created before Flutter 3.19), update â
â /Users/mackall/development/BugTesting/ELIMINATEME/blah/android/build.gradle â
â ext.kotlin_version = '<latest-version>' â
ââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââââ
```
2024-03-29 00:31:01 +00:00
engine-flutter-autoroll
a366e5e69d
Roll Flutter Engine from b917b24836fd to 8b893cb3b607 (1 revision) ( #145941 )
...
b917b24836...8b893cb3b6skia-flutter-autoroll@skia.org Roll Skia from e25b0f9006a4 to 6042ad386bcf (1 revision) (flutter/engine#51763 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-29 00:08:24 +00:00
engine-flutter-autoroll
11d632e5dd
Roll Flutter Engine from c176d114d01e to b917b24836fd (4 revisions) ( #145938 )
...
c176d114d0...b917b24836matanlurey@users.noreply.github.com Test that `clangd --check` works at HEAD. (flutter/engine#50901 )
2024-03-28 matanlurey@users.noreply.github.com Remove `--verbose` from clang_tidy execution on CI. (flutter/engine#51760 )
2024-03-28 matanlurey@users.noreply.github.com Remove Android API v33 tests from CI. (flutter/engine#51751 )
2024-03-28 30870216+gaaclarke@users.noreply.github.com Reland: [Impeller] adds a plus advanced blend for f16 pixel formats (flutter/engine#51756 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-03-28 23:21:34 +00:00
LongCatIsLooong
460a5e22bd
RenderFlex baseline intrinsics (#145483 )
...
Implements `RenderFlex` intrinsics calculation when children are baseline aligned in the cross axis.
2024-03-28 23:07:06 +00:00
