6982 Commits

Author SHA1 Message Date
Adam Barth
09f764494e Update engine.version (#6414) 2016-10-19 23:29:23 -07:00
Adam Barth
db9fb69b69 Migrate HostMessages to PlatformMessages (#6409)
We'll eventually remove HostMessages because it's just a pass-through to
PlatformMessages, but that will be a separate step.
2016-10-19 22:55:25 -07:00
Adam Barth
beb8afa456 Switch to the assets plugin (#6408)
This patch removes our dependency on asset_bundle.mojom.
2016-10-19 22:04:56 -07:00
Adam Barth
32e95cc6e1 Update engine.version (#6411) 2016-10-19 19:10:28 -07:00
Jason Simmons
edbe034847 Specify the algorithm used to sign APK packages (#6404)
Required for compatibility with older versions of Android
2016-10-19 16:10:46 -07:00
Hans Muller
5d19fe3537 export the Overflow enum (#6403) 2016-10-19 15:56:58 -07:00
Adam Barth
c08ea4eb33 Switch to TextInputPlugin (#6392)
This patch removes uses of keyboard.mojom in favor of the
TextInputPlugin.
2016-10-19 15:53:31 -07:00
Yegor
4f8da89dc4 Revert "reenable dev/devicelab/test/run_test.dart (#6364)" (#6378)
This reverts commit 8f273e49dea9233aa2958744a2c513e23b4f3fe6.
2016-10-19 18:43:19 -04:00
Adam Barth
50b283144f Update engine.version (#6402) 2016-10-19 15:02:03 -07:00
Matt Perry
d39eb84ac4 Add a maxLines parameter for multiline Input. (#6328)
If maxLines is 1, it's a single line Input that scrolls horizontally.
Otherwise, overflowed text wraps and scrolls vertically, taking up at
most `maxLines`.

Also fixed scrolling behavior so that the Input scrolls ensuring the
cursor is always visible.

Fixes https://github.com/flutter/flutter/issues/6271
2016-10-19 17:18:16 -04:00
Matt Perry
97dbd9eacf Rename RawInputLine to RawInput, and RenderEditableLine to RenderEdit… (#6401)
They support multiline text now.
2016-10-19 17:17:51 -04:00
Ian Hickson
5bde9d284d Expand Semantics dartdocs. (#6399)
I based this on a conversation I had with @mpcomplete.
2016-10-19 17:01:04 -04:00
Hans Muller
9eef853580 Update Android scrolling physicsAndroid physics (#6391) 2016-10-19 09:08:54 -07:00
Adam Barth
2cfc040572 Add TextInput class for interacting with the IME (#6386)
This class will eventually replace the Keyboard class we currently use. As part
of this migration, we'll switch from using mojom to interact with the IME to
using platform messages.
2016-10-18 22:41:09 -07:00
Ian Hickson
cfddacbb81 Platform selector in gallery. (#6390) 2016-10-18 22:44:43 -04:00
Jason Simmons
1f1d72853b Enable call to Keyboard.ClearClient now that it's available in the engine (#6384)
Fixes https://github.com/flutter/flutter/issues/6274
2016-10-18 14:42:25 -07:00
Phil Quitslund
57044c2a63 Bump to Dart SDK 1.21.0-dev.0.0. (#6372)
Bump to latest Dart SDK dev build (`1.21.0-dev.0.0`).

* updates to analyzer w/ support for bazel workspaces
* removes deprecated analysis `cacheSize` variable access
2016-10-18 13:38:13 -07:00
Jason Simmons
ebe60bab22 BottomNavigationBar: fix the calculation of the expanding circle animation (#6373)
The circle's offset represents the position of a navigation button within the
row of buttons.  Previously, this offset had been applied to the entire width
of the bottom bar, not just the button region.

Fixes https://github.com/flutter/flutter/issues/6046
2016-10-18 11:51:34 -07:00
Yegor
1eda886e7e unlock device before running transition test (#6371) 2016-10-18 10:20:05 -07:00
Adam Barth
88cf68c847 Migrate Clipboard to platform messages (#6367)
The platform plugin now supports clipboard operations.
2016-10-18 10:04:17 -07:00
Adam Barth
50ebcd1dff Migrate RawKeyboard to platform events (#6366)
This patch moves RawKeyboard from mojom over to platform messages. In
the process, I've also cleaned up the interface substantially.

Currently raw key events are supported only on Android, but the
interfaces defined in this patch should scale up to multiple platforms.
2016-10-18 00:59:40 -07:00
Adam Barth
67a298443e Update engine.version (#6365) 2016-10-17 22:29:50 -07:00
Yegor
8f273e49de reenable dev/devicelab/test/run_test.dart (#6364)
I ran the test 10 times on Linux and Mac and it succeeded
consistently. Let's reenable until there are new reports that it's
flaky.

Fixes #5901
2016-10-17 19:31:58 -07:00
Yegor
eabadad6c0 Add more logging to the gallery transitions test (#6363) 2016-10-17 17:30:51 -07:00
Yegor
995fcdc92b add description to by-predicate finders (#6362)
Add an option to provide a custom description to predicate
finders. Without a custom description we default to printing the
predicate function's signature, which is not all that useful.

Use this new option in the driver extension to print the text of the
sought after tooltip.
2016-10-17 17:16:22 -07:00
Adam Barth
08ba8dc495 Add a mechanism for receiving platform messages (#6361) 2016-10-17 16:42:01 -07:00
Yegor
88e065de86 driver: forward device logs to local console (#6360)
Fixes #4261
2016-10-17 14:52:46 -07:00
Adam Barth
48690d7c2e Add support for persistent footer buttons (#6345)
Fixes #616
2016-10-17 12:50:47 -07:00
Adam Barth
c77798a384 PaintingContext should say when alwaysNeedsCompositing is needed (#6338)
Also, update the docs to point to the correct property.

Fixes #6224
2016-10-17 12:35:19 -07:00
Adam Barth
63e7a0e80a Add BuildContext.size as a convenience getter (#6355)
Developers need to get the size of the BuildContext sufficiently often
that we should provide a convenient getter for the value. Having this
getter is also an opportunity to catch common mistakes and provide
useful error messages that guide developers towards better patterns.

Fixes #2321
2016-10-17 12:33:11 -07:00
Adam Barth
4052a36677 Test what context the overlay entries build in (#6337)
Fixes #6245
2016-10-17 11:17:08 -07:00
Adam Barth
1d6fa089c4 Improve error message for createState type errors (#6339)
Fixes #6209
2016-10-17 11:16:50 -07:00
Adam Barth
8b16c0252d Add custom clipping to ClipRRect (#6346)
Fixes #773
2016-10-17 11:16:26 -07:00
Phil Quitslund
3203757958 Bump to Dart SDK 1.20.1 stable (#6357) 2016-10-17 10:30:13 -07:00
Adam Barth
61240fe8c6 Tap above LongPressDraggable should work (#6348)
Previously, we were nulling out the ArenaEntry in MultiDragPointerState
too early, which was prevent MultiDragPointerState from rejecting the
gesture in `dispose` if we hadn't accepted by the time the pointer went
up. Now we properly reject the gesture, which causes the tap gesture to
win during `sweep` in the arena.

Also, add a bunch of docs and annotations based on information I learned
while studying this issue. Finally, rename a private member of tap
recognizer to a name that would have confused me less in my
investigation.

Fixes #1186
2016-10-17 10:05:28 -07:00
Adam Barth
6399a3af41 Fix DropdownButton regression (#6353)
When I changed how routes complete their futures, I broke the Dropdown
button because it was still waiting for its own Completer to complete
instead of using the Future returned by push. This patch fixes that
issue.

I've also removed the previous behavior of the DropdownButton forwarding
its text style to its route. The mechansim that we were using doesn't
work properly in all cases. For example, if the DropdownButton is a
child of a LayoutBuilder, then the route will have already built by the
time the DropdownButton gets a chance to forward its text style, causing
an assert in setState.

Finally, I've tweaked PopupMenuButton to work the same way as
DropdownButton in a couple corner cases (e.g., not calling the changed
callback if the button was removed from the tree before the menu
completed its Future).

Fixes #6352
2016-10-17 10:00:48 -07:00
Adam Barth
e81e06a6ae Fix typo in TableRow.toString (#6354)
Fixes #6351
2016-10-17 10:00:09 -07:00
Devon Carew
e9b041f21e don't run the summary code if the upgrade fails (#6350) 2016-10-16 10:05:13 -07:00
Adam Barth
06babb2898 Removing a Draggable during a drag should work (#6341)
Previously we would maroon the feedback in the overlay. Now we let the
drag proceed and only tear down the gesture recognizer when all the
drags it spawns have been resolved.

Fixes #6151
2016-10-15 18:31:14 -07:00
Adam Barth
1262833377 Support zero for Draggable.maxSimultaneousDrags (#6342)
This patch also makes it possible for a single DragTarget to handle
multiple draggables with the same data without asserting.

Fixes #6086
2016-10-15 18:25:25 -07:00
Adam Barth
ea3c3f53a5 Add Draggable.onDragStarted (#6343)
Fixes #6084
2016-10-15 13:03:31 -07:00
Adam Barth
034d2fcd5d Ensure delayed multidrag timer is stopped (#6340)
Previously we were relying on the gesture arena to call us back to
cancel our timer. However, in the case where we've already been
accepted, asking the gesture arena to reject us doesn't lead to a
callback and we fail to stop the timer (and hence trigger an assert).

Fixes #6156
2016-10-15 13:02:38 -07:00
Adam Barth
9cab64a72c More automated edits of iml files 2016-10-14 21:57:28 -07:00
Hans Muller
f167efba49 Tweaked scroll simulation for iOS platform (#6334) 2016-10-14 20:09:19 -07:00
Adam Barth
71f44f331a Update engine.version (#6336) 2016-10-14 18:42:28 -07:00
Adam Barth
ffe14b0d27 Navigator.push and Navigator.pushNamed should return Futures (#6333)
These futures complete when the route is popped off the navigator. This
generalizes and simplifies a mechanism already in place for dialogs and
menus.

Fixes #5283
2016-10-14 16:05:45 -07:00
Todd Volkert
cedbfd4896 Don't crash if we fail to get the flutter or engine revision (#6332) 2016-10-14 15:43:44 -07:00
Adam Barth
93d757c3e0 Dismissable should cull and clip background (#6325)
When not dismissing, the Dismissable widget should cull its background.
When a dismiss is in progress, it should clip the background to just the
part that is revealed.

Fixes #6127
2016-10-14 13:32:56 -07:00
Chris Bracken
4a3cd61044 Execute flutter doctor on upgrade (#6330)
Ensure that any new/changed doctor checks are evaluated and reported
post upgrade.
2016-10-14 12:57:37 -07:00
Adam Barth
9a136b8722 Reduce logspam on iOS simulator (#6327)
Fixes #6311
2016-10-14 11:06:10 -07:00