41672 Commits

Author SHA1 Message Date
engine-flutter-autoroll
ac74e26a70
Roll Flutter Engine from 3c6a373bda3e to 1f0f950ea02a (1 revision) (#151326)
3c6a373bda...1f0f950ea0

2024-07-04 skia-flutter-autoroll@skia.org Roll Skia from 72b2ea81c959 to abda211b2753 (1 revision) (flutter/engine#53732)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-05 01:46:34 +00:00
engine-flutter-autoroll
a33c5302cb
Roll Flutter Engine from 79a91e38c587 to 3c6a373bda3e (2 revisions) (#151318)
79a91e38c5...3c6a373bda

2024-07-04 skia-flutter-autoroll@skia.org Roll Skia from a2d00a28c563 to 72b2ea81c959 (1 revision) (flutter/engine#53731)
2024-07-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -VgqOfoW5sf04SuJh... to 5WGhpr75y_pb6u2OO... (flutter/engine#53728)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from -VgqOfoW5sf0 to 5WGhpr75y_pb

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 17:36:23 +00:00
engine-flutter-autoroll
360bd54ff4
Roll Packages from d2705fb82b26 to 754de1918a33 (3 revisions) (#151315)
d2705fb82b...754de1918a

2024-07-03 49699333+dependabot[bot]@users.noreply.github.com [interactive_media_ads]: Bump com.google.ads.interactivemedia.v3:interactivemedia from 3.33.0 to 3.34.0 in /packages/interactive_media_ads/android (flutter/packages#7037)
2024-07-03 stuartmorgan@google.com [google_maps_flutter] Fix Circle update regression (flutter/packages#7056)
2024-07-03 engine-flutter-autoroll@skia.org Roll Flutter from 99bb2ff6a614 to af913a75b5d2 (30 revisions) (flutter/packages#7047)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 15:48:25 +00:00
engine-flutter-autoroll
2a7fff6ab9
Roll Flutter Engine from 2b6bb516e7e6 to 79a91e38c587 (2 revisions) (#151314)
2b6bb516e7...79a91e38c5

2024-07-04 skia-flutter-autoroll@skia.org Roll Skia from 28ba3b1b0951 to a2d00a28c563 (2 revisions) (flutter/engine#53726)
2024-07-04 skia-flutter-autoroll@skia.org Roll Skia from d5f8dde714e4 to 28ba3b1b0951 (1 revision) (flutter/engine#53724)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 15:37:23 +00:00
engine-flutter-autoroll
36e392630b
Roll Flutter Engine from 8e2d05fa95d7 to 2b6bb516e7e6 (2 revisions) (#151299)
8e2d05fa95...2b6bb516e7

2024-07-04 98614782+auto-submit[bot]@users.noreply.github.com Reverts "fix: mask disappeared when having nested mask filter on Flutter web HTML (#45166)" (flutter/engine#53725)
2024-07-04 jonahwilliams@google.com [Impeller] mark the end of a frame boundary for system compositor interop. (flutter/engine#53722)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 10:29:26 +00:00
engine-flutter-autoroll
fa70e610cc
Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) (#151293)
4190543cb0...8e2d05fa95

2024-07-04 flar@google.com [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721)
2024-07-03 yjbanov@google.com [web] ignore pointer events on plain text spans (flutter/engine#53694)
2024-07-03 mdebbar@google.com Add Semantics Property `linkUrl` (flutter/engine#53507)
2024-07-03 chinmaygarde@google.com [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720)
2024-07-03 chinmaygarde@google.com [Impeller] Make storage sizes typed. (flutter/engine#53700)
2024-07-03 matanlurey@users.noreply.github.com Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645)
2024-07-03 matanlurey@users.noreply.github.com Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587)
2024-07-03 chinmaygarde@google.com [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671)
2024-07-03 kingtous@qq.com [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998)
2024-07-03 kingtous@qq.com fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-04 04:59:34 +00:00
flutter-pub-roller-bot
bf40ae3bc7
Roll pub packages (#151203)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-07-03 21:47:16 +00:00
Aaron Housh
25b72bab18
Fix invalid URL suggestion for gradle incompatability (#150999)
The current URL has 2 /to, but it should only be 1. However, this url redirects to https://docs.flutter.dev/release/breaking-changes/android-java-gradle-migration-guide, so I can change it to that if it's preferred just to go to the final destination - just don't know if it's a redirect for a reason

i didn't create an issue as it's a doc change, but if that's a requirement I can do that
2024-07-03 20:38:11 +00:00
Vincent Velociter
6e246ac854
Cupertino transparent navigation bars (#149102)
This PR is making the `CupertinoNavigationBar` and `CupertinoSliverNavigationBar` appear transparent as long as the content is not scrolled under them, so they look like standard iOS apps nav bars.

https://github.com/flutter/flutter/assets/423393/eee2700b-2a91-4577-922c-6163d47cb357

https://github.com/flutter/flutter/assets/423393/3847f2b5-0dac-4d5e-aa6f-03c1d2893e30

<details>
  <summary>Demo app code</summary>
  
  ```dart
import 'package:flutter/cupertino.dart';

/// Flutter code sample for [CupertinoTabScaffold].

void main() => runApp(const TabScaffoldApp());

class TabScaffoldApp extends StatefulWidget {
  const TabScaffoldApp({super.key});

  @override
  State<TabScaffoldApp> createState() => _TabScaffoldAppState();
}

class _TabScaffoldAppState extends State<TabScaffoldApp> {
  Brightness _brightness = Brightness.light;

  @override
  Widget build(BuildContext context) {
    return CupertinoApp(
      theme: CupertinoThemeData(brightness: _brightness),
      home: TabScaffoldExample(
          brightness: _brightness, onBrightnessToggle: _toggleBrightness),
    );
  }

  void _toggleBrightness() {
    setState(() {
      _brightness =
          _brightness == Brightness.light ? Brightness.dark : Brightness.light;
    });
  }
}

class TabScaffoldExample extends StatefulWidget {
  const TabScaffoldExample(
      {required this.brightness, required this.onBrightnessToggle, super.key});

  final VoidCallback onBrightnessToggle;
  final Brightness brightness;

  @override
  State<TabScaffoldExample> createState() => _TabScaffoldExampleState();
}

class _TabScaffoldExampleState extends State<TabScaffoldExample> {
  @override
  Widget build(BuildContext context) {
    return CupertinoTabScaffold(
      tabBar: CupertinoTabBar(
        items: const <BottomNavigationBarItem>[
          BottomNavigationBarItem(
            icon: Icon(CupertinoIcons.home),
            label: 'Home',
          ),
          BottomNavigationBarItem(
            icon: Icon(CupertinoIcons.search_circle_fill),
            label: 'Explore',
          ),
          BottomNavigationBarItem(
            icon: Icon(CupertinoIcons.person_fill),
            label: 'Profile',
          ),
          BottomNavigationBarItem(
            icon: Icon(CupertinoIcons.settings_solid),
            label: 'Settings',
          ),
        ],
      ),
      tabBuilder: (BuildContext context, int index) {
        return CupertinoTabView(
          builder: (BuildContext context) {
            return CupertinoPageScaffold(
              backgroundColor: index == 3
                  ? CupertinoColors.secondarySystemBackground
                      .resolveFrom(context)
                  : null,
              child: CustomScrollView(
                slivers: [
                  CupertinoSliverNavigationBar(
                    largeTitle: Text('Tab $index'),
                    initiallyTransparent: index != 2,
                    trailing: CupertinoButton(
                      padding: EdgeInsets.zero,
                      onPressed: widget.onBrightnessToggle,
                      child: Icon(
                        widget.brightness == Brightness.light
                            ? CupertinoIcons.moon_stars
                            : CupertinoIcons.sun_max,
                      ),
                    ),
                  ),
                  SliverSafeArea(
                    top: false,
                    sliver: SliverList.list(
                      children: [
                        CupertinoButton(
                          child: const Text('Next page'),
                          onPressed: () {
                            Navigator.of(context).push(
                              CupertinoPageRoute<void>(
                                builder: (BuildContext context) {
                                  return CupertinoPageScaffold(
                                    navigationBar: CupertinoNavigationBar(
                                      middle: Text('Inner page of tab $index'),
                                    ),
                                    child: ListView(
                                      children: [
                                        Center(
                                          child: CupertinoButton(
                                            child: const Text('Back'),
                                            onPressed: () {
                                              Navigator.of(context).pop();
                                            },
                                          ),
                                        ),
                                        if (index == 0) const _LongList(),
                                        const SizedBox(height: 20),
                                      ],
                                    ),
                                  );
                                },
                              ),
                            );
                          },
                        ),
                        if (index == 1) const _LongList(),
                        const SizedBox(height: 20),
                      ],
                    ),
                  ),
                ],
              ),
            );
          },
        );
      },
    );
  }
}

class _LongList extends StatelessWidget {
  const _LongList();

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        for (int i = 0; i < 50; i++) ...[
          CupertinoListTile(
            leading: const Icon(CupertinoIcons.book),
            title: Text('Bookstore item $i'),
          ),
        ],
      ],
    );
  }
}
  ```
</details>

This is the continuation of https://github.com/flutter/flutter/pull/142439.

I tried to keep the simplest API possible, so it's only introducing a new `automaticBackgroundVisibility` boolean parameter. 

In the implementation I had to use the `CupertinoPageScaffold` background color to make it look transparent instead of a 0 opacity, because of issues with route transitions.

I used an `InheritedWidget` so the nav bar is always getting the right background color from the parent scaffold, whether it is overridden or not. It would probably be better to make the inherited widget private but we'd need to move all the nav bar code to the same file as the scaffold, so for now I've just hidden it from the export. Let me know if it is okay to do that.

This PR is not dealing with the bottom tab bar, because the same [straightforward approach](dde8ec6dc7) doesn't work here. The problem is that the scroll notification is sent only when the scroll view is created or updated, so it doesn't work if one pushes a screen and navigates back.

Issues:
- #78607 
- #60411
2024-07-03 20:35:27 +00:00
Harry Terkelsen
8e44e94e22
Prepares semantics_update_test for upcoming link URL change (#151261)
Prepares for https://github.com/flutter/engine/pull/53507 by adding a missing parameter to the `updateNode` test method.

Part of https://github.com/flutter/flutter/issues/150263
2024-07-03 20:31:23 +00:00
Nate Wilson
aad381638d
Add a message about spam/brigading (#150583)
~~I decided to add this message to CODE_OF_CONDUCT.md~~ never mind 🙂 

Let me know if anything should be changed.
2024-07-03 20:18:04 +00:00
Hans Muller
abd7cd0528
PinnedHeaderSliver example based on the iOS Settings AppBar (#151205)
A relatively elaborate PinnedSliverHeader example which creates an app bar that's similar to the one that appears in the iOS Settings app. In this example the pinned header starts out transparent and the first item in the list serves as the app's "Settings" title. When the title item has been scrolled completely behind the pinned header, the header animates its opacity from 0 to 1 and its (centered) "Settings" title appears. The fact that the header's opacity depends on the height of the title item - which is unknown until the list has been laid out - necessitates monitoring its SliverConstraints.scrollExtent from a scroll NotificationListener. 

https://github.com/flutter/flutter/assets/1377460/539e2591-d0d7-4508-8ce8-4b8f587d7648
2024-07-03 20:06:16 +00:00
Kate Lovett
143847626d
Update deprecation policy (#151257)
We are pausing our cadence of removing deprecated API from the framework until we can create a new policy.
The last couple of cycles we noticed customers having more difficult migrations, and it being harder to remove the APIs in the scheduled time period. So we need to reevaluate the policy and update it.

This is the policy working as intended. Signals like flutter/tests provide feedback on how we are affecting users - so that for folks that contributed!

Related to https://github.com/flutter/website/pull/10839
2024-07-03 20:01:07 +00:00
Hans Muller
d1e150099e
SliverFloatingHeader (#151145)
A sliver that shows its [child] when the user scrolls forward and hides it when the user scrolls backwards. Similar headers can be found in  Google Photos and Facebook.

This sliver is preferable to the general purpose SliverPersistentHeader for its relatively narrow use case because there's no need to create a SliverPersistentHeaderDelegate or to predict the header's size.

https://github.com/flutter/flutter/assets/1377460/82b67dfb-5d38-4adf-9415-fc8527d0eb9f
2024-07-03 19:52:52 +00:00
Gray Mackall
f60f85abcd
Remove warning when KGP version not detected (#151254)
The Kotlin Gradle plugin isn't actually required. Assume the good case if we can't find the version (that the project doesn't need it).
2024-07-03 19:49:07 +00:00
Kishan Rathore
fbd6890fb7
Feat: Add withOpacity to gradient (#150670)
Feat: Add withOpacity to gradient because sometimes it's required to call withOpacity directly on gradient

Resolves #150501 

This adds a `withOpacity` feature to a gradient, given user has given colors this will override opacity to given opacity for them.
2024-07-03 18:06:04 +00:00
Michael Goderbauer
56835d6039
Fix references in examples (#151204)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-03 17:56:48 +00:00
derdilla
91b928d52f
Fix link in tree hygene doc (#151235)
Link in how section of tree hygiene doc pointed to the wrong url for the style-guide doc introduced in [#148790](65abc95542).
2024-07-03 17:56:46 +00:00
flyboy
7b69688c8a
content dimensions are not established get controller value error (#148938)
*Fixed #[146986](https://github.com/flutter/flutter/issues/146986)*
2024-07-03 17:17:28 +00:00
Snoppy
65cd7cf7b2
chore: fix typos and link broken (#150402)
**fix some typos and link broken**
2024-07-03 17:10:19 +00:00
Alejandro Santiago
e383db7087
Add example of goldenFileComparator usage in widget tests (#150422)
As from #76337, precisely https://github.com/flutter/flutter/issues/76337#issuecomment-795486138 and https://github.com/flutter/flutter/issues/76337#issuecomment-2172941109. There is missing documentation with an example on how the [`goldenFileComparator`](https://api.flutter.dev/flutter/flutter_test/goldenFileComparator.html) can be used.

This change updates the documentation by providing an additional code snippet to the example that was already stated by the documentation. 

Follows the effort made by #76337 and https://github.com/flutter/flutter/pull/150343.
2024-07-03 17:03:08 +00:00
Navaron Bracke
ab8bc00e2c
Fix project name fallback (#150614)
This PR changes the project name logic for `flutter create` to look for the name in the pubspec.yaml `name` field,
before falling back to the directory name.

Fixes https://github.com/flutter/flutter/issues/53106 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-07-03 16:28:27 +00:00
engine-flutter-autoroll
c512a79b2f
Roll Flutter Engine from a3e61c0fd1c2 to 4190543cb093 (1 revision) (#151241)
a3e61c0fd1...4190543cb0

2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 92f928d81a27 to c14cce59222b (1 revision) (flutter/engine#53712)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 16:25:09 +00:00
engine-flutter-autoroll
8b7cd85b98
Roll Flutter Engine from 8274f54f11be to a3e61c0fd1c2 (2 revisions) (#151237)
8274f54f11...a3e61c0fd1

2024-07-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from x5Sccm0dUoMVbnyed... to -VgqOfoW5sf04SuJh... (flutter/engine#53711)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 9d530bb0bcbf to 92f928d81a27 (1 revision) (flutter/engine#53710)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from x5Sccm0dUoMV to -VgqOfoW5sf0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 13:59:13 +00:00
Jason Simmons
ea89f20eb5
Force regeneration of platform-specific manifests before running performance tests (#151003)
Some performance tests run "flutter create" to generate platform-specific project configuration files for the test app.  These files may be further patched by the test script to apply settings such as the Impeller backend.

The manifests need to be deleted and recreated on each run so that settings applied by previous runs will not be used by the current run.
2024-07-03 13:23:23 +00:00
Jason Simmons
b373fa2c6e
Handle a SocketException thrown when sending the browser close command to Chrome (#151197)
https://github.com/flutter/flutter/pull/150645 tries to shut down Chrome by sending a browser close command through a debug protocol.  The webkit_inspection_protocol library used to send the command may throw a SocketException if Chrome has already been shut down.
2024-07-03 13:23:20 +00:00
engine-flutter-autoroll
84b3f0ab79
Roll Flutter Engine from a02e3f673da3 to 8274f54f11be (4 revisions) (#151226)
a02e3f673d...8274f54f11

2024-07-03 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland "Output .js files as ES6 modules. (#52023)" (#53688)" (flutter/engine#53709)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from d78676d54cb5 to 9d530bb0bcbf (1 revision) (flutter/engine#53708)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 62c7020b7b36 to d78676d54cb5 (2 revisions) (flutter/engine#53707)
2024-07-03 skia-flutter-autoroll@skia.org Roll Skia from 7c69f39fa85b to 62c7020b7b36 (1 revision) (flutter/engine#53706)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 11:01:05 +00:00
engine-flutter-autoroll
aa179bdc01
Roll Flutter Engine from c5c0c54d6d1d to a02e3f673da3 (1 revision) (#151212)
c5c0c54d6d...a02e3f673d

2024-07-03 jiahaog@users.noreply.github.com Revert "Reland [DisplayList] Add support for clipOval to leverage Impeller optimization" (flutter/engine#53705)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 06:34:15 +00:00
engine-flutter-autoroll
f20962672e
Roll Flutter Engine from 44278941443e to c5c0c54d6d1d (9 revisions) (#151208)
4427894144...c5c0c54d6d

2024-07-03 jacksongardner@google.com Reland "Output .js files as ES6 modules. (#52023)" (flutter/engine#53688)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from d02998fba957 to 7c69f39fa85b (1 revision) (flutter/engine#53701)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c1f2dd0fc5f6 to d02998fba957 (2 revisions) (flutter/engine#53699)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from c0ee0e108900 to c1f2dd0fc5f6 (2 revisions) (flutter/engine#53697)
2024-07-02 flar@google.com [Impeller] fix typo in setup for fast elliptical rrect blurs (flutter/engine#53673)
2024-07-02 skia-flutter-autoroll@skia.org Roll Fuchsia GN SDK from RgErspyYHapUO2Spc... to sbh76PYVTMxav4ACT... (flutter/engine#53693)
2024-07-02 30870216+gaaclarke@users.noreply.github.com [Impeller] fixed units for memory measurement (flutter/engine#53687)
2024-07-02 jhy03261997@gmail.com [deep link][ios] Update openURL method to reflect the result from framework  (flutter/engine#52643)
2024-07-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from c23e58143793 to ffc8bb004a64 (2 revisions) (flutter/engine#53690)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-03 02:59:23 +00:00
Jonathan Lau
5698944196
Fix scheduler event loop being stuck due to task with Priority.idle (#151168)
`handleEventLoopCallback()` should return `true` rather than `false` when there are tasks in the queue but the highest priority task is not run because of the `schedulingStrategy`. If `false` is returned when the queue still has tasks, the event loop stops, causing existing and new tasks to never be scheduled.

For full context, see https://github.com/flutter/flutter/issues/73766#issuecomment-2202427256.

Fixes #73766 and #82016.
2024-07-02 23:59:20 +00:00
Matej Knopp
348fdeebb3
Fix result propagation in RenderSliverEdgeInsetsPadding.hitTestChildren (#149825)
Fixes https://github.com/flutter/flutter/issues/149824
2024-07-02 23:21:22 +00:00
Michael Goderbauer
cfa7777f7a
docImports for flutter_test (#151189)
Part of https://github.com/flutter/flutter/issues/150800

Issues encountered:
2024-07-02 23:05:52 +00:00
Igor Hnízdo
46030f1eff
Interactable ScrollView content when settling a scroll activity (#145848)
Currently when the user:
- flings a scrollable 
- overscrolls, and the scrollable is trying to settle
- applies `DrivenScrollActivity`
- swipes from one tab to the next

All inputs are discarded or forwarded directly to the Scrollable widget (scroll activity).

This leads to situations like these:

https://github.com/flutter/flutter/assets/12874766/51b7876f-5a91-4a86-aa21-c72f0b2c4263

https://github.com/flutter/flutter/assets/12874766/2f756a45-5e42-47d7-98a0-12f071d34e7c

https://github.com/flutter/flutter/assets/12874766/5eb998a1-b3b8-42a1-8b04-543f68823c2b

Which leads to poor experience on iOS. The native behavior of iOS is to allow touches while a scrollable is settling:

https://github.com/flutter/flutter/assets/12874766/e1ae61f8-d59c-40ae-a4c4-ad919f0dc6bf

This PR alters the `shouldIgnoreTouches` of `BallisticScrollAvtivity` and `DrivenScrollActivity` to not make the child of the scrollable ignore touches.

Fixes #145330

Currently tests that test tap to stop are not working as the taps now register when they should not. Because there is no distinction between flings inside and flings that go out of range.
2024-07-02 23:01:44 +00:00
Danny Tuppeny
ce0e5c4330
[flutter_tools] Update the mapping for the Dart SDK internal URI (#151170)
This changes the mapping for the Dart SDK inside Flutter from `org-dartlang-sdk:///third_party/dart/sdk` to org-dartlang-sdk:///flutter/third_party/dart/sdk`. This URI changed in https://github.com/flutter/engine/pull/51917 but was not caught by tests because they only tested a specific set of mappings and there were no integration tests checking what URIs were actually produced by a running app.

So, this change also adds an integration tests that ensures that a real running app produces URIs that are then correctly mapped.

Fixes https://github.com/Dart-Code/Dart-Code/issues/5164.
2024-07-02 22:56:17 +00:00
flutter-pub-roller-bot
d0852df663
Roll pub packages (#151129)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-07-02 22:36:13 +00:00
Qun Cheng
5d3c4568d4
Fix typo (#151192)
Trivial PR to fix typo. The code snippet uses `alignment1`.

4cb6d38492/packages/flutter/lib/src/animation/animation.dart (L208-L211)
2024-07-02 22:15:06 +00:00
Andrew Kolos
8acf86d995
[tool] Fix stdin.flush calls on processes started by FakeProcessManager (#151183)
Fixes https://github.com/flutter/flutter/issues/151151
2024-07-02 20:40:06 +00:00
engine-flutter-autoroll
4cb6d38492
Roll Flutter Engine from 433d360eee11 to 44278941443e (4 revisions) (#151186)
433d360eee...4427894144

2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 42fad315c162 to c0ee0e108900 (1 revision) (flutter/engine#53691)
2024-07-02 jiahaog@users.noreply.github.com Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus" (flutter/engine#53679)
2024-07-02 kjlubick@users.noreply.github.com [skia] Use more GNI file lists (flutter/engine#53685)
2024-07-02 skia-flutter-autoroll@skia.org Roll Skia from 7f2094d4cf43 to 42fad315c162 (1 revision) (flutter/engine#53684)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 20:13:23 +00:00
Andrew Kolos
af913a75b5
Use ErrorHandlingFileSystem.deleteIfExists when deleting .plugin_symlinks (#151073)
Fixes https://github.com/flutter/flutter/issues/137168.
2024-07-02 18:46:22 +00:00
Hans Muller
acb41f3174
ScrollEndNotification example: auto-scroll based on RenderSliver constraints and geometry (#143538)
Adds a new ScrollNotificationEnd example that demonstrates how to trigger an auto-scroll based on an individual sliver's `SliverConstraints` and `SliverGeometry`. 

Then new example auto-scrolls one special "aligned item" sliver to the top or bottom of the viewport, whenever it's partially visible (because it overlaps the top or bottom of the viewport). This example differs from the existing ScrollEndNotification example because the layout of the to-be aligned sliver is retrieved from its `RenderSliver` via a
GlobalKey.  The new example does not rely on all of the list items having the same extent.
2024-07-02 18:46:19 +00:00
engine-flutter-autoroll
9527259c70
Roll Packages from 412ec4615aa4 to d2705fb82b26 (13 revisions) (#151169)
412ec4615a...d2705fb82b

2024-07-01 engine-flutter-autoroll@skia.org Roll Flutter from 651a17db5427 to 99bb2ff6a614 (10 revisions) (flutter/packages#7038)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#7032)
2024-07-01 stuartmorgan@google.com [google_maps_flutter] Semi-convert remaining Android host API calls to Pigeon (flutter/packages#6980)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [local_auth]: Bump androidx.test.espresso:espresso-core from 3.5.1 to 3.6.1 in /packages/local_auth/local_auth_android/android (flutter/packages#7022)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [video_player]: Bump com.android.tools.build:gradle from 7.2.1 to 8.5.0 in /packages/video_player/video_player_android/android (flutter/packages#6931)
2024-07-01 49699333+dependabot[bot]@users.noreply.github.com [camera]: Bump com.android.tools.build:gradle from 7.3.0 to 8.5.0 in /packages/camera/camera_android/android (flutter/packages#6928)
2024-07-01 matanlurey@users.noreply.github.com [ci] Adds @matanlurey to some Android CODEOWNERS until Impeller is enabled. (flutter/packages#7014)
2024-06-29 ditman@gmail.com [video_player] Bumps web implementation dependency. (flutter/packages#7015)
2024-06-29 engine-flutter-autoroll@skia.org Manual roll Flutter from 15f95ce0c38e to 651a17db5427 (7 revisions) (flutter/packages#7013)
2024-06-28 36687028+phong010198@users.noreply.github.com [flutter_markdown] Add horizontal scroll for markdown table (flutter/packages#6983)
2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.1 to 2.3.3 (flutter/packages#6709)
2024-06-28 stuartmorgan@google.com [google_maps_flutter] Fix Obj-C type handling (flutter/packages#7010)
2024-06-28 engine-flutter-autoroll@skia.org Manual roll Flutter from e726eb401c2c to 15f95ce0c38e (48 revisions) (flutter/packages#7002)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-07-02 17:49:53 +00:00
Michael Goderbauer
12e3635e8e
docimports for painting (#151143)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:44:06 +00:00
Michael Goderbauer
9ff9c67272
docimports for scheduler (#151126)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:31:58 +00:00
Nate Wilson
c9ec61ee90
dismissible.dart code cleanup (#150276)
While I was working on #149966, I noticed a couple of ways that `_DismissibleState` could be tweaked to be easier to follow.

Changes are described in comments below, and we're currently [awaiting a test exemption](https://discord.com/channels/608014603317936148/608018585025118217/1251255349277626490).
2024-07-02 17:31:53 +00:00
Michael Goderbauer
12954d1a38
docimports for physics (#151125)
Part of https://github.com/flutter/flutter/issues/150800

The `physics` library is completely clean after this! 🥳
2024-07-02 17:31:51 +00:00
Michael Goderbauer
06b9f7ba0b
docimports for services (#151134)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:30:41 +00:00
Michael Goderbauer
3cf357ac7b
docimports for cupertino (#151149)
Part of https://github.com/flutter/flutter/issues/150800

Cupertino is fully clean after this!
2024-07-02 17:30:39 +00:00
Michael Goderbauer
82aaf3b44c
docimports for gestures (#151123)
Part of https://github.com/flutter/flutter/issues/150800
2024-07-02 17:29:43 +00:00
Michael Goderbauer
455be19d92
Docimports for foundation (#151119)
Part of https://github.com/flutter/flutter/issues/150800

Things I couldn't get to work:
2024-07-02 16:19:14 +00:00
Michael Goderbauer
0aedb5e688
docimports for semantics (#151132)
Part of https://github.com/flutter/flutter/issues/150800

Issues encountered:
2024-07-02 16:17:41 +00:00