1707 Commits

Author SHA1 Message Date
Ian Hickson
292519be98
Roll dart package dependencies (#42496) 2019-10-11 11:12:31 -07:00
Janice Collins
4dcf1ab828
Update dartdoc to 0.28.7 (#42136) 2019-10-11 08:47:12 -07:00
Dan Field
bb7acc1346
add WAKE_LOCK back to abstract method test (#42530) 2019-10-11 08:26:53 -07:00
Michael Klimushyn
6d18d31b5c
Fix abstract_method_smoke_test flakiness (#42454)
The flake appears to be coming from the Google Maps plugin. This test
just needs a platform view plugin without the interface method
implemented in general, not Maps specifically. Update it here to avoid
the issue in Maps until that's fixed.

Create a very simple platform view implementation that exercises this
potential bug in order to create a minimal test case with less risk of
causing second order issues like depending on any kind of full package
would cause.
2019-10-10 18:23:23 -07:00
Greg Spencer
ff2fdf4039
Fix semantics testing now that dropdown can take a11y focus again. (#42475)
Fixes the android_semantics_testing integration test to have the right criteria now that ce15097 has landed.
2019-10-10 15:19:58 -07:00
Greg Spencer
ce1509714c
Re-land keyboard traversal PRs (#42278)
This attempts to reland #40186 and #41220, that were reverted in #41945.

The main modifications from the original PRs are that I predefine the shortcuts and actions maps instead of defining them inline in the build function, and I use a new mapEquals to do a deep comparison so that we don't rebuild modified things if the contents of the map haven't changed.

I also eliminated an operator== and hashCode that were defined on the Actions widget, since widgets shouldn't have those. (it's too bad though: I get an 85% speedup if we leave this in! Too bad it prevents rebuilding of the children...)

Fixes #40101
2019-10-10 13:49:33 -07:00
Michael Klimushyn
29bfb11c04
Partial deflaking of abstract_method_smoke_test (#42379)
1. The platform code to show the keyboard wasn't working on certain
devices. From my testing it appears to be related to when the code was
firing. IMM won't show the soft input (or shows and then immediately
hides it, it's hard to tell) if it's called before the Flutter UI is
loaded. Change this to instead show the soft keyboard after a message
from Flutter that main() has been started.

2. A text field was visible in the UI, and the test was run under a
fuzzer that random tapped portions of the screen. Remove the text field
so that the fuzzer can't accidentally open the keyboard on its own at a
random time.

3. The keyboard was left open even after the app was closed. Also toggle
the input off when the app was closed, so that this test can be ran
multiple times in succession relatively hermetically.
2019-10-10 10:36:24 -07:00
Yegor
9cd9680b5e
Shard web tests; enable semantics tests on the Web (#42203)
Shard web tests; enable semantics tests on the Web
2019-10-10 07:04:38 -07:00
Emmanuel Garcia
9eaac9c414
Add smoke test for the new Android embedding (#42360)
* Add smoke test for the new Android embedding

* Update AndroidManifest.xml in app template

* Update test README.md

* Remove widget_test.dart

* Update pubspec.yaml

* Force GeneratedPluginRegistrant.java
2019-10-09 21:57:19 -07:00
Emmanuel Garcia
1d2eaaf204
Ensure that flutter assets are copied in the AAR (#42306) 2019-10-09 16:29:20 -07:00
Shi-Hao Hong
a3c750a272
Improve trailing whitespace message (#42243) 2019-10-09 16:29:07 -07:00
Greg Spencer
3ff51c74b1
Update android semantics test to match existing engine behavior. (#42368)
This updated the broken android_semantics_test to correspond to existing engine behavior.
2019-10-09 15:32:30 -07:00
Greg Spencer
89d6c8d90b
Enables setting of semantics focused and focusable attributes within Focus widgets. (#41814)
This adds a Semantics node to the Focus and FocusScope widgets, setting the focused and focusable attributes so that the accessibility subsystem can be told when a control has the input focus.

Includes an engine roll to flutter/engine@77252d2, and the following 8 engine changes:

flutter/engine@77252d2 Greg Spencer Add missing focusable testing info (flutter/engine#13013)
flutter/engine@0e42a29 skia-flutter-.. Roll src/third_party/skia 54548626a977..e27a503a0a21 (1 commits) (flutter/engine#13024)
flutter/engine@6b56ed7 gaaclarke Refactor: FlutterDartProject (flutter/engine#13006)
flutter/engine@393480c skia-flutter-.. Roll src/third_party/skia 77dde599c98a..54548626a977 (1 commits) (flutter/engine#13023)
flutter/engine@080b89d skia-flutter-.. Roll src/third_party/skia 2b1a25a4d324..77dde599c98a (1 commits) (flutter/engine#13021)
flutter/engine@90b0f30 Ben Konyi Roll src/third_party/dart f4a72bfc64..bb04f145b2 (18 commits) (flutter/engine#13020)
flutter/engine@049fb89 skia-flutter-.. Roll fuchsia/sdk/core/linux-amd64 from q_uYX... to cknsi... (flutter/engine#13019)
flutter/engine@6925b2a skia-flutter-.. Roll fuchsia/sdk/core/mac-amd64 from wuAtw... to u0JpE... (flutter/engine#13018)

Related Issues
Addresses #40101

Landing on red in order to fix the build: it's red because of the needed engine roll.
2019-10-09 14:45:42 -07:00
Emmanuel Garcia
3c521fb980
Add android.permission.WAKE_LOCK permission to abstract_method_smoke_test (#42352) 2019-10-09 13:42:25 -07:00
Yegor
ebfe6020b8
Enable more web tests; use blacklist to filter them out (#41922)
Add more web tests;use blacklist instead of whitelist
2019-10-07 15:05:24 -07:00
Emmanuel Garcia
fa4d31b311
Fix smoke test (#42022) 2019-10-07 10:05:40 -07:00
Zachary Anderson
3b66db6bf7
Updates packages (#41936) 2019-10-07 09:46:57 -07:00
Jonah Williams
f25812bae5
Revert "replace package:vm_service_client with package:vm_service in the devicelab project (#41646)" (#41960) 2019-10-03 21:30:37 -07:00
Devon Carew
4de496a4e5 replace package:vm_service_client with package:vm_service in the devicelab project (#41646) 2019-10-03 20:43:34 -07:00
Greg Spencer
3e2dc8ca7b Revert ActivateAction PR (#41945) 2019-10-03 20:27:37 -07:00
Jenn Magder
4331c172d7
Set DEFINES_MODULE=YES in plugin templates (#41828) 2019-10-03 18:35:20 -07:00
Greg Spencer
bedf46d06e
Add shortcuts and actions for default focus traversal (#40186)
This adds the default shortcuts and actions for keyboard-based focus traversal of apps.

This list of shortcuts includes shortcuts for TAB, SHIFT TAB, RIGHT_ARROW, LEFT_ARROW, UP_ARROW, DOWN_ARROW, and the four DPAD keys for game controllers (because the DPAD produces arrow key events).

It doesn't yet include functionality for triggering a control (e.g. SPACE, ENTER, or controller buttons), because that involves restructuring some of the Flutter controls to trigger animations differently, and so will be done in another PR (#41220)
2019-10-02 15:21:45 -07:00
Yegor
33f4f8e6df
run services tests on the Web (#41806) 2019-10-02 15:11:22 -07:00
Ian Hickson
8c6d60bcfd
Move commands into their own shard (#39140) 2019-10-02 12:46:51 -07:00
liyuqian
cdb94cd675
Revert "Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)" (#41780)" (#41795)
This reverts commit 19c08e891d2c862b685c6803b6cce73d1e386b54.

The attempted revert doesn't fix the problem, so we'll reland.
2019-10-02 12:35:42 -07:00
Christopher Fujino
e70236e36c
Fix tools test verifyVersion() regex (#41744) 2019-10-02 09:32:30 -07:00
Greg Spencer
19c08e891d
Revert "Dsiable CPU/GPU measurement on BackdropFilter test (#41736)" (#41780)
This reverts c9d920f so that we can attempt to fix the build. The build dashboard clearly shows that things started failing at this change, although it's not totally clear that it is the cause: tests succeed locally.

If it doesn't fix things we can re-land this.
2019-10-02 07:22:25 -07:00
Mouad Debbar
e045ef2969
Keymap for Web (#41397) 2019-10-01 14:10:53 -07:00
Jonah Williams
b2f38396f4
Reland: Switch to assemble API for dart2js (#41659)
* Stop using build_runner for dart2js

* fixes to yield when computing hashes and to imports

* add missing await

* Update filecache_test.dart

* Fix paths in filecache test

* use file uri for import

* add test cases and configurable override

* remove test dep

* fix filepaths for windows

* test no longer failing

* fix paths for test cases

* fix typo

* address comments

* make a constant

* make filehash async and use constant

* fix silly logic error
2019-10-01 14:03:42 -07:00
Yegor
8246785f3f
Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests. (#40630)
Spawn no more than 1 iframe in web tests. Using multiple iframes in DDK mode times out tests. Also set concurrency to 1 to guarantee that the test runner does not even attempt to parallelize tests.
2019-10-01 13:58:05 -07:00
liyuqian
c9d920f301
Dsiable CPU/GPU measurement on BackdropFilter test (#41736)
This test is flaky if CPU/GPU measurement is enabled due to
https://github.com/flutter/flutter/issues/41577
2019-10-01 13:07:27 -07:00
Jonah Williams
06a6fdbf23
Revert "Switch to assemble API for dart2js (#41447)" (#41658) 2019-09-30 18:35:01 -07:00
Jonah Williams
ccc3dd968c
Switch to assemble API for dart2js (#41447) 2019-09-30 18:26:28 -07:00
Jenn Magder
1eb1e2226b
Skip pod initialization if version >= 1.8.0. (#41491) 2019-09-30 13:14:42 -07:00
Jonah Williams
69af9adeac
Update minimum build_runner version and enable incremental builder (#41499) 2019-09-29 13:01:33 -07:00
liyuqian
3606300bf5
Rename the file to fix the device lab (#41579)
TBR: @goderbauer
2019-09-29 11:51:04 -07:00
liyuqian
9cc29c61df
Reland "Measure iOS CPU/GPU percentage #41426" (#41578)
This reverts commit baea9bf7cc7447b5ec6e6d377a68b17e79cb9ccf.

Additionally,   we let the test run on mac8 with iphonexs because the test won't run on Xcode 10.1 (mac3-7). Hence we force it to run on mac8 which currently has Xcode 10.2.
2019-09-29 11:33:43 -07:00
liyuqian
baea9bf7cc
Revert "Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)" (#41575)
This reverts commit 67b5bdf99b19e5f04bae5fb82af91aa695fbfbb9.

Reason: it broke device lab.

TBR: @goderbauer
2019-09-29 10:58:13 -07:00
liyuqian
67b5bdf99b
Reland "Measure iOS CPU/GPU percentage (#41234)" (#41426)
This reverts commit f1e7fe8142a0b75da74617bec617589882a730a7.

This fix is in https://github.com/flutter/packages/pull/39
2019-09-28 14:24:46 -07:00
Greg Spencer
0223565fd5
Reland changes to Intent.doNothing to avoid analyzer issue (#41477)
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
2019-09-28 08:55:47 -07:00
Greg Spencer
25f2399ba3
Add flutter drive to readme. (#41509)
This adds a description of the command needed to run the driver test
2019-09-28 00:22:37 -07:00
Emmanuel Garcia
2466ca5bb0
Copy Flutter assets before merging the rest of resources (#41333) 2019-09-27 10:53:37 -07:00
Greg Spencer
957d839775
Revert "Address previous comments, fix Intent.doNothing. (#41417)" (#41449)
This reverts commit eb3e2f559f2563a0878d19bd997629ce07becd3c because of a suspected analyzer bug.  Reverting to investigate.
2019-09-26 22:45:21 -07:00
Greg Spencer
eb3e2f559f
Address previous comments, fix Intent.doNothing. (#41417)
This addresses comments in the original PR (#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
2019-09-26 19:54:28 -07:00
gaaclarke
a66ea4f21b
Devicelab run.dart: Fixed check for path equality (#41403)
Fixed check for path equality.  It was too strict, disallowing leading "./".
2019-09-26 17:09:05 -07:00
Jonah Williams
f1e7fe8142
Revert "Reland "Measure iOS CPU/GPU percentage (#39439)" (#41234)" (#41400) 2019-09-26 12:27:01 -07:00
liyuqian
406b44983a
Reland "Measure iOS CPU/GPU percentage (#39439)" (#41234)
This reverts commit 652be88ecd259407b47d0dbeb243f5fbbef81638.

This fix is in https://github.com/flutter/packages/pull/37
2019-09-26 10:39:24 -07:00
Tong Wu
17e4ae135d
Enable FTL reporting on an integration test (#40285) 2019-09-25 22:45:30 -07:00
Emmanuel Garcia
975e770e13
Add embedding as API dependency instead of compile only dependency (#41142) 2019-09-25 17:59:17 -07:00
Greg Spencer
9749f59cf5
Desktop manual tests (#41247)
This enables the manual tests to be built on a macOS desktop machine in desktop mode.

I created the macos directory by using flutter create --macos
2019-09-25 14:49:22 -07:00