firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
83,653 Commits 1 Branch 0 Tags
Commit Graph

30234 Commits

Author SHA1 Message Date
Camille Simon
38e19d01dc
Update Dart revision to 3.8.0-278.4.beta (#168391) 
* Updated Dart revision to [`e7f2f0556e3e57acb60749467e54f9a44b2bfc76`](http://goto.google.com/dart-hash/e7f2f0556e3e57acb60749467e54f9a44b2bfc76) (`3.8.0-278.4.beta`).
* ~Ran `gclient sync -D` and `tools/dart/create_updated_flutter_deps.py` (nothing was updated)~ ran wrong command
* Ran `gclient sync -D` and `tools/dart/create_updated_flutter_deps.py -f <flutter_DEPS_file_path>` (Dart style revision was updated)
 2025-05-09 16:48:01 +00:00
Matan Lurey
b7e009ca24
Exclude a specific auto-generated Dart file from engine license checks (#168544) 
Manual cherrypick of https://github.com/flutter/flutter/pull/168508.

Closes https://github.com/flutter/flutter/issues/168493.
 2025-05-08 19:54:26 +00:00
flutteractionsbot
87cd28951e
[CP-beta]Only build and download Fuchsia artifacts on master (#168169) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/168088

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

N/A: Infrastructure only change.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

N/A
 2025-05-01 22:33:15 +00:00
flutteractionsbot
5f0ca4df71
[CP-beta]Remove release_build: "false" which is interpreted as true due to a recipes bug. (#168147) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/pull/168098

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Works around infrastructure bug that would cause the release build process for release candidates to take longer than expected.

### Workaround:
Is there a workaround for this issue?

Yes, wait longer.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Already validated on master.
 2025-05-01 15:53:23 +00:00
Jonah Williams
a5ca02f31c
[CP][Impeller] report application version info as 2.0 (#168086) 
Cherry pick of https://github.com/flutter/flutter/pull/167961
 2025-04-30 21:11:35 +00:00
flutteractionsbot
3d03881a90
[CP-beta]Move backfill: "false" out of properties, make it a boolean. (#167831) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

https://github.com/flutter/flutter/issues/167755

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

N/A (CI Infrastructure Only)

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Allows removing technical debt from Cocoon.

### Workaround:
Is there a workaround for this issue?

N/A

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

It is already live on the master channel.
 2025-04-25 19:42:07 +00:00
flutteractionsbot
80230cc7c4
[CP-beta]Refine developer message for announcement use (#167505) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.

### Issue Link:
What is the link to the issue this cherry-pick is addressing?

This was a follow-up to https://github.com/flutter/flutter/pull/165195 and part of issue https://github.com/flutter/flutter/issues/165510

### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples

Developer warning message in `SemanticService.announce` is not clear when using internal flutter widgets.

### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)

Developers see non-actionable warning messages when Accessibility Services are on and developers are using widgets like TimePicker, DatePicker, ExpansionTile, and Form.

### Workaround:
Is there a workaround for this issue?

No workaround.

### Risk:
What is the risk level of this cherry-pick?

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

### Validation Steps:
What are the steps to validate that this fix works?

Run the example below: 5491c8c146/examples/api/lib/material/time_picker/show_time_picker.0.dart (L10)

When opening the time picker, the corrected warning message should show.
 2025-04-21 23:32:08 +00:00
flutteractionsbot
2cf78c5583
[CP-beta][skwasm] Use queueMicrotask instead of postMessage when single-threaded (#167154) 
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)

### Issue Link:
https://github.com/flutter/flutter/issues/166905

### Changelog Description:
* [flutter/166905](https://github.com/flutter/flutter/issues/166905) Fixes a performance regression in skwasm when running in single-threaded mode.

### Impact Description:
This fixes a significant regression in the skwasm renderer when running single-thraaded (i.e. in a non-`crossOriginIsolated` browsing context)

### Workaround:
Is there a workaround for this issue?

The only workaround is to run skwasm in a multi-threaded context or to disable skwasm.

### Risk:
What is the risk level of this cherry-pick?

  - [ x ] Low

This essentially returns the single-threaded renderer to the previous message passing strategy.

### Test Coverage:
Are you confident that your fix is well-tested by automated tests?

  - [ x ] Yes

### Validation Steps:
What are the steps to validate that this fix works?

Built the Wonderous app and take a Chrome profile.
 2025-04-16 01:09:26 +00:00
Matan Lurey
72ee26e314
Initialize Flutter Beta (flutter-3.32-candidate.0) (#166783) 
Closes https://github.com/flutter/flutter/issues/166811.

```sh
$ dev/conductor/bin/conductor start \
  --candidate-branch=flutter-3.32-candidate.0 \
  --release-channel=beta \
  --github-username=matanlurey \
  --dart-revision=0d6811928830b87e36a0f49eb7fe554c308d3699 
```
 2025-04-09 22:57:49 +00:00
engine-flutter-autoroll
c827c535bb
Roll Skia from 57a1644f0f8f to 7b929584566c (1 revision) (#166760) 
https://skia.googlesource.com/skia.git/+log/57a1644f0f8f..7b929584566c

2025-04-08 bungeman@google.com [fontations] Flat pixel geometry only
when requested

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jlavrova@google.com,jonahwilliams@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-08 17:20:08 +00:00
engine-flutter-autoroll
ca37883165
Roll Skia from 515eb6238867 to 57a1644f0f8f (1 revision) (#166748) 
https://skia.googlesource.com/skia.git/+log/515eb6238867..57a1644f0f8f

2025-04-08 danieldilan@google.com Define flag again for PNG encoding

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC
jlavrova@google.com,jonahwilliams@google.com,kjlubick@google.com on the
revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-08 14:58:32 +00:00
engine-flutter-autoroll
242f413f6e
Roll Skia from f493d403c01b to 245d2b8fb042 (3 revisions) (#166720) 
https://skia.googlesource.com/skia.git/+log/f493d403c01b..245d2b8fb042

2025-04-07 robertphillips@google.com Add debugging info for Assert
firing in Chrome
2025-04-07 jvanverth@google.com [graphite] Store ref to textureProxy in
CoverageMaskShape.
2025-04-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from fb4fe29989cb to 6a9ff527eade (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-07 23:22:20 +00:00
Yegor
0a29c6d444
[web] reland fix text selection offset in multi-line fields (#166714) 
Fixes https://github.com/flutter/flutter/issues/162698

This reland contains the original changes from
https://github.com/flutter/flutter/pull/166565, plus Safari-specific
test fixes.
 2025-04-07 22:37:08 +00:00
engine-flutter-autoroll
110b07835a
Roll Skia from 5f0f9b76b975 to f493d403c01b (3 revisions) (#166710) 
https://skia.googlesource.com/skia.git/+log/5f0f9b76b975..f493d403c01b

2025-04-07 jvanverth@google.com De-virtualize some of AtlasSubRun.
2025-04-07 bungeman@google.com Do not add nullptr typeface to cache
2025-04-07 bungeman@google.com [fci] Do not add nullptr typeface to
cache

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,jlavrova@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-07 20:27:13 +00:00
Jason Simmons
920865d4a2
Roll HarfBuzz to 11.0.0 (#166596) 
Fixes https://github.com/flutter/flutter/issues/162819
 2025-04-07 20:25:34 +00:00
auto-submit[bot]
778ed9e8b6
Reverts "[web] fix text selection offset in multi-line fields (#166565)" (#166644) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166565
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jtmcdole
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Tree is broken
https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20linux_web_engine_tests/1240/overview
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: yjbanov
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {justinmc}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/162698
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-05 17:14:19 +00:00
engine-flutter-autoroll
31dfefc79e
Roll Skia from a7da13848085 to 943df306bc3a (8 revisions) (#166609) 
https://skia.googlesource.com/skia.git/+log/a7da13848085..943df306bc3a

2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 374c10637d4a to 8faeb7707de8 (1 revision)
2025-04-04 kjlubick@google.com Minor cleanups
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from e615014fb3e1 to 5d081c7499b4 (2 revisions)
2025-04-04 kjlubick@google.com Remove unused function in SkScan.h
2025-04-04 bungeman@google.com Simplify "font with random glyph mask
formats" gm.
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from 0f9feb495ff9 to 127aec7e6c2c (13 revisions)
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 22e0e37fcf6e to db66eb3d2ec7 (22 revisions)
2025-04-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 897477bba573 to e615014fb3e1 (7 revisions)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-04 22:00:41 +00:00
chunhtai
7afe7a5f8b
Adds semantics input type (#165925) 
<!--
Thanks for filing a pull request!
Reviewers are typically assigned within a week of filing a request.
To learn more about code review, see our documentation on Tree Hygiene:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
-->

fixes https://github.com/flutter/flutter/issues/162130

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-04 21:15:12 +00:00
Jim Graham
790d1b1d9a
Relands "[Impeller] Render conics without conversion from Flutter apps (#166305)" (#166598) 
Reverts flutter/flutter#166591

Golden diffs were not discovered the first time this was submitted.
Re-submitting to double check the goldens.
 2025-04-04 20:47:09 +00:00
Yegor
a56ff4890d
[web] fix text selection offset in multi-line fields (#166565) 
Fixes https://github.com/flutter/flutter/issues/162698
 2025-04-04 20:30:18 +00:00
Jonah Williams
f00d387cb8
[Impeller] if drawTextFrame scale is massive, convert to Path. (#166234) 
Fixes https://github.com/flutter/flutter/issues/165583
Fixes https://github.com/flutter/flutter/issues/136112

If the text scale gets too big, its faster (and higher res) to switch to
path rendering than to keep using the glyph atlas cache.
 2025-04-04 20:28:25 +00:00
Matej Knopp
a400e79ce6
[Embedder] Only call removeview callback when raster thread is done with the view (#164571) 
Fixes
https://github.com/flutter/flutter/issues/164564#issuecomment-2698714466

This would ensure that raster thread is completely done with the view,
i.e. it won't try to use the opengl context, which might be associated
with view window. So the client can know for sure, that when the
callback returns, it is safe to destroy the view and container window.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

---------

Co-authored-by: Loïc Sharma <737941+loic-sharma@users.noreply.github.com>
 2025-04-04 18:38:19 +00:00
engine-flutter-autoroll
c45cead566
Roll Dart SDK from 4293d50dd30d to 87965ab4864e (3 revisions) (#166571) 
https://dart.googlesource.com/sdk.git/+log/4293d50dd30d..87965ab4864e

2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-265.0.dev
2025-04-04 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-264.0.dev
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-263.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-04 18:12:55 +00:00
Jackson Gardner
4a8d42a9b1
Disable firefox image_to_byte_data_test as a group. (#166559) 
Grouping allows us to avoid running the setup function when the tests
are skipped, and the setup function is where it was actually stalling.
Skipping as a group seems to avoid this problem.

We can turn `bringup: true` off of the web unit tests now.
 2025-04-04 18:12:55 +00:00
Jia Hao
97f53167b3
Add x64 ddm variants (#166511) 
As a follow up to https://github.com/flutter/flutter/pull/162855. Adding
x64 allows us to add tests internally.

Towards b/393719931

Tested:

```
$ bin/et build --config ci/android_release_arm64_ddm
$ bin/et build --config ci/android_release_x64_ddm
```

cc @sigmundch 

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-04 18:11:21 +00:00
engine-flutter-autoroll
485d6b8ae3
Roll Skia from af7ff0e98c4e to a7da13848085 (3 revisions) (#166560) 
https://skia.googlesource.com/skia.git/+log/af7ff0e98c4e..a7da13848085

2025-04-03 danieldilan@google.com Add correct type to SkStringPrintf in
EncodeTest
2025-04-03 nicolettep@google.com [graphite] Formatting fixes
2025-04-03 bungeman@google.com Mark SkScalerContext::fRec const

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-04 18:11:21 +00:00
auto-submit[bot]
b1c08092d0
Reverts "[Impeller] Render conics without conversion from Flutter apps (#166305)" (#166591) 
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166305
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: gaaclarke
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Integration golden test failures. Please reland it
this and address golden diffs.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: flar
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jonahwilliams}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
 2025-04-04 17:10:47 +00:00
engine-flutter-autoroll
2615ab6c19
Roll Dart SDK from d174ec16c3ea to 4293d50dd30d (1 revision) (#166557) 
https://dart.googlesource.com/sdk.git/+log/d174ec16c3ea..4293d50dd30d

2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-262.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 21:25:07 +00:00
engine-flutter-autoroll
dafbc0e1c0
Roll Skia from 5f65df75febd to af7ff0e98c4e (7 revisions) (#166551) 
https://skia.googlesource.com/skia.git/+log/5f65df75febd..af7ff0e98c4e

2025-04-03 danieldilan@google.com Implement ConvertPixels in
SkPngEncoder with guard for Chrome
2025-04-03 kjlubick@google.com Decouple SkEdge and SkAnalyticEdge
2025-04-03 kjlubick@google.com Clean up SkPathEdgeIter::Edge enum
2025-04-03 borenet@google.com [infra] Fix OS dimension for migrated
GalaxyS7_G930FD, Mokey, and Nexus7
2025-04-03 egdaniel@google.com Check angle driverVersion for Ganesh
powerVR workaround.
2025-04-03 michaelludwig@google.com [graphite] Add
RecorderOptions.fRequireOrderedRecordings
2025-04-03 bungeman@google.com Remove forceOffGenerateImageFromPath

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 20:12:37 +00:00
Jim Graham
cb0e649e78
[Impeller] Render conics without conversion from Flutter apps (#166305) 
Now that Impeller performs high fidelity tessellation of Conic curves we
will no longer convert Flutter app's conic curves into approximated
quadratic curves.
 2025-04-03 20:06:23 +00:00
engine-flutter-autoroll
ceec33f16b
Roll Skia from b67e53719e78 to 5f65df75febd (2 revisions) (#166538) 
https://skia.googlesource.com/skia.git/+log/b67e53719e78..5f65df75febd

2025-04-03 robertphillips@google.com [graphite] Fix PipelineUsesInEpoch
UMA stat
2025-04-03 nicolettep@google.com [graphite] Fix ordering of image layout
transition call

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 17:28:13 +00:00
Jenn Magder
73590fb0d2
Update docs to debug the Android embedder (#166170) 
Update Android embedder debugging instructions.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-03 17:23:05 +00:00
engine-flutter-autoroll
269d544a9b
Roll Dart SDK from 72562ca93bb5 to d174ec16c3ea (1 revision) (#166525) 
https://dart.googlesource.com/sdk.git/+log/72562ca93bb5..d174ec16c3ea

2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-261.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 15:47:27 +00:00
Matej Knopp
3237222b62
[macOS] Implement merged UI and platform thread (#162883) 
Original issue: https://github.com/flutter/flutter/issues/150525

This PR lets the macOS embedder run both with and without UI and
platform thread merged.

Thread merging is controlled through `FLTEnableMergedPlatformUIThread`
`info.plist` option similar to iOS embedder, though the default value is
currently `false`.

Changes in the resize / vsync synchronization:

- Added `FlutterRunLoop` class to schedule Flutter tasks on main thread
in a way where it is possible to only process these (Flutter posted)
tasks while waiting for correct frame size during resizing. This
significantly simplifies the resize synchronization and makes the same
code work both with separate UI thread and with UI and platform thread
merged.
- `FlutterThreadSynchronizer` has been renamed to
`FlutterResizeSynchronizer` vastly simplified, mutex and conditions are
removed and the blocking is now done by only processing Flutter messages
while waiting for resizing. It is now per view (instead of storing a
viewId->Size map internally) and owned by the view itself, instead of
engine.
- This approach to resize synchronization will work for Windows and
Linux as well. This will allow us to conceptually consolidate the way we
do threading and resize synchronization on all three desktop embedders.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-03 15:25:17 +00:00
engine-flutter-autoroll
9a363420db
Roll Dart SDK from 2a1a13cc3a91 to 72562ca93bb5 (2 revisions) (#166514) 
https://dart.googlesource.com/sdk.git/+log/2a1a13cc3a91..72562ca93bb5

2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-260.0.dev
2025-04-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-259.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 07:44:26 +00:00
engine-flutter-autoroll
5f33d1800b
Roll Fuchsia Linux SDK from v7PGvypiiWLO8PbsZ... to vYisSsIgqw0mqFRVJ... (#166508) 
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter
Please CC aaclarke@google.com,zra@google.com on the revert to ensure
that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 03:22:28 +00:00
engine-flutter-autoroll
ef084c83ee
Roll Dart SDK from b8b4076b1237 to 2a1a13cc3a91 (1 revision) (#166504) 
https://dart.googlesource.com/sdk.git/+log/b8b4076b1237..2a1a13cc3a91

2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-258.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 02:08:07 +00:00
engine-flutter-autoroll
51aabac708
Roll Skia from 75a0ec473181 to c106d7831592 (1 revision) (#166499) 
https://skia.googlesource.com/skia.git/+log/75a0ec473181..c106d7831592

2025-04-02 jvanverth@google.com [graphite] Limit plot invalidation in
DrawAtlas::compact().

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-03 01:04:26 +00:00
Matan Lurey
997f742ac5
Fix ISSUE_TEMPLATE Ordering: 10 < 9, but 10 > 09 (#166455) 
Unfortunately `10_google3_bug.yml` comes before `2_bug.yml`.

This changes the name (slightly) of the issue templates based on the
instructions from GitHub on what to do when you have 10+ issue templates
(as a side-note: I wonder if we need/still use umbrella bugs for the
feature tracker, or two types of performance bugs)
 2025-04-03 00:24:34 +00:00
Yegor
fbbe0f9e7a
[a11y] add SemanticsValidationResult (#165935) 
Add `SemanticsValidationResult` to semantics that maps onto
`aria-invalid`.

Fixes https://github.com/flutter/flutter/issues/162142
 2025-04-02 22:00:19 +00:00
engine-flutter-autoroll
a22e3fec6e
Roll Skia from 52cbb917fffd to 75a0ec473181 (21 revisions) (#166484) 
https://skia.googlesource.com/skia.git/+log/52cbb917fffd..75a0ec473181

2025-04-02 thomsmit@google.com [graphite] Align the new pendingBase to
the stride of incoming elements.
2025-04-02 nicolettep@google.com [graphite] Add Vulkan render pass and
texture changes to support reading from the dst texture
2025-04-02 nicolettep@google.com [graphite] Align DrawPass and
RenderPassDesc dst read strategy
2025-04-02 drott@chromium.org [Fontations] Path not modified for
advanced metrics, PostScript name
2025-04-02 bungeman@google.com [fontations] Set font format in
onGetAdvancedMetrics
2025-04-02 jvanverth@google.com Make VertexFiller backend independent.
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 5b6a0bdc7c48 to b0afd1a16c52 (2 revisions)
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE
from bbf92d12266d to c9956ce0c4be (9 revisions)
2025-04-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn
from 1411699ba4cd to bd7a6d4fe2b1 (27 revisions)
2025-04-01 danieldilan@google.com Implement asImageFilter for
SkShaderMaskFilter
2025-04-01 robertphillips@google.com [graphite] Expand
PrecompileContext::reportPipelineStats
2025-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll
vulkan-deps from 12ef946decd5 to 5b6a0bdc7c48 (3 revisions)
2025-04-01 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms
from 1e365691d01a to 374c10637d4a (1 revision)
2025-04-01 bungeman@google.com Fix gn side fontations sources
2025-04-01 robertphillips@google.com Add
SK_HISTOGRAM_CUSTOM_EXACT_LINEAR
2025-04-01 sharaks@google.com Merge 2 release notes into
RELEASE_NOTES.md
2025-04-01 sharaks@google.com Update Skia milestone to 137
2025-04-01 egdaniel@google.com Plumb SurfaceDrawContext through
asFragmentProcessor calls.
2025-04-01 borenet@google.com [infra] Older versions of setarch require
a parameter
2025-04-01 robertphillips@google.com Address TSAN issue in
GrSurfaceProxy::backingStoreDimensions
2025-04-01 jamesgk@google.com [ganesh] Fix blank screen when creating
offscreen surface

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,egdaniel@google.com,kjlubick@google.com on
the revert to ensure that a human
is aware of the problem.

To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-02 21:29:46 +00:00
gaaclarke
25f7c15dd7
Started pixel aligning hairlines (#166351) 
fixes https://github.com/flutter/flutter/issues/162378
builds from: https://github.com/flutter/flutter/pull/165079
gets rid of the line artifacts in
https://github.com/flutter/flutter/issues/165689

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-02 21:28:58 +00:00
Jackson Gardner
34ea67bdbf
Reland "[skwasm] Dynamic Threading" (#166454) 
This is a reland of https://github.com/flutter/flutter/pull/164748,
which was reverted here: https://github.com/flutter/flutter/pull/165350

It was reverted due to some issues in the flutter packages roller:
https://github.com/flutter/flutter/issues/165347

The unit test in flutter/packages was modified to be more deterministic
and less affected by minor timing differences:
https://github.com/flutter/packages/pull/8920

So this is basically being relanded without any significant changes,
since the downstream tests have been fixed.
 2025-04-02 21:27:09 +00:00
Tong Mu
f2e0a2afb3
[dart:ui] Add Path.addRSuperellipse (#166045) 
This PR adds `Path.addRSuperellipse` to `dart:ui`. This is needed to
implement a parity class to `RoundedRectangleBorder` as discussed
[here](https://github.com/flutter/flutter/pull/164857#issuecomment-2715637356).

<details>
<summary>
Obsolete description, no longer applicable
</summary>
I want to reuse the existing algorithm created for impeller stroking.
The existing algorithm is moved from `path_builder.cc` to
`round_superellipse_param.cc`, and a delegated is added so that the same
algorithm can output for different path classes.

I'm not 100% sure this is _the_ best way to implement this, but I've
tried some methods in vain.
* `DlPathReceiver` added in
https://github.com/flutter/flutter/pull/164753 sounds like a similar
concept as the delegate created in this PR. I tried to use that but not
only are the methods private, they're neither in an accessible
directory.
* I also thought of converting an impeller `Path` to a skia path, but it
seems that the impeller path isn't designed to be traversed.
* Another possibility is that we refactor impeller stroking to be based
on the triangles instead of path, a direction we agreed to eventually
move toward, which allows avoiding code share at all. I've briefly read
the code in `StrokePathGeometry` and have some ideas but also something
uncertain, so I didn't choose this path for now.
</details>

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2025-04-02 21:27:08 +00:00
Jonah Williams
901b0f1afe
[Impeller] cache for text shadows. (#166228) 
Fixes https://github.com/flutter/flutter/issues/164303
Fixes https://github.com/flutter/flutter/issues/165116

When rendering a text shadow, cache the resulting snapshot for at least
one frame. Only attempts to content-aware hash for single glyphs
(Icons). in other cases the exact layout may be different enough that
its not worth trying to cache.
 2025-04-02 20:29:14 +00:00
engine-flutter-autoroll
d90c9611b3
Roll Dart SDK from 4e1f02bc704f to b8b4076b1237 (7 revisions) (#166474) 
https://dart.googlesource.com/sdk.git/+log/4e1f02bc704f..b8b4076b1237

2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-257.0.dev
2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-256.0.dev
2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-255.0.dev
2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-254.0.dev
2025-04-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-253.0.dev
2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-252.0.dev
2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-251.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-02 20:08:19 +00:00
engine-flutter-autoroll
a0b1b32534
Roll Dart SDK from b4d374ec59ec to 4e1f02bc704f (2 revisions) (#166342) 
https://dart.googlesource.com/sdk.git/+log/b4d374ec59ec..4e1f02bc704f

2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-250.0.dev
2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-249.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-01 16:33:23 +00:00
engine-flutter-autoroll
fbe64c68d8
Roll Dart SDK from 6b07a09cbd2d to b4d374ec59ec (2 revisions) (#166321) 
https://dart.googlesource.com/sdk.git/+log/6b07a09cbd2d..b4d374ec59ec

2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-248.0.dev
2025-04-01 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com
Version 3.8.0-247.0.dev

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter
Please CC aaclarke@google.com,dart-vm-team@google.com on the revert to
ensure that a human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2025-04-01 11:15:09 +00:00
Robert Ancell
be79e0a0a6
Rename FlRenderer to FlCompositorOpenGL (#166037) 
Matches the Flutter engine compositor and is similar to the Windows
embedder classes.
 2025-04-01 04:04:08 +00:00
Kevin Moore
8b0cf61ebd
[engine, web_ui] Fix instances of library_private_types_in_public_api (#166156) 
Not all of them, but many. Make a lot of functions private
 2025-04-01 02:36:52 +00:00