17486 Commits

Author SHA1 Message Date
Bonsai11
6d2d9b2f3c
Adding onLongPress for DataRow (#87172)
* Adding onLongPress for DataRow

Useful to be able to e.g. start a selection mode of rows or show a drop down menu.

* Test for onLongPress

* Changed parameter
2021-09-21 11:17:08 -07:00
Jason Simmons
c761c6c2d4
Fix an unnecessary_import analyzer error in the skeleton app template (#90417) 2021-09-20 15:18:37 -07:00
nt4f04uNd
49332da76a
Fix Dismissible confirmDismiss errors (#88672)
* Fix Dismissible confirmDismiss errors

* +

* refactor test

* fix rebase

* remove new line
2021-09-20 13:50:32 -07:00
Casey Rogers
76b3c6758c
Allow Developers to Stop Navigator From Requesting Focus (#90097) 2021-09-20 13:13:03 -07:00
chunhtai
c9751c9292
Fixes dialog title announce twice (#90075) 2021-09-20 12:48:05 -07:00
Kate Lovett
d50ec2469f
Fix overflow in stretching overscroll (#90215) 2021-09-20 12:23:05 -07:00
Pierre-Louis
8d5d37d6df
Exclude semantics is semanticslabel is present (#90136) 2021-09-20 12:18:05 -07:00
Greg Spencer
19722fb96c
Clean up dismissable_test to be less fragile (#89870)
This cleans up the dismissable_test to be less fragile, and make it harder to forget to reset things between runs.

I eliminated a bunch of globals that were susceptible to being missed and passed them in to buildTest instead, and removed some values that were always the same (itemExtent).
2021-09-20 09:07:28 -07:00
Jason Simmons
58056bbe74
Close the IntegrationTestTestDevice stream when the VM service shuts down (#90022) 2021-09-17 19:18:03 -07:00
Varun Kamani
de0aab1751
Issue 88543: TextField labelText doesn't get hintTextStyle when labelTextStyle is non-null Fixed (#89386)
labelText now gets hintTextStyle when no labelStyle, per the docs
2021-09-17 16:19:55 -07:00
Kate Lovett
f9ff83432c
Add more tests for dart fixes (#90291) 2021-09-17 16:08:05 -07:00
Jason Simmons
c2f452c0a8
Reuse a TimelineTask for the scheduler frame and animate events (#90168) 2021-09-17 10:07:06 -07:00
Kate Lovett
4889064ff5
Fix the fix (#90217) 2021-09-17 09:07:03 -07:00
Renzo Olivares
4b330ddbed
Create DeltaTextInputClient (#90205)
* Create DeltaTextInputClient

* Remove old tests as updateEditingValueWithDeltas is no longer implemented

* fix analyzer

* Update docs

* Make example more general

* Update docs

* Add assert to check that TextInputClient is a DeltaTextInputClient

* Update assert

* More docs

* update

* Clean up docs

* updates

* Update docs

* updates

* Fix test

* add test

* updates

* remove logs

* fix tests

* Address reviewer comments

* Add text_input_utils.dart

* Address reviewer comments
2021-09-16 17:29:58 -07:00
smitsk
93de90bc26
Revert "Revert "Fix computeMinIntrinsicHeight in _RenderDecoration (#87404)" (#89667)" (#89822)
Improve the layout/sizing of InputDecorator
2021-09-16 15:37:11 -07:00
Yegor
d672d20f69
fix draggable_scrollable_sheet_test.dart (#90204) 2021-09-16 13:51:33 -07:00
Liam Appelbe
9afbab8477
Use report_lines flag in flutter coverage (#90142)
* Use the report lines flag

* Handle major version bumps in the version check

* Fix existing tests and add a new test
2021-09-16 11:33:32 -07:00
Ahmed Ashour
eb185d73ce
internationalization: fix select with incorrect message (#90096) 2021-09-16 09:23:22 -07:00
Kate Lovett
5ab7e6e13b
Update docs for https://github.com/flutter/engine/pull/28616 (#90081) 2021-09-15 18:42:02 -07:00
Jenn Magder
ab6f2fc8ce
Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) 2021-09-15 18:37:04 -07:00
Renzo Olivares
bf66cc2e08
Framework can receive TextEditingDeltas from engine (#88477) 2021-09-15 18:27:04 -07:00
Kate Lovett
65d8dd988d
Update md5 method in flutter_goldens_client (#90154) 2021-09-15 17:42:05 -07:00
nt4f04uNd
d3f1a3ceda
RefreshProgressIndicator to look native (#88301) 2021-09-15 16:23:02 -05:00
Parker Stromberg
a31e0a4336
Added time picker entry mode callback and tests (#87595) 2021-09-15 16:05:56 -05:00
Casey Rogers
e7df5ec5d0
Add Snapping Behavior to DraggableScrollableSheet (#84394) 2021-09-15 15:30:35 -05:00
Ian Hickson
2420718389
Remove our extra timeout logic. (#89952) 2021-09-15 09:42:05 -07:00
LongCatIsLooong
5d9afaa0f7
Revert "Make FilteringTextInputFormatter's filtering Selection/Composing Region agnostic (#89327)" (#90089) 2021-09-15 04:27:04 -07:00
Pierre-Louis
b129fffa23
Add semanticsLabel to SelectableText (#89369)
* add `semanticsLabel` to `SelectableText`

* remove unused vars

* Squashed commit of the following:

commit 3e687a9facfba751667529dd10194403c85e3d2f
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Tue Sep 14 17:42:05 2021 -0400

    Roll Plugins from 4a98e239b131 to b85edebe7134 (2 revisions) (#90083)

commit ad936b4e4b778dde40b6adfea265b5f97f76f62d
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Sep 14 14:39:17 2021 -0700

    [flutter_conductor] Support initial stable release version (#89775)

commit ff5dd54c6e2314e358d2e75d9c2c4fe24ed466d7
Author: Ian Hickson <ian@hixie.ch>
Date:   Tue Sep 14 13:02:04 2021 -0700

    Mention the ToS on our README (#89765)

commit 8587b609a6b2cd253c9718c61fdebf89a2039169
Author: Kate Lovett <katelovett@google.com>
Date:   Tue Sep 14 14:53:33 2021 -0500

    Update local gold api (#90072)

commit 7d368dcf0c00b45fef5b02c5cccb8aa5306234ba
Author: Justin McCandless <jmccandless@google.com>
Date:   Tue Sep 14 12:39:19 2021 -0700

    InteractiveViewer with a child of zero size (#90012)

    Asserts that the InteractiveViewer child can't have zero size.

commit 2b4ef184b7217bdc34e5b382398bc9077f748150
Author: Akira Aratani <developer.a.akira@gmail.com>
Date:   Wed Sep 15 03:30:50 2021 +0900

    Fix document of the switch. (#89641)

commit a2cd16ba826cb8708f5b2ded9c99c6aa200551d9
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Tue Sep 14 11:22:02 2021 -0700

    use test logger, which does not allow colors (#90010)

commit 0f0613c0aee159ff2089b4ce788744f8cbe46c3a
Author: Varun Sharma <varunsh@stepsecurity.io>
Date:   Tue Sep 14 11:17:03 2021 -0700

    Add specific permissions to .github/workflows/lock.yaml (#89820)

commit 2866f79c89e9540595727481b51c783dc65e8bbe
Author: Jason Simmons <jason-simmons@users.noreply.github.com>
Date:   Tue Sep 14 10:46:35 2021 -0700

    Initialize all bindings before starting the text_editing_action_target test suite (#90067)

    Fixes https://github.com/flutter/flutter/issues/90057

commit b889915997df2ad9f4329b7caba1eee6b2c53b31
Author: Michael Thomsen <mit@google.com>
Date:   Tue Sep 14 14:08:36 2021 +0200

    Change min Dart SDK constraint to track actual version (#88743)

commit 3b7adb989fc59fd6aa906ee642d749b26f1a4b29
Author: godofredoc <54371434+godofredoc@users.noreply.github.com>
Date:   Mon Sep 13 21:32:04 2021 -0700

    Lock only issues. (#90023)

commit 528f77dc99e43f3eb20698cb683c25705725ced0
Author: Dan Field <dnfield@google.com>
Date:   Mon Sep 13 19:10:15 2021 -0700

    Opacity fix (#90017)

    * Make sure Opacity widgets/layers do not drop the offset

commit 2470f63ebba59ebdd9a7127a7c51c22471f3b1d7
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Sep 13 22:07:02 2021 -0400

    4a98e239b [flutter_plugin_tools] Make no unit tests fatal for iOS/macOS (flutter/plugins#4341) (#90016)

commit a01e4733df822f641fb017f3d6d4c56de7427f5d
Author: stuartmorgan <stuartmorgan@google.com>
Date:   Mon Sep 13 20:57:05 2021 -0400

    Re-enable plugin analysis test (#89856)

commit cdad35f2d87f2684d6b651d8db17e938d3570d8a
Author: Aneesh Rao <sidrao2006@gmail.com>
Date:   Tue Sep 14 05:17:04 2021 +0530

    Fix path in example (#84707)

commit 576aab08334e9f7989b32620cdc6b58d31162111
Author: Christopher Fujino <christopherfujino@gmail.com>
Date:   Mon Sep 13 15:47:03 2021 -0700

    add analysis_options.yaml to dev/conductor (#90005)

commit fad5e4cf892bcf65ad3f1cde092cfb9671c3de99
Author: Jason Simmons <jason-simmons@users.noreply.github.com>
Date:   Mon Sep 13 13:37:07 2021 -0700

    Remove a redundant test case in the flutter_tools create_test (#89872)

commit 738430cad787543bd815beb256acf29161771d92
Author: Darren Austin <darrenaustin@google.com>
Date:   Mon Sep 13 13:33:48 2021 -0700

    Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)

    This reverts commit 43e31977

commit 9db9256b38ea33641b7bc02b537501ccde3a9957
Author: Dan Field <dnfield@google.com>
Date:   Mon Sep 13 13:15:19 2021 -0700

    Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)

    This reverts commit 0d0f7a4fb065da5de8640f1d6757cd5b9bc5534b.

commit 00f78cf263066dedaa5cddfccb9e8c4d620abe13
Author: keyonghan <54558023+keyonghan@users.noreply.github.com>
Date:   Mon Sep 13 13:04:01 2021 -0700

    renew cirrus key (#89988)

commit 826da7f82665c37a10dd3281e66dd14a205dc42d
Author: engine-flutter-autoroll <engine-flutter-autoroll@skia.org>
Date:   Mon Sep 13 15:52:03 2021 -0400

    cfc8a20a1 renew cirrus key (flutter/plugins#4340) (#89996)

commit cd112e551c6a49434e30bd375e28144ab739c7a3
Author: Anna Gringauze <annagrin@google.com>
Date:   Mon Sep 13 12:13:42 2021 -0700

    Update all packages (#89797)
2021-09-15 11:51:47 +02:00
Sam Rawlins
bcb5db7758
Remove "unnecessary" imports from packages/ (#89795) 2021-09-15 01:27:02 -07:00
Kate Lovett
8587b609a6
Update local gold api (#90072) 2021-09-14 14:53:33 -05:00
Justin McCandless
7d368dcf0c
InteractiveViewer with a child of zero size (#90012)
Asserts that the InteractiveViewer child can't have zero size.
2021-09-14 12:39:19 -07:00
Akira Aratani
2b4ef184b7
Fix document of the switch. (#89641) 2021-09-14 11:30:50 -07:00
Christopher Fujino
a2cd16ba82
use test logger, which does not allow colors (#90010) 2021-09-14 11:22:02 -07:00
Jason Simmons
2866f79c89
Initialize all bindings before starting the text_editing_action_target test suite (#90067)
Fixes https://github.com/flutter/flutter/issues/90057
2021-09-14 12:46:35 -05:00
Michael Thomsen
b889915997
Change min Dart SDK constraint to track actual version (#88743) 2021-09-14 14:08:36 +02:00
Dan Field
528f77dc99
Opacity fix (#90017)
* Make sure Opacity widgets/layers do not drop the offset
2021-09-13 19:10:15 -07:00
Aneesh Rao
cdad35f2d8
Fix path in example (#84707) 2021-09-13 16:47:04 -07:00
Jason Simmons
fad5e4cf89
Remove a redundant test case in the flutter_tools create_test (#89872) 2021-09-13 13:37:07 -07:00
Darren Austin
738430cad7
Revert "Removed default page transitions for desktop and web platforms. (#82596)" (#89997)
This reverts commit 43e31977
2021-09-13 13:33:48 -07:00
Dan Field
9db9256b38
Revert "Make sure Opacity widgets/layers do not drop the offset (#89264)" (#89999)
This reverts commit 0d0f7a4fb065da5de8640f1d6757cd5b9bc5534b.
2021-09-13 13:15:19 -07:00
Anna Gringauze
cd112e551c
Update all packages (#89797) 2021-09-13 12:13:42 -07:00
Dan Field
0d0f7a4fb0
Make sure Opacity widgets/layers do not drop the offset (#89264) 2021-09-12 21:17:23 -07:00
LongCatIsLooong
86c79a83a2
[TextPainter] Don't invalidate layout cache for paint only changes (#89515) 2021-09-11 13:27:02 -07:00
LongCatIsLooong
0b1832ba60
Make FilteringTextInputFormatter's filtering Selection/Composing Region agnostic (#89327) 2021-09-10 21:47:04 -07:00
xubaolin
b2550fe5fa
fix a dropdown button menu position bug (#89199) 2021-09-10 20:17:04 -07:00
Kate Lovett
4ec75580fb
Revert clamping scroll simulation changes (#89885) 2021-09-10 16:02:02 -07:00
Phil Quitslund
975fcc1f2f
master->main deafult branch migration (#89782) 2021-09-10 15:42:03 -07:00
Souvik Biswas
e7b1b2065d
[Docs: Integration Test Readme] Updated with proper commands (#88214)
* Updated with proper docs

* Add the casting
2021-09-10 12:12:20 -07:00
Chase Latta
aed4315a7d
Replace amber_ctl with pkgctl for Fuchsia (#89785)
Fuchsia is deprecating amber_ctl and replacing it with pkgctl.
This change removes the FuchsiaAmberCtl class and replaces it
with the FuchsiaPkgctl class and updates the usages appropriately.

BUG: fxbug.dev/83865
2021-09-10 10:33:45 -07:00
Jason Simmons
eb5ae39f13
Skip the drawShadow call in a MergeableMaterial with zero elevation (#89699) 2021-09-10 10:22:02 -07:00