Andrew Kolos
06e2b18173
[tools] use Java class for all java-searching behavior ( #127354 )
...
Fixes #124252 , finishing work on the umbrella tracking issue, #126126 .
Essentially, after this PR, no (non-test) code should be be referencing/invoking the java home or binary paths.
2023-06-01 04:19:19 +00:00
Andrew Kolos
9dbd6e6139
[tools] Apply Android Studio version detection logic to explicitly configured installation directory (flutter config --android-studio-dir) ( #125596 )
...
Fixes #121468 (when considered along with https://github.com/flutter/flutter/pull/125247 ).
This applies the pre-existing Android Studio version detection logic to the install configured with `flutter config android-studio-dir`.
2023-05-01 07:10:20 +00:00
Andrew Kolos
cf76b24df1
When searching for the JDK bundled with an unrecognized version of Android Studio, assume the version to be the latest ( #125247 )
...
Fixes #125246 by restoring the intended behavior of #101862 . That is, when searching for a JDK and we encounter an Android Studio version we don't recognize, assume it to be the latest version `flutter` is aware of.
Also does some light refactoring in the tests, like using test objects instead of referencing `globals`.
2023-04-21 01:12:59 +00:00
Andrew Kolos
68ec71f46c
[flutter_tools] Remove Version.unknown ( #124771 )
...
Fixes #124756 by removing the concept of `Version.unknown`.
`Version` fields that needed the ability to represent an unknown version have been made nullable. Assigning `null` to them represents an unknown version.
2023-04-15 19:56:41 +00:00
Andrew Kolos
ec13058a1e
Normalize Java SDK (JDK) location logic across the tool ( #124233 )
...
Normalize Java SDK (JDK) location logic across the tool
2023-04-05 20:36:50 +00:00
Christopher Fujino
aed9b4adce
Revert "Revert "Fix unable to find bundled Java version ( #119244 )" ( #119981 )" ( #120107 )
...
This reverts commit f7c2bd05f0167f9d9c8cc4e96f10dfc7a6a7c848.
2023-02-07 21:42:20 +00:00
godofredoc
f7c2bd05f0
Revert "Fix unable to find bundled Java version ( #119244 )" ( #119981 )
...
This reverts commit 57fd50f84e013146ecfe40a3c77f8b0499bf59da.
2023-02-04 02:57:53 +00:00
crasowas
57fd50f84e
Fix unable to find bundled Java version ( #119244 )
2023-02-03 18:04:04 -08:00
Michael Goderbauer
38630b6bd1
Remove unnecessary null checks in flutter_tool ( #118857 )
...
* dart fix --apply
* manual fixes
* fix after merge conflicts
* review
2023-01-23 21:43:08 +00:00
Jenn Magder
2f03dda55e
Fix Android Studio version string nullablity, fake AndroidStudio in test ( #113295 )
2022-10-12 18:32:55 +00:00
Phil Quitslund
b5e7fb076c
[flutter_tools] rename local functions with _s ( #102688 )
2022-04-27 16:19:07 -07:00
Lau Ching Jun
c2dc92ca88
Default to the newer version path when checking Android Studio Java path ( #101862 )
2022-04-13 22:49:06 -07:00
Jenn Magder
9e88fe328e
Remove globals_null_migrated.dart, move into globals.dart ( #92861 )
2021-11-01 17:18:03 -07:00
Taha Tesser
d72287522b
[tools] Fix Android Studio duplicate detection ( #88384 )
2021-08-18 02:02:03 -07:00
Taha Tesser
f9aa5842c2
[tools] Fix Android Studio Arctic Fox Java path on macOS ( #87267 )
2021-07-29 10:24:07 -07:00
Taha Tesser
94f71f374f
[flutter_tools] Refactor Android Studio Detection on Windows (support 4.x and 202x releases detection) ( #86624 )
2021-07-20 12:16:03 -07:00
Taha Tesser
3c72ef374d
Fix Android Studio 4.2 detection on Windows ( #82484 )
2021-05-13 22:54:04 -07:00
Jenn Magder
ba4177f6da
Find Android Studio installations with Spotlight query on macOS ( #80475 )
2021-04-28 19:09:03 -07:00
Jenn Magder
026ee9756c
Allow null config values ( #79917 )
2021-04-06 21:52:35 -07:00
Jenn Magder
fb68d07477
Migrate android_studio to null safety ( #79504 )
2021-04-01 20:24:04 -07:00
Jenn Magder
8ddc27e607
Split globals.dart into null sound and unsound libraries ( #79016 )
2021-03-31 16:55:20 -07:00
Jonah Williams
90f353f9b1
[flutter_tools] dont crash when looking for AS4.1 on windows with no LOCALAPPDATA ( #77261 )
2021-03-04 11:29:20 -08:00
William Oprandi
679b8c2982
Fix Android Studio detection and plugins on Linux ( #75612 )
2021-03-03 08:29:03 -08:00
Jonah Williams
74bd7b6f6d
[flutter_tools] opt all flutter tool libraries and tests out of null safety. ( #74832 )
...
* opt out the flutter tool
* oops EOF
* fix import
* Update tool_backend.dart
* Update daemon_client.dart
* fix more
2021-01-27 15:17:53 -08:00
Mokusesei
6269abb75b
Reland: fix android studio 4.1 plugin path for mac ( #69954 )
2020-11-06 10:57:04 -08:00
Vyacheslav Egorov
4c24eb10b8
Revert "Fix: fix android studio 4.1 plugin path for macOS" ( #69870 )
...
This reverts commit 422a97d1e5851be853b7081a75cb4e2f86763913 due to https://github.com/flutter/flutter/issues/69863
2020-11-05 11:18:00 +01:00
Mokusesei
422a97d1e5
Fix: fix android studio 4.1 plugin path for macOS ( #69364 )
2020-11-04 17:25:53 -08:00
Jenn Magder
537cf33a21
Move processUtils to globals ( #67976 )
2020-10-14 13:12:46 -07:00
Jonah Williams
1c976933f3
[flutter_tools] support Android Studio 4.1 on Windows ( #67992 )
...
Android Studio 4.1 moved the location of the .home file on Windows which is used to located the install directory. This functionality is important because it is how we locate and discover the Android SDK functionality, as well as the appropriate JRE.
fixes #67986
2020-10-13 11:33:26 -07:00
Jenn Magder
ba57ea09d1
Revert "Move processUtils into globals ( #53209 )" ( #53301 )
2020-03-25 14:59:03 -07:00
Jenn Magder
9ccac00599
Move processUtils into globals ( #53209 )
2020-03-25 11:23:08 -07:00
Zachary Anderson
6c408a0567
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #52021 )
...
* Reland: [flutter_tool] Where possible, catch only subtypes of Exception
* Add armv7f to getIOSArchForName
2020-03-06 10:22:12 -08:00
Jenn Magder
cbbb7ec5a7
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51774 )" ( #51960 )
...
This reverts commit 57c6721cd54b6747ef3444cfc6d06d4c33e310ea.
2020-03-04 12:40:15 -08:00
Flutter GitHub Bot
57c6721cd5
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51774 )
2020-03-04 11:41:02 -08:00
Zachary Anderson
b32ee2f15c
Revert "Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51567 )" ( #51616 )
...
This reverts commit 9de7787f258870e60a7c4127883e8f7f1af5822c.
2020-02-27 22:57:13 -08:00
Zachary Anderson
9de7787f25
Reland: [flutter_tool] Where possible, catch only subtypes of Exception ( #51567 )
2020-02-27 22:46:23 -08:00
Zachary Anderson
483f49962c
Revert "[flutter_tool] Where possible, catch only subtypes of Exception ( #51440 )" ( #51539 )
...
This reverts commit f1cd47ef5cd9a365e968a83b84f4e893595accc2.
2020-02-26 23:42:19 -08:00
Zachary Anderson
f1cd47ef5c
[flutter_tool] Where possible, catch only subtypes of Exception ( #51440 )
2020-02-26 21:45:02 -08:00
Jonah Williams
80619f100f
[flutter_tools] remove globals from plist parser and update tests ( #51444 )
2020-02-26 18:31:42 -08:00
Zachary Anderson
6bfff984de
[flutter_tools] Handle AndroidStudio validator crash ( #50282 )
2020-02-06 16:03:02 -08:00
Zachary Anderson
390ed1cd81
[flutter_tools] Move homeDirPath to FileSystemUtils ( #49909 )
2020-02-03 14:33:03 -08:00
Alexandre Ardhuin
b5f328e37e
remove unnecessary string interpolations ( #49622 )
2020-01-31 18:30:21 +01:00
Dan Field
fabeb2a16f
Revert string interp ( #49602 )
2020-01-28 07:56:51 -08:00
Alexandre Ardhuin
92cbaa3efe
remove unnecessary string interpolations ( #49352 )
2020-01-23 20:43:01 -08:00
Alexandre Ardhuin
4f9b6cf017
enable lint prefer_final_in_for_each ( #47724 )
2020-01-07 16:32:04 +01:00
Jonah Williams
ee7a37f1d3
[flutter_tools] Ensure that global variables are easily identifiable ( #47398 )
2020-01-06 11:04:20 -08:00
Ian Hickson
449f4a6673
License update ( #45373 )
...
* Update project.pbxproj files to say Flutter rather than Chromium
Also, the templates now have an empty organization so that we don't cause people to give their apps a Flutter copyright.
* Update the copyright notice checker to require a standard notice on all files
* Update copyrights on Dart files. (This was a mechanical commit.)
* Fix weird license headers on Dart files that deviate from our conventions; relicense Shrine.
Some were already marked "The Flutter Authors", not clear why. Their
dates have been normalized. Some were missing the blank line after the
license. Some were randomly different in trivial ways for no apparent
reason (e.g. missing the trailing period).
* Clean up the copyrights in non-Dart files. (Manual edits.)
Also, make sure templates don't have copyrights.
* Fix some more ORGANIZATIONNAMEs
2019-11-27 15:04:02 -08:00
Alexandre Ardhuin
adc7351046
implicit-casts:false on flutter_tools/lib ( #44447 )
...
* implicit-casts:false on flutter_tools/lib
* address review comments
* use castStringKeyedMap
* introduce {bool,string,strings}Arg
* fix ci
2019-11-19 07:57:42 +01:00
Emmanuel Garcia
175b37247d
Refactor gradle.dart ( #43479 )
2019-10-31 13:19:15 -07:00
Zachary Anderson
e2340c641d
[flutter_tool] Use curly braces around single statment control structures ( #40446 )
2019-09-13 14:51:35 -07:00
