11260 Commits

Author SHA1 Message Date
Jonah Williams
41b87255f5
Add support for depfile dependency in assemble (#41530) 2019-09-30 12:17:45 -07:00
Alexandre Ardhuin
f0553ba58e
Missing trailing commas (#41473)
* add missing trailing commas

* add more missing trailing commas

* add more and more missing trailing commas
2019-09-30 18:48:23 +02:00
stuartmorgan
d1761f1072
Pass Linux build mode on command line (#41551)
Currently Linux builds override the default BUILD mode by putting it in
the generated config. That makes it sticky for manual runs of make,
which is inconsistent with how other platforms work.

Instead, pass the build mode as a command-line override, the same way
someone would if building directly with make. This makes the flow of
controlling the mode less confusing.

Fixes #41528
2019-09-30 09:36:40 -07:00
Justin McCandless
67ea92cbca
Fix exception when selecting in TextField (#41326) 2019-09-30 09:24:30 -07:00
Erick Ghaumez
d122f09959 Fix the ThemeData.copyWith toggleButtonsTheme argument type (#40994)
* set the copyWith toggleButtonsTheme argument type to ToggleButtonsThemeData

* add a ThemeData.copyWith test
2019-09-30 23:52:35 +08:00
Jonah Williams
c8b3c9b727
use IOOverrides to allow inject file system, write test, find bug (#40066) 2019-09-30 08:41:12 -07:00
Zachary Anderson
45f3c8d060
[flutter_tool] Report to analytics when the tool is killed by a signal (#41493)
* [flutter_tool] Report to analytics when the tool is killed by a signal

* Fix analyzer lint
2019-09-30 07:38:11 -07:00
Danny Tuppeny
7e73cd74b1
Fix visibility of web server device when Chrome is not available (#40757)
* Fix visbility of web server device when Chrome is not available

* Add tests

* Update workflow test

* Fix tests to not rely on Chrome being on the underlying machine
2019-09-30 14:45:30 +01:00
Alexander Aprelev
839fdbd2ed
Retry devfs uploads in case they fail. (#41406)
* Retry devfs uploads in case they fail.

Fixes #34959.
2019-09-29 21:32:06 -07:00
Jonah Williams
69af9adeac
Update minimum build_runner version and enable incremental builder (#41499) 2019-09-29 13:01:33 -07:00
Greg Spencer
0223565fd5
Reland changes to Intent.doNothing to avoid analyzer issue (#41477)
This re-lands #41417 with a slight change that will hopefully not tickle the analyzer as it did before. The last time I tried to land this, the analyzer succeeded for the analyze step in Cirrus, and locally, but failed in an integration test.
2019-09-28 08:55:47 -07:00
MH Johnson
f4ba8d1a93
[Material] Remove text ripple from TextFields (#41320)
* remove splash logic

* update tests
2019-09-28 11:47:17 -04:00
Jonah Williams
07e5cf005c
Reland: Exit resident web runner on compilation failure (#41505) 2019-09-27 18:54:58 -07:00
Jonah Williams
7a487b2cbf
Ensure we find dart.exe on local engines (#41514) 2019-09-27 18:54:24 -07:00
LongCatIsLooong
5f9c262e66
Revert "CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919)" (#41521) 2019-09-27 17:46:15 -07:00
LongCatIsLooong
97b27fafd4
CupertinoDatePicker & CupertinoTimerPicker dark mode (#39919) 2019-09-27 16:03:51 -07:00
Jonah Williams
d968b7cfd6
Revert "Dont update last compiled time when compilation is rejected (#41424)" (#41515) 2019-09-27 15:18:06 -07:00
Zachary Anderson
feaaa5d738
[flutter_tool] Add analytics events for ios-mdns fallback success/failure (#41482) 2019-09-27 12:18:59 -07:00
Jonah Williams
618fac92c9
Revert "Exit resident web runner on initial compilation failure (#41441)" (#41498) 2019-09-27 11:50:23 -07:00
Emmanuel Garcia
2466ca5bb0
Copy Flutter assets before merging the rest of resources (#41333) 2019-09-27 10:53:37 -07:00
krisgiesing
2b138fd7d2
Fix ReorderableListView's use of child keys (#41334) (#41338)
ReorderableListView was constructing a GlobalObjectKey using
the child key as the value. This only had the intended behavior
if the child key was identical across build method invocations.

The new strategy is to scope the child key's value to the
State object's identity, allowing child keys to have value
compare semantics while disambiguating among different list view
instances.
2019-09-27 10:48:42 -07:00
Jonah Williams
d7a8dda219
Dont update last compiled time when compilation is rejected (#41424) 2019-09-27 10:32:57 -07:00
Jonah Williams
a1852a1993
Exit resident web runner on initial compilation failure (#41441) 2019-09-27 10:32:38 -07:00
Zachary Anderson
716a672bc8
[flutter_tools] Adds tests of mdns analytics events (#41410) 2019-09-27 08:07:26 -07:00
Alexandre Ardhuin
f11c34109c
fix bad indentations(mainly around collection literals) (#41355) 2019-09-27 10:46:45 +02:00
Greg Spencer
957d839775
Revert "Address previous comments, fix Intent.doNothing. (#41417)" (#41449)
This reverts commit eb3e2f559f2563a0878d19bd997629ce07becd3c because of a suspected analyzer bug.  Reverting to investigate.
2019-09-26 22:45:21 -07:00
Greg Spencer
eb3e2f559f
Address previous comments, fix Intent.doNothing. (#41417)
This addresses comments in the original PR (#41245) that introduced Intent.doNothing, adds tests, and fixes an issue with it.
2019-09-26 19:54:28 -07:00
Devon Carew
1044457225
add tests to ensure the sdk is well-formed (#41408)
add tests to ensure the sdk is well-formed
2019-09-26 18:22:25 -07:00
Hans Muller
ecc4764fe2
Revert "Dropdown Menu layout respects menu items intrinsic sizes (#41120)" (#41422)
This reverts commit e47a1dc21613d67a2e2e13c4b81f98c98ee5d4f3.
2019-09-26 17:57:08 -07:00
Jonah Williams
efd2ba296b
Flutter build bundle without --precompiled should always perform a debug build. (#41401) 2019-09-26 15:57:57 -07:00
Greg Spencer
a085635899
Change the way ActionDispatcher is found. (#41245)
This changes the way ActionDispatchers are found by the Actions widget, so that by default it will look for dispatchers of the parent Actions widgets instead of just creating a default ActionDispatcher. This allows overriding of the ActionDispatcher at the top level: before, the custom action dispatcher would only be invoked if explicitly set on all the Actions widgets.

This is not a breaking change because there was a default value to the dispatcher parameter before that performed this function, and not specifying the dispatcher anywhere will still result in a default dispatcher being created.
2019-09-26 14:31:08 -07:00
Greg Spencer
1a7bb1f583
Added proper focus handling when pushing and popping routes (#40166)
The proposed change will change focus handling when pushing and popping routes so that the FocusScopeNode for the route receives focus when pushed, and that the FocusScopeNode in the navigator receives focus when the route is popped.

This means that the last setFirstFocus call on the scope is used to determine which control actually receives focus. When the focus scope receives focus, it traverses its children, trying to find a non-scope node that is the "first focus" of itself or a child node.

This is a breaking change, because the focus behavior has changed. If you push a route after this change, and had a 'first focus' set on a widget via FocusScopeNode.setFirstFocus, it won't currently receive focus immediately, but after this change it will. Similarly, if you pop a route after this change, the focus will go back to where it was before the route was pushed, which is correct, but different from what happens now.
2019-09-26 14:30:39 -07:00
Jonah Williams
c93839131c
Fix timing issues in initialization of web resident runner (#41347) 2019-09-26 14:23:19 -07:00
stuartmorgan
56d68a9071
Add the beginnings of plugin support for Windows and Linux (#41015)
Adds very preliminary support for Windows and Linux plugins:
- Adds those platforms to the new plugin schema, initially supporting just a plugin class.
- Adds C++ plugin registrant generation for any Windows or Linux plugins found.

This doesn't have yet have any build tooling for either platform, so anyone using the generated registrant still needs to do manual build configuration. This reduces the manual work, however, and creates a starting point for future tooling work.

As with all Windows and Linux work at this time, this is not final, and subject to change without warning in the future (e.g., Windows could potentially switch to a C# interface, or
'linux' may change to 'gtk' or 'linux_gtk' in pubspec.yaml).
2019-09-26 14:01:57 -07:00
Kristin Ho
034358e341 Prevent PointerEnter[or Exit]Event from erasing event.down value (#40637) (#41332)
* MouseRegion documentation claimed that onEnter and onExit
  would track entry and exit regardless of whether the pointer was
  down or up
* It did such, but when grabbing the value of `event.down` from
  the passed event, the value was always `false`
* PointerEnterEvent and PointerExitEvent were overriding the value
  passed from PointerEvent in constructors, even if the value was true
  e.g. in invocations of .fromMouseEvent((PointerMoveEvent...))
* This change now passes the value along to PointerEnter/ExitEvents
  while providing it a default of false, and updates documentation

Fixes #40637
2019-09-26 13:48:40 -07:00
Zachary Anderson
bb7e3f6045
[flutter_tools] Report iOS mDNS lookup failures to analytics (#41384) 2019-09-26 13:41:11 -07:00
Jonah Williams
0980fa2ddd
Serve every html file under web (#41386) 2019-09-26 13:24:05 -07:00
Greg Spencer
0509791663
Fix mouse hover to not schedule a frame for every mouse move. (#41014)
This fixes the mouse hover code to not schedule frames with every mouse move.

Before this, it would schedule a post frame callback, and then schedule a frame immediately, even if there was nothing that needed to be updated. Now it will schedule checks for mouse position updates synchronously, unless there's a new annotation, and skip scheduling a new frame in all cases. It has to be async in the case of a new annotation (i.e. a new MouseRegion is added), since when the annotation is added, it hasn't yet painted, and it can't hit test against the new layer until after the paint, so in that case it schedules a post frame callback, but since it's already building a frame when it does that, it doesn't need to schedule a frame.

The code also used to do mouse position checks for all mice if only one mouse changed position. I fixed this part too, so that it will only check position for the mouse that changed.
2019-09-26 13:13:42 -07:00
Zachary Anderson
7fa5dd7454
[flutter_tools] Allows adding multiple signal handlers (#41304) 2019-09-26 08:12:48 -07:00
Hans Muller
e47a1dc216
Dropdown Menu layout respects menu items intrinsic sizes (#41120) 2019-09-26 07:18:25 -07:00
Emmanuel Garcia
975e770e13
Add embedding as API dependency instead of compile only dependency (#41142) 2019-09-25 17:59:17 -07:00
Jonah Williams
89ebd700f2
Support deferred imports on profile/release builds of Flutter Web (#41222) 2019-09-25 15:12:58 -07:00
Jonah Williams
7065e43306
Allow skipping chrome launch with --no-web-browser-launch (#40627) 2019-09-25 13:55:54 -07:00
Jonah Williams
9bd02a1787
Re-Re-Re-land implement flutter build bundle with assemble (#41302) 2019-09-25 13:55:29 -07:00
Francisco Magdaleno
d2a95ee344
Fix crash on vswhere query on missing installations (#40786) 2019-09-25 13:38:53 -07:00
Nurhan Turgut
ae529d8be0
Fixing the editable_text unit tests by clearing the log. Add a modification for also testing cached size. (#41300) 2019-09-25 13:14:59 -07:00
Zachary Anderson
5142238c85
[flutter_tool] Report rss high watermark in command analytics events (#40988) 2019-09-25 11:26:06 -07:00
Alexandre Ardhuin
9c6f11d5d1
fix bad indentation (#41263) 2019-09-25 20:24:57 +02:00
LongCatIsLooong
deb4184f63
Remove CupertinoSystemColors in favor of CupertinoColors (#40566) 2019-09-25 10:17:37 -07:00
Jonah Williams
cc3ca9a916
Revert "Re-Re-land Implement flutter build bundle with assemble (#41230)" (#41295) 2019-09-25 10:57:58 -04:00