Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.
Fixes#23458
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
The lerp method for IconThemeData was not doing anything to prevent exceptions when null arguments are used. This change fixes that and adds a test for it.
* Include caret gaps in position calculation to avoid descender cutoff
* Calculate caret offset instead of exposing it
* Test that textfields scroll vertically by full line height
* Only add offset to end of caret to avoid going above 0.0
* Fix and test horizontal vs. vertical scrolling
* CR: docs and top caret offset logic
* Take max instead of assuming caretRect.top is always a full line down
* Always subtract caretOffset from caretTop since caretRect.top can be negative
fdfb0e72f0...09e149e897
git log fdfb0e72f0af7b4de3f8cd04ca8519ba5acc12fe..09e149e89787fb0722b8a43ec5406e66d6901eec --no-merges --oneline
09e149e89 Roll src/third_party/skia 98c65fc9558f..47b7cd9a6baf (4 commits) (flutter/engine#7501)
87e8d3059 Roll src/third_party/dart d9944433af..2195a70249 (28 commits) 2195a70249 Make sure that path is correct on all test platforms 56f87f409e [dart:io,fuchsia] Pass Isolate namespace to child process. Fix double free. b55bc09f1f Add list literal spread collection parsing support 4074ebd0a0 Partial implementation of the unified specification of definite assignment, type promotion, and reachability analysis. 43a96d49af Revert "[vm/compiler] AOT inline heuristics improvements" a55b6fc183 Remove unused import 2908e61f2a [vm/compiler] AOT inline heuristics improvements 3154bb0d37 Stop using external deprecated members in front_end ff06d233aa Set CompletionSuggestion.elementUri everywhere in analysis server that element is already being set. 23f427b1a7 Reland [VM/Compiler] Removing definition status from Store{Indexed,InstanceField}. edca6169c1 Fixed a number of dart:html P1 issues. ff5e5b6896 Regenerate LSP classes from spec + update README 116f678a69 [build] Enable mitigations for Cortex-A53 Erratum #843419 bug. 21edbbbac6 Add spread collection token to scanner 030fa85cea Fix windows tests 23b5aee978 Update dartfix NNBD to handle more situations fe6b384ff5 revise dartfix protocol version check 61e81217f0 Update LSP status doc (rename is complete + tested in VS Code) daead8dff8 Add test for LSP rename that edits multiple files bdade89081 Improve testing of document versions in LSP renames ecc1411685 Print constant table when printing libraries. 999c2a7582 Check for conflict with static members 3f44bd1bf9 Check for conflicts in mixins aa59b20b4b Don't report conflicts twice 3ef8c296bd Improve detection of conflicts with inherited members and setters 50fa633c4a Report InheritedMembersConflict correctly c25c30dc32 Remove some unused imports c6ab52c9f9 Using the right conjunction
6c68bf3ca Revert "Revert "Add elevation and thickness to SemanticsNode (#7282)" (#7483)" (flutter/engine#7484)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
Previously, a disabled floating action button always had zero
elevation, which looks dumb.
This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.
This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:
package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.
becomes:
package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
* Fix `flutter test`e xpression eval tests
We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.
* Ensure we wait for breakpoints before trying to evaluate
* Allow a widget to be specified for the textfield count, and allow no count at all
* Test all possible states for counter and counterText
* Docs for counter
* counter is a function that generates a widget
* Tests use counter as function
* Fix analyze error in docs
* InputDecoration has counter widget, TextField has buildCounter function
* InputDecorator tests expect counter to be widget again and include
buildCounter
* counter widget example that might actually fit
* Clarify accessiblity concerns in docs
* Include isFocused param for accessibility
* Fix analyze error
* Improve docs per code review
* Rearrange getEffectiveDecoration a bit for clarity
* Fix analyze error about hashValues params
* Clean up docs and redundant code per code review
* Code review doc improvement
* Automatically wrap buildCounter widget in a Semantics widget for accessibility
This was causing analysis to fail when there was an import statement in a comment, such as when snippets add imports to their examples.
I narrowed the RegExp to match only those lines which aren't commented out, but it really should probably be using the analysis server to catch all cases (e.g. if someone put the doc comment into /** */ comments, it could still match). Since this is a Flutter-specific script, it's probably not worth doing that.
17a90fbe8f...e68a3fa912
git log 17a90fbe8f23b6efb97c322e5ea67a0a55f4de0e..e68a3fa912cd1ba0e2aaf1f87e7abdec96e68aee --no-merges --oneline
e68a3fa91 Roll src/third_party/dart b0855ffd35ad4878fb3b36d8f5ff00a421719e7c..1c9eb3cef80779601f964b05a68a785bf49b084f (1 commits) 1c9eb3cef8 [Kernel] Allow constant declarations without an initializer
386cb4859 Roll src/third_party/skia 33f58abef2b7..da068c0d1d7c (1 commits) (flutter/engine#7462)
6f89a132d Roll src/third_party/dart f81dd1da9f9f879c17dda7b20a2572fa5549f3dd..b0855ffd35ad4878fb3b36d8f5ff00a421719e7c (4 commits) b0855ffd35 [infra] Fix testing on Android 8d9247b9fc dartfix README 7b5f24db6f Change wiki link to follow contents moved. 6f4e85d11f [dart2js js_runtime] Run dartfmt --fix-doc-comments
82bb5f7c8 Roll src/third_party/skia 60a2f675ddce..33f58abef2b7 (1 commits) (flutter/engine#7460)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
5722a9685e...abbc34e148
git log 5722a9685e3cba77649ba5257a91ed21933ca063..abbc34e1482d0a118a84040933f61cfa42a1fb5f --no-merges --oneline
abbc34e14 Roll src/third_party/skia 82223aae39b7..2ee498c6749a (2 commits) (flutter/engine#7454)
f817343a7 Roll src/third_party/skia e548161aba5b..82223aae39b7 (3 commits) (flutter/engine#7453)
cd0169ae2 Roll src/third_party/skia c334df71b8f9..e548161aba5b (1 commits) (flutter/engine#7452)
377ff1975 Roll src/third_party/dart f0c7d971c472066e29a949aab8826c204cfbaf35..f81dd1da9f9f879c17dda7b20a2572fa5549f3dd (2 commits) f81dd1da9f Handle super* in ir/impact.dart 99a9ae66c3 [dart2js] run dartfmt --fix-doc-comments on stragglers
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
