8028 Commits

Author SHA1 Message Date
Ian Hickson
bf017b79b3 Move Point to Offset (#9277)
* Manually fix every use of Point.x and Point.y

Some of these were moved to dx/dy, but not all.

* Manually convert uses of the old gradient API

* Remove old reference to Point.

* Mechanical changes

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\bPoint[.]origin\b/Offset.zero/g'
git ls-files -z | xargs -0 sed -i 's/\bPoint[.]lerp\b/Offset.lerp/g'
git ls-files -z | xargs -0 sed -i 's/\bnew Point\b/new Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bconst Point\b/const Offset/g'
git ls-files -z | xargs -0 sed -i 's/\bstatic Point /static Offset /g'
git ls-files -z | xargs -0 sed -i 's/\bfinal Point /final Offset /g'
git ls-files -z | xargs -0 sed -i 's/^\( *\)Point /\1Offset /g'
git ls-files -z | xargs -0 sed -i 's/ui[.]Point\b/ui.Offset/g'
git ls-files -z | xargs -0 sed -i 's/(Point\b/(Offset/g'
git ls-files -z | xargs -0 sed -i 's/\([[{,]\) Point\b/\1 Offset/g'
git ls-files -z | xargs -0 sed -i 's/@required Point\b/@required Offset/g'
git ls-files -z | xargs -0 sed -i 's/<Point>/<Offset>/g'
git ls-files -z | xargs -0 sed -i 's/[.]toOffset()//g'
git ls-files -z | xargs -0 sed -i 's/[.]toPoint()//g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point, /show /g'
git ls-files -z | xargs -0 sed -i 's/\bshow Point;/show Offset;/g'

* Mechanical changes - dartdocs

I applied the following at the root of the Flutter repository:

git ls-files -z | xargs -0 sed -i 's/\ba \[Point\]/an [Offset]/g'
git ls-files -z | xargs -0 sed -i 's/\[Point\]/[Offset]/g'

* Further improvements and a test

* Fix minor errors from rebasing...

* Roll engine
2017-04-12 15:06:12 -07:00
Chris Bracken
7b0b5c5760 Roll engine to 059ab3a47165d98cb1d7ac5e2a2e4b50abf39832 (#9352) 2017-04-12 14:43:34 -07:00
Hans Muller
d9cd85e3ef Remove the pesto gallery demo (#9341) 2017-04-12 14:41:03 -07:00
Ian Hickson
2a54524337 Fix tests to use Ahem, and helpful changes around that (#9332)
* Fix tests to use Ahem, and helpful changes around that

- Fix fonts that had metric-specific behaviours.

- LiveTestWidgetsFlutterBinding.allowAllFrames has been renamed
  to LiveTestWidgetsFlutterBinding.framePolicy.

- LiveTestWidgetsFlutterBinding now defaults to using a frame policy
  that pumps slightly more frames, to animate the pointer crosshairs.

- Added "flutter run --use-test-fonts" to enable Ahem on devices.

- Changed how idle() works to be more effective in live mode.

- Display the test name in live mode (unless ahem fonts are enabled).

- Added a toString to TextSelectionPoint.

- Style nit fixes.

* Roll engine to get Ahem changes.

* Update tests for dartdoc changes.

* Fix flutter_tools tests
2017-04-12 13:33:02 -07:00
Jason Simmons
c12c019bcc Throw an exception with the asset key if a string asset load fails (#9325)
Fixes https://github.com/flutter/flutter/issues/7715
2017-04-11 13:48:04 -07:00
Yegor
9dfcc6ec79 Revert "temporarily mark iOS tests as flaky (#9314)" (#9333)
This reverts commit ff23a1ebfe5d01af8924761253cc574f23ac5295.

Our iOS lab hardware is back to normal.
2017-04-11 12:26:15 -07:00
Devon Carew
20e83e3e58 change the reload success message to include both the elapsed time and the library count (#9328) 2017-04-11 07:57:18 -07:00
xster
89a7fdfc56 Rename State.config to widget everywhere (#9273)
Rename State.config to State.widget
Rename State.didUpdateConfig to State.didUpdateWidget
Renamed all State subclasses' local variables named config to something else
2017-04-10 18:32:24 -07:00
Yegor
a5593b1678 fix analyzer warning: use const where possible (#9320) 2017-04-10 14:20:47 -07:00
Yegor
5efbe05f04 do not warn about out-of-date Flutter installation too often (#9271)
* do not warn about out-of-date Flutter installation too often

* style fix
2017-04-10 13:21:02 -07:00
Yegor
ff23a1ebfe temporarily mark iOS tests as flaky (#9314) 2017-04-10 10:51:31 -07:00
Jakob Andersen
7ffa82aaf0 Inject plugin registration. (#9216)
Added a PluginRegistry to the new project template. The registry files will be automatically updated at build time to register the native plugins.

Fixes #7814.
2017-04-10 15:44:19 +02:00
xster
4f258357c9 Fix lints (#9307) 2017-04-10 02:09:51 -07:00
xster
7ce1cfd48d AppBar automatically show a close button for dialogs (#9268)
* Wiring fullscreen dialog

* Make fullscreen dialog use the new API. Add tests

* Review notes

* Move field back up

* final
2017-04-10 01:05:25 -07:00
Devon Carew
70e2acfb6c tweak the layout for the ios doctor checks (#9306) 2017-04-09 12:43:48 -07:00
Devon Carew
ca5f0c9a3e fix the return type on flutterPlatformOverride (#9269) 2017-04-09 11:08:32 -07:00
Kyle Bradshaw
55e51e798b Form.dart doc typo fixes (#9302)
Came across "can ve" while experimenting with Forms using VSCode and Dart Code. Glanced over the rest of the docs for typos while I was at it.
2017-04-08 10:39:01 -07:00
Ian Hickson
9350f2875d Fix some error message text typos. (#9294)
Also, add a specific message for BuildContext.size for RenderSlivers.
2017-04-08 00:32:02 -07:00
Dariusz Baciński
d25981cfb3 generate_from_arb has been moved to intl_translantion library (#9255)
* generate_from_arb has been moved to intl_translantion library

* fixed typo

* added missing intl dependency

* Regenerated language files with latest intl script

* Added version to intl_translations

* added isolate min version constraint
2017-04-08 00:25:01 -07:00
Alexandre Ardhuin
610955f81d upgrade to linter-0.1.30 (#9297)
* upgrade to linter-0.1.30

* add prefer_is_empty lint
* add directives_ordering lint
* add no_adjacent_strings_in_list lint
* add no_duplicate_case_values lint
* add prefer_collection_literals lint
* add prefer_const_constructors lint
* add prefer_contains lint
* add prefer_initializing_formals lint
* add unnecessary_null_aware_assignments lint
* add unnecessary_null_in_if_null_operators lint
2017-04-08 08:43:19 +02:00
Yegor
361afef305 fix checkLockAcquired: support re-entrant locking (#9272)
* fix checkLockAcquired: support re-entrant locking

* add test; address comments

* add comment
2017-04-07 21:08:53 -07:00
xster
33997bb7bb Add some more details to implicit animation's dartdoc (#9292) 2017-04-07 18:40:06 -07:00
Ian Hickson
2a5810e36f Point from gallery's routing table to stocks'. (#9287)
The stocks routing table is a clearer example of how to do this.
People know to look at the gallery, but don't think to look at the
stocks version. This points them from the former to the latter.
2017-04-07 17:51:41 -07:00
Seth Ladd
c358ddbaf2 example of a package dependency asset (#9295) 2017-04-07 17:51:34 -07:00
Ian Hickson
a6eeaa5e34 Fix some typos in icon_theme.dart (#9296) 2017-04-07 17:24:50 -07:00
Ian Hickson
ebe6da5b17 Rename BlockBody to ListBody. (#9291)
Nobody knew what a Block was.
2017-04-07 17:14:54 -07:00
Adam Barth
f9ae22677a Improve cooperation between scale and drag gestures (#9298)
Now the scale gesture will accept if its focal point moves more than the pan
slop. This change lets it compete with a drag gesture (e.g., a containing scrol
view) in the same way that the pan gesture does.

Fixes #8735
2017-04-07 17:00:32 -07:00
Jason Simmons
8ee6525cc8 Remove the obsolete build apk --target-arch flag (#9239)
Gradle APK builds include engine binaries for all applicable architectures
2017-04-07 13:48:10 -07:00
Jason Simmons
67b3871e2a Filter Android logs by the pid of the remote process (#9293)
Fixes https://github.com/flutter/flutter/issues/6849
2017-04-07 13:41:29 -07:00
Alexandre Ardhuin
8bcf302e23 use conditional assignment (#9252) 2017-04-07 21:41:17 +02:00
Ian Hickson
3eb87830e9 Constants! Constants everywhere! (#9286)
Aggressively apply the const lint.
2017-04-07 12:24:32 -07:00
Ian Hickson
54bbb6fb4d SliverFill: s/size/extent/ as requested by abarth a while ago... (#9279) 2017-04-07 12:24:06 -07:00
Ian Hickson
6d5488ad3e Minor fixes to flutter packages. (#9278) 2017-04-07 12:23:57 -07:00
Chris Bracken
ecc590f958 Eliminate WidgetTester.idle() after enterText() (#9290)
enterText() now includes a call to idle().
2017-04-07 11:42:22 -07:00
Chris Bracken
a7a95daa52 Update TextEditingValue.selection on selection change (#9284)
Fixes a bug where tapping in the text under edit moved the cursor but
did not push the updated selection to the engine.

Adds a test for caret position updates.
2017-04-07 11:13:10 -07:00
Phil Quitslund
5b89c10105 Bump to Dart SDK 1.23.0-dev.11.6. (#9285)
Pulls in latest 1.23. cherry picks, including @abarth’s fix to restrict `@immutable` checks to instance fields.
2017-04-07 09:43:09 -07:00
Ian Hickson
c1bdf5e032 TextPainter control test (#9275) 2017-04-06 16:56:00 -07:00
Yegor
d538c11486 update devicelab docs (#9274) 2017-04-06 16:27:29 -07:00
Jason Simmons
bb0adcb873 Update version strings in Gallery (#9263)
Fixes https://github.com/flutter/flutter/issues/9259
2017-04-06 13:11:20 -07:00
Jason Simmons
e04376895d Handle tabs in rendering of licenses (#9264) 2017-04-06 13:11:06 -07:00
Adam Barth
470db7d96e TextField should update IME when controller changes (#9261)
Fixes #9246
2017-04-06 12:28:30 -07:00
Ryan Macnak
249bbac362 Support for placing an AOT dylib in the flx. Part of Fuchsia AOT sup… (#9240)
Support for placing an AOT dylib in the flx.  Part of Fuchsia AOT support.
2017-04-06 11:12:12 -07:00
Yegor
57ca2b5ce8 obey custom timeout supplied by cocoon (#9260) 2017-04-06 10:48:45 -07:00
David Yang
c96ab53b42 Allowing more flexibility to the active opacity of the Cupertino Button (#9071)
* Allowing overrides to the activeOpacity of the button

* adding tests

* fix

* fixing animation

* fixes

* moar fixes
2017-04-05 23:52:24 -07:00
Ian Hickson
9b5d1fbe1e Provide more widget const constructors. (#9247)
Still many more to go.
2017-04-05 23:39:07 -07:00
Adam Barth
93b90362fd Add more breadcrumbs in Notification docs (#9245)
Fixes #7519
2017-04-05 23:31:52 -07:00
Ian Hickson
2144a8964f Fill in the test for button color splash and highlights (#9224)
Fixes https://github.com/flutter/flutter/pull/8643

Fixes https://github.com/flutter/flutter/issues/8804 by adding a test
to verify that Material elevation changes animate.

Also tweak some dartdocs, add some trailing commas, improve some
toString output, make the inkwell test agnostic to the PhysicalModel
logic, and move the material buttons test to the material test
directory.
2017-04-05 22:46:58 -07:00
Adam Barth
954b35bf25 Add some more asserts to RenderFlex (#9209) 2017-04-05 22:46:43 -07:00
Ian Hickson
2f4835429b Better toStrings for Listenable subclasses (#9244) 2017-04-05 22:46:36 -07:00
Michael Goderbauer
18d69b1b3e Delete Color supported test :( (#9235) 2017-04-05 16:25:20 -07:00