3669 Commits

Author SHA1 Message Date
Devon Carew
4678c12098 find all repo packages (#3368)
* find all repo packages

* .dartignore
2016-04-15 20:25:57 -07:00
Hans Muller
c4ae13ed22 Refresh indicator (#3354) 2016-04-15 18:39:18 -07:00
Yegor
9ce995f65e [driver] refactor API to finder objects (#3365) 2016-04-15 16:57:35 -07:00
Ian Hickson
a91bc0ba9c Material Data Tables (#3337)
+ Add new demo to gallery to show data tables. (This currently doesn't
use a Card; I'll create a Card version in a subsequent patch.)

+ Fix checkbox alignment. It now centers in its box regardless.

+ Add Colors.black54.

+ Some minor fixes to dartdocs.

+ DataTable, DataColumn, DataRow, DataCell

+ RowInkWell

+ Augment dartdocs of materia/debug.dart.

+ DropDownButtonHideUnderline to hide the underline in a drop-down when
  used in a DataTable.

+ Add new capabilities to InkResponse to support RowInkWell.

+ Augment dartdocs of materia/material.dart.

+ Add an assert to catch nested Blocks.

+ Fix a crash in RenderBox when you remove an object and an ancestor
  used its baseline. (https://github.com/flutter/flutter/issues/2874)

+ Fix (and redocument) RenderBaseline/Baseline.

+ Add flex support to IntrinsicColumnWidth.

+ Document more stuff on the RenderTable side.

+ Fix a bug with parentData handling on RenderTable children.

+ Completely rewrite the column width computations. The old logic made
  no sense at all.

+ Add dartdocs to widgets/debug.dart.

+ Add a toString for TableRow.
2016-04-15 16:51:03 -07:00
Yegor
db2f66aab1 [test] make CommonFinders constructor private to disallow extensions (#3371) 2016-04-15 16:49:51 -07:00
Hans Muller
f7cf0d97ca Fix the progress indicator demo (#3367) 2016-04-15 16:21:38 -07:00
Ian Hickson
efbcb0aa0c Fix docs for Divider. (#3364)
Fixes https://github.com/flutter/flutter/issues/3363
2016-04-15 15:40:04 -07:00
Ian Hickson
b5e471eec5 Include the error runtimeType in the message. (#3355)
Fixes https://github.com/flutter/flutter/issues/3352
2016-04-15 15:15:52 -07:00
Ian Hickson
d348f28df7 Use the same logic in flushPaint as flushLayout (#3353)
If two repaint boundaries mark themselves dirty, but the second one is a
child of the first, then the second one will get repainted by the first
and then when we come to paint it directly, we get confused because it
isn't dirty any more.

We ran into this in layout before. Apply the same fix. Also, apply the
same fix to composition while we're at it.
2016-04-15 14:55:18 -07:00
Ian Hickson
d9ca22a397 have invokeFrameCallback print the right stack (#3351)
Exception stack variable was shadowing the function argument stack.
2016-04-15 13:18:37 -07:00
Ian Hickson
e41c1c0b06 Split services/ into services/ and foundation/ (#3350)
We're getting back to the point where we have a bunch of foundation APIs
and it's getting confusing having them mixed with services/.
2016-04-15 13:18:29 -07:00
Eric Seidel
711bf72620 Make update-packages cover dev/benchmarks.
update-packages only looks one level down, instead of
changing that, I'm just adding dev/benchmarks explicitly.

This will unbreak the bots which are dying trying to
flutter drive dev/benchmarks/complex_layout without
pub get having been run there.

@yjbanov @devoncarew
2016-04-15 12:35:02 -07:00
Ian Hickson
0f1dee5f46 Always dump (unwanted) exceptions during tests (#3344)
...even if the test fails.
2016-04-15 09:38:04 -07:00
Yegor
0e9737e4cc [driver] upgrade to the latest version of vm_service_client (#3348) 2016-04-14 23:23:45 -07:00
Yegor
86597cd10d [driver] lock vm_service_client
until we have a fix for the breaking changes
2016-04-14 16:26:17 -07:00
Yegor
d5d4e7c054 [driver] output per-frame build times in the timeline summary (#3334) 2016-04-14 11:28:16 -07:00
pq
de25ea22f7 Adding @optionalTypeArgs.
With the new dev build we've got the updated linter and so can use the `@optionalTypeArgs` annotation (in `meta 0.12.0`).

Bonus: this lets us clean up one more Regexp in the `analyze` command! :)
2016-04-14 10:03:46 -07:00
Yegor
f3a4f722c4 [flutter_test] new WidgetTester API based on finder objects (#3288) 2016-04-13 23:40:15 -07:00
Ian Hickson
a5a34d9704 AnimatedDefaultTextStyle (#3324) 2016-04-13 20:58:42 -07:00
Alhaad Gokhale
c40f4cfedb Merge pull request #3329 from alhaad/repaint_childview
Repaint child view on attach / detach.
2016-04-13 20:26:52 -07:00
Devon Carew
b172dd5a1a run pub for analyze and test (#3310)
* run pub for analyze and test

* don't run pub when doing repo analysis

* move logic for when to run pub into the commands

* re-write ternary expression
2016-04-13 19:55:28 -07:00
Alhaad Gokhale
6f9acb84ff Repaint child view on attach / detach. 2016-04-13 18:01:49 -07:00
Ian Hickson
571e2e84aa Stop importing identifiers we don't use. (#3314) 2016-04-13 14:42:07 -07:00
Ian Hickson
7861d02943 Fix dependency skew. (#3306)
...by adding tests to our examples that don't import flutter_test, which
pins the relevant dependencies.

Also, provide more information when complaining about leaked transient
callbacks in tests.

Also, make tests display full information when they have an exception,
by bypassing the throttling we have for Android logging in tests.

Also, make the word wrapping not wrap stack traces if they happen to
be included in exception output.

Also, fix a leaked transient callback in the checkbox code.
2016-04-13 13:53:39 -07:00
Eric Seidel
341bd47624 Move flutter drive to use 8183 to not conflict with diagnostic server
When @jason-simons added the diagnostic server on Android this
happened to conflict with flutter drive's usage of 8182.

We really should fix both of these port users to be dynamic
but this fixes https://github.com/flutter/flutter/issues/3291
for now.

@yjbanov
2016-04-13 11:22:38 -07:00
Devon Carew
dd81a21c93 small change to the generated dartdoc styles (#3290) 2016-04-13 10:04:35 -07:00
Ian Hickson
e1aaf39f82 Fix Block intrinsic functions (#3286)
* Fix Block intrinsic functions

* Update block_test.dart

Fix the test per travis
2016-04-13 09:35:10 -07:00
Ian Hickson
ecf1cce82c Provide details when reporting invalid constraints (#3281)
This also shrinks the width of the error messages a bit because now that
we use 'package:' URLs the stacks are a bit narrower.
2016-04-12 15:42:00 -07:00
Adam Barth
ec4a6a96f2 Add more dartdocs to material.dart (#3279) 2016-04-12 14:18:58 -07:00
Devon Carew
8d02f304cf update styles for the generated dartdocs (#3276)
* styles updates for the api docs

* update library docs

* use the new --favion and --use-categories options for dartdoc
2016-04-12 13:08:57 -07:00
Adam Barth
47715c5076 Add padding support to LazyBlock (#3272)
Also fill in some related dartdocs.
2016-04-12 13:05:44 -07:00
Adam Barth
d9b73a2b7a Improve docs about why we pin analyzer (#3254) 2016-04-12 12:42:14 -07:00
Adam Barth
69f994446b Add more dartdoc to material.dart (#3261)
Now past halfway though material.dart by files.
2016-04-12 12:41:59 -07:00
Jason Simmons
0f70464e1d Treat pointer cancel events similarly to pointer up events (#3242) 2016-04-12 11:17:43 -07:00
Hans Muller
ba5a04e85a ClampOverscrolls Inherited Widget (#3267)
* ClampOverscrolls Inherited Widget
2016-04-12 10:12:44 -07:00
Devon Carew
8849cd6b2d add a --deploy flag to build apk (#3249)
* add a --deploy flag to build apk

* update command description

* use an enum instead of a bool param for build variants

* rename buildForDeploy flag to buildVariant

* review comments
2016-04-12 09:21:17 -07:00
Devon Carew
b4173e20d4 fix to showing a progress display for long tasks (#3265) 2016-04-12 08:39:24 -07:00
pq
f270c3d069 Migrate enable-strict-call-checks flag to options file.
As per https://github.com/dart-lang/sdk/issues/25723, moves last command-line flag to `.analysis_options`.
2016-04-11 14:05:44 -07:00
Phil Quitslund
9b2d2ad9d2 Merge pull request #3245 from pq/lint_fixes
Analyze Command lint cleanup.
2016-04-11 13:17:59 -07:00
pq
937f0eaf12 Analyze Command lint cleanup.
The push to dev-4 allows us to cleanup a few more bits:
  * `api_docs` lint message special casing (lint fixed)
  * `allowedIdentifiersPattern` (lint fixed)
2016-04-11 11:18:15 -07:00
Devon Carew
2a33e3f0c0 make flutter upgrade less verbose (#3237)
* more terse flutter upgrade

* fix an issue when updating and the engine update code has changed

* call flutter precache; add a --no-color hidden option

* fix a lint related to getters/setters
2016-04-11 11:17:09 -07:00
Ian Hickson
47f5c6f2e0 Add even more careful checks around BoxConstraints (#3243)
I ran into a case where I was setting minHeight=∞ and then calling
layout() with that constraint, which is all kinds of bad. To try to
catch this earlier, this patch now provides a way to catch constraints
that are requiring infinite values.

We don't _always_ check this because there are valid uses for
BoxConstraints.biggest, e.g. as an additionalConstraint.
2016-04-11 11:10:11 -07:00
Seth Ladd
f43e1dfaff Fix instruction when app is missing enableFlutterDriverExtension (#3239) 2016-04-11 09:17:51 -07:00
Seth Ladd
3e661965c2 de-dupe API docs in flutter_driver (#3240) 2016-04-11 09:11:32 -07:00
Devon Carew
7ad1e38eac Fix windows crash (#3236)
* better messaging about windows support

* fix lints
2016-04-11 08:34:01 -07:00
Devon Carew
26906240e5 fix an issue parsing adb devices (#3235) 2016-04-11 07:50:03 -07:00
krisgiesing
504610791f Update wording on viewport test (#3228) 2016-04-08 23:52:52 -07:00
stevemessick
8847b86681 Add validity checks to create (#3215)
* Add validity checks to create

* Adjust indent
2016-04-08 20:37:50 -07:00
Hans Muller
d9e0c32da2 Remove ScrollableListPainter (#3226)
* Remove ScrollableListPainter
2016-04-08 17:08:35 -07:00
Hans Muller
df0a9fc179 Scrollbar cleanups (#3229) 2016-04-08 16:45:54 -07:00