9498 Commits

Author SHA1 Message Date
Seth Westphal
71a15896d8 Fix error message and other typos (#25126) 2019-01-15 19:22:32 -08:00
Michael Goderbauer
f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Michael Goderbauer
e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 (#26596) 2019-01-15 19:00:05 -08:00
Gary Qian
fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson
29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00
Chris Bracken
d7458e3da4
Add asserts for @required parameters (#26449)
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:

  package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.

becomes:

  package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
2019-01-15 10:24:06 -08:00
Igor Borges
9880baa396 Add flutter_shared assets to module artifact (#23782)
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
2019-01-15 10:23:19 -08:00
Amir Hardon
cbff7ca43c
Cleanup temporary catchError. (#26454)
This was added to make sure we don't crash before the engine is rolled
with the system channel API addition and is no longer needed.
2019-01-15 10:13:48 -08:00
tonyzhao1
3f3a829c88 Move runner directory messages to the user messages class (#25682) 2019-01-15 10:06:44 -08:00
Dan Field
f0620f4776
add type parameter back to PageRouteFactory (#26559) 2019-01-15 10:01:37 -08:00
Dan Field
774e8c18e3
remove ignore_for_file lints (#26545)
* remove ignore_for_file lints

* update comments

* remove example
2019-01-15 08:42:47 -08:00
Dan Field
025d04ad52
remove todo (#26562) 2019-01-15 08:42:12 -08:00
Hans Muller
a152a2097c
Deprecate Scaffold resizeToAvoidBottomPadding, now resizeToAvoidBottomInset (#26259) 2019-01-15 08:16:49 -08:00
Jonah Williams
3a694a6d5d
desktop workflow, devices, and test (#26511) 2019-01-15 07:45:04 -08:00
Danny Tuppeny
fda193aa5d
Fix+unskip flutter test expression eval tests (#26579)
* Fix `flutter test`e xpression eval tests

We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.

* Ensure we wait for breakpoints before trying to evaluate
2019-01-15 15:39:35 +00:00
Jason Simmons
cf4c903144
Update compileSdkVersion in the Android app templates to Android P (#26444)
Fixes https://github.com/flutter/flutter/issues/25703
2019-01-14 16:16:12 -08:00
Justin McCandless
de2470ffa4
InputDecorator Count Widget (#25095)
* Allow a widget to be specified for the textfield count, and allow no count at all

* Test all possible states for counter and counterText

* Docs for counter

* counter is a function that generates a widget

* Tests use counter as function

* Fix analyze error in docs

* InputDecoration has counter widget, TextField has buildCounter function

* InputDecorator tests expect counter to be widget again and include
buildCounter

* counter widget example that might actually fit

* Clarify accessiblity concerns in docs

* Include isFocused param for accessibility

* Fix analyze error

* Improve docs per code review

* Rearrange getEffectiveDecoration a bit for clarity

* Fix analyze error about hashValues params

* Clean up docs and redundant code per code review

* Code review doc improvement

* Automatically wrap buildCounter widget in a Semantics widget for accessibility
2019-01-14 15:22:42 -08:00
Ian Hickson
567db6f0d4
Improved positioning of leading and trailing widgets in overflowing ListTiles (#24767) 2019-01-14 12:39:43 -08:00
Alexander Aprelev
07e06171ba
Report overall and transfer timings as part of hot reload statistics, analytics. (#26537) 2019-01-14 12:23:09 -08:00
jslavitz
4377083810
Selects a word on force tap (#25683)
* adds force press select word functionality
2019-01-14 10:29:51 -08:00
Danny Tuppeny
150079db6e
Skip flutter test expression eval tests (#26519)
See https://github.com/flutter/flutter/issues/26518.
2019-01-14 15:21:06 +00:00
Ian Hickson
3ee473c587
Make decodeImageFromList mockable (#25864) 2019-01-13 21:02:46 -08:00
Jason Simmons
8efd6c1a21
Add a manifest for profile builds that enables INTERNET permission (#26450)
Profile builds need access to sockets in order to launch the Dart
observatory server.

This permission used to be enabled by default in all build types,
but was moved to a build type specific manifest in
88b853f7eb
2019-01-11 18:19:17 -08:00
Greg Spencer
141d6e1394
Add support for detecting which modifier keys have been pressed on RawKeyboardEvents (#26265)
This adds some functions to the interface for RawKeyEventData and all subclasses that allow the recipient of an event to determine which modifier keys are currently being pressed without needing to know the specific modifier bitmasks for the platform.

Also adds constants for the modifier bitmasks for each platform, for completeness (and because I needed them anyhow to implement the above).

Added tests for the RawKeyEventData subclasses, and modified the raw_keyboard manual test app to show modifier keys being pressed. I also separated the different platform-specific subclasses into separate files.

Fixes #26155.
2019-01-11 13:41:45 -08:00
Dan Field
8af3e480a9
Revert "move analysis_options to package" (#26436)
* Revert "move analysis_options to package (#26244)"

This reverts commit d4d1b29a35d7ab83bae77890ac8f46863adfbd37.
2019-01-11 13:38:02 -08:00
Andrei Lesnitsky
88b853f7eb move INTERNET permission to debug/AndroidManifest.xml (#22139) 2019-01-11 07:45:49 -08:00
Dan Field
d4d1b29a35
move analysis_options to package (#26244)
* move analysis_options to package
2019-01-10 18:53:01 -08:00
Chris Bracken
88b77a7d0f
Avoid use of ParagraphConstrains const ctor (#26392)
Usages of ParagraphConstraints (from dart:ui) whose constructor could be
const as of flutter/engine#7346 are currently marked //
ignore:prefer_const_constructors in the framework until all
Google-internal embedders have been updated to an engine version that
includes the above change. These were initially updated in engine roll
flutter/flutter#26252, but broke internal embedders.

We should re-enable use of the const constructor in those cases once
internal embedders are updated.

See: https://github.com/flutter/flutter/issues/26390
2019-01-10 17:25:24 -08:00
Stanislav Baranov
585e23173a
Friendlier flutter tool messages for dynamic mode (#26378) 2019-01-10 16:07:50 -08:00
Michael Klimushyn
5293fef26d
Deprecate the animated image frame cache (#26385)
Disables the cache by default and deprecates the API for setting its
size.

flutter/flutter#26081
2019-01-10 15:07:57 -08:00
Jonah Williams
83af6f48d6
Adds a type parameter to invokeMethod (and additional utility methods) (#26303) 2019-01-10 13:21:03 -08:00
Greg Spencer
dca8d36d62
Change flutter create to use master-docs.flutter.io instead of firebase URL. (#25516)
Now that we have our DNS mapping we should refer to the master docs site that way everywhere.
2019-01-10 12:55:57 -08:00
Michael Goderbauer
b13eacc717
Fix Listenable.merge to not leak (#26313) 2019-01-10 12:17:45 -08:00
Sander Dalby Larsen
6c6fdaff81 Added the superellipse (a.k.a. squircle) shape to flutter. (#26295)
* Added the superellipse (a.k.a. squircle) shape to flutter, which is needed to recreate some cupertino components, e.g. buttons in pixel-perfect detail (issue #13914).
2019-01-10 12:17:01 -08:00
Danny Tuppeny
1a0481591d
Add some basic tests for evaluating expressions in flutter test (#24513)
* Add some basic tests for evaluating expressions in `flutter test`

* Review tweaks
2019-01-10 15:33:59 +00:00
MH Johnson
090c3bcd0e
[Material] Bottom app bar theme (#24156)
* [WIP] BAB theme

* [WIP] BAB theme

* Update goldens

* Extract helper function in tests

* Update Goldens version

* Add tests

* [WIP] Hans first round comments

* Added test

* Added docs

* Hans second round comments

* Fixed analyzer error

* Hans third round comments

* ambient

* Change [BottomAppBarTheme.of] to static

* Final doc change
2019-01-10 10:19:35 -05:00
Danny Tuppeny
b16ef489e0
Add a validator to ensure NO_PROXY is set correctly if HTTP_PROXY is set (#25974)
* Add a validator to ensure NO_PROXY is set correctly if HTTP_PROXY is set

Fixes #24854.

* Fix typo

* Dummy edit to try and force update of PR desc on Cirrus
2019-01-10 07:47:29 +00:00
Dan Field
e19851191a
Revert "Check for duplicative Flutter.framework emeddings when building for Xcode 10" (#26339)
* Revert "Check for duplicative Flutter.framework emeddings when building for Xcode 10 (#23188)"
2019-01-09 19:34:14 -08:00
Stanislav Baranov
e2c0349157
Add logic for creating rollback dynamic patches. (#26312)
Before this change, rolling back a patch relied on deleting the patch
file from the server completely. This PR implements a more reliable
approach where developer needs to create a physical rollback patch file.
This is more robust to mistakenly taking down a patch from user devices.
2019-01-09 16:43:03 -08:00
Marco Scannadinari
c486bdb6f5 Add new curve animations to class documentation (#26290) 2019-01-09 14:55:05 -08:00
Tim Sneath
c944d88788
Add link to Flutter brand guidelines (#26257) 2019-01-09 14:52:29 -08:00
Andrew Davies
bd6ac326f6
[flutter_driver] Move Fuchsia logging code. (#26266)
When setting the Fuchsia logging function, it should happen before any
initialization code, as init can still cause warning/error/info messages
to get printed to logs. Since the default stderr/stdout fd's aren't
correct, this can cause a program to crash for unclear reasons.
2019-01-09 14:47:35 -08:00
Dan Field
75ebce1c0c
Update docs for editable_text (TextField) (#26269)
* update docs for editable_text (TextField)

* typo, clarify behavior when lines > 1
2019-01-09 14:44:42 -08:00
Dan Field
bc28a220c9
Check for duplicative Flutter.framework emeddings when building for Xcode 10 (#23188)
* Check for bad configuration in Xcode10
2019-01-09 14:43:49 -08:00
matthew-carroll
517f8dc279
Add consumedScrollExtent to SliverConstraints as reported by Viewport (#24551) 2019-01-09 12:34:54 -08:00
kongshanshan33
305ab1a35b Fix project directory has spaces lead to compile error when use 'flutter create -t module'command (#23817) 2019-01-09 11:18:40 -08:00
Sean Freiburg
0468742910 Fix flutter root error message string interpolation (#24944)
The variable isn't interpolating because it's using "${}" when ruby uses "#{}".
2019-01-09 10:57:20 -08:00
jslavitz
cea4aa9b7b
Teach drag start behaviors to DragGestureRecognizer (#26246)
* the onStart callback will report the location of the pointer where it wins the gesture arena by default instead of the pointer down location. Fixes all tests related to changing this default value.
2019-01-09 10:53:47 -08:00
jxltom
843f26207f Do not ignore pubspec.lock in project templates (#24209)
* Remove *.lock from gitignore

* Remove pubspec.lock from gitignore
2019-01-09 10:10:38 -08:00
Jonah Williams
a2fa98ebaf
Add polling module discovery for Fuchsia (#24994) 2019-01-09 09:28:31 -08:00