13172 Commits

Author SHA1 Message Date
Danny Tuppeny
244b077bee
Give integration tests unique temp folder names (#26227)
This will help track down any that aren't cleaning up and also may help track down leaked flutter_tester processes (https://github.com/dart-lang/sdk/issues/35549).
2019-01-17 11:29:18 +00:00
Dan Field
c74b59a5b8
Roll engine back to 1e93a8eb39d79f643952737aa4fc31e1787a5a17 (#26694) 2019-01-17 00:31:56 -08:00
engine-flutter-autoroll
9b60ad4cd8
Roll engine 3c0aa918de87..25559ed07796 (11 commits) (#26683)
3c0aa918de...25559ed077

git log 3c0aa918de8782ed73b12fc148c4ab7cb6ed1416..25559ed0779604d56c47c5d2341ffd16b137cd10 --no-merges --oneline
25559ed07 Wrap the user entrypoint function in a zone with native exception callback. (flutter/engine#7512)
1b0d09b21 Roll src/third_party/dart f701e11756..700254996f (5 commits) 700254996f [ Observatory / Dartium ] Updated observatory documentation and tests to remove references to Dartium. 78abb98ee7 [vm/bytecode] Fix AST removal for package-split kernel files with bytecode 0075b58bb8 CHANGELOG entry for DEPRECATED_MEMBER_USE split a5f102a7d1 Analyzer: first pass at reporting unchecked nullable value usage. a10ddca1b1 [ VM / Service ] Allow for `profile_period` flag to be set via the service protocol
e7ade51da Remove unused headers (flutter/engine#7511)
369b4db35 Roll src/third_party/skia 1374c85fbf53..081e6f375497 (6 commits) (flutter/engine#7510)
366d44e11 Roll src/third_party/dart 9b5eabdaca..f701e11756 (10 commits) f701e11756 [ VM / Debugger ] Fix issue where a 'Step' command issued when there's no stack caused a crash. c5bfccc6fb Make downloading the LSP spec a flag and commit the version parsed locally dbeec3bbf3 Fix formatting in generated LSP file header bfe15d87d8 Fix LSP exceptions serializing ResponseErrors with Uris 7984dc4fcc Prepare to publish analyzer version 0.34.2. 4b1b2f9176 Switch LSP formatter to not fetch resolved ASTs that aren't used 5ce5d697da Implement LSP code folding b47524d5b0 Ensure all unhandled exceptions are recorded on the server 8ba2de2344 Sort context for conflicting inherited members 215f6620e7 [Kernel] Signal errors on static fields in constant contexts
1e93a8eb3 Deprecate FlutterProjectArgs.main_path, packages_path (flutter/engine#7497)
b058920ca Edit the bundleid so that it conform to UIT specifications. (flutter/engine#7503)
32c9ae616 Roll src/third_party/skia 2c379d8e27e6..1374c85fbf53 (4 commits) (flutter/engine#7508)
96d10b184 Roll src/third_party/dart 492df72739..9b5eabdaca (8 commits) 9b5eabdaca Fix crash in color support a533753bec Remove --fast-startup flag support from testing scripts and status files 5f10aed19c [Kernel] Don't print static fields in instance constants bdb51e2837 Improve input path handling and remove extra schemas. 0604110806 Reduce expectations on thrown exception 966e007b63 Pass CallStructure on dynamic and static use in ResolutionWorldBuilder 3e7801294e Remove unneeded code in OrderedTypeSet 8a91948c03 [Kernel] Properly signal compilation errors for constants
770984088 Roll src/third_party/skia a8694cc150a1..2c379d8e27e6 (1 commits) (flutter/engine#7506)
046ddc68d Roll src/third_party/skia 47b7cd9a6baf..a8694cc150a1 (1 commits) (flutter/engine#7504)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-01-16 23:34:39 -05:00
Jonah Williams
83b9497c69
do not exit tool if fuchsia workflow fails (#26589) 2019-01-16 17:43:01 -08:00
Ian Hickson
800a6e1670 Quick fix for tap-to-show-keyboard regression (#26629)
* Fixes Android keyboard bug
2019-01-16 17:30:26 -08:00
Dan Field
4c99958df6
Revert "Move flutter_assets to App.framework (#26630)" (#26675)
This reverts commit d8db70af1a9b43e17a0b94fe096f464c49484cfb.
2019-01-16 16:46:37 -08:00
Luca Zuccarini
36a493602c Create an injectable factory for application packages. (#26422) 2019-01-16 14:12:47 -08:00
Dan Field
d8db70af1a
Move flutter_assets to App.framework (#26630)
* move flutter_assets to App.framework

* remove flutter_assets references from all pbxproj files checked in
2019-01-16 14:02:54 -08:00
Vyacheslav Egorov
8f65ee9f53
Fix --build-shared-library on newer NDKs (#26642)
Newer NDKs switched to clang which by default uses system linker, instead
we need to force it to use appropriate toolchain linker by passing
-fuse-ld= command line flag.

Fixes #23458
2019-01-16 21:30:37 +01:00
Kenzie Schmoll
a172de0159
Send ServiceExtensionToggled event when service extension is set to a value. (#26426) 2019-01-16 12:29:20 -08:00
Vyacheslav Egorov
7c434a5cf2
Revert "Add flutter_shared assets to module artifact (#23782)" (#26644)
This reverts commit 9880baa3964789674ad265e18cbc448ec23e0b76.

Reason for revert: broke `--local-engine` command line option.
2019-01-16 21:23:18 +01:00
Kyrel Jerome
a0f58c5e7a Grammatical fix: "places" to "placed" (#26482) 2019-01-16 10:43:29 -08:00
Chris Bracken
9a7b1a73bd
Replace platform check with swtich (#24752)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-16 10:31:44 -08:00
MH Johnson
5e8e39723d
[Material] TabBarTheme text style parameters (#26533)
* Add labelStyle + unselectedLabelStyle to TabBarTheme
2019-01-16 13:30:21 -05:00
Michael Goderbauer
e4c8f1b993
3D SemanticsTree (#25670) 2019-01-16 10:29:00 -08:00
Justin McCandless
14faa8d935
Fix rounding error in build tests (#26652) 2019-01-16 09:48:04 -08:00
Michael Goderbauer
b4e9d0a440
Add tests for getOffsetToReveal on RenderSlivers (#26598) 2019-01-16 08:47:37 -08:00
rami-a
f22043e25f
Prevent crash when calling lerp for IconThemeData with null arguments (#26592)
The lerp method for IconThemeData was not doing anything to prevent exceptions when null arguments are used. This change fixes that and adds a test for it.
2019-01-16 11:42:29 -05:00
Hans Muller
14f486685e
Updated AlertDialog content doc (#26613) 2019-01-16 08:35:51 -08:00
Hans Muller
fbedd97682
IconButton backgroundColor doc sample (#26611) 2019-01-16 08:35:34 -08:00
engine-flutter-autoroll
b576e093d1
3c0aa918d Roll src/third_party/dart 2195a70249..492df72739 (2 commits) 492df72739 Fix fasta test under windows 4ec9dbf1d0 Add set literal spread collection parsing support (#26645)
09e149e897...3c0aa918de

git log 09e149e89787fb0722b8a43ec5406e66d6901eec..3c0aa918de8782ed73b12fc148c4ab7cb6ed1416 --no-merges --oneline
3c0aa918d Roll src/third_party/dart 2195a70249..492df72739 (2 commits) 492df72739 Fix fasta test under windows 4ec9dbf1d0 Add set literal spread collection parsing support

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-01-16 11:34:40 -05:00
Justin McCandless
105026cd68
Fix descenders cutoff in TextField (#26309)
* Include caret gaps in position calculation to avoid descender cutoff

* Calculate caret offset instead of exposing it

* Test that textfields scroll vertically by full line height

* Only add offset to end of caret to avoid going above 0.0

* Fix and test horizontal vs. vertical scrolling

* CR: docs and top caret offset logic

* Take max instead of assuming caretRect.top is always a full line down

* Always subtract caretOffset from caretTop since caretRect.top can be negative
2019-01-16 08:13:00 -08:00
engine-flutter-autoroll
c20db6689c
Roll engine fdfb0e72f0af..09e149e89787 (3 commits) (#26633)
fdfb0e72f0...09e149e897

git log fdfb0e72f0af7b4de3f8cd04ca8519ba5acc12fe..09e149e89787fb0722b8a43ec5406e66d6901eec --no-merges --oneline
09e149e89 Roll src/third_party/skia 98c65fc9558f..47b7cd9a6baf (4 commits) (flutter/engine#7501)
87e8d3059 Roll src/third_party/dart d9944433af..2195a70249 (28 commits) 2195a70249 Make sure that path is correct on all test platforms 56f87f409e [dart:io,fuchsia] Pass Isolate namespace to child process. Fix double free. b55bc09f1f Add list literal spread collection parsing support 4074ebd0a0 Partial implementation of the unified specification of definite assignment, type promotion, and reachability analysis. 43a96d49af Revert "[vm/compiler] AOT inline heuristics improvements" a55b6fc183 Remove unused import 2908e61f2a [vm/compiler] AOT inline heuristics improvements 3154bb0d37 Stop using external deprecated members in front_end ff06d233aa Set CompletionSuggestion.elementUri everywhere in analysis server that element is already being set. 23f427b1a7 Reland [VM/Compiler] Removing definition status from Store{Indexed,InstanceField}. edca6169c1 Fixed a number of dart:html P1 issues. ff5e5b6896 Regenerate LSP classes from spec + update README 116f678a69 [build] Enable mitigations for Cortex-A53 Erratum #843419 bug. 21edbbbac6 Add spread collection token to scanner 030fa85cea Fix windows tests 23b5aee978 Update dartfix NNBD to handle more situations fe6b384ff5 revise dartfix protocol version check 61e81217f0 Update LSP status doc (rename is complete + tested in VS Code) daead8dff8 Add test for LSP rename that edits multiple files bdade89081 Improve testing of document versions in LSP renames ecc1411685 Print constant table when printing libraries. 999c2a7582 Check for conflict with static members 3f44bd1bf9 Check for conflicts in mixins aa59b20b4b Don't report conflicts twice 3ef8c296bd Improve detection of conflicts with inherited members and setters 50fa633c4a Report InheritedMembersConflict correctly c25c30dc32 Remove some unused imports c6ab52c9f9 Using the right conjunction
6c68bf3ca Revert "Revert "Add elevation and thickness to SemanticsNode (#7282)" (#7483)" (flutter/engine#7484)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-01-16 03:43:48 -05:00
engine-flutter-autoroll
684d050791
Roll engine 5983e34a3c0e..fdfb0e72f0af (2 commits) (#26620)
5983e34a3c...fdfb0e72f0

git log 5983e34a3c0e1217da7e8bbe9f2fe685048fe259..fdfb0e72f0af7b4de3f8cd04ca8519ba5acc12fe --no-merges --oneline
fdfb0e72f Roll src/third_party/skia cb7149e05864..98c65fc9558f (3 commits) (flutter/engine#7498)
5401803f6 Validate dynamic patches before attempting to install (flutter/engine#7496)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop
the roller if necessary.
2019-01-16 01:01:51 -05:00
Chris Bracken
584ef083c7
Replace Android-specific check with switch (#24754)
Generally, we should always use default-less switches for
platform-specific behaviour so we're forced to make a conscious decision
on each instance of such behaviour any time we add support for a new
platform.
2019-01-15 19:42:55 -08:00
Seth Westphal
71a15896d8 Fix error message and other typos (#25126) 2019-01-15 19:22:32 -08:00
Michael Goderbauer
f3f2d5a1bd
Remove TODO, reduce tech debt (#26612)
I fixed this TODO a while ago during my a11y work.
2019-01-15 19:06:07 -08:00
Michael Goderbauer
e8bfa81b70
Roll engine to 5983e34a3c0e1217da7e8bbe9f2fe685048fe259 (#26596) 2019-01-15 19:00:05 -08:00
Gary Qian
fc779c69a7
Add Golden test for background painting order. (#25988) 2019-01-15 19:40:39 -05:00
Ian Hickson
29928a46ed
Support setting the elevation of disabled floating action buttons (#24728)
Previously, a disabled floating action button always had zero
elevation, which looks dumb.

This also fixes the issue whereby highlightElevation was not honoured
on floating action buttons.

This also fixes an issue I found during testing whereby setState was
being called during build when onHighlightChanged fired due to
onPressed becoming null while a gesture is ongoing (which triggers an
onTapCancel synchronously during build).
2019-01-15 15:06:29 -08:00
Chris Bracken
d7458e3da4
Add asserts for @required parameters (#26449)
Adds asserts on required constructor parameters to a transition widgets.
This improves debuggability for those who aren't developing with live
analysis. e.g. when `turns` is not specified in a RotationTransition
constructor:

  package:flutter/src/widgets/transitions.dart: Failed assertion: line 43 pos 15: 'listenable != null': is not true.

becomes:

  package:flutter/src/widgets/transitions.dart': Failed assertion: line 259 pos 15: 'turns != null': is not true.
2019-01-15 10:24:06 -08:00
Igor Borges
9880baa396 Add flutter_shared assets to module artifact (#23782)
copySharedFlutterAssetsTask copies the `flutter_shared` folder assets to android's `src/main` folder of Flutter project, so that folder is bundled on the generated AAR
2019-01-15 10:23:19 -08:00
Amir Hardon
cbff7ca43c
Cleanup temporary catchError. (#26454)
This was added to make sure we don't crash before the engine is rolled
with the system channel API addition and is no longer needed.
2019-01-15 10:13:48 -08:00
tonyzhao1
3f3a829c88 Move runner directory messages to the user messages class (#25682) 2019-01-15 10:06:44 -08:00
Dan Field
f0620f4776
add type parameter back to PageRouteFactory (#26559) 2019-01-15 10:01:37 -08:00
Dan Field
774e8c18e3
remove ignore_for_file lints (#26545)
* remove ignore_for_file lints

* update comments

* remove example
2019-01-15 08:42:47 -08:00
Dan Field
025d04ad52
remove todo (#26562) 2019-01-15 08:42:12 -08:00
Hans Muller
a152a2097c
Deprecate Scaffold resizeToAvoidBottomPadding, now resizeToAvoidBottomInset (#26259) 2019-01-15 08:16:49 -08:00
Jonah Williams
3a694a6d5d
desktop workflow, devices, and test (#26511) 2019-01-15 07:45:04 -08:00
Danny Tuppeny
fda193aa5d
Fix+unskip flutter test expression eval tests (#26579)
* Fix `flutter test`e xpression eval tests

We weren't passing `beforeStart` through so the breakpoints were never being set, which means the evaluations were happening while the code was running.

* Ensure we wait for breakpoints before trying to evaluate
2019-01-15 15:39:35 +00:00
Jonathan Wilbur
c713ef971e Added key.properties and *.jks to .gitignore to prevent sensitive commits (#25413) 2019-01-15 02:51:17 -08:00
Janice Collins
4007ff6ee2
Update dartdoc to 0.28.0 and add flags to constrain warnings (#26546) 2019-01-14 16:18:17 -08:00
Jason Simmons
cf4c903144
Update compileSdkVersion in the Android app templates to Android P (#26444)
Fixes https://github.com/flutter/flutter/issues/25703
2019-01-14 16:16:12 -08:00
Justin McCandless
de2470ffa4
InputDecorator Count Widget (#25095)
* Allow a widget to be specified for the textfield count, and allow no count at all

* Test all possible states for counter and counterText

* Docs for counter

* counter is a function that generates a widget

* Tests use counter as function

* Fix analyze error in docs

* InputDecoration has counter widget, TextField has buildCounter function

* InputDecorator tests expect counter to be widget again and include
buildCounter

* counter widget example that might actually fit

* Clarify accessiblity concerns in docs

* Include isFocused param for accessibility

* Fix analyze error

* Improve docs per code review

* Rearrange getEffectiveDecoration a bit for clarity

* Fix analyze error about hashValues params

* Clean up docs and redundant code per code review

* Code review doc improvement

* Automatically wrap buildCounter widget in a Semantics widget for accessibility
2019-01-14 15:22:42 -08:00
Greg Spencer
35fcd9077f
Narrow regexp for import search in bot's analyze script. (#26539)
This was causing analysis to fail when there was an import statement in a comment, such as when snippets add imports to their examples.

I narrowed the RegExp to match only those lines which aren't commented out, but it really should probably be using the analysis server to catch all cases (e.g. if someone put the doc comment into /** */ comments, it could still match). Since this is a Flutter-specific script, it's probably not worth doing that.
2019-01-14 13:49:50 -08:00
Ian Hickson
567db6f0d4
Improved positioning of leading and trailing widgets in overflowing ListTiles (#24767) 2019-01-14 12:39:43 -08:00
Alexander Aprelev
07e06171ba
Report overall and transfer timings as part of hot reload statistics, analytics. (#26537) 2019-01-14 12:23:09 -08:00
engine-flutter-autoroll
d22cc77d27
fea645b80 update site to use SkFont for text fields (flutter/engine#7464) (#26536)
e68a3fa912...fea645b801

git log e68a3fa912cd1ba0e2aaf1f87e7abdec96e68aee..fea645b801343c8a103bc0ff66539f40ef57321a --no-merges --oneline
fea645b80 update site to use SkFont for text fields (flutter/engine#7464)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
2019-01-14 14:14:48 -05:00
jslavitz
4377083810
Selects a word on force tap (#25683)
* adds force press select word functionality
2019-01-14 10:29:51 -08:00
engine-flutter-autoroll
35a7fd1252
Roll engine 17a90fbe8f23..e68a3fa912cd (4 commits) (#26534)
17a90fbe8f...e68a3fa912

git log 17a90fbe8f23b6efb97c322e5ea67a0a55f4de0e..e68a3fa912cd1ba0e2aaf1f87e7abdec96e68aee --no-merges --oneline
e68a3fa91 Roll src/third_party/dart b0855ffd35ad4878fb3b36d8f5ff00a421719e7c..1c9eb3cef80779601f964b05a68a785bf49b084f (1 commits) 1c9eb3cef8 [Kernel] Allow constant declarations without an initializer
386cb4859 Roll src/third_party/skia 33f58abef2b7..da068c0d1d7c (1 commits) (flutter/engine#7462)
6f89a132d Roll src/third_party/dart f81dd1da9f9f879c17dda7b20a2572fa5549f3dd..b0855ffd35ad4878fb3b36d8f5ff00a421719e7c (4 commits) b0855ffd35 [infra] Fix testing on Android 8d9247b9fc dartfix README 7b5f24db6f Change wiki link to follow contents moved. 6f4e85d11f [dart2js js_runtime] Run dartfmt --fix-doc-comments
82bb5f7c8 Roll src/third_party/skia 60a2f675ddce..33f58abef2b7 (1 commits) (flutter/engine#7460)

The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff (cbracken@google.com), and stop
the roller if necessary.
2019-01-14 13:00:48 -05:00