Todd Volkert
52fc807dd2
Remove references to HttpClientResponseCompressionState ( #33792 )
...
https://github.com/flutter/flutter/issues/33791
2019-06-03 14:53:43 -07:00
Chris Bracken
2467c528f5
Roll engine 69ebe5fb28fc..a4b7d1c2895d (3 commits) ( #33697 )
...
69ebe5fb28..68a3ca46b4#9158 )
68a3ca46b Roll src/third_party/dart 445a23a9bc..0e6b74543c (29 commits) (#9159 )
1d1cff1fa Roll src/third_party/skia 3cd435eecf5e..09f5aedf2cc8 (3 commits) (#9160 )
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff (cbracken@google.com ), and stop
the roller if necessary.
2019-05-31 21:17:43 -07:00
Harry Terkelsen
13e9bfcc94
Add binaryMessenger constructor argument to platform channels ( #30406 )
...
* Deprecates `BinaryMessages` in favor of a default instance of `BinaryMessenger`, called `defaultBinaryMessenger`
* Platform channels use the `defaultBinaryMessenger` for their binaryMessenger default argument.
2019-05-28 11:18:22 -07:00
Sam Rawlins
c2a93bd545
Fix missing return statements on function literals ( #33058 )
2019-05-20 12:51:57 -07:00
Todd Volkert
1f2972c7b6
Prepare for API addition to HttpClientResponse ( #32834 )
...
https://github.com/dart-lang/sdk/issues/36971
2019-05-17 10:44:08 -07:00
Greg Spencer
a5053bfb29
Fix transforms for things with RenderPointerListeners ( #32535 )
...
This fixes #32525 , because it now marks the compositing bits as needing to be recalculated if the mouse tracker changes its idea of whether or not a mouse is attached.
This bug occurred because the test framework was leaking state from one test to the next (the state about whether a mouse pointer was active), and so even though there was a "passing" test when run in order with the other tests in the file, when the test was run individually (or first), it would have failed and caught the bug.
This adds an assert to make sure that after each test there are no simulated mouse pointers connected, and now calls removePointer in all of the tests where this was a problem.
2019-05-13 15:48:12 -07:00
Jacob Richman
63aa5b3647
Refactor core uses of FlutterError. ( #30983 )
...
Make FlutterError objects more structured so they can be displayed better in debugging tools such as Dart DevTools.
2019-05-01 11:20:12 -07:00
chunhtai
e2dfd73c2e
only build asset when there is asset declared in pubspec ( #31804 )
2019-04-30 16:03:47 -07:00
Greg Spencer
7775c23784
[Re-Land] Implement focus traversal for desktop platforms. ( #31614 )
...
This re-lands the Focus changes in #30040 . Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.
Addresses #11344 , #1608 , #13264 , and #1678
Fixes #30084
Fixes #26704
2019-04-25 16:26:58 -07:00
sjindel-google
e84b4c47b8
Allow all tests to run with --update-goldens. ( #31562 )
...
Previously benchmark_test.dart would break if run with --update-goldens.
Now the entire test suite can be run with --update-goldens.
2019-04-25 17:13:26 +02:00
Greg Spencer
590cc27b31
Revert "Implement focus traversal for desktop platforms, shoehorn edition. ( #30040 )" ( #31461 )
...
This reverts commit 4218c0bc38bc74a97b1b03d7b8b7f0ce32e29468.
2019-04-22 18:02:35 -07:00
Greg Spencer
4218c0bc38
Implement focus traversal for desktop platforms, shoehorn edition. ( #30040 )
...
Implements focus traversal for desktop platforms, including re-implementing the existing focus manager and focus tree.
This implements a Focus widget that can be put into a widget tree to allow input focus to be given to a particular part of a widget tree.
It incorporates with the existing FocusScope and FocusNode infrastructure, and has minimal breakage to the API, although FocusScope.reparentIfNeeded is removed, replaced by a call to FocusAttachment.reparent(), so this is a breaking change:
FocusScopeNodes must now be attached to the focus tree using FocusScopeNode.attach, which takes a context and an optional onKey callback, and returns a FocusAttachment that should be kept by the widget that hosts the FocusScopeNode. This is necessary because of the need to make sure that the focus tree reflects the widget hierarchy.
Callers that used to call FocusScope(context).reparentIfNeeded in their build method will call reparent on a FocusAttachment instead, which they will obtain by calling FocusScopeNode.attach in their initState method. Widgets that own FocusNodes will need to call dispose on the focus node in their dispose method.
Addresses #11344 , #1608 , #13264 , and #1678
Fixes #30084
Fixes #26704
2019-04-22 09:51:40 -07:00
chunhtai
b275e11170
fix issue 12999: Make assets available during tests ( #31207 )
2019-04-18 15:31:47 -07:00
Dan Field
330dc94c0f
Check that ErrorWidget.builder is not modified after test ( #30898 )
2019-04-15 12:38:51 -07:00
Sam Rawlins
83ddd98849
Fix additional @mustCallSuper indirect overrides and mixins ( #30667 )
2019-04-10 14:54:51 -07:00
Alexandre Ardhuin
bfa1d25bf9
some formatting of map, parameters and spaces ( #29760 )
2019-03-23 00:02:21 +01:00
Alexandre Ardhuin
a0d1f93b07
fix block formatting ( #29051 )
2019-03-09 09:03:11 +01:00
Gary Qian
8f1a430557
Initialize the lifecycle state with initial state in window. Roll engine (19 commits) ( #28688 )
...
git log --oneline --no-merges f4951df193a7966f9ed4da43d555eee0913d84d1..a48cd16e077778a7aa5908e4faa4da07714260f2
a48cd16e0 Update a11y word forward/back enum names (https://github.com/flutter/engine/pull/8073 )
b5f59ed89 Delay the vsync callback till the frame start time specified by embedder. (https://github.com/flutter/engine/pull/8072 )
7426305f5 Mark const extern (https://github.com/flutter/engine/pull/8077 )
d3f6d7a21 only partial rule revert (https://github.com/flutter/engine/pull/8078 )
d71bfe58d Only build a full Dart SDK when building for the host system (https://github.com/flutter/engine/pull/8071 )
de90dbff7 Refactor web configuration/ Add dartdevc (https://github.com/flutter/engine/pull/7978 )
ff46dd38f Roll src/third_party/skia 4c1ea43a79b5..88b8d1124b72 (8 commits) (https://github.com/flutter/engine/pull/8070 )
80c6dd286 Roll src/third_party/skia 692122e3ef23..4c1ea43a79b5 (3 commits) (https://github.com/flutter/engine/pull/8069 )
68ed654ea Roll src/third_party/skia 3c957d575c58..692122e3ef23 (6 commits) (https://github.com/flutter/engine/pull/8067 )
ca0bac4fb Revert "add signal to pointer kinds" (https://github.com/flutter/engine/pull/8066 )
3fb627f2c add signal to pointer kinds (https://github.com/flutter/engine/pull/8065 )
5a06afa2a Roll src/third_party/skia 801a9c16d81e..3c957d575c58 (19 commits) (https://github.com/flutter/engine/pull/8063 )
a93d99db9 A11y callback (https://github.com/flutter/engine/pull/8005 )
3661d5e43 Re-land "Buffer lifecycle in WindowData" (https://github.com/flutter/engine/pull/8032 )
471a2c89a Send scroll events from the macOS shell (https://github.com/flutter/engine/pull/8056 )
2fe9c9b5f Roll src/third_party/skia 72542816cadb..801a9c16d81e (46 commits) (https://github.com/flutter/engine/pull/8060 )
3335764ae Skip skp files in license check (https://github.com/flutter/engine/pull/8050 )
7f16789b2 Remove redundant thread checker in FML. (https://github.com/flutter/engine/pull/8053 )
840c5233a Correct URL for Cirrus CI build status badge (https://github.com/flutter/engine/pull/8054 )
57c120a29 remove extra source files (https://github.com/flutter/engine/pull/8052 )
4773375c6 Used named conditionals for platform specific dependencies and suppress Android and Windows hooks on Mac. (https://github.com/flutter/engine/pull/8051 )
70a18b515 Add clang static analysis support to gn wrapper (https://github.com/flutter/engine/pull/8047 )
b30f9897b Improve elevation bounds for physical shape layers (https://github.com/flutter/engine/pull/8044 )
e37bd27b4 Fix weak pointer use violations in shell and platform view. (https://github.com/flutter/engine/pull/8046 )
dd80fc9ff Add engine support for scrollwheel events (https://github.com/flutter/engine/pull/7494 )
2019-03-07 20:05:42 -08:00
TruongSinh Tran-Nguyen
0c7fe40e37
fix #19175 How should addTime be used from a test? ( #25202 )
2019-03-06 15:32:33 -08:00
Alexandre Ardhuin
4c1f4d14e1
fix some formatting issues ( #28809 )
...
* fix some formatting issues
* address review comments
* fix indent
2019-03-06 09:37:32 +01:00
Alexandre Ardhuin
387f885481
Add missing trailing commas ( #28673 )
...
* add trailing commas on list/map/parameters
* add trailing commas on Invocation with nb of arg>1
* add commas for widget containing widgets
* add trailing commas if instantiation contains trailing comma
* revert bad change
2019-03-01 08:17:55 +01:00
Alexandre Ardhuin
5169ab5974
format parameter list ( #27261 )
2019-02-21 09:27:07 +01:00
Jonah Williams
3205736fcf
add ui.Window fallback to TestViewConfiguration ( #27987 )
2019-02-14 22:49:49 -08:00
Matt Carroll
92125ed38f
Enable dependency injection of Window instead of using static property ( #27389 )
2019-02-04 16:46:04 -08:00
Konstantin Scheglov
39289b83ac
Update additionalTime in TestWidgetsFlutterBinding.runAsync() to 1000. ( #27256 )
2019-01-30 07:31:00 -08:00
Konstantin Scheglov
4fe41abfcc
Add default values for optional parameters. ( #27197 )
2019-01-29 11:49:57 -08:00
Greg Spencer
1811d57445
Implement hover support for mouse pointers. ( #24830 )
...
This implements support for hovering mouse pointers, so that mice connected to Android devices, and ChromeOS devices running Android apps will work properly.
It teaches flutter_test about hover events, which required changing how they are created and used.
Also modifies AnnotatedRegion to allow a region that can be located someplace other than just the origin.
Along with tests for all of the above.
Fixes #5504
2019-01-29 11:34:26 -08:00
sjindel-google
4881777203
Fix behavior of handleDrawFrame() in benchmark mode. ( #25049 )
2019-01-22 11:46:14 +01:00
Gary Qian
dfd0229560
New locale resolution algorithm to use full preferred locale list, include scriptCode in Locale. ( #23583 )
2018-11-09 11:33:42 -08:00
Jonah Williams
a43e3a4a2f
Retry remove package:test from flutter ( #24007 )
2018-11-06 10:48:34 -08:00
Jonah Williams
23a7535a39
Revert "Remove package:test dependency from flutter_test ( #23755 )" ( #24004 )
...
This reverts commit 71e9bd6f25125112473d5a094ee77fadaf7c259e.
2018-11-06 09:12:48 -08:00
Jonah Williams
71e9bd6f25
Remove package:test dependency from flutter_test ( #23755 )
2018-11-06 08:39:27 -08:00
Alexandre Ardhuin
344ebe02ff
avoid returning null for Future ( #23784 )
2018-11-05 16:38:23 +01:00
Alexandre Ardhuin
7ce28d1277
use Duration.zero ( #23218 )
2018-10-18 13:57:52 +02:00
Yegor
3fbd140e77
Use new mixin syntax for super-mixins ( #22870 )
...
This re-lands 3c56e6c on top of a new Dart SDK that contains new mixin syntax fixes.
2018-10-17 13:10:05 -07:00
Alexandre Ardhuin
8b0de38ef8
fix upcoming lint avoid_returning_null_for_void ( #23190 )
2018-10-17 11:01:37 +02:00
Alexandre Ardhuin
0e76cb4c10
prefer_void_to_null in flutter_test ( #22847 )
...
* prefer_void_to_null in flutter_test
* fix CI
2018-10-11 18:00:46 +02:00
Yegor
3184b7cb66
Revert "Use mixin syntax for Flutter's super-mixins ( #22435 )" ( #22748 )
...
This reverts commit 3c56e6c77dc5c351d610d5c2a11d86e8be88519f.
It breaks the AOT build.
2018-10-05 15:09:38 -07:00
Yegor
3c56e6c77d
Use mixin syntax for Flutter's super-mixins ( #22435 )
...
* first pass
* revert WidgetsBindingObserver
* disable prefer_mixin
* docs and more mixins
* newer engine; binding fixes
* upgrade dependencies
* fix test binding
* remove whitespace
* remove the obsolete `enableSuperMixins: true`
* upgrade dartdoc to 0.22.0
* temporarily use git version of dartdoc
* fix pub global activate syntax
* use dartdoc 0.23.0
2018-10-05 14:54:41 -07:00
Alexandre Ardhuin
f62afdcf57
add missing type parameter on methods ( #22096 )
2018-10-01 21:29:08 +02:00
Alexandre Ardhuin
d927c93310
Unnecessary new ( #20138 )
...
* enable lint unnecessary_new
* fix tests
* fix tests
* fix tests
2018-09-12 08:29:29 +02:00
Jonah Williams
0e9cfe7df1
Address follow up to https://github.com/flutter/flutter/pull/20354 ( #21181 )
2018-08-29 16:48:23 -07:00
Jonah Williams
e235ccd76f
Support disabled animations ( #20354 )
2018-08-23 11:50:04 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links ( #20772 )
...
* Fixes resulting from audit of issues links
I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.
* Update run_test.dart
skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
Ian Hickson
ef71d9d956
Increase timeouts because some CI systems are REALLY SLOW. ( #20396 )
2018-08-12 00:16:43 -07:00
Alexandre Ardhuin
eda03e2586
re-re-enable lint unnecessary_const ( #20103 )
2018-08-02 12:02:32 +02:00
Todd Volkert
00aac68e2d
Revert flutter/flutter#19592 ( #19861 )
...
It was causing problems rolling Flutter into Fuchsia
2018-07-27 08:44:39 -07:00
Alexandre Ardhuin
27018359d2
re-enable lint unnecessary_const ( #19592 )
...
* re-enable lint unnecessary_const
* remove trailling whitespaces
* remove unnecessary const (after merge)
2018-07-23 08:31:48 +02:00
Ian Hickson
f630f90d6d
Revert "enable lint unnecessary_const ( #19342 )" ( #19423 )
...
This reverts commit cc1cf13eec6752af992d3db0265cf04cc90bfd13.
2018-07-16 13:30:27 -07:00
Alexandre Ardhuin
cc1cf13eec
enable lint unnecessary_const ( #19342 )
2018-07-16 21:43:48 +02:00
