39414 Commits

Author SHA1 Message Date
Tirth
e93a10d1fb
Pass-Through inputFormatters in DropdownMenu (#143250)
Pass-Through `inputFormatters` in `DropdownMenu`.

Fixes: #142374
2024-02-13 03:57:15 +00:00
Taha Tesser
d271791e8c
Fix insetPadding parameter nullability for dialogs (#143305)
fixes [`insetPadding` should be nullable in dialogs](https://github.com/flutter/flutter/issues/117125)
2024-02-13 00:12:02 +00:00
Camille Simon
0650b76884
Revert "Migrate integration_test plugin to Gradle Kotlin DSL (#142008)" (#143329)
This reverts https://github.com/flutter/flutter/pull/142008 because it broke the Flutter --> packages roller.
2024-02-12 23:26:18 +00:00
Ross Llewallyn
525cffd717
Badge class doc typo - missing [ (#143318)
Doc typo fix

No issue made
2024-02-12 23:24:41 +00:00
auto-submit[bot]
0377bc3ac8
Reverts "Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322)" (#143338)
Reverts flutter/flutter#143322

Initiated by: zanderso

Reason for reverting: The tree is red.

Original PR Author: engine-flutter-autoroll

Reviewed By: {fluttergithubbot}

This change reverts the following previous change:
Original Description:

1c3ecee773...a19077503a

2024-02-12 737941+loic-sharma@users.noreply.github.com [Windows] Make the view own its EGL surface (flutter/engine#50421)
2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559)
2024-02-12 1889916+miguelfrde@users.noreply.github.com [fuchsia] Update Inspect library usage (flutter/engine#50467)
2024-02-12 zanderso@users.noreply.github.com Initializes RBE in the build config runner (flutter/engine#50543)
2024-02-12 tugorez@users.noreply.github.com Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533)
2024-02-12 dnfield@google.com Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540)
2024-02-12 30870216+gaaclarke@users.noreply.github.com [Impeller] deleted the old blur (flutter/engine#50470)
2024-02-12 kjlubick@users.noreply.github.com Update codec defines for Skia (flutter/engine#50554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 22:44:18 +00:00
engine-flutter-autoroll
1e6a902473
Roll Flutter Engine from 1c3ecee77350 to a19077503a0c (8 revisions) (#143322)
1c3ecee773...a19077503a

2024-02-12 737941+loic-sharma@users.noreply.github.com [Windows] Make the view own its EGL surface (flutter/engine#50421)
2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from 5c9e79e66364 to dca13675e65e (1 revision) (flutter/engine#50559)
2024-02-12 1889916+miguelfrde@users.noreply.github.com [fuchsia] Update Inspect library usage (flutter/engine#50467)
2024-02-12 zanderso@users.noreply.github.com Initializes RBE in the build config runner (flutter/engine#50543)
2024-02-12 tugorez@users.noreply.github.com Rename [ViewFocusDirection.backwards] to [ViewFocusDirection.backward] (flutter/engine#50533)
2024-02-12 dnfield@google.com Refactor NDK helpers some more, add methods for SurfaceControl/Transaction, tests (flutter/engine#50540)
2024-02-12 30870216+gaaclarke@users.noreply.github.com [Impeller] deleted the old blur (flutter/engine#50470)
2024-02-12 kjlubick@users.noreply.github.com Update codec defines for Skia (flutter/engine#50554)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 20:12:20 +00:00
Kevin Moore
e1645b150f
[web] Move JS interop to extension types (#143274)
Now that we can bump the min SDK to latest.
2024-02-12 11:14:10 -08:00
Valentin Vignal
52f923c360
Add documentation for best practices for StreamBuilder like FutureBuilder (#143295)
Fixes https://github.com/flutter/flutter/issues/142189
2024-02-12 18:25:57 +00:00
engine-flutter-autoroll
cf2c68417f
Roll Flutter Engine from 8806987182a3 to 1c3ecee77350 (1 revision) (#143315)
8806987182...1c3ecee773

2024-02-12 zanderso@users.noreply.github.com Remove host_debug_unopt build from  linux_host_engine.json (flutter/engine#50555)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 18:18:07 +00:00
Nitesh Sharma
49f620d8ea
Fix dual focus issue in CheckboxListTile, RadioListTile and SwitchListTile (#143213)
These widgets can now only receive focus once when tabbing through the focus tree.
2024-02-12 10:07:51 -08:00
Reid Baker
ace3e58f0a
Revert "[Re-land] Enforce a policy on supported Gradle, Java, AGP, and KGP versions" (#143314)
Reverts flutter/flutter#143132
2024-02-12 18:04:05 +00:00
Jenn Magder
1d25b0c700
Update integration_test iOS FTL README script to remove targeted version (#143248)
1. Remove `dev_target` from suggested Firebase Test Lab iOS script and use wildcard instead.
2. First run `flutter clean` before building to avoid collisions between runs.
3. Use `zip --must-match` in case the xctestrun or `Release-iphoneos` directories are missing (like ran with `--profile` instead of `--release` on purpose) to fail instead of zipping up only part of what's needed.

This came out of a discussion with FTL about these instructions and I tried to run them locally and avoided setting `dev_target`.

See also #74428
2024-02-12 17:53:05 +00:00
Konstantin Scheglov
5a649aa8ab
Remove unnecessary 'debugLabel: null'. (#143253)
There was a change https://dart-review.googlesource.com/c/sdk/+/350920 to the analyzer that caused reporting this lint.

https://github.com/flutter/flutter/issues/143254
2024-02-12 17:33:03 +00:00
Tirth
10442399fb
Introduce iconAlignment for the buttons with icon (#137348)
Adds `iconAlignment` property to `ButtonStyleButton` widget.

Fixes #89564

### Example

https://github.com/flutter/flutter/assets/13456345/1b5236c4-5c60-4915-b3c6-0a56c43f8a19
2024-02-12 17:08:20 +00:00
engine-flutter-autoroll
82668f1688
Roll Packages from 11152d2bc8f3 to 0a692590a885 (4 revisions) (#143306)
11152d2bc8...0a692590a8

2024-02-09 everythingoutdated@gmail.com [local_auth]: Renamed `local_auth_ios` to `local_auth_darwin` (flutter/packages#5809)
2024-02-09 ltv.luongthevinh@gmail.com [webview_flutter] Add listener for content offset (flutter/packages#3444)
2024-02-09 David.Chopin@wwt.com [go_router] Expose full `Uri` on `GoRouterState` in `GoRouterRedirect` (flutter/packages#5742)
2024-02-09 stuartmorgan@google.com [webview_flutter] Minor test cleanup (flutter/packages#6031)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 15:36:34 +00:00
engine-flutter-autoroll
75784a20c9
Roll Flutter Engine from 4f119619dfa8 to 8806987182a3 (1 revision) (#143304)
4f119619df...8806987182

2024-02-12 skia-flutter-autoroll@skia.org Roll Dart SDK from efc514815312 to 5c9e79e66364 (1 revision) (flutter/engine#50552)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 14:57:22 +00:00
engine-flutter-autoroll
e1752040a8
Roll Flutter Engine from b0753c0e25f8 to 4f119619dfa8 (1 revision) (#143291)
b0753c0e25...4f119619df

2024-02-12 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from uoByvKUBgYXArsFGL... to RVHAIKU50ogkiV-Lj... (flutter/engine#50546)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from uoByvKUBgYXA to RVHAIKU50ogk

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-12 02:36:14 +00:00
engine-flutter-autoroll
dbb3c16aad
Roll Flutter Engine from 936495d94cc6 to b0753c0e25f8 (1 revision) (#143282)
936495d94c...b0753c0e25

2024-02-11 skia-flutter-autoroll@skia.org Roll Dart SDK from c64c3d6bae2f to efc514815312 (1 revision) (flutter/engine#50544)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-11 07:05:17 +00:00
engine-flutter-autoroll
8533d276cb
Roll Flutter Engine from b06b3e0d75ad to 936495d94cc6 (1 revision) (#143280)
b06b3e0d75...936495d94c

2024-02-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from H1cNBBNhq0bEpcyPs... to uoByvKUBgYXArsFGL... (flutter/engine#50542)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from H1cNBBNhq0bE to uoByvKUBgYXA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-11 04:25:23 +00:00
engine-flutter-autoroll
d006184041
Roll Flutter Engine from 1478f4e75dd9 to b06b3e0d75ad (1 revision) (#143275)
1478f4e75d...b06b3e0d75

2024-02-10 matanlurey@users.noreply.github.com Remove legacy references to `Cirrus` and suspected dead-code. (flutter/engine#50442)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-11 00:33:23 +00:00
LongCatIsLooong
bc49cf8091
Fix text painter longest line resizing logic for TextWidthBasis.longestLine (#143024)
Fixes https://github.com/flutter/flutter/issues/142309.
2024-02-10 23:39:20 +00:00
engine-flutter-autoroll
4fdfe7850a
Roll Flutter Engine from e6ceb3504f50 to 1478f4e75dd9 (1 revision) (#143273)
e6ceb3504f...1478f4e75d

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 0119704af522 to c64c3d6bae2f (1 revision) (flutter/engine#50538)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 22:42:23 +00:00
Zachary Anderson
9f832218da
Move Windows arm64 tests to bringup true (#143272)
For https://github.com/flutter/flutter/issues/143271
2024-02-10 21:21:09 +00:00
engine-flutter-autoroll
7ad7d3ac60
Roll Flutter Engine from 3c5149ccde38 to e6ceb3504f50 (1 revision) (#143267)
3c5149ccde...e6ceb3504f

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from ed5730124fd1 to 0119704af522 (1 revision) (flutter/engine#50527)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 19:48:20 +00:00
engine-flutter-autoroll
581ec63df4
Roll Flutter Engine from c587bd69985f to 3c5149ccde38 (2 revisions) (#143266)
c587bd6998...3c5149ccde

2024-02-10 skia-flutter-autoroll@skia.org Roll Dart SDK from 10ca8dc7d2b4 to ed5730124fd1 (1 revision) (flutter/engine#50523)
2024-02-10 zanderso@users.noreply.github.com Update build/rbe CIPD hash (flutter/engine#50524)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 06:31:26 +00:00
engine-flutter-autoroll
bb3374f247
Roll Flutter Engine from e08b6c899c42 to c587bd69985f (1 revision) (#143265)
e08b6c899c...c587bd6998

2024-02-10 zanderso@users.noreply.github.com Adds a runner to engine_build_configs (flutter/engine#50342)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 04:17:14 +00:00
engine-flutter-autoroll
f3e367bed7
Roll Flutter Engine from 1b8f23bbd099 to e08b6c899c42 (2 revisions) (#143264)
1b8f23bbd0...e08b6c899c

2024-02-10 dnfield@google.com Clean up additional NDK helper related code (flutter/engine#50518)
2024-02-09 tugorez@users.noreply.github.com Make the web engine publish view forward focus and unfocus events (flutter/engine#50177)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 02:40:47 +00:00
engine-flutter-autoroll
ee8d3f5e0c
Roll Flutter Engine from 41daa5b913b9 to 1b8f23bbd099 (2 revisions) (#143261)
41daa5b913...1b8f23bbd0

2024-02-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RK2irywND2DKT4l6C... to H1cNBBNhq0bEpcyPs... (flutter/engine#50517)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 444f7a422da4 to 10ca8dc7d2b4 (1 revision) (flutter/engine#50516)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from RK2irywND2DK to H1cNBBNhq0bE

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 01:17:05 +00:00
engine-flutter-autoroll
923c6ed338
Roll Flutter Engine from f969c52f133a to 41daa5b913b9 (1 revision) (#143258)
f969c52f13...41daa5b913

2024-02-09 chinmaygarde@google.com [Impeller] Add --enable-impeller-vulkan-playgrounds to ./flutter/tools/gn (flutter/engine#50477)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 00:39:10 +00:00
engine-flutter-autoroll
e38e7d781d
Roll Flutter Engine from 6a3b0216ff5b to f969c52f133a (3 revisions) (#143256)
6a3b0216ff...f969c52f13

2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Remove the unused Vulkan queue submit task runner (flutter/engine#50511)
2024-02-09 zanderso@users.noreply.github.com Make .style.yapf and .pylintrc agree on line length (flutter/engine#50510)
2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Call vkQueuePresentKHR through the ContextVK's synchronized graphics queue wrapper (flutter/engine#50509)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-10 00:00:41 +00:00
engine-flutter-autoroll
d385d027f1
Roll Flutter Engine from 8c521eb24171 to 6a3b0216ff5b (4 revisions) (#143251)
8c521eb241...6a3b0216ff

2024-02-09 30870216+gaaclarke@users.noreply.github.com [Impeller] cleaned up StrokePathGeometry and removed runtime polymorphism (flutter/engine#50506)
2024-02-09 ditman@gmail.com [web] Fix HtmlViewEmbedder.dispose (flutter/engine#50482)
2024-02-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 03130d49f214 to 444f7a422da4 (6 revisions) (flutter/engine#50502)
2024-02-09 jonahwilliams@google.com [Impeller] improve performance of polyline and stroke generation by reducing allocation and lambda usage. (flutter/engine#50379)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 23:20:57 +00:00
Polina Cherkasova
b48dfca382
Upgrade leak_tracker. (#143236) 2024-02-09 14:41:22 -08:00
Kris Pypen
2f117c545b
Fix: performance improvement on golden test comparison (#142913)
During golden test image comparison 2 lists of a different type are compared with the method "identical", so this will never be true. The test image is a _Uint8ArrayView while the master image is an Uint8List. So that results in always a heavy computation to get the difference between the test and the master image.

When you run this test snippet I go from 51 seconds to 14 seconds:
```dart
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  for (int i = 0; i < 100; i++) {
    testWidgets('Small test', (WidgetTester tester) async {
      await tester.pumpWidget(Directionality(textDirection: TextDirection.ltr, child: Text('jo')));
      await expectLater(find.byType(Text), matchesGoldenFile('main.png'));
    });
  }
}
```
2024-02-09 22:05:00 +00:00
Nate
1887bc410f
Implementing switch expressions in lib/src/material/ (#142793)
This PR is the 6ᵗʰ step in the journey to solve issue #136139 and make the entire Flutter repo more readable.

(previous pull requests: #139048, #139882, #141591, #142279, #142634)

The current focus is on `packages/flutter/lib/src/material/`. The previous 2 PRs covered files in this directory starting with letters `a-m`; this one takes care of everything else.
2024-02-09 22:03:23 +00:00
Henry Riehl
fa71e8029b
Add position data to OnDragEnd callback (#140378)
This PR adds localPosition/globalPosition data to the `DragEndDetails`
argument of the `onDragEnd` callback.
2024-02-09 12:37:20 -08:00
engine-flutter-autoroll
ed02cf2f4a
Roll Flutter Engine from 1232d598f7c4 to 8c521eb24171 (2 revisions) (#143237)
1232d598f7...8c521eb241

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from fbe1d2265637 to 4081496b7693 (1 revision) (flutter/engine#50499)
2024-02-09 zanderso@users.noreply.github.com Supports building with RBE on a Windows host. (flutter/engine#49877)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 19:49:25 +00:00
engine-flutter-autoroll
2edf7d7bef
Roll Flutter Engine from 7a5390c6b3bd to 1232d598f7c4 (1 revision) (#143235)
7a5390c6b3...1232d598f7

2024-02-09 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 452dd17120b7 to 03130d49f214 (4 revisions) (flutter/engine#50494)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 19:11:51 +00:00
Jenn Magder
2fc19619e8
Set plugin template minimum iOS version to 12.0 (#143167)
Fixes https://github.com/flutter/flutter/issues/140474

See https://github.com/flutter/flutter/pull/122625 where this was done 11->12.
2024-02-09 18:32:10 +00:00
engine-flutter-autoroll
2207a3077b
Roll Flutter Engine from 7a241130fcf8 to 7a5390c6b3bd (1 revision) (#143231)
7a241130fc...7a5390c6b3

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 14ee546dcfe8 to fbe1d2265637 (2 revisions) (flutter/engine#50495)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 18:12:02 +00:00
Bartek Pacia
60f30a65b4
Migrate integration_test plugin to Gradle Kotlin DSL (#142008)
We already have a simple app in this repo that fully uses Gradle Kotlin DSL (see #141541). The next small step is to have at least one plugin that also uses Gradle Kotlin DSL. Let's use `integration_test` for that, since it's versioned with Flutter SDK.
2024-02-09 18:07:56 +00:00
engine-flutter-autoroll
445b08685a
Roll Flutter Engine from dcac9863a1fc to 7a241130fcf8 (1 revision) (#143222)
dcac9863a1...7a241130fc

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 68cb550de88d to 14ee546dcfe8 (1 revision) (flutter/engine#50493)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 17:30:07 +00:00
engine-flutter-autoroll
2174915cc3
Roll Flutter Engine from 1508b11bf791 to dcac9863a1fc (1 revision) (#143220)
1508b11bf7...dcac9863a1

2024-02-09 jason-simmons@users.noreply.github.com [Impeller] Remove the Vulkan queue submit thread and always present Vulkan images on the raster thread (flutter/engine#50484)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 16:44:07 +00:00
engine-flutter-autoroll
03891a4578
Roll Packages from 29d8cc006b0e to 11152d2bc8f3 (4 revisions) (#143217)
29d8cc006b...11152d2bc8

2024-02-09 jsharp83@gmail.com [webview_flutter] Add interface for showing javascript dialog message (flutter/packages#4704)
2024-02-09 32931186+erdzan12@users.noreply.github.com [pigeon] Implement Screaming Snake Case Conversion for Kotlin Enum Cases (flutter/packages#5918)
2024-02-09 43054281+camsim99@users.noreply.github.com [camerax] Small fixes to starting/stopping video capture (flutter/packages#6068)
2024-02-08 engine-flutter-autoroll@skia.org Roll Flutter from 8431cae8843c to eb5d0a434ef1 (33 revisions) (flutter/packages#6079)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 15:38:16 +00:00
engine-flutter-autoroll
5f89a50349
Roll Flutter Engine from 350dc662e5af to 1508b11bf791 (1 revision) (#143214)
350dc662e5...1508b11bf7

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 64a25300fe1c to 68cb550de88d (2 revisions) (flutter/engine#50491)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 12:55:20 +00:00
David Martos
f0bb9d57e6
barrierColor property in DialogTheme (#142490) 2024-02-09 01:50:14 -08:00
engine-flutter-autoroll
8b228b9eda
Roll Flutter Engine from f6dddb257a4f to 350dc662e5af (1 revision) (#143208)
f6dddb257a...350dc662e5

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 9bcc54924128 to 64a25300fe1c (3 revisions) (flutter/engine#50489)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 06:31:07 +00:00
engine-flutter-autoroll
950e0025c4
Roll Flutter Engine from 377f1b068541 to f6dddb257a4f (1 revision) (#143207)
377f1b0685...f6dddb257a

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from c36362d95df0 to 9bcc54924128 (1 revision) (flutter/engine#50488)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 05:38:30 +00:00
engine-flutter-autoroll
88dead0168
Roll Flutter Engine from 1f3b15738adb to 377f1b068541 (1 revision) (#143204)
1f3b15738a...377f1b0685

2024-02-09 skia-flutter-autoroll@skia.org Roll Skia from 672bb50b6d8f to c36362d95df0 (3 revisions) (flutter/engine#50485)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 04:17:10 +00:00
engine-flutter-autoroll
189fe6b77e
Roll Flutter Engine from f9a169e0e0c1 to 1f3b15738adb (1 revision) (#143201)
f9a169e0e0...1f3b15738a

2024-02-09 dnfield@google.com [Impeller] Move impeller/image to impeller/playground/image (flutter/engine#50480)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 02:11:07 +00:00
engine-flutter-autoroll
345857712f
Roll Flutter Engine from 7b579dc30979 to f9a169e0e0c1 (2 revisions) (#143199)
7b579dc309...f9a169e0e0

2024-02-09 chinmaygarde@google.com Sever the //flutter/vulkan dependency in Flutter in the Android embedder. (flutter/engine#50472)
2024-02-08 skia-flutter-autoroll@skia.org Roll Skia from 59943f4e92b9 to 672bb50b6d8f (3 revisions) (flutter/engine#50476)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC chinmaygarde@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-02-09 01:25:32 +00:00