40716 Commits

Author SHA1 Message Date
Kate Lovett
e10e9a90af
Update icon tree shaker to allow system font fallback (#147202)
Fixes https://github.com/flutter/flutter/issues/147189

This allows const `IconData` to fallback to the system font if `fontFamily` is not provided.

A similar non-fatal error occurs when IconData specifies a font that is not included in the manifest, so I modeled after that error message:

b4121a1867/packages/flutter_tools/lib/src/build_system/targets/icon_tree_shaker.dart (L122)
2024-04-23 16:40:29 +00:00
Nate
a83e111a87
flutter/lib/src/: refactoring if-chains into switch expressions (#146293)
Based on issue #144903, this pull request aims to bring the codebase more in line with the [Flutter repo style guide](https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#avoid-using-if-chains-or--or--with-enum-values):

> ### Avoid using `if` chains or `?:` or `==` with enum values
2024-04-23 16:32:15 +00:00
engine-flutter-autoroll
a91c62dcd0
Roll Flutter Engine from 79f49954cce8 to f794e6719d3c (1 revision) (#147241)
79f49954cc...f794e6719d

2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from b340d0f393b6 to acd54f86bdbb (1 revision) (flutter/engine#52321)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:59:42 +00:00
engine-flutter-autoroll
a399fa4b71
Roll Packages from 01a32c4a464f to cf6d2803d93e (5 revisions) (#147240)
01a32c4a46...cf6d2803d9

2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.2 to 4.3.3 (flutter/packages#6598)
2024-04-22 zeqinjie@qq.com [image_picker] Fix If imageToScale is nil, the app will crash (#146682) (flutter/packages#6514)
2024-04-22 engine-flutter-autoroll@skia.org Roll Flutter from 1a905d508de1 to 140edb988312 (5 revisions) (flutter/packages#6594)
2024-04-22 ditman@gmail.com [pointer_interceptor_web] Remove semantic tests. (flutter/packages#6580)
2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.2 (flutter/packages#6571)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 15:45:17 +00:00
engine-flutter-autoroll
77043bae1a
Roll Flutter Engine from ffd3911b1ff7 to 79f49954cce8 (2 revisions) (#147235)
ffd3911b1f...79f49954cc

2024-04-23 jonnywang@google.com [fuchsia] Update Fuchsia API version to 17 (flutter/engine#52266)
2024-04-23 kjlubick@users.noreply.github.com [skia] Remove no-op GN flag (flutter/engine#52121)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 14:17:32 +00:00
engine-flutter-autoroll
a9a556be29
Roll Flutter Engine from c7d9deb66bf7 to ffd3911b1ff7 (1 revision) (#147227)
c7d9deb66b...ffd3911b1f

2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/engine#52318)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 11:11:33 +00:00
flutter-pub-roller-bot
1465da40b7
Roll pub packages (#147220)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-23 09:37:29 +00:00
engine-flutter-autoroll
572c75e968
Roll Flutter Engine from 075d834489d0 to c7d9deb66bf7 (2 revisions) (#147215)
075d834489...c7d9deb66b

2024-04-23 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.1 to 4.3.3 (flutter/engine#52319)
2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from fe545a316f68 to a373bf46bffb (3 revisions) (flutter/engine#52317)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 08:16:59 +00:00
Bruno Leroux
e9926c4848
Mention visualDensity impact on ButtonStyle.padding documentation (#147048)
## Description

This PR adds some information about how the Material buttons padding is impacted by visual density.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/137411

## Tests

Documentation only.
2024-04-23 08:15:53 +00:00
engine-flutter-autoroll
1f59013c65
Roll Flutter Engine from 9c0d24ff1cb6 to 075d834489d0 (1 revision) (#147214)
9c0d24ff1c...075d834489

2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 9f64eecc8cf3 to b340d0f393b6 (1 revision) (flutter/engine#52316)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 07:32:33 +00:00
Valentin Vignal
1be28aa61a
Fix memory leaks in CupertinoTextMagnifier (#147208) 2024-04-22 22:26:09 -07:00
engine-flutter-autoroll
3e8408bb63
Roll Flutter Engine from 004e98839ed7 to 9c0d24ff1cb6 (1 revision) (#147211)
004e98839e...9c0d24ff1c

2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from db21ce8d0f28 to fe545a316f68 (1 revision) (flutter/engine#52313)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 05:15:09 +00:00
engine-flutter-autoroll
b11c4bc0f0
Roll Flutter Engine from 79f753650c6e to 004e98839ed7 (1 revision) (#147209)
79f753650c...004e98839e

2024-04-23 skia-flutter-autoroll@skia.org Roll Dart SDK from 95f95b3118fe to 9f64eecc8cf3 (2 revisions) (flutter/engine#52312)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 04:27:31 +00:00
engine-flutter-autoroll
dbcbaf8d53
Roll Flutter Engine from f8e373da5227 to 79f753650c6e (1 revision) (#147206)
f8e373da52...79f753650c

2024-04-23 skia-flutter-autoroll@skia.org Roll Skia from e6de04b82b57 to db21ce8d0f28 (1 revision) (flutter/engine#52309)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 03:47:32 +00:00
Dimil Kalathiya
65fbd52b1a
fixes cupertino page transition leak (#147133) 2024-04-22 20:40:43 -07:00
Valentin Vignal
4938403a7a
Fix memory leaks in PopupMenu (#147174) 2024-04-22 20:40:33 -07:00
engine-flutter-autoroll
89a4ffaad5
Roll Flutter Engine from 62c9f17169cf to f8e373da5227 (2 revisions) (#147205)
62c9f17169...f8e373da52

2024-04-22 41930132+hellohuanlin@users.noreply.github.com [ios_edit_menu]add native edit menu  (flutter/engine#50095)
2024-04-22 matanlurey@users.noreply.github.com Fail `run_impeller_golden_tests` if `LUCI_CONTEXT && !GOLDCTL` (flutter/engine#52300)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 02:16:42 +00:00
engine-flutter-autoroll
33c6acbed3
Roll Flutter Engine from 33c828fb3ff5 to 62c9f17169cf (4 revisions) (#147203)
33c828fb3f...62c9f17169

2024-04-22 jonahwilliams@google.com [Impeller] skip lineTo for empty contours. (flutter/engine#52290)
2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from 3b32e3280b67 to e6de04b82b57 (6 revisions) (flutter/engine#52304)
2024-04-22 jonahwilliams@google.com [Impeller] re-enable gold CTL. (flutter/engine#52299)
2024-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0ed66a4d77cb to 95f95b3118fe (1 revision) (flutter/engine#52301)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 01:33:09 +00:00
dependabot[bot]
c217f763e9
Bump actions/upload-artifact from 4.3.2 to 4.3.3 (#147192)
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.2 to 4.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>updating <code>@actions/artifact</code> dependency to v2.1.6 by <a href="https://github.com/eggyhead"><code>@​eggyhead</code></a> in <a href="https://redirect.github.com/actions/upload-artifact/pull/565">actions/upload-artifact#565</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3">https://github.com/actions/upload-artifact/compare/v4.3.2...v4.3.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="65462800fd"><code>6546280</code></a> updating package version</li>
<li><a href="c004fb4bf6"><code>c004fb4</code></a> Merge branch 'main' into eggyhead/use-artifact-v2.1.6</li>
<li><a href="90aba496fc"><code>90aba49</code></a> updating toolkit artifact dependency to 2.1.6</li>
<li><a href="b06cde36fc"><code>b06cde3</code></a> Merge pull request <a href="https://redirect.github.com/actions/upload-artifact/issues/563">#563</a> from actions/eggyhead/release-4.3.2</li>
<li>See full diff in <a href="1746f4ab65...65462800fd">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/upload-artifact&package-manager=github_actions&previous-version=4.3.2&new-version=4.3.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-04-23 00:23:02 +00:00
dependabot[bot]
be62c7f743
Bump github/codeql-action from 3.25.1 to 3.25.2 (#147193)
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.1 to 3.25.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="8f596b4ae3"><code>8f596b4</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2254">#2254</a> from github/update-v3.25.2-4909c1ffb</li>
<li><a href="de8916ec5a"><code>de8916e</code></a> Update changelog for v3.25.2</li>
<li><a href="4909c1ffb9"><code>4909c1f</code></a> Bump the npm group with 3 updates (<a href="https://redirect.github.com/github/codeql-action/issues/2253">#2253</a>)</li>
<li><a href="f45390cde1"><code>f45390c</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2252">#2252</a> from github/henrymercer/failed-external-repo-config-...</li>
<li><a href="1be8c488eb"><code>1be8c48</code></a> Add configuration error for failing to clone external Git repo</li>
<li><a href="82edfe29ce"><code>82edfe2</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2246">#2246</a> from github/koesie10/remove-incorrect-log</li>
<li><a href="8786e1f9a1"><code>8786e1f</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/2249">#2249</a> from github/mergeback/v3.25.1-to-main-c7f91257</li>
<li><a href="3c7ac61481"><code>3c7ac61</code></a> Update checked-in dependencies</li>
<li><a href="b5bd9be6da"><code>b5bd9be</code></a> Update changelog and version after v3.25.1</li>
<li><a href="5d73b1bd71"><code>5d73b1b</code></a> Remove incorrect log message</li>
<li>See full diff in <a href="c7f9125735...8f596b4ae3">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=3.25.1&new-version=3.25.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-04-23 00:21:05 +00:00
engine-flutter-autoroll
0c7270f435
Roll Flutter Engine from a4b71f02a1c7 to 33c828fb3ff5 (9 revisions) (#147190)
a4b71f02a1...33c828fb3f

2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from eb29b46236e6 to 3b32e3280b67 (1 revision) (flutter/engine#52298)
2024-04-22 magder@google.com Break dependency cycle of FlutterViewController <-> FlutterPlatformView (flutter/engine#52271)
2024-04-22 chris@bracken.jp [et] Lookup output filesystem path, not label (flutter/engine#52248)
2024-04-22 skia-flutter-autoroll@skia.org Roll Skia from 975859a96f8f to eb29b46236e6 (9 revisions) (flutter/engine#52297)
2024-04-22 1961493+harryterkelsen@users.noreply.github.com [canvaskit] Add configuration for maximum canvases (flutter/engine#51735)
2024-04-22 120297255+PurplePolyhedron@users.noreply.github.com Fix link in BlendMode.saturation (flutter/engine#52156)
2024-04-22 magder@google.com Refactor and migrate FlutterUndoManagerPlugin to ARC (flutter/engine#52234)
2024-04-22 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from Rr9lFiKCPhMXDGa89... to L533ubzhjWwW7jxbc... (flutter/engine#52293)
2024-04-22 skia-flutter-autoroll@skia.org Roll Dart SDK from 0a83dd7e61b1 to 0ed66a4d77cb (1 revision) (flutter/engine#52294)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from Rr9lFiKCPhMX to L533ubzhjWwW

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-23 00:06:31 +00:00
flutter-pub-roller-bot
b4121a1867
Roll pub packages (#147094)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-22 20:42:07 +00:00
Polina Cherkasova
1d7c680e25
Re-land fix for not disposed TabController (#146745)
Fixes https://github.com/flutter/flutter/issues/144910
2024-04-22 20:28:50 +00:00
engine-flutter-autoroll
d261a908d4
Roll Flutter Engine from 75ca2195c936 to a4b71f02a1c7 (1 revision) (#147175)
75ca2195c9...a4b71f02a1

2024-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from d4c5d9c92e4d to 0a83dd7e61b1 (1 revision) (flutter/engine#52291)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 20:19:07 +00:00
Lam Thanh Nhan
bd651347e1
Update examples/api for android platform (#147102)
In the `examples/api`, the Android platform missed this step while migrating to the declarative plugins {} block described in [flutter-gradle-plugin-apply](https://docs.flutter.dev/release/breaking-changes/flutter-gradle-plugin-apply), so all examples of `examples/api` cannot run.

Fixes #147100

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
2024-04-22 20:14:13 +00:00
Anis Alibegić
140edb9883
Fixed few typos (#147087)
Here's another PR with a couple of typos fixed. As you can see there was a typo in _fileReferenceI**n**dentifiers_, in class _ParsedProjectInfo._ Maybe we should do some check on that since I'm not sure if that property is used somewhere outside Flutter?
2024-04-22 16:49:19 +00:00
Amir Panahandeh
d737b7bae0
Add Amir Panahandeh to AUTHORS (#147052)
Reference: [author:amir-p](https://github.com/flutter/flutter/issues?q=author%3Aamir-p+)
2024-04-22 16:47:22 +00:00
Andrew Kolos
4c46030927
print traces when transforming an asset (#146374)
From https://github.com/flutter/flutter/issues/143348#issuecomment-2016047148:

> before we ship, we should add a printTrace to the tool about each asset transformer we're invoking and the path/arguments we called it with

I think this is a good idea since asset transformers can be arbitrary Dart programs—meaning that a lot can go wrong when running them. For example, they can hang indefinitely or perform some sort of I/O that later results in a tool crash. Knowing that asset transformation was involved when debugging a crash (or a slow/stuck `flutter build`) could be useful, so I think adding a `printTrace` or two is a good idea (or at least not a bad one).
2024-04-22 16:37:24 +00:00
engine-flutter-autoroll
af439ac374
Roll Packages from 88a3a561f16c to 01a32c4a464f (5 revisions) (#147164)
88a3a561f1...01a32c4a46

2024-04-22 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.2 to 4.1.3 (flutter/packages#6587)
2024-04-21 engine-flutter-autoroll@skia.org Roll Flutter from 98685a099fdd to 1a905d508de1 (30 revisions) (flutter/packages#6583)
2024-04-19 dawidope@gmail.com [flutter_markdown] Custom fontfeature superscript (flutter/packages#5874)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter from fb110b98da15 to 98685a099fdd (28 revisions) (flutter/packages#6577)
2024-04-19 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 300451adae58 to 54e66469a933 (1 revision) (flutter/packages#6575)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-22 15:46:15 +00:00
Andrew Kolos
0fc08abe5b
Reland "Expose build mode in environment of asset transformer processes" (#144958)
Relands https://github.com/flutter/flutter/pull/144752, which had to be reverted because the branch was stale. The original branch branched off `master` before https://github.com/flutter/flutter/pull/144734 landed. That PR introduced a new `AssetTransformer` call site.

This PR branch is identical to the original but with a new commit that addresses the new call site, [update new call sites](6bb5296a61).
2024-04-22 15:46:13 +00:00
engine-flutter-autoroll
1a905d508d
Roll Flutter Engine from 1c3f0f1f6500 to 75ca2195c936 (1 revision) (#147136)
1c3f0f1f65...75ca2195c9

2024-04-21 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 3cyVJn1037SXTT5qT... to Rr9lFiKCPhMXDGa89... (flutter/engine#52289)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from 3cyVJn1037SX to Rr9lFiKCPhMX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 10:44:23 +00:00
engine-flutter-autoroll
5291344acc
Roll Flutter Engine from 1e247ccaa911 to 1c3f0f1f6500 (1 revision) (#147134)
1e247ccaa9...1c3f0f1f65

2024-04-21 skia-flutter-autoroll@skia.org Roll Skia from dec629b762ec to 975859a96f8f (1 revision) (flutter/engine#52288)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 09:54:25 +00:00
engine-flutter-autoroll
d6a818d540
Roll Flutter Engine from 1ac3ce3b4729 to 1e247ccaa911 (1 revision) (#147128)
1ac3ce3b47...1e247ccaa9

2024-04-21 skia-flutter-autoroll@skia.org Roll Dart SDK from 95e0894dc8e6 to d4c5d9c92e4d (1 revision) (flutter/engine#52287)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 05:07:36 +00:00
engine-flutter-autoroll
eab7c0ad36
Roll Flutter Engine from 40110ec82d4b to 1ac3ce3b4729 (1 revision) (#147125)
40110ec82d...1ac3ce3b47

2024-04-20 jonahwilliams@google.com [Impeller] compute UVs in vertex stage. (flutter/engine#52106)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-21 00:05:40 +00:00
Dimil Kalathiya
158a9a8177
fixes some gesture not getting disposed (#147112) 2024-04-20 10:20:37 -07:00
engine-flutter-autoroll
28675753ff
Roll Flutter Engine from d8a8f29612b6 to 40110ec82d4b (1 revision) (#147114)
d8a8f29612...40110ec82d

2024-04-20 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from RruZA4WorQDkGpz25... to 3cyVJn1037SXTT5qT... (flutter/engine#52283)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from RruZA4WorQDk to 3cyVJn1037SX

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 12:25:25 +00:00
engine-flutter-autoroll
731cee39b9
Roll Flutter Engine from 499eddab8451 to d8a8f29612b6 (2 revisions) (#147108)
499eddab84...d8a8f29612

2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 9735c573e7e9 to dec629b762ec (1 revision) (flutter/engine#52282)
2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 7be6fe3150fc to 9735c573e7e9 (2 revisions) (flutter/engine#52281)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 07:46:21 +00:00
engine-flutter-autoroll
f0b0e773c4
Roll Flutter Engine from 4d34b6d3da7d to 499eddab8451 (3 revisions) (#147105)
4d34b6d3da...499eddab84

2024-04-20 chris@bracken.jp [et] Fix concurrent modification exception (flutter/engine#52247)
2024-04-20 johnstiles@google.com Remove SkScalarIsFinite from Flutter Engine. (flutter/engine#52270)
2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 514d7fc627b3 to 7be6fe3150fc (1 revision) (flutter/engine#52280)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 06:03:27 +00:00
engine-flutter-autoroll
55b48036ed
Roll Flutter Engine from f22fb591870f to 4d34b6d3da7d (1 revision) (#147104)
f22fb59187...4d34b6d3da

2024-04-20 chris@bracken.jp [et] Simplify path canonicalisation logic (flutter/engine#52275)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 05:19:22 +00:00
engine-flutter-autoroll
41e08714b1
Roll Flutter Engine from 6f4d753ffddc to f22fb591870f (1 revision) (#147101)
6f4d753ffd...f22fb59187

2024-04-20 skia-flutter-autoroll@skia.org Roll Dart SDK from d882ce089110 to 95e0894dc8e6 (1 revision) (flutter/engine#52279)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 04:03:06 +00:00
engine-flutter-autoroll
2c473b33f3
Roll Flutter Engine from 3db86b3cabec to 6f4d753ffddc (2 revisions) (#147099)
3db86b3cab...6f4d753ffd

2024-04-20 skia-flutter-autoroll@skia.org Roll Skia from 1910252ea26a to 514d7fc627b3 (6 revisions) (flutter/engine#52277)
2024-04-20 chris@bracken.jp [et] Fix path canonicalization (flutter/engine#52274)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 02:32:24 +00:00
engine-flutter-autoroll
babc722438
Roll Flutter Engine from 55670b71eb00 to 3db86b3cabec (4 revisions) (#147095)
55670b71eb...3db86b3cab

2024-04-19 skia-flutter-autoroll@skia.org Roll Dart SDK from 2ff00e4eb759 to d882ce089110 (1 revision) (flutter/engine#52272)
2024-04-19 dkwingsmt@users.noreply.github.com [macOS] Consolidate view management (flutter/engine#52254)
2024-04-19 skia-flutter-autoroll@skia.org Roll Skia from f4a214ecf197 to 1910252ea26a (3 revisions) (flutter/engine#52269)
2024-04-19 jonahwilliams@google.com [Impeller] add non-emulated advanced blend support to experimental canvas (flutter/engine#52245)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-20 00:34:25 +00:00
Kostia Sokolovskyi
a5fa351c89
Add Kostiantyn Sokolovskyi to the AUTHORS. (#147065)
This PR adds my name to AUTHORS.

Reference: [author:ksokolovskyi](https://github.com/flutter/flutter/issues?q=author%3Aksokolovskyi)
2024-04-19 23:33:06 +00:00
engine-flutter-autoroll
a11438f51b
Roll Flutter Engine from a9a6f598f007 to 55670b71eb00 (1 revision) (#147091)
a9a6f598f0...55670b71eb

2024-04-19 jonahwilliams@google.com [Impeller] organize texture shaders / delete blend.frag + external_texture_fill (flutter/engine#52137)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 23:23:03 +00:00
flutter-pub-roller-bot
16a2fe88d3
Roll pub packages (#147030)
This PR was generated by `flutter update-packages --force-upgrade`.
2024-04-19 23:15:37 +00:00
Kostia Sokolovskyi
142e247fab
Add tests for gesture_detector.0.dart and gesture_detector.1.dart API examples. (#146724)
This PR contributes to https://github.com/flutter/flutter/issues/130459

### Description
- Adds `examples/api/test/widgets/gesture_detector/gesture_detector.0_test.dart` test
- Adds `examples/api/test/widgets/gesture_detector/gesture_detector.1_test.dart` test
2024-04-19 23:08:04 +00:00
dependabot[bot]
24def4d417
Bump actions/checkout from 4.1.2 to 4.1.3 (#147090)
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.2 to 4.1.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.1.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1650">actions/checkout#1650</a></li>
<li>Check git version before attempting to disable <code>sparse-checkout</code> by <a href="https://github.com/jww3"><code>@​jww3</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1656">actions/checkout#1656</a></li>
<li>Add SSH user parameter by <a href="https://github.com/cory-miller"><code>@​cory-miller</code></a> in <a href="https://redirect.github.com/actions/checkout/pull/1685">actions/checkout#1685</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a href="https://github.com/actions/checkout/compare/v4.1.2...v4.1.3">https://github.com/actions/checkout/compare/v4.1.2...v4.1.3</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="1d96c772d1"><code>1d96c77</code></a> Add SSH user parameter (<a href="https://redirect.github.com/actions/checkout/issues/1685">#1685</a>)</li>
<li><a href="cd7d8d697e"><code>cd7d8d6</code></a> Check git version before attempting to disable <code>sparse-checkout</code> (<a href="https://redirect.github.com/actions/checkout/issues/1656">#1656</a>)</li>
<li><a href="8410ad0602"><code>8410ad0</code></a> Update <code>actions/checkout</code> version in <code>update-main-version.yml</code> (<a href="https://redirect.github.com/actions/checkout/issues/1650">#1650</a>)</li>
<li>See full diff in <a href="9bb56186c3...1d96c772d1">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=actions/checkout&package-manager=github_actions&previous-version=4.1.2&new-version=4.1.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>
2024-04-19 23:03:04 +00:00
Jago
5c5e64722e
[material] Fix info text (#147040)
Fixes intro info text for `IconButton.outlined` constructor.

No fixing issue required as this is a text fix.
2024-04-19 22:55:05 +00:00
engine-flutter-autoroll
5931b7b1ce
Roll Flutter Engine from 0902c4117ed9 to a9a6f598f007 (1 revision) (#147088)
0902c4117e...a9a6f598f0

2024-04-19 skia-flutter-autoroll@skia.org Roll Skia from 0689969ffaee to f4a214ecf197 (1 revision) (flutter/engine#52265)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 22:22:11 +00:00
engine-flutter-autoroll
6b2122bfa6
Roll Flutter Engine from 5083af669cee to 0902c4117ed9 (1 revision) (#147085)
5083af669c...0902c4117e

2024-04-19 flar@google.com [Impeller] Use the new DisplayList depth info in the experimental canvas prototype (flutter/engine#52214)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-04-19 21:22:26 +00:00