7119 Commits

Author SHA1 Message Date
xster
4fcdb50d9b
Add Cupertino scrollbar (#13290)
* Create CupertinoScrollbar

* handle main axis margin

* Adaptive material scrollbar and tests

* Small tweaks

* reapply changes on head

* Docs

* start

* Refactored ScrollbarPainter to be more immutable

* fix tests

* fix bug: one animationcontroller pointed to multiple painters

* some docs tweak

* remove unused import

* review

* review

* add dispose
2017-12-21 16:44:42 -08:00
Michael Goderbauer
4e13cd07bb
Fixes crash caused by invisible semantics children (#13740)
**tl;dr:** A `RenderObject` can only be an effective semantics boundary if it actually owned a `SemanticsNode` in the previous tree generation.

When using the `BlockSemantics` widget it is possible to introduce `RenderObject`s that are configured to be a semantics boundary, but because their semantics are blocked by `BlockSemantics` they will not (immediately) end up owning a `SemanticsNode`. When now a descendant of such a node-less semantics boundary marks itself as needing a semantics update we walk up the tree until we find the closest semantics boundary (which is our node-less `RenderObject`). We now incorrectly assume that this semantics boundary has a valid `SemanticsNode` and only regenerate the semantics subtree below this node. However, because the identified semantics boundary doesn't actually own a valid `SemanticsNode` asserts are throwing (e.g. `Child with id xx is invisible and should not be added to tree.`).

To fix this problem, we can just abort the walk if we reach a semantics boundary without a semantics node because (for now) we know that the semantics information of this branch will not make it into the final semantics tree.
If the semantics block is ever removed, the current algorithm re-generates the semantics for the entire branch and the semantics will be up-to-date then despite the abort. I've added a test to verify this to make sure it continues to work even when we change the algorithm.

Fixes https://github.com/flutter/flutter/issues/13326.
/cc @gavindoughtie FYI
2017-12-21 16:09:43 -08:00
amirh
56061759fc
Add an AnimatedIcon class and vitool (vector icon tool) to generate data for it (#13530) 2017-12-21 15:46:05 -08:00
Ian Hickson
370c73d9bc
Audit all the "final Widget child" properties. (#13718)
This attempts to apply some of what we learnt from UX studies, namely
that people wonder how to add multiple children to widget that take
one child.
2017-12-21 15:02:35 -08:00
Ian Hickson
4e2f77745f
Miscellaneous documentation improvements (#13719)
This is a collection of fixes I've run into recently.
2017-12-21 15:02:21 -08:00
Ian Hickson
4e16b9db29
Attempt a less invasive way to disable fading. (#13733)
Hopefully this will fix the performance regression in https://github.com/flutter/flutter/pull/13680 but with an easier way to flip the switch.
2017-12-21 15:02:03 -08:00
Leaf Petersen
b3cfa785c4
Uncontroversial and backwards compatible 2.0 SDK fixes (#13723)
Small code changes as part of moving the framework SDK forward to a 2.0 dev version.
2017-12-21 13:39:03 -08:00
Ian Hickson
ecb708ee3a
Clean up lerp() methods and their documentation. (#13684)
This cleans up lerp, lerpFrom, lerpTo, and scale methods, and their
documentation.

Fixes https://github.com/flutter/flutter/issues/12377.
2017-12-21 11:09:49 -08:00
Yegor
291602db92
localize a11y tab labels in the TabBar (#13714)
* localize a11y tab labels in the TabBar

* break import cycle

* test boilerplate

* fix German translation

* more test boilerplate fixes
2017-12-20 17:10:32 -08:00
Yegor
6873608184
Make UserAccountsDrawerHeader accessible (#13711)
* other accounts a11y; show accounts button a11y

* layout with bigger tap areas; all semantics

* internationalize UserAccountsDrawerHeader a11y labels

* better Russian translation

* break import cycle

* address comments
2017-12-20 17:10:06 -08:00
Greg Spencer
dd796853cc
Revert "Adding minzip to packaging steps for Windows (#13679)" (#13716)
This reverts commit 765191e7b4ec55758293090cdd37c97cbd9ec757.
because the updated packages cause a gradle build problem.
2017-12-20 16:21:57 -08:00
Greg Spencer
765191e7b4
Adding minzip to packaging steps for Windows (#13679)
This adds our self-compiled copy of the MinGit executable (built from the flutter/git repo) to the archive when building an archive for Windows.

I also tweaked the internal API for prepare_package.dart so that there's a single entry point to build an archive.
2017-12-20 15:35:53 -08:00
Hans Muller
83134cd39f
Added find.ancestor to CommonFinders (#13691) 2017-12-20 15:03:58 -08:00
Ian Hickson
b1c870b312
Reenable fade transition for Material page transition (#13048) (#13680)
Fixes #12877 by reverting #9472
2017-12-20 13:52:01 -08:00
Victor Choueiri
ba58111b7b Add .vscode/ to .gitignore template (#13697)
Adds .vscode/ to the .gitignore rules generated on flutter create.
2017-12-20 12:43:22 -08:00
Yegor
81d4834278
support increase and decrease SemanticsActions in time picker (#13689)
* support increase and decrease SemanticsActions in time picker

* test roll over
2017-12-20 10:25:33 -08:00
Mikkel Nygaard Ravn
36bcdc4c7e
Fix Android templates (#13681) 2017-12-20 10:50:40 +01:00
Michael Goderbauer
52ebff721a
selected ListTile is selected (#13676)
* selected ListTile is selected

* review comment

* analyzer fix
2017-12-19 16:39:56 -08:00
Hans Muller
31418570a2
Gen localization classes intead of a big map (#13653)
* Gen localization classes intead of a big map

* tighten up the newlines so that std output matches file output

* restore locale sorting
2017-12-19 14:02:22 -08:00
Alan Russian
30720bd148 Change async stubbing to use thenAnswer. (#13521)
* Change async stubbing to use thenAnswer.

Mockito now prohibits calling thenReturn with Futures and Streams. dart-lang/mockito#79

* Update all Mockito deps to 3.0.0.

* Revert "Update all Mockito deps to 3.0.0."

This reverts commit e8ab9d37c33d3d7fe384abde64ea5b4d72623c75.

I did not correctly update the mockito dep, and there's no easy way to update to 3.0 alpha right now.

* Change thenAnswer((_) => to thenAnswer((invocation) =>

* Add Invocation type to thenAnswer lambdas
2017-12-19 13:13:57 -08:00
Ian Hickson
78ff7707e1
Fix niggling PaginatedDataTable bugs (#13556)
Prevent header from thinking it can wrap and then overflowing.

Fix default footer string which lost its colon (localized values are fine).

Make the "rows per page" drop-down include at least one value even when the table lacks many items. (Previously it would assert if your table was too short.)

Make the footer scrollable.

Fix some todos and improve some debug output.

Tests for much of the above.
2017-12-19 12:39:48 -08:00
Yegor
b5eac0422a
use different delimiter for generated code; print generated code into mismatch description (#13667) 2017-12-19 11:45:29 -08:00
Michael Goderbauer
e6f20eb95c
IconButton is a button, semantically (#13674)
* IconButton is a button, semantically

* fix datepicker test
2017-12-19 11:33:23 -08:00
Hans Muller
12f405578f
Added five new locales to flutter_localizations (#13621) 2017-12-19 11:09:50 -08:00
xster
ce75911f1a
Add flutter_assets and *.class to gitignore (#13664) 2017-12-19 10:21:59 -08:00
Mikkel Nygaard Ravn
d2d86e35c5
Bump test timeout threshold (#13661) 2017-12-18 23:04:07 +01:00
Sarah Zakarias
73552ecae2 Remove app.flx on iOS (#13648) 2017-12-18 18:58:44 +01:00
Sarah Zakarias
2ef379ad12
Remove app.flx from apk (#13647) 2017-12-18 14:33:35 +01:00
Chris Bracken
7fb78523e9
Require Xcode 9.0 or later for iOS builds (#13608) (#13622)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.

This re-lands flutter/flutter#13608 now that the devicelab Macs have
been updated to Xcode 9.
2017-12-15 18:13:10 -08:00
Ian Hickson
8e5d77d3fa
Make animating opacity cheaper. (#13583)
No need to update the compositing bits all the time.
2017-12-15 18:10:36 -08:00
Chris Bracken
813be533cd
Apply media padding to snackbar contents (#13623)
Applies any additional bottom, left, and right media padding inside the
snackbar, if present. This accounts for the iPhone X home indicator
widget and horizontal padding for the sensor housing notch in landscape
orientation.
2017-12-15 17:55:25 -08:00
xster
a43be998ec
Split one CustomPainter doc paragraph to bullet points (#13590)
* split doc paragraph

* specify shouldRepaint argument nullability

* review
2017-12-15 15:56:28 -08:00
Chris Bracken
f39a847c8b
Apply media padding in UserAccountsDrawerHeader (#13619)
Applies top, left, right media padding to avoid placing content within
the safe area insets (e.g. iPhone X notch area in landscape
orientation).
2017-12-15 15:52:19 -08:00
Ian Hickson
e65c882e97
Provide a navigatorKey property on MaterialApp and WidgetsApp (#13591)
This lets people poke at navigators without having to get their
BuildContext from a build function or State first.
2017-12-15 14:41:52 -08:00
amirh
05dba60c63
keep recursing past directories with pubspec.yaml when gathering packages (#13573) 2017-12-15 12:21:03 -08:00
Chris Bracken
6728d4845d
Revert "Require Xcode 9.0 or later for iOS builds (#13608)" (#13612)
Our devicelab machines have not yet been upgraded to Xcode 9. Once this
has been done, I'll re-land this.

This reverts commit 0fac5f01a2469b2658a64da139884b337de5f9dd.
2017-12-15 11:59:42 -08:00
Chris Bracken
0fac5f01a2
Require Xcode 9.0 or later for iOS builds (#13608)
We now require Xcode 9.0, which ships with the iOS 11 SDK, for iOS
builds. This change does not affect the minimum supported iOS deployment
target, which remains iOS 8.

The iOS 11 SDK adds support for safe area insets, which model the status
bar, iPhone X home indicator, and symmetric horizontal insets to avoid
the iPhone X sensor housing when in landscape mode.
2017-12-15 11:44:01 -08:00
Yegor
235b64ed2f
make date picker accessible (#13502)
* make date picker accessible

* make test file lookup location-independent

* address some comments

* always wrap in IgnorePointer

* no bitmasks for flags and actions

* recommend List<*>
2017-12-14 20:38:39 -08:00
Chris Bracken
5bbcf6d4fc
Apply T, L, R media padding in Cupertino nav bar (#13580)
Applies top, left, right media padding for iOS safe area insets. This is
a follow-up to the media padding applied to large titles in
flutter/flutter#13550.
2017-12-14 15:26:16 -08:00
Ian Hickson
c28121eeca
Allow the ErrorWidget to be overridden. (#13578)
Fixes https://github.com/flutter/flutter/issues/10695
2017-12-14 15:05:41 -08:00
Michael Goderbauer
f9cf5a1f3d
Add a11y label to modal barrier (#13543) 2017-12-14 15:03:51 -08:00
xster
6299dbada8
Document various 'alignment' members so it's clear how to concretely specify it. (#13577) 2017-12-14 13:19:26 -08:00
amirh
becab558e1
flutter update-packages (#13571)
* flutter update-packages

* update plugin registrant for flutter_gallery
2017-12-14 10:07:51 -08:00
amirh
7d90bfc179
Pin the test package to 0.12.26 (#13546) 2017-12-14 08:52:56 -08:00
Phil Quitslund
3346c5c736
Update plugin test template. (#13516)
* Update plugin test template.

* Add flutter test run verification.

* Tweak and test runs for package projects.
2017-12-14 08:51:33 -08:00
Sarah Zakarias
5e18c07614
Reapply flutter_assets (#13567)
* Revert "Revert engine (#13547)"

This reverts commit ee65db11d4618620ddc286f4618b707239205136.

* Keep flaky mark
2017-12-14 17:27:25 +01:00
Sarah Zakarias
5c90c35f22
Write flutter_assets directory on Windows (#13564) 2017-12-14 16:08:31 +01:00
Mikkel Nygaard Ravn
5ae507a752
Revert "Refresh template instances (#13563)" (#13565)
This reverts commit 05d6b08ffe12bed1328f65d911440ddab55751a2.
2017-12-14 15:38:39 +01:00
Mikkel Nygaard Ravn
05d6b08ffe
Refresh template instances (#13563) 2017-12-14 15:19:59 +01:00
Mikkel Nygaard Ravn
a2296aa8e3
Simplify project template (#13558) 2017-12-14 11:38:20 +01:00