10026 Commits

Author SHA1 Message Date
Jonah Williams
514fb2c7c0
Revert "fix edge swiping and dropping back at starting point (#31623)" (#31876) 2019-04-30 15:44:09 -07:00
Dan Field
4bc35fc87a
Allow DSS to be dragged when its children do not fill extent (#31832)
* Allow DSS to be dragged when its children do not fill extent

* Fix when maxChildSize  < 1.0
2019-04-30 15:42:42 -07:00
Dan Field
c0d5fd23ab
Handle notification errors (#31868) 2019-04-30 15:42:22 -07:00
Jonah Williams
5e77d6508e
Initial sketch of tools testbed (#31765) 2019-04-30 15:42:16 -07:00
Jonah Williams
48936d9a95
Remove deprecated commands (#31759) 2019-04-30 14:43:03 -07:00
liyuqian
fb87619143
Fix prefer_const_constructors (#31860)
This will fix our flutter build post-submit analyze test

Merge on red to fix flutter build
2019-04-30 10:38:26 -07:00
Tong Mu
fea2c7d671
Redo: Add buttons to gestures (#31819)
* Revert "Revert "Add buttons to gestures (#30339)" (#31801)"

This reverts commit 8fd7fa492aaad0d0d4aa062d71b1ecba8b0d4f44.

* Synthesise kPrimaryButton for unknown devices

* Change TestPointer to a better API
2019-04-30 09:56:24 -07:00
liyuqian
71a89a469a
Reland "Fix text field selection toolbar under Opacity (#31097)" (#31802)
This reverts commit 120a1fc47f7379de556e02d3eb5b49ccd78a28b6.

Updated the golden file
2019-04-30 09:47:32 -07:00
liyuqian
7cab6d5e1c
Support clipBehavior changes in hot reload (#31761)
## Description

Make `_RenderCustomClip`'s `clipBehavior` non-final so we can update it during `updateRenderObject`. This will support `clipBehavior` changes in hot reload.

## Related Issues

Fixes #30863

## Tests

I added the following tests:

* ClipRect updates clipBehavior in updateRenderObject
* ClipRRect updates clipBehavior in updateRenderObject
* ClipOval updates clipBehavior in updateRenderObject
* ClipPath updates clipBehavior in updateRenderObject
* PhysicalModel updates clipBehavior in updateRenderObject
* PhysicalShape updates clipBehavior in updateRenderObject
2019-04-30 09:46:38 -07:00
Keerti Parthasarathy
eae67f05df
Make const available for classes that override AssetBundle (#31807) 2019-04-30 09:10:04 -07:00
Dan Field
eac2104bc6
remove assert for Flutter Driver (#31815) 2019-04-29 17:03:25 -07:00
Shi-Hao Hong
39712854fc
Fix ExpansionPanelList Duplicate Global Keys Exception (#31228)
- Move `setState` to only be invoked when guarded by `widget._allowMultiplePanelsOpen`, fixing the case for `ExpansionPanelList`

- Remove setting `_currentOpenPanel` to `widget.initialOpenPanelValue` in `didUpdateWidget`, since this should only occur on `initState` and not every time the widget is updated. This fixes the problem for `ExpansionPanelList.radio`

- Added a `didUpdateWidget` condition for when `ExpansionPanelList` changes into `ExpansionPanelList.radio` to open the panel at `widget.initialOpenPanelValue`

- Added test cases for regression, expansionCallback cases, and `didUpdateWidget` transitions between `ExpansionPanelList` and `ExpansionPanelList.radio`
2019-04-29 16:55:05 -07:00
Jonah Williams
37e25238a8
Attempt to reduce usage of runtimeType (#31696) 2019-04-29 16:44:50 -07:00
Dan Field
fe9512fa72
Re-enable const (#31600)
* Re-enable const
2019-04-29 16:02:42 -07:00
Jonah Williams
8fd7fa492a
Revert "Add buttons to gestures (#30339)" (#31801)
This reverts commit 727e7e829f4debf7a7aaaad3c37151b362ed4cba.
2019-04-29 12:59:30 -07:00
Jonah Williams
120a1fc47f
Revert "Fix text field selection toolbar under Opacity (#31097)" (#31800) 2019-04-29 12:57:35 -07:00
liyuqian
e427c2dd86
Fix text field selection toolbar under Opacity (#31097)
## Description

As we've introduced offset to the Opacity layer, we have to override
`applyTransform` to make Leader/FollowerLayer work correctly.

## Related Issues

Fixes https://github.com/flutter/flutter/issues/30587

Together with https://github.com/flutter/engine/pull/8585,
this test will also exercise test against
https://github.com/flutter/flutter/issues/30586.

## Tests

I added the following tests:
* text field selection toolbar renders correctly inside opacity
2019-04-29 11:25:41 -07:00
xster
d12f359991
fix edge swiping and dropping back at starting point (#31623) 2019-04-29 11:05:24 -07:00
Tong Mu
727e7e829f
Add buttons to gestures (#30339)
* Callbacks of tap, long press, drag, and double tap GR respond to only primary events.
* Add "secondary" callbacks to tap.
* Recognizers only compete on events if there are any related callbacks.
* Add "kSecondaryButton" constant.
2019-04-29 10:46:33 -07:00
Jonah Williams
c1c15dd702
Revert "update packages and unpin build (#31736)" (#31795) 2019-04-29 09:56:55 -07:00
Jonah Williams
41b18422df
update packages and unpin build (#31736) 2019-04-29 09:10:01 -07:00
Jonah Williams
4ff467191b
make FlutterProject synchronous (#31757) 2019-04-29 08:21:32 -07:00
MH Johnson
5412ef07f2
[Material] Update TabController to support dynamic Tabs (#30884)
* Update TabController to support dynamic tabs.

* Added test for single Tab showing correct color.
2019-04-29 10:35:55 -04:00
Dmitriy Zaitsev
8e66c53f3d Fix the documentation for UiKitView#creationParams (#31619)
It looks like the documentation for UiKitView has been copy-pasted from AndroidView or so.
This PR fixes the word 'Android' to 'iOS' for the `creationParams`.
2019-04-29 14:50:44 +02:00
Sander Kersten
9d16b84b35 Fix calculation of hero rectTween when Navigator isn't fullscreen (#29677) 2019-04-29 14:43:44 +02:00
James D. Lin
ae5749819b Make the matchesGoldenFile docs link to an explanation of how to create golden image files (#31093) 2019-04-29 14:43:24 +02:00
Antti Ahti
bf8262d85b Remove trailing whitespace from README template (#31762) 2019-04-29 13:04:55 +02:00
Kent Boogaart
392d5b2c28 Fix typo (#31771) 2019-04-29 13:04:30 +02:00
Shi-Hao Hong
7c4ccb349e
Improve ThemeData.accentColor connection to secondary color (#31295) 2019-04-26 19:39:22 -07:00
K. P. Sroka
59f4e92b6e Update onChange docs to Radio and RadioListTile
Added note that onChange callback will not be invoked if the radio is already selected
2019-04-26 19:36:22 -07:00
xster
26d7f502a9
Add some docs to StatefulBuilder (#31291) 2019-04-26 18:10:18 -07:00
Greg Spencer
7565093f3e
Revert "Add support for Tooltip hover (#31561)" (#31692)
This reverts commit eca93640697f4ed4b37bf8d0817c15b5f9ca4575 because of four
performance regressions. Will fix and re-land.
2019-04-26 14:29:19 -07:00
Dan Field
6a48e663ef
Bottom sheet scrolling (#21896) 2019-04-26 14:12:11 -07:00
Danny Tuppeny
fdcc8aafa7
Allow adb stdout to contain the port number without failing (#31491)
* Allow adb stdout to contain the port number without failing

* Add tests that port forwarder correctly responds to known ADB output
2019-04-26 21:03:25 +01:00
Jonah Williams
9d364043af
Refactor the test compiler into a separate library (#31642) 2019-04-26 12:33:41 -07:00
chunhtai
d121df9987
fix 31511: Test performance has regressed (#31582) 2019-04-26 09:02:38 -07:00
Shi-Hao Hong
14f2f98f9d
Add InkWell docs on transitions and ink splash clipping (#31316) 2019-04-26 07:55:29 -07:00
Dan Field
81803cacf3
Remove engine tests (#31452) 2019-04-26 01:01:51 -07:00
LongCatIsLooong
7d19f97d03
Fix refresh control in the gallery demo, update comments (#30129)
- Fixed the bug where CupertinoRefreshControl doesn't work in the gallery demo on Android.
- Updated documentation on CupertinoRefreshControl
- Added comments to the gallery demo
- Added concrete examples to ScrollPhysics
2019-04-25 20:49:47 -07:00
Todd Volkert
e57d0ff73b
Fix doc link (#31638) 2019-04-25 20:31:45 -07:00
Greg Spencer
7775c23784
[Re-Land] Implement focus traversal for desktop platforms. (#31614)
This re-lands the Focus changes in #30040. Correctness changes in routes.dart, and removes the automatic requesting of focus on reparent when there is no current focus, which caused undesirable selections.

Addresses #11344, #1608, #13264, and #1678
Fixes #30084
Fixes #26704
2019-04-25 16:26:58 -07:00
Jonah Williams
fdae7bb871
add check that xcode project configuration is not missing (#31621) 2019-04-25 15:51:25 -07:00
Jonah Williams
0acd3e6b04
refactor context to be implicit-downcast safe (#31622) 2019-04-25 15:51:08 -07:00
Jonah Williams
52415cb0a5
baby-steps to testing/refactoring flutter_platform (#31616) 2019-04-25 14:01:28 -07:00
Greg Spencer
eca9364069
Add support for Tooltip hover (#31561)
Adds support for mouse pointer hovering to trigger tooltips, as well as custom timeouts for the tooltip durations, and a custom decoration. It also makes the tooltip be fully opaque when shown, and fade in over 150ms, and fade out over 75ms, and draw a 4.0 corner radius, all to conform with the material spec. Prior to this change, it was using a corner radius of 2.0 when shown, and faded in and out over 200ms.

Fixes #22817
2019-04-25 13:39:52 -07:00
Justin McCandless
a21a1f4105
iOS selection handles are invisible (#31332)
Fix a bug where text selection handles were invisible in iOS
2019-04-25 12:32:10 -07:00
Jonah Williams
6b191841f3
Allow filtering devices to only those supported by current project (#31446) 2019-04-25 12:25:12 -07:00
Phil Quitslund
5ec33654b1
fix transform assert (#31568)
* fix transform assert
2019-04-25 10:56:44 -07:00
Dan Field
1db5d66932
Capture JSON RPC errors that presently get swallowed (#31584)
* Update packages
* Capture JSON RPC errors that presently get swallowed
2019-04-25 08:27:00 -07:00
sjindel-google
e84b4c47b8
Allow all tests to run with --update-goldens. (#31562)
Previously benchmark_test.dart would break if run with --update-goldens.
Now the entire test suite can be run with --update-goldens.
2019-04-25 17:13:26 +02:00