20933 Commits

Author SHA1 Message Date
Kate Lovett
cfc8ec23b6
Re-land 'Wrap PopupMenu with SafeArea to respect status bar' (#67578) 2020-10-07 17:07:05 -07:00
Darren Austin
3c21775c94
Migrate Material framework tests to null safety (#67556)
Migrate Material framework tests to null safety.
2020-10-07 16:44:00 -07:00
Casey Hillers
9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON (#67550) 2020-10-07 16:37:09 -07:00
Chris Bracken
b851f99794
Preserve composing range if possible on sel change (#67197)
When setting the TextSelection in a TextEditingController, preserve the
composing range so long as the new selection is:

  * a collapsed selection; in other words, a cursor rather than a
    selection with an extent. A selection with an extent is not
    permitted when composing.
  * within the composing region. Moving the cursor outside the composing
    region ends composing mode.

When using physical keyboards for input with an IME, users expect to be
able to navigate using the cursor within the composing region with the
arrow keys in order to edit text in the composing range.

As an example, a user might erroneously enter the composing text
にほんごにゅうろく in kana, then hit the left arrow, followed by
backspace in order to delete the ろ, then input りょ in order to
generate the correct composing text にほんごにゅうりょく, before then
hitting the conversion key to convert to the kanji text 日本語入力 and
commit.
2020-10-07 16:36:01 -07:00
Kate Lovett
019e90f7df
[NNBD] Migrates some rendering tests (#67449) 2020-10-07 16:27:06 -07:00
Ayush Bherwani
3517412446
Exposes ListTile.shape for CheckboxListTile and SwitchListTile (#67419) 2020-10-07 16:22:05 -07:00
Jonah Williams
b3f9944f3c
[flutter_tools] remove deprecated flutter command (#67478) 2020-10-07 16:21:08 -07:00
Jonah Williams
a4e0e2a8ee
Revert "[flutter_tools] remove all pub caching logic (#66776)" (#67572)
This reverts commit 76cbc462d21cf3e0399bccbac043b003c7efc888.
2020-10-07 15:30:46 -07:00
Jonah Williams
5e4c86d124
Revert "Wrap PopupMenu with SafeArea to respect status bar (#64678)" (#67566)
This reverts commit 2e419ff769281fb10ab875667fbe2ba1ecbe87ca.
2020-10-07 14:58:12 -07:00
Dan Field
ad49e25a6b
Revert "[null-safety] reland: migrate app side flutter driver to null-safety (#67441)" (#67561)
This reverts commit d411242468773a800945f0d8c6cfcf40c7ea8e44.
2020-10-07 13:57:49 -07:00
Justin McCandless
e98e0b409f
EditableText action handlers swallow errors (#66851)
Errors that happen in user-defined callbacks (like onChanged) will now make it to the console.
2020-10-07 13:40:38 -07:00
Markus Aksli
571b190f07
Explained parent constraints in SizedBox (#66639) 2020-10-07 13:32:03 -07:00
Juyeong Lee
2e419ff769
Wrap PopupMenu with SafeArea to respect status bar (#64678) 2020-10-07 13:27:06 -07:00
Ian Hickson
553577ab03
Run docs shard on everything. (#67549) 2020-10-07 13:22:04 -07:00
Michael Goderbauer
52d3bef017
Reland removal of examples/catalog (#67545) 2020-10-07 13:17:08 -07:00
YeungKC
db25441fd9
Update the cupertino picker visuals (#65501) 2020-10-07 13:12:12 -07:00
Tong Mu
0fbc95df21
Remove the extra wrapping of Listener (#67340) 2020-10-07 13:12:05 -07:00
Jonah Williams
76cbc462d2
[flutter_tools] remove all pub caching logic (#66776)
There have been some more additional reports of a missing 'package:characters' import after upgrading flutter, as well as problems with detecting the correct language version. This has me concerned that our pub caching logic is incorrect. Instead of the tool attempting to guess when pub should be run, always delegate to pub.
2020-10-07 13:11:07 -07:00
Daniel Iglesia
826b70466a
Add rootOverlay flag to [Draggable], to put feedback on root [Overlay] (#67375) 2020-10-07 11:55:49 -07:00
Michael Goderbauer
727cee6d87
Migrate More Material Tests (#67482) 2020-10-07 11:02:04 -07:00
Michael Goderbauer
bd2ec40c08
Revert "Remove catalog (#67470)" (#67542)
This reverts commit 2462f6964ac267f884dd6cbb8035feb1da4b0f5d.
2020-10-07 10:28:06 -07:00
Michael Goderbauer
3961a12a6d
Migrate some material tests to nnbd (#67477) 2020-10-07 10:11:24 -07:00
Darren Austin
af0c7aed1c
Migrate framework tests for rendering, semantics, widgets to null safety (#67453)
Migrate framework tests for rendering, semantics, widgets to null safety.
2020-10-07 10:06:32 -07:00
Michael Goderbauer
2462f6964a
Remove catalog (#67470) 2020-10-07 09:57:02 -07:00
Andre
b77753b969
Add transformAlignment and clipBehavior to AnimatedContainer (#67046)
* Add transformAlignment and clipBehavior to AnimatedContainer, make Container.transformAlignment an AlignmentGeometry.

* Add clipBehavior test

* Fix comment

* Clarify clipBehavior animation
2020-10-07 12:26:02 -04:00
Jenn Magder
f8b1de3a63
Add publish-port flag to disable mDNS port discovery (#67452) 2020-10-07 08:52:05 -07:00
Jonah Williams
e1b4142a74
[flutter_tools] remove stray print from engine locator (#67530)
Woops, this is breaking Dart's golem benchmarks
2020-10-07 08:51:20 -07:00
Janice Collins
e9a9a6104c
Update dartdoc to 0.35.0 (#67432) 2020-10-07 08:47:05 -07:00
Jonah Williams
13bf341584
[flutter_tools] update build rules to depend on subset of package_config contents (#67165)
Split from #66776

Even if pub does not change the packge_config contents, it will still update a timestamp in one of the fields. This causes unnecessary rebuilds. To fix this, generate an additional file when running pub get that only contains the relevant fields and then update the KernelSnapshot rule to depend on it only.
2020-10-07 08:46:11 -07:00
Hans Muller
ab9373bf48
Removed remaining obsolete button widget references (#67440) 2020-10-07 08:45:41 -07:00
Jonah Williams
6620f831e9
fix dart docs for build (#67479) 2020-10-06 18:15:15 -07:00
Jonah Williams
e9c94e6c45
fix build analysis errors (#67476) 2020-10-06 17:41:21 -07:00
Alexandre Ardhuin
f1c1d944e3
fix nullability issues (#67443) 2020-10-06 17:07:05 -07:00
Justin McCandless
896c19a292
Characters docs (#67361) 2020-10-06 17:02:04 -07:00
Kate Lovett
b5562c1b19
[NNBD] More test migration for Cupertino & Painting (#67323) 2020-10-06 16:57:03 -07:00
Jonah Williams
ef6c720d40
[flutter_test] handle breaking change to test main (#67425)
* [flutter_test] handle breaking change to test main . Fixes #67382
2020-10-06 16:52:23 -07:00
Ian Hickson
8d923bf9a7
flutter_web_plugins cleanup and documentation (#67164) 2020-10-06 16:52:02 -07:00
Jonah Williams
d411242468
[null-safety] reland: migrate app side flutter driver to null-safety (#67441)
Reland: #67155

Fixes analysis error caused by landing of material migration, and g3 error caused by moving of fuchsia lib.
2020-10-06 16:51:37 -07:00
engine-flutter-autoroll
bdfef51414
Roll Engine from 443cd5a1e1b3 to 7e6191de077d (6 revisions) (#67442) 2020-10-06 13:52:02 -07:00
Hans Muller
1a08ce7400
Updated the remaining obsolete button references in flutter_gallery (#67437) 2020-10-06 13:21:08 -07:00
Michael Goderbauer
4fa4f91d5c
Remove required for onRemove in InteractiveInkFeature.create (#67427) 2020-10-06 12:31:25 -07:00
Jenn Magder
e5131fa31b
Increase device discovery timeout in devicelab health check (#67337) 2020-10-06 12:23:02 -07:00
Michael Goderbauer
582c67a125
Make CupertinoTabView restorable (#67169) 2020-10-06 11:03:13 -07:00
Jonah Williams
4818537044
Revert "[null-safety] migrate app dependencies of flutter driver (#67155)" (#67433)
This reverts commit e826442ef4215d6d32ec668ce798c6b3f1d72936.
2020-10-06 10:41:45 -07:00
Jonah Williams
e826442ef4
[null-safety] migrate app dependencies of flutter driver (#67155)
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.
2020-10-06 10:30:15 -07:00
stuartmorgan
be6a368801
Improve Windows symlink instructions (#67029)
When the developer doesn't have permission to create symlinks, we
display specific instructions, but they were only correct for recent
versions of Windows 10. This improves them by:
- Giving the correct instructions for older versions.
- For recent versions, adds a command that will deep-link into the
  settings application so that developers don't have to figure out
  where/how to enable developer mode.

Fixes https://github.com/flutter/flutter/issues/66973
2020-10-06 08:32:54 -07:00
Nate Bosch
8ee2b2f1d1
Condense package:test_core imports (#67357)
Use the new single `src/platform.dart` import to pick up what is needed
to implement a test platform from both `test_api` and `test_core`.
2020-10-06 08:26:31 -07:00
Alexandre Ardhuin
555cb66ece
fix tree (#67410) 2020-10-06 14:38:19 +02:00
Alexandre Ardhuin
f551178408
migrate material to nullsafety (#67166)
* migrate material to nullsafety

* address review comments

* address review comments

* fix build
2020-10-06 11:36:50 +02:00
engine-flutter-autoroll
aaa99f6d4e
Roll Engine from 6e1e73d899b9 to 443cd5a1e1b3 (2 revisions) (#67381) 2020-10-06 00:47:04 -07:00