10615 Commits

Author SHA1 Message Date
Jonah Williams
6b17840cbf
Don't try to flutterExit if isolate is still paused (#36199) 2019-07-15 15:44:58 -07:00
Christopher Fujino
102ab1e6d9
Reland bundle ios deps (#36093)
This updates the flutter tool cache to download binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-15 09:22:29 -07:00
Jonah Williams
e3ee5c6bbb
Add better handling of JSON-RPC exception (#36082) 2019-07-13 16:02:09 -07:00
Ian Hickson
d919e694b8
Move tools tests into a general.shard directory in preparation to changing how we shard tools tests (#36108) 2019-07-13 11:51:44 -07:00
Hey24sheep
bec1b9a15c Optimize gesture recognizer instantiation (#35979) 2019-07-13 10:33:21 -07:00
Zachary Anderson
13382f41c0
[flutter_tool] Catch a yaml parse failure during project creation (#36105) 2019-07-12 23:24:04 -07:00
Jonah Williams
7056214151
Handle google3 version of pb (#36084) 2019-07-12 13:45:26 -07:00
Jonah Williams
0a97553e5e
Revert "Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2" (#36096) 2019-07-12 13:42:32 -07:00
Kate Lovett
8809f698cb
Revert "Part 1: Skia Gold Testing (#33688)" (#36094)
This reverts commit eb0b17902876f1a75eb7180c0b9f3571efb312b8.
Skia Gold post-submit test were failing due to the service account not being found on Cirrus.
2019-07-12 13:35:36 -07:00
Tim Sneath
67ab890b60 Merge branches 'master' and 'master' of github.com:flutter/flutter into timsneath-precache2 2019-07-12 12:59:08 -07:00
Tim Sneath
7349970462 Update comments to match precache help 2019-07-12 12:59:01 -07:00
Tim Sneath
b322fdd518 Update precache help 2019-07-12 12:57:28 -07:00
Kate Lovett
eb0b179028
Part 1: Skia Gold Testing (#33688)
* Fresh PR for Gold integration.

* Nits

* WIP

* Artifacts from merge

* Changed some platform dependencies for web, added library prefix notation for Skia Gold test names.

* Updating for CI implementation

* Write out service account

* Writing to skip out

* WIP

* ++

* Fixing depot tools deps

* Windows depot_tools

* Fixing setup scripts

* ++

* depot tools

* ++

* WIP

* Tracing depot_tools clone

* WIP

* ++

* analyzer

* WIP

* chrome typo

* copy artifact

* Working on tests

* Code cleanup

* ++

* Code cleanup, updated tests

* ++ review feedback

* Review

* Analyzer

* Review feedback

* Nits from review

* PRogress

* ++

* Fixing tests

* ++

* Testing repo route

* Just needing documention around new structures.

* cleanup

* Analyzer

* Documentation updates

* Documentation updates

* Cirrus updates

* cirrus nit

* Review feedback

* Review feedback

* Fixing skip comparator

* Fix base directory for Skia Gold case

* ++

* Feedback

* ++

* Fixed uri assertion

* Made GoldensClient abstract, altered SkiaGoldClient constructor

* Analyzer
2019-07-12 12:23:04 -07:00
chunhtai
fc7bd6ad24
refactor out selection handlers (#35207) 2019-07-12 12:13:50 -07:00
Christopher Fujino
e91822da24
Revert "Bundle ios dependencies (#34669)" (#36071)
This reverts commit 14d489adc5d584490595790ca0deb29da7ee4470.
2019-07-12 09:03:34 -07:00
Jonah Williams
7b150f81c5
move reload and restart handling into terminal (#35846) 2019-07-12 08:48:14 -07:00
Christopher Fujino
14d489adc5
Bundle ios dependencies (#34669)
This updates the flutter tool to cache binary files for ideviceinstaller, ios-deploy, libimobiledevice, and dynamically linked dependencies from Flutter's GCP bucket.
2019-07-12 08:36:18 -07:00
Anoop B
90326b6184 [ImgBot] Optimize images (#35971) 2019-07-11 21:16:48 -07:00
Jonah Williams
e91b98a41f
Add initial implementation of flutter assemble (#32816) 2019-07-11 16:53:17 -07:00
Ben Konyi
8d81c30a7c [WIP] Use public _registerService RPC 2019-07-11 16:01:07 -07:00
Dan Field
7a20148548
Add colorFilterLayer/Widget (#35468) 2019-07-11 15:49:51 -07:00
LongCatIsLooong
539f09f801
Remove _debugWillReattachChildren assertions from _TableElement (#34202) 2019-07-11 13:54:51 -07:00
Dan Field
735352a8c0
Deflake ImageProvider.evict test (#35999) 2019-07-11 13:09:30 -07:00
Jonah Williams
ae8ff41abf
Revert "Keep LLDB connection to iOS device alive while running from CLI. (#35731)" (#35996)
This reverts commit d200dc150bb069ff7ec6c50c00d25f2b1a3ed631.
2019-07-11 10:44:41 -07:00
sjindel-google
d200dc150b
Keep LLDB connection to iOS device alive while running from CLI. (#35731) 2019-07-11 18:56:48 +02:00
Greg Spencer
e8fbdd85f0
Add example showing how to move from one field to the next. (#35926)
This adds an example of how to move to the "next" field when using TextInputAction.next. This is all that is needed to have "next field" functionality in a field. I thought about making it the default when handling the "next" or "previous" actions, but it's better that the developer has control over whether or not they actually move to the next field, and within which scope.
2019-07-11 07:56:30 -07:00
Greg Spencer
3b945da00d
Change focus example to be more canonical (and correct), listening to the focus node for changes. (#35913)
This changes the example for FocusNode to be more correct, listening to the focus node for changes, instead of assuming that it is the only one doing the changing.
2019-07-10 16:49:32 -07:00
Justin McCandless
ff53fbe194
Text selection menu show/hide cases (#35219)
Show and hide the text selection menu at the correct time with various gestures in the text field.
2019-07-10 14:08:14 -07:00
Tom Robinson
ef42c36ab0
Cleanup widgets/sliver_persistent_header.dart with resolution of dart-lang/sdk#31543 (#35828)
* Remove extra classes.

Now that https://github.com/dart-lang/sdk/issues/31543 is fixed, we
can remove extra classes.

* Add snapConfiguration to parameters for _RenderSliverFloatingPersistentHeaderForWidgets and _RenderSliverFloatingPinnedPersistentHeaderForWidgets constructors.
2019-07-10 13:54:27 -07:00
rami-a
70bb5d1d5a
Add flag to use root navigator for showModalBottomSheet (#35878)
* Add flag to use root navigator for showModalBottomSheet

* Add documentation

* Add tests

* Address feedback and fix analyzer issues

* Address feedback

* Update comments
2019-07-10 16:07:15 -04:00
Kate Lovett
14e4565fa4
Doc fixes (#35892)
* Fixed assets embedding

* ++

* Completed snippet audit

* Analyzer
2019-07-10 12:40:35 -07:00
Ian Hickson
176ebfd53e
flutter/tests support (#33140)
This introduces a script that implements the conventions described in https://github.com/flutter/tests/pull/1.
2019-07-10 12:10:28 -07:00
Jenn Magder
ec2c3f2116
Disable CocoaPods input and output paths in Xcode build phase for ephemeral add2app (#35833) 2019-07-10 10:40:15 -07:00
Shi-Hao Hong
e7ef75680e
Update Dark Theme disabledColor to White38 (#35136)
* Add Colors.white38

* Update ThemeData.disabledColor and ButtonThemeData.disabledColor to Colors.white38

* Update pre-existing tests to expect Colors.white38 instead of Colors.white30

* Update API documentation to reflect these changes
2019-07-10 08:50:24 -07:00
Jonah Williams
2b20345bb8
use pub run for create test and remove [INFO] logs (#35839) 2019-07-10 08:48:01 -07:00
Greg Spencer
e3a08d2392
Remove reverseDuration from implicitly animated widgets, since it's ignored. (#35785)
When I added reverseDuration to animation controllers in #32730, I also added it to the implicit animations that Flutter has. However, as @efortuna pointed out to me, it doesn't actually do anything there, since all of the intrinsic animations run forwards, not in the reverse direction, and there's no way to reverse them.

So, this PR removes the reverseDuration argument from the implicit animations to avoid confusion.

Fixes #35769
2019-07-10 08:18:26 -07:00
John Ryan
871b58986d
add sample code for AnimatedContainer (#35225)
* add sample code for AnimatedContainer

* use stateful_widget_scaffold snippet template

* add sample explanation

* add setState() to example assumptions for analyzer

* update description

* use snippet instead of sample

* change sample to match assets-for-api-docs

* remove constant

* update AnimatedContainer sample description

add indication the example is depicted by the video and animates when
tapped

* fix example formatting

* make sample conform to 80 col limit

* add "implemented below" to illustration description

* formatting for readability
2019-07-09 15:34:39 -07:00
Darren Austin
af1bd09c78
Added MaterialApp.themeMode to control which theme is used. (#35499)
Added support for a themeMode property to the MaterialApp to control
how the light or dark theme is selected.
2019-07-09 15:26:42 -07:00
Jonah Williams
adf45d1e40
Refactor signal and command line handler from resident runner (#35406) 2019-07-09 13:10:26 -07:00
Gary Qian
9c1783e989
Update TextStyle and StrutStyle height docs (#33281) 2019-07-09 10:38:01 -07:00
Anthony
aae50f541a
[Material] Text scale and wide label fixes for Slider and Range Slider value indicator shape (#35496)
Various bug fixes for Slider and Range Slider value indicator around accessibility and wide labels.
2019-07-09 13:26:10 -04:00
chunhtai
a76e39f984
Rendering errors with root causes in the widget layer should have a reference to the widget (#32511) 2019-07-09 10:18:30 -07:00
Kate Lovett
97b2c98642
Navigator pushAndRemoveUntil Fix (#35223)
* Initial work

* ++

* Updated tests

* Moved TestObserver out for access across tests.

* ++

* Added hero tests

* Review feedback

* simplified preceding route overlay

* Review feedback

* trailing doc slash
2019-07-09 10:17:30 -07:00
Alexandre Ardhuin
b041a589c8
enable lint prefer_if_null_operators (#35745) 2019-07-09 10:53:35 +02:00
Hiroki Matsue
0e7cfc1e41 Add missing [applicationIcon] property to LicensePage widget (#34906)
* Add missing [applicationIcon] property to LicensePage widget
2019-07-08 17:30:28 -07:00
Michael Goderbauer
4e973adc79
Various doc fixes (#35548) 2019-07-08 17:02:25 -07:00
Jenn Magder
559c9982dd
UIApplicationLaunchOptionsKey -> UIApplication.LaunchOptionsKey (#35763) 2019-07-08 16:55:27 -07:00
Dan Field
e3acb5ca71
Refactor keymapping for resident_runner (#35762) 2019-07-08 16:38:49 -07:00
Jenn Magder
f3150ed0b5
Remove Swift Obj-C Inference build setting (#35756) 2019-07-08 16:04:16 -07:00
Jonah Williams
1e26c41f17
Remove web, fuchsia, and unsupported devices from all (#35709) 2019-07-08 15:58:38 -07:00