1246 Commits

Author SHA1 Message Date
Danny Tuppeny
4108240a7c
Update devicelab test for rename of materialize -> make-host-app-editable (#22034)
This fixes the devicelab failure after #22006 renamed this command.
2018-09-19 16:12:01 +01:00
Alexandre Ardhuin
e2d0b062d9
remove unnecessary ignore prefer_const_constructors (#21934) 2018-09-18 05:54:03 +02:00
Ian Hickson
9f359aeee2
Remove all "flaky" annotations from devicelab (#21895)
These tests don't seem particularly more flaky than ony others any more.
2018-09-17 13:02:34 -07:00
liyuqian
872eba2d4c
Track 90th, 99th percentile instead of missed_frame_build_budget_count (#21754)
See https://github.com/flutter/flutter/pull/19121#issuecomment-419520765
2018-09-14 13:24:13 -07:00
Alexandre Ardhuin
a07d3719a1
enable lint prefer_generic_function_type_aliases (#21680) 2018-09-14 21:06:19 +02:00
Jacob Richman
de7ad06d6d
Increase startup delay for semantics_perf_test. (#21735) 2018-09-12 13:54:03 -07:00
Jacob Richman
547e2e95e7
Revert "Increase initial delay for scroll_perf_test to try to reduce worst frame stats flakiness." (#21743)
This reverts commit 8cf68731e010023e5dcae1f00991f4ac5b1b758b.
2018-09-12 12:21:12 -07:00
Jacob Richman
8cf68731e0
Increase initial delay for scroll_perf_test to try to reduce worst frame stats flakiness. 2018-09-12 08:20:42 -07:00
Alexandre Ardhuin
d927c93310
Unnecessary new (#20138)
* enable lint unnecessary_new

* fix tests

* fix tests

* fix tests
2018-09-12 08:29:29 +02:00
Jonah Williams
fc1b304326
Add text field to semantics integration test (#21665) 2018-09-11 09:39:41 -07:00
Alexandre Ardhuin
774ca2f197
enable lint avoid_void_async (#21652) 2018-09-11 07:14:04 +02:00
Alexandre Ardhuin
976cffa24d
lint unnecessary_new on samples (#21539)
* lint unnecessary_new on samples

* fix tests
2018-09-07 11:00:05 +02:00
Alexandre Ardhuin
3c58195350
lint unnecessary_const on samples (#21155) 2018-09-07 09:13:13 +02:00
TL Lee
e2167b9f53
Add build test for Flutter codelabs (#19579)
* Add build test for Flutter codelabs

* Fix indentation in build test script

* Correct filename for the codelabs build test run by travis

* Change if statement to elif

* Replace echo statements with set -x

* Add BSD-style license

* Add codelabs build test to Cirrus

* Remove codelabs_build_test from Travis.

* Remove codelabs_build_test from travis_script.sh

* Update documentation for codelabs_build_test.sh

* Update readme for build test

* Add link to open a new issue to MDC-Flutter

* Add phrase to address "if you think you really need to break this test, please escalate this"
2018-09-06 17:16:22 -04:00
Jonah Williams
c6e8a513f0
Add android semantics integration test to device lab (#20971) 2018-09-06 12:31:18 -07:00
Chris Bracken
3519eabe8a
Do not pass --preview-dart-2 to Dart VM (#21455)
--preview-dart-2 is no longer necessary as it is now the default for the
standalone Dart VM.
2018-09-06 10:59:37 -07:00
Danny Tuppeny
7fc9165e4e
Add a detach command to detach without terminating (#21490)
* Add a detach command to detach without terminating (#21376)

* Add a detach command to detach without terminating

Fixes #21154.

* Bump protocol version for app.detach

* Tweak to detach/quit text

* Change logPrefix to named param

* Fix the text that the devicelab attach test looks for
2018-09-06 15:26:55 +01:00
Todd Volkert
2f32166f4b
Update packges (#21241)
https://github.com/flutter/flutter/issues/19578
2018-08-30 18:16:23 -07:00
Chris Bracken
9f9676c4c6
Eliminate Dart 1 support in devicelab tests (#21240)
Flutter commands all default to --preview-dart-2. Eliminate support for
the use of this option and the previewDart2 parameter in dev/devicelab
tests.
2018-08-30 17:17:37 -07:00
Alexander Aprelev
eab5cd9853
Fix analysis shard of dev/bots/test.dart so it works on Windows. (#21203)
Normalize file path to non-Windows so string path comparison works.
2018-08-30 14:47:04 -07:00
Alexander Aprelev
391e91c996
Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart (#21174)
* Split analysis steps out of dev/bots/test.dart into dev/bots/analyze.dart.

This allows to run analysis step with command line arguments that are only applicable to flutter analyze(like --dart-sdk, needed for dart-flutter-engine head-head-head bot).

* Add forgotten dev/bots/analyze.dart

* Refactor common code from analyze.dart and test.dart into run_command.dart

* Remove comments, add header
2018-08-30 07:30:25 -07:00
Janice Collins
e7d87af4d2
Update dartdoc to 0.20.4. (#21131) 2018-08-28 14:58:52 -07:00
Janice Collins
5e39476aef
Remove workaround for markup stripping dartdoc bug (#20748)
* Remove workaround for dart-lang/dartdoc#1125

* Update update_icons.dart for optional const and to remove markup stripping workaround
2018-08-28 13:23:07 -07:00
Ian Hickson
1c2d3f324d
Shut down gradle at the end of each task (#20968)
Apparently Gradle leaks memory and it's causing failures.
2018-08-28 11:28:25 -07:00
Ian Hickson
53b635817c
Re-enable missing_return (#20844) 2018-08-28 11:22:57 -07:00
Danny Tuppeny
5eebfeb345
Let bot/devicelab tests run concurrently (#21116) 2018-08-28 18:15:00 +01:00
Greg Spencer
2b14ac1efc
Fix setting of ANDROID_HOME in deploy_gallery.sh (#21080)
ANDROID_HOME should be coming from the env, and it wasn't: it was being set in the script.
2018-08-27 22:17:22 -07:00
Greg Spencer
977da4fb20
Ignore pub-cache when analyzing (#20925)
This adds ".pub-cache" to the list of directories to ignore when checking for dependence upon dart:test, since when people install a downloadable package, their pub cache is in the flutter directory.

Also, I centralized the ANSI "red line" so that they would all use the same final string.
2018-08-24 14:06:25 -07:00
amirh
fd44d0bb65
Update the android_views integration test to the new Android views API. (#20999)
This updates the test to match the engine API change introduced in:
https://github.com/flutter/engine/pull/6081

This also rolls the engine, the roll includes only the relevant engine commit:
```
091492601 Allow passing extra creation parameters for embedded Android views. (#6081)
```
2018-08-24 12:43:56 -07:00
amirh
146b906bbb
Mark the embedded_android_views_test as non flaky. (#20962)
Was marked as flaky as that's our policy for assing new device lab
tests. It's been consistently green so marking as non flaky.
2018-08-23 19:01:28 -07:00
Danny Tuppeny
dc5a5c18a9
Start logger in startProgress to avoid assertion failure (#20814)
* Start logger in startProgress to avoid assertion failure

There are lots of places that create a Status() and all but two of them call ..start() immediately. This is one of the places that doesn't, which causes an assertion failure when running with --enable-asserts and the other is in the same file (I suspect it's also incorrect, but possibly it's never used - I'll look at that separately when I can trace some code that calls it).

Fixes #20812.

* Enable asserts for tools tests

* Fix lint

* Rename enableAsserts -> enableFlutterToolAsserts

To make it clearer that it only enables asserts for flutter_tools when set.
2018-08-23 20:49:59 +01:00
Hans Muller
be601c26a5
Correct gen_date_localizations.dart supported locales computation (#20920) 2018-08-23 11:56:33 -07:00
amirh
1f31c3b354
Run the embedded Android views integration test on the device lab. (#20841) 2018-08-23 10:26:00 -07:00
Janice Collins
d3844d7d9c
Strip upstream from footer (#20757)
* Strip upstream from footer

* cleanup (readd accidentally deleted whitespace)
2018-08-23 10:25:15 -07:00
Jonah Williams
99b382953b
Create flutter_driver infra for testing the Android AccessibilityNodeInfo generated by Flutter (#19700) 2018-08-22 22:56:54 -07:00
Jonah Williams
f0e80933b0
Mark memory_nav as flaky (#20930) 2018-08-22 17:34:29 -07:00
Ian Hickson
22f376418f
Track number of package dependencies in Flutter (#20831)
* Track number of package dependencies in Flutter

Relands #20774.

* Use evalFlutter instead of startProcess.

That way we don't need `flutter` on the PATH.
2018-08-21 14:02:33 -07:00
Ian Hickson
b7261586e5
Audit TODO syntax (#20837)
Fixes the pattern for some TODOs to match our style guide.

(Also, a couple of minor code order fixes.)
2018-08-21 14:02:11 -07:00
Ian Hickson
a56a5c598d
Add ignore_for_file to the technical debt menu (#20755)
If //ignore is bad, ignoring something for a whole file is presumably worse.
2018-08-20 17:59:11 -07:00
Amir Hardon
f4caa21c88 flutter update-packages 2018-08-20 14:29:26 -07:00
Amir Hardon
72ef4485e9 Integration test for embeded Android Views touch support.
The test places an embedded Android view at the top left, and verifies
that motion events that get to FlutterView are equivalent to the
synthesized motion events that gets to the embedded view.

See the README.md for more high level details.
2018-08-20 14:29:26 -07:00
Ian Hickson
ad1eaff45a
flutter analyze cleanup (#20490)
* `flutter analyze` cleanup

* Make `--dartdocs` work in all modes.
* Make `analyze-sample-code.dart` more resilient.
* Add a test for `analyze-sample-code.dart`.
* Minor cleanup in related code and files.

* Apply review comments

* Fix tests
2018-08-20 12:51:07 -07:00
Ian Hickson
8c79f40d71
Fixes resulting from audit of issues links (#20772)
* Fixes resulting from audit of issues links

I looked at every link to GitHub in our repo. For cases where we had a TODO that was waiting for a bug to be fixed, and the bug has now been fixed, I applied the pending change. For cases where the link was out of date, I updated the link.

* Update run_test.dart

skip this test again since it failed on linux and macos bots
2018-08-18 16:44:39 -07:00
Ian Hickson
809721d0ee
Revert "Track number of package dependencies in Flutter" (#20774)
* Revert "Deprecated CupertinoDialog in favor of a new widget called CupertinoP… (#20649)"

This reverts commit 3a4ae280e3a4af0f93709bac7a87a1ce5445533a.

* Revert "Feature pesto new recipes (#19415)"

This reverts commit e2f3b3d6f2c164975c0ec0d81345c9f603cd2d44.

* Revert "Use markdown table (#20721)"

This reverts commit 82d43b952ac3fc8c412c850f105710e55e6df565.

* Revert "Documentation regarding tap gesture callbacks (#20647)"

This reverts commit 3acc2785219e61cba73dc5540a9a50360d7716f0.

* Revert "Add branch to footer information in flutter docs (#20711)"

This reverts commit 9118d3d715bf2f3407a1146b7c6585abe7d031a5.

* Revert "Performance test cleanup (#20652)"

This reverts commit 1993a67381f03a8d472da687cd2c1582e9f788a1.

* Revert "Track number of package dependencies in Flutter (#20722)"

This reverts commit 03d6f18f4a900e0e7f94060b54042365b00ad069.
2018-08-17 18:34:05 -07:00
TL Lee
e2f3b3d6f2 Feature pesto new recipes (#19415)
<img width="273" alt="pesto_before" src="https://user-images.githubusercontent.com/13839358/43009716-64b6d726-8c0c-11e8-989a-13eaff72ccee.png">
<img width="273" alt="pesto_after" src="https://user-images.githubusercontent.com/13839358/43009717-66074a34-8c0c-11e8-92ae-f5fb4074f43a.png">
2018-08-17 17:58:25 -04:00
Janice Collins
9118d3d715
Add branch to footer information in flutter docs (#20711) 2018-08-17 14:10:33 -07:00
Ian Hickson
1993a67381
Performance test cleanup (#20652)
* Fix TODO syntax.
* Clarify messages for some timeouts, to aid debugging.
* Increase some other timeouts that were a needlessly short, to reduce sources of flakes.
* Remove some more timeouts that were mostly redundant, to remove complexity.
* Minor style cleanup.
* Remove some dangerous traps (specifically, hide the explicit start/end times in TimedEvent since they shouldn't matter).
2018-08-17 13:19:28 -07:00
Ian Hickson
03d6f18f4a
Track number of package dependencies in Flutter (#20722) 2018-08-17 13:19:06 -07:00
Ian Hickson
3dec6a6930
Clean up usage of temporary directories (#20682)
All temporary directory start with `flutter_` and have their random component separated from the name by a period, as in `flutter_test_bundle.YFYQMY`.

I've tried to find some of the places where we didn't cleanly delete temporary directories, too. This greatly reduces, though it does not entirely eliminate, the directories we leave behind when running tests, especially `flutter_tools` tests.

While I was at it I standardized on `tempDir` as the variable name for temporary directories, since it was the most common, removing occurrences of `temp` and `tmp`, among others.

Also I factored out some common code that used to catch exceptions that happen on Windows, and made more places use that pattern.
2018-08-17 13:17:23 -07:00
Mikkel Nygaard Ravn
d4e5e1e11e
Materialize Flutter module, Android (#20520) 2018-08-16 13:21:55 +02:00