engine-flutter-autoroll
68b18918db
Roll Flutter Engine from 7f12e3497428 to 220ece4d9faa (6 revisions) ( #128282 )
...
7f12e34974...220ece4d9fzanderso@users.noreply.github.com Ensure Dart roll script picks up udpates to dart-sdk/tools (flutter/engine#42576 )
2023-06-05 chillers@google.com Run dependabot in off peak hours (flutter/engine#42572 )
2023-06-05 flar@google.com fix bounds of inverted rendered rectangles (flutter/engine#42556 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from fgfgAhpxFpse7Xi4i... to tCxDcZ3yi0rnKGVHt... (flutter/engine#42574 )
2023-06-05 kjlubick@users.noreply.github.com Add missing #include of SkCFObject.h (flutter/engine#42573 )
2023-06-05 matej.knopp@gmail.com Improve getting non-overlapping rectangles from RTree (flutter/engine#42399 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from fgfgAhpxFpse to tCxDcZ3yi0rn
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 22:18:37 +00:00
Jonah Williams
9881aa69e8
[framework] attempt non-key solution ( #128273 )
...
Adds a special opacity widget that does not act like a repaint boundary.
Better solution for https://github.com/flutter/flutter/pull/128138
2023-06-05 21:24:51 +00:00
Casey Hillers
2be476d401
[labeler] Fix adding labels when name is directory ( #128243 )
...
https://github.com/flutter/flutter/issues/126002
2023-06-05 21:23:05 +00:00
Kate Lovett
a3ddead1a4
Remove scrollbar deprecations isAlwaysShown and hoverThickness ( #127351 )
...
The deprecated `[RawScrollbar/Scrollbar/CupertinoScrollbar/ScrollbarThemeData].isAlwaysShown` has expired and is removed in thi PR.
Also, `Scrollbar.hoverThickness` is also removed after having expired.
The replacement for `isAlwaysShown` is `thumbVisibility`. This deprecation was introduced in #96957 . The name change came from new behaviors like a track that is conditionally visible. Since the original API only referred to the thumb, the name was changed to reflect this intention. This change is supported by dart fix. â
The replacement for `hoverThickness` is `ScrollbarThemeData.thickness`, which is a MaterialStateProperty that allows for the thickness to respond to multiple states including hover. This deprecation was introduced in #97173 . This change is not supported by dart fix. ð
Part of https://github.com/flutter/flutter/issues/127042
2023-06-05 21:15:32 +00:00
Kate Lovett
9a263466ae
Fix update drag error that made NestedScrollView un-scrollable ( #127718 )
...
#### (plus some more docs)
Fixes https://github.com/flutter/flutter/issues/76760
Fixes https://github.com/flutter/flutter/issues/82391
Fixes https://github.com/flutter/flutter/issues/45619
Fixes #117316
Fixes #110956
Fixes #127282
Fixes #32563
Fixes #46089
Fixes #79077
Part of fixing #62833
This fixes (a bunch of) issues that have been reported differently over the years, but all have the same root cause. Sometimes the NestedScrollView would incorrectly calculate whether or not there is enough content to allow scrolling. This would only apply to drag scrolling (not mouse wheel scrolling for example). This did not relate to how the extent of the NestedScrollView is computed, but just the logic that enabled the actual drag gestures. This fixes that. :)
2023-06-05 21:14:22 +00:00
engine-flutter-autoroll
270b3d487c
Roll Flutter Engine from f9f72388a4da to 7f12e3497428 (4 revisions) ( #128271 )
...
f9f72388a4...7f12e34974matej.knopp@gmail.com Fix clang tidy error and crash (flutter/engine#42564 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from gp1k1agqxQIz0oTXV... to vAwdggqMrL1yoH_Zn... (flutter/engine#42570 )
2023-06-05 zanderso@users.noreply.github.com Revert Dart SDK to 3.1.0-163.0.dev for branch alignment (flutter/engine#42569 )
2023-06-05 zanderso@users.noreply.github.com Check more optional accesses (flutter/engine#42528 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from gp1k1agqxQIz to vAwdggqMrL1y
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 19:11:25 +00:00
Michael Goderbauer
17f86df8bd
Migrate SemanticsBinding to onSemanticsActionEvent ( #128254 )
...
Follow-up to https://github.com/flutter/engine/pull/42493 .
2023-06-05 18:16:06 +00:00
engine-flutter-autoroll
130e84ecd2
Roll Flutter Engine from c838a1b05924 to f9f72388a4da (19 revisions) ( #128252 )
...
c838a1b059...f9f72388a4zanderso@users.noreply.github.com Revert Dart SDK to
3.1.0-166.0.dev (flutter/engine#42568 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from a10e944601cf to
a226cfbd6cc7 (1 revision) (flutter/engine#42562 )
2023-06-05 kjlubick@users.noreply.github.com Add missing includes of
GrBackendSurface.h (flutter/engine#42563 )
2023-06-05 49699333+dependabot[bot]@users.noreply.github.com Bump
github/codeql-action from 2.3.5 to 2.3.6 (flutter/engine#42561 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Skia from 210ad9cde42b to
a10e944601cf (3 revisions) (flutter/engine#42560 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
sk-SFXAARqkT7wGmf... to fgfgAhpxFpse7Xi4i... (flutter/engine#42558 )
2023-06-05 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d00a370c1fd3 to 5144119b99c8 (2 revisions) (flutter/engine#42557 )
2023-06-05 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
839LDf0p1Q4wyszA5... to gp1k1agqxQIz0oTXV... (flutter/engine#42553 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
5pFMQIRHNENhekRDO... to sk-SFXAARqkT7wGmf... (flutter/engine#42551 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 8ca7bad9158f to
210ad9cde42b (1 revision) (flutter/engine#42549 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Skia from 611132d6ab8c to
8ca7bad9158f (1 revision) (flutter/engine#42548 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
Bb9z8SjSCzRN6SVee... to 839LDf0p1Q4wyszA5... (flutter/engine#42544 )
2023-06-04 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
vVgQ12wNh2DIT_hV7... to 5pFMQIRHNENhekRDO... (flutter/engine#42543 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 0e80a97ccee3 to
611132d6ab8c (2 revisions) (flutter/engine#42542 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 98da8d7a299d to
0e80a97ccee3 (1 revision) (flutter/engine#42541 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
VtLnfLmVda1_h1AtM... to Bb9z8SjSCzRN6SVee... (flutter/engine#42538 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Skia from 656de7fc6994 to
98da8d7a299d (1 revision) (flutter/engine#42537 )
2023-06-03 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from
gcm-vsCu6IPUZZnN0... to vVgQ12wNh2DIT_hV7... (flutter/engine#42536 )
2023-06-03 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
d198f84f5e4e to d00a370c1fd3 (3 revisions) (flutter/engine#42535 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from VtLnfLmVda1_ to gp1k1agqxQIz
fuchsia/sdk/core/mac-amd64 from gcm-vsCu6IPU to fgfgAhpxFpse
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 10:17:02 -07:00
Jonah Williams
b3f32004d4
[framework] force flexible space background to rebuild. ( #128138 )
...
Fixes https://github.com/flutter/flutter/issues/127836
The flexible scroll bar needs to rebuild even if the child/opacity hasn't changed. Force this with a value key.
2023-06-05 15:51:49 +00:00
engine-flutter-autoroll
1e70c52b4e
Roll Packages from 75085edb54fe to db4e5c26ed3f (4 revisions) ( #128246 )
...
75085edb54...db4e5c26edengine-flutter-autoroll@skia.org Roll Flutter from 3db9504dcda2 to 0b7415356e07 (108 revisions) (flutter/packages#4135 )
2023-06-05 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 9cd3d0d9ff05 to f92f44110e87 (4 revisions) (flutter/packages#4133 )
2023-06-02 engine-flutter-autoroll@skia.org Roll Flutter from ee162e4b7f4f to 3db9504dcda2 (31 revisions) (flutter/packages#4098 )
2023-06-02 43054281+camsim99@users.noreply.github.com [many] Bump most robolectric dependencies to version 4.10.3 (flutter/packages#4128 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-05 15:48:31 +00:00
engine-flutter-autoroll
0b7415356e
Roll Flutter Engine from 54293721816a to c838a1b05924 (2 revisions) ( #128161 )
...
5429372181...c838a1b059skia-flutter-autoroll@skia.org Roll Skia from daf2219fec54 to 656de7fc6994 (23 revisions) (flutter/engine#42534 )
2023-06-03 bdero@google.com Revert "[Impeller] Add Impeller Metal support in the embedder API (#42411 )" (flutter/engine#42532 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-03 11:16:37 +00:00
engine-flutter-autoroll
39adf1b32a
Roll Flutter Engine from 8769e9ce3a90 to 54293721816a (8 revisions) ( #128158 )
...
8769e9ce3a...5429372181jonahwilliams@google.com [Impeller] Fix 1-d grid computation
for compute (flutter/engine#42516 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from
PuYA-6NVHeHPlkCdk... to VtLnfLmVda1_h1AtM... (flutter/engine#42529 )
2023-06-02 chris@bracken.jp [macOS] Top-left origin for PlatformView
container (flutter/engine#42523 )
2023-06-02 skia-flutter-autoroll@skia.org Manual roll Dart SDK from
9d8df2a5210b to d198f84f5e4e (1 revision) (flutter/engine#42527 )
2023-06-02 flar@google.com Revert "Reland "add non-rendering operation
culling to DisplayListBuilder" (#41463 )" (flutter/engine#42525 )
2023-06-02 godofredoc@google.com Move benchmarks no upload to staging.
(flutter/engine#42524 )
2023-06-02 mdebbar@google.com [web] Support platform view creation
params (flutter/engine#42255 )
2023-06-02 goderbauer@google.com MultiView changes for dart:ui
(flutter/engine#42493 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from PuYA-6NVHeHP to VtLnfLmVda1_
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on
the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 21:59:50 -07:00
Michael Goderbauer
dffd0c3a9d
Prefix for dart:ui multiview change ( #128152 )
...
For https://github.com/flutter/engine/pull/42493 .
2023-06-02 19:08:05 -07:00
Alexander Aprelev
581ebe2965
Roll dds dependency to 2.8.3 for expression evaluation upcoming fixes. ( #128124 )
...
The fix is coming as part of https://dart-review.git.corp.google.com/c/sdk/+/306908 dart sdk roll as well as https://github.com/flutter/flutter/pull/128084 .
BUG=https://github.com/dart-lang/sdk/issues/52522
2023-06-02 23:31:07 +00:00
engine-flutter-autoroll
af5a9614bb
Roll Flutter Engine from f3f6a020595d to 8769e9ce3a90 (3 revisions) ( #128149 )
...
f3f6a02059...8769e9ce3agodofredoc@google.com Use json for json blocks in docs. (flutter/engine#42521 )
2023-06-02 mdebbar@google.com [web] New platform view API to get view by ID (flutter/engine#41784 )
2023-06-02 jason-simmons@users.noreply.github.com Generate a unique temporary directory name in the iOS scenario test script (flutter/engine#42520 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 23:00:06 +00:00
engine-flutter-autoroll
6b69a74dc6
Roll Flutter Engine from b4250acbf3ca to f3f6a020595d (3 revisions) ( #128147 )
...
b4250acbf3...f3f6a02059jason-simmons@users.noreply.github.com Wrap concurrent message loop tasks in an autorelease pool on iOS/Mac platforms (flutter/engine#42459 )
2023-06-02 godofredoc@google.com Update engine build config docs. (flutter/engine#41468 )
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Bump unit test robolectric version to 4.10.3 (flutter/engine#42454 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 22:14:08 +00:00
Jim Graham
6f6611359c
Reland "Remove obsolete drawShadow bounds workaround ( #127052 )" ( #127231 )
...
This workaround was created 6 years ago with no links to bug databases to track. As best we can determine, the issue is no longer present in SkPicture or DisplayList and is most likely obsolete. More importantly, though, non-rendering primitives are ignored by the DisplayList construction and so this workaround will just be ignored anyway. If a problem surfaces about this issue that we haven't discovered by a thorough code search of the current code base, then workarounds should be installed within the relevant implementation modules rather than in the framework (and documented with bugs filed in either or both of Flutter's github repos, and/or the Skia issue database).
Workaround originally created in this PR: https://github.com/flutter/flutter/pull/9654
2023-06-02 22:03:07 +00:00
engine-flutter-autoroll
0845d0d76c
Roll Flutter Engine from c6e9383f2143 to b4250acbf3ca (8 revisions) ( #128142 )
...
c6e9383f21...b4250acbf3737941+loic-sharma@users.noreply.github.com Manually roll ANGLE (flutter/engine#42169 )
2023-06-02 jason-simmons@users.noreply.github.com [Impeller] Fix a bugprone-unchecked-optional-access warning in SurfaceMTL (flutter/engine#42518 )
2023-06-02 amyles@google.com [web] Move announcement live elements to the end of the DOM and make them `div`s instead of `label`s. (flutter/engine#42432 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from JQRQ1nH1ILNA--N_b... to gcm-vsCu6IPUZZnN0... (flutter/engine#42515 )
2023-06-02 godofredoc@google.com Add cpu as drone dimension to mac ios build. (flutter/engine#42514 )
2023-06-02 godofredoc@google.com Move benchmarks no upload to a test. (flutter/engine#42356 )
2023-06-02 43054281+camsim99@users.noreply.github.com [Android] Change Linux Android Emulator Tests to run on a device running API 33 (flutter/engine#42492 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 47b0db43f6a4 to daf2219fec54 (1 revision) (flutter/engine#42513 )
Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from JQRQ1nH1ILNA to gcm-vsCu6IPU
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 21:28:08 +00:00
Michael Goderbauer
e50b2507bf
Pre-migration for dart:ui multi view changes ( #128092 )
...
For https://github.com/flutter/engine/pull/42493 .
2023-06-02 20:51:09 +00:00
Michael Goderbauer
4cf89cc278
Remove LiveTestRenderView ( #127882 )
...
In the multi view world, `RenderViews` are created by the `View` widget and no longer owned by the binding. Prior to this change, the `LiveTestWidgetsFlutterBinding` owned and managed a special subclass of `RenderView`, the `_LiveTestRenderView`. In the new world, where `RenderView`s can be created anywhere in the widget tree where a `View` widget is used, this setup is no longer feasible. This change removes this special `_LiveTestRenderView` and instead adds debug hocks to `RenderView` to allow the `LiveTestWidgetsFlutterBinding` to draw a debug overlay on top of the content of any `RenderView`.
2023-06-02 20:41:05 +00:00
engine-flutter-autoroll
6f8ef1a197
Roll Flutter Engine from 02d6fbb68b69 to c6e9383f2143 (15 revisions) ( #128119 )
...
02d6fbb68b...c6e9383f21jason-simmons@users.noreply.github.com [Impeller] clang-tidy fixes (flutter/engine#42503 )
2023-06-02 103135467+sealesj@users.noreply.github.com Allow for optional label to trigger vuln scan on patch PRs (flutter/engine#42494 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 881a8df6f9e9 to 47b0db43f6a4 (1 revision) (flutter/engine#42512 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from X4Pkixxtt3BkjRW9P... to PuYA-6NVHeHPlkCdk... (flutter/engine#42511 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 7777ee2bf7ef to 881a8df6f9e9 (1 revision) (flutter/engine#42510 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 3d4d29d8f16b to 9d8df2a5210b (2 revisions) (flutter/engine#42509 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 02e706e9761b to 7777ee2bf7ef (2 revisions) (flutter/engine#42508 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 0c75f1877b37 to 02e706e9761b (2 revisions) (flutter/engine#42506 )
2023-06-02 dkwingsmt@users.noreply.github.com Revert "[Rasterizer] Make resubmit information temporary" (flutter/engine#42455 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from f4854a3d009d to 0c75f1877b37 (1 revision) (flutter/engine#42505 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Dart SDK from 0d3c310fd6d9 to 3d4d29d8f16b (3 revisions) (flutter/engine#42502 )
2023-06-02 skia-flutter-autoroll@skia.org Roll Skia from 082a7d1f72f7 to f4854a3d009d (4 revisions) (flutter/engine#42500 )
2023-06-01 godofredoc@google.com Do not retry lint or clang tidy tests. (flutter/engine#42498 )
2023-06-01 dnfield@google.com [Impeller] Compute in Vulkan (flutter/engine#42294 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from yqJfBsLdfLP4_vbFu... to JQRQ1nH1ILNA--N_b... (flutter/engine#42499 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from X4Pkixxtt3Bk to PuYA-6NVHeHP
fuchsia/sdk/core/mac-amd64 from yqJfBsLdfLP4 to JQRQ1nH1ILNA
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 20:39:24 +00:00
fzyzcjy
de368fca94
Tiny remove unnecessary method in text_selection.dart ( #127480 )
...
I come across this when migrating my codebase. There is indeed a linter rule for it: unnecessary_overrides (see screenshot below for an example). I can help enabling the rule (as well as other rules, and/or dart formatter, etc) for Flutter codebase if needed.
2023-06-02 20:19:12 +00:00
Victoria Ashworth
cd18c8c02f
Workaround for Dart VM timeout ( #127875 )
...
Workaround solution for: https://github.com/flutter/flutter/issues/121231
See https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 Error Case 2 for more information.
Sometimes the `ios-deploy` process does not return the logs from the application. We've been unable to figure out why. This is a solution to workaround that by using `idevicesyslog` alongside `ios-deploy` as a backup in getting the log for the Dart VM url. As explained in https://github.com/flutter/flutter/issues/120808#issuecomment-1551826299 , when error case 2 happens, the `idevicesyslog` does successfully find the Dart VM.
Also, in the comments of the code it mentions `syslog` is not written on iOS 13+, this was added in response to this issue: https://github.com/flutter/flutter/issues/41133 .
However, `idevicesyslog` does in fact work (at least for iOS 16), we use it to collect device logs for our CI tests already: 1dc26f80f0/dev/devicelab/lib/framework/devices.dart (L998-L1006)
2023-06-02 17:17:57 +00:00
Michael Goderbauer
95cd3c0340
Make --flutter-repo analyze whole repo ( #127990 )
...
Fixes https://github.com/flutter/flutter/issues/127989 .
2023-06-02 17:17:54 +00:00
engine-flutter-autoroll
7febf62c83
Roll Packages from f0513ae199e1 to 75085edb54fe (3 revisions) ( #128121 )
...
f0513ae199...75085edb5443054281+camsim99@users.noreply.github.com [camerax] Mock `InstanceManager` in unit tests (flutter/packages#4121 )
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.core:core from 1.9.0 to 1.10.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3991 )
2023-06-01 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.10 to 1.8.21 in /packages/image_picker/image_picker_android/android (flutter/packages#4054 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 16:57:05 +00:00
Midori
87324ec09d
[Refactor] fix quote style in template ( #127762 )
...
*Just replaced double quote to single.*
*this looks weird to me.*
2023-06-02 16:11:51 +00:00
engine-flutter-autoroll
5e5966d8af
Roll Flutter Engine from 3a453f2ccb77 to 02d6fbb68b69 (14 revisions) ( #128089 )
...
3a453f2ccb...02d6fbb68bjonahwilliams@google.com [Impeller] Emplace directly into host buffer (avoid VBB) for text data (flutter/engine#42484 )
2023-06-01 john@johnmccutchan.com Ensure PlatformView engine life cycle callbacks are invoked (flutter/engine#42491 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from c408e8e9cc96 to 082a7d1f72f7 (8 revisions) (flutter/engine#42496 )
2023-06-01 leroux_bruno@yahoo.fr [Windows - TextInput] Insert new line only when TextInputAction.newline (flutter/engine#42244 )
2023-06-01 zanderso@users.noreply.github.com Revert "Move clang tidy v2 build to prod." (flutter/engine#42495 )
2023-06-01 linxunfeng@yeah.net Add myself to AUTHORS (flutter/engine#42406 )
2023-06-01 bdero@google.com [Impeller] Add Impeller Metal support in the embedder API (flutter/engine#42411 )
2023-06-01 jinhe.zjh@alibaba-inc.com Support DisposalMethod::kRestorePrevious in MultiFrameCodec and fix the apng problem. (flutter/engine#42153 )
2023-06-01 smartercallum@gmail.com Fix crash getting spell-check suggestions (flutter/engine#42466 )
2023-06-01 bdero@google.com Fix lint in rectangle packer (flutter/engine#42489 )
2023-06-01 jason-simmons@users.noreply.github.com Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test (flutter/engine#42438 )
2023-06-01 mdebbar@google.com Reland "[web] Remove the JS API for url strategy (#42134 )" (flutter/engine#42486 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Skia from f5bc3d12f0eb to c408e8e9cc96 (9 revisions) (flutter/engine#42487 )
2023-06-01 kjlubick@users.noreply.github.com Clean up Skia includes around SkSurfaceCharacterization (flutter/engine#42485 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-02 15:23:09 +00:00
Michael Goderbauer
5bbd866762
Fix typos in labels ( #128093 )
2023-06-02 14:39:17 +00:00
Zachary Anderson
fdb71de7a0
Revert "Fix issue where DevTools would not be immediately available when using --start-paused" ( #128117 )
...
Reverts flutter/flutter#126698
There are a bunch of tool crashes on CI that start with this commit. I'm
not sure this PR is the cause because there is no backtrace from the
tool on the crashes. The only error message is `Oops; flutter has exited
unexpectedly: "Null check operator used on a null value`.
2023-06-02 07:31:07 -07:00
Michael Goderbauer
60a87d0798
Sync Lints ( #127976 )
...
Syncs our lints with https://github.com/dart-lang/linter/blob/master/example/all.yaml :
* removed the deprecated `iterable_contains_unrelated_type` and `list_remove_unrelated_type` lints (their replacement `collection_methods_unrelated_type` was already enabled for us)
* enabled the new `no_self_assignments` and fixed one issue triggered by the lint.
2023-06-02 04:27:17 +00:00
Hans Muller
4464d09db0
Updated TabBar and ToggleButtons examples ( #128088 )
...
Updated the ToggleButtons example and test to M3.
Updated the nested tabs test to avoid warnings like:
```
Warning: A call to tap() with finder "exactly one widget with type "Tab" which is an ancestor of text "Explore": Tab(text: "Explore", icon: Icon)" derived an Offset (Offset(666.7, 92.0)) that would not hit test on the specified widget.
```
2023-06-02 01:05:31 +00:00
Qun Cheng
ab70aea3ee
Text should still be centered when search bar height is less than 48 ( #128068 )
...
Fixes #127092
This fix can solve the alignment issue in `SearchBar` but we still need to investigate the root cause for the `TextField`. The
text baseline of `TextField` doesn't change when the height is less than 48 and greater than 40. The problem should be related to the `minContainerHeight` which is 48 by default but the `contentHeight` has become smaller than this min value already. Setting `isDense`/`isCollapsed` to true gives the `minContainerHeight` a smaller number which is 0.0: ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L1086)ff33555b23/packages/flutter/lib/src/material/input_decorator.dart (L3907)https://github.com/flutter/flutter/assets/36861262/6ddc8e90-1b47-4dd5-9a57-59b86cafec6d
This is a demo to show the text baseline that doesn't change when we set the text field height under 48.
https://github.com/flutter/flutter/assets/36861262/ce2ee815-f1f5-493a-930e-0540a627bec8
2023-06-02 00:27:22 +00:00
Flutter GitHub Bot
4a8780d228
Roll pub packages ( #128053 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-06-02 00:23:16 +00:00
Taha Tesser
513ff44bce
Add FilterChip.elevated, ChoiceChip.elevated, & ActionChip.elevated variants ( #128049 )
2023-06-01 16:29:28 -07:00
Hans Muller
14136ae319
Updated custom ListTile examples ( #128071 )
2023-06-01 16:21:42 -07:00
Ben Konyi
35174cc2b7
Fix issue where DevTools would not be immediately available when using --start-paused ( #126698 )
...
Service extensions are unable to handle requests when the isolate they were registered on is paused. The DevTools launcher logic was waiting for some service extension invocations to complete before advertising the already active DevTools instance, but when --start-paused was provided these requests would never complete, preventing users from using DevTools to resume the paused isolate.
Fixes https://github.com/flutter/flutter/issues/126691
2023-06-01 22:35:02 +00:00
Kate Lovett
acf5a259e4
Add error message when sliver overlap absorber is missing ( #128075 )
...
Adds an error message where we previously would crash without any help.
Came across this while working on https://github.com/flutter/flutter/pull/127718
Fixes https://github.com/flutter/flutter/issues/128074
2023-06-01 22:29:08 +00:00
Hans Muller
f0e32fc6ca
Updated Menu examples ( #128080 )
2023-06-01 15:27:34 -07:00
fzyzcjy
ffe94a2267
Add retry flag to flutter_test ( #125851 )
...
Closes https://github.com/flutter/flutter/issues/125920
I will add tests, polish code, etc, if this change looks generally OK!
2023-06-01 22:25:52 +00:00
Christopher Fujino
7f1f765521
[flutter_tools] Use process matcher for multidex test ( #127996 )
...
Part of https://github.com/flutter/flutter/issues/127135
Part of https://github.com/flutter/flutter/issues/125115
2023-06-01 22:24:08 +00:00
Hans Muller
420f442e5c
Updated InputDecoratorExamples for M3 ( #128065 )
2023-06-01 15:22:03 -07:00
engine-flutter-autoroll
ef843b5fe4
Roll Flutter Engine from 7c0a639efd0a to 3a453f2ccb77 (1 revision) ( #128064 )
...
7c0a639efd...3a453f2ccbflar@google.com Reland "add non-rendering operation culling to DisplayListBuilder" (#41463 ) (flutter/engine#42330 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 22:21:12 +00:00
Christopher Fujino
0d2772238e
migrate the package_autoroller from querying by label to title ( #128066 )
...
Fixes https://github.com/flutter/flutter/issues/128067
2023-06-01 22:16:50 +00:00
Hans Muller
1a098ae8eb
Revised Floating Action Button examples ( #128058 )
...
Of the original 4 examples, the first 3 mostly covered the same API features and occupied quite a bit of real-estate at the top of https://api.flutter.dev/flutter/material/FloatingActionButton-class.html . Additionally the illustrations and the code samples didn't match in some cases.
Replaced examples 0,1,2 with one example that changes attributes of the FAB when it's pushed.
Fixes https://github.com/flutter/flutter/issues/128048
2023-06-01 22:16:48 +00:00
engine-flutter-autoroll
ff33555b23
Roll Flutter Engine from fdd39c421fb9 to 7c0a639efd0a (2 revisions) ( #128056 )
...
fdd39c421f...7c0a639efdskia-flutter-autoroll@skia.org Roll Skia from 934d90ab7370 to f5bc3d12f0eb (1 revision) (flutter/engine#42482 )
2023-06-01 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from htio0wC3kDb9tB1Wd... to X4Pkixxtt3BkjRW9P... (flutter/engine#42481 )
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from htio0wC3kDb9 to X4Pkixxtt3Bk
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 17:48:17 +00:00
engine-flutter-autoroll
96734538f9
Roll Flutter Engine from c8e1a8d6fb57 to fdd39c421fb9 (1 revision) ( #128050 )
...
c8e1a8d6fb...fdd39c421fskia-flutter-autoroll@skia.org Roll ICU from a2961dc659b4 to 1eea59cabae0 (2 revisions) (flutter/engine#42479 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jonahwilliams@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 16:45:40 +00:00
Casey Hillers
51cb871986
[labeler] Remove use of any ( #128011 )
...
https://github.com/flutter/flutter/issues/127722
2023-06-01 16:34:07 +00:00
Jonah Williams
47c0454a15
[framework] remove reference to closed issue. ( #128007 )
...
Shaders are supported everywhere but HTML backend. We missed this doc update.
2023-06-01 16:16:06 +00:00
engine-flutter-autoroll
82b8d906a9
Roll Packages from 95bb7930e12b to f0513ae199e1 (3 revisions) ( #128045 )
...
95bb7930e1...f0513ae19954558023+keyonghan@users.noreply.github.com Remove legacy xcode properties and dependencies (flutter/packages#4093 )
2023-05-31 43054281+camsim99@users.noreply.github.com [camerax] Correct missing features list in `README` (flutter/packages#4123 )
2023-05-31 JeroenWeener@users.noreply.github.com [image_picker] Move disk accesses to background thread (flutter/packages#4058 )
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com ,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2023-06-01 15:53:22 +00:00
Vasiliy Ditsyak
114f05cef6
Add fallback font to IconData class ( #127269 )
...
This PR adds an ability to specify `fallbackFont` for `Icon` class via `IconData` props.
Read detailed description here https://github.com/flutter/flutter/issues/126670
2023-06-01 15:43:18 +00:00
