Renzo Olivares
ef9befc9da
Reland leak fix for EditableTextState ( #133806 )
...
Relands: https://github.com/flutter/flutter/pull/131377
Reverted in: https://github.com/flutter/flutter/pull/133804
2023-09-03 18:23:20 +00:00
Zachary Anderson
3896912d44
Fix for new analyzer lint ( #133923 )
...
For https://github.com/flutter/flutter/issues/133922
2023-09-02 12:47:28 -07:00
Polina Cherkasova
248645a2b2
RestorableProperty should dispatch creation in constructor. ( #133883 )
2023-09-01 17:59:25 -07:00
Polina Cherkasova
a3362a9ff8
MaterialStatesController should dispatch creation in constructor. ( #133826 )
...
This PR also updates other tests to use matcher.
2023-09-01 17:29:47 -07:00
Polina Cherkasova
80f737d1e0
Mark leak in _DayPickerState. ( #133863 )
2023-09-01 17:10:41 -07:00
Renzo Olivares
b1f691c9fc
Remove deprecated TestWindow.platformBrightnessTestValue/TestWindow.clearPlatformBrightnessTestValue ( #133178 )
...
Part of: https://github.com/flutter/flutter/issues/133171
2023-09-01 20:35:58 +00:00
Renzo Olivares
959cdb79fb
Remove deprecated TestWindow.textScaleFactorTestValue/TestWindow.clearTextScaleFactorTestValue ( #133176 )
...
Part of: https://github.com/flutter/flutter/issues/133171
2023-09-01 20:31:16 +00:00
Polina Cherkasova
78ff1226c9
Test cover more tests with leak tracking. ( #133828 )
2023-09-01 08:53:53 -07:00
chunhtai
0f3bd90d9b
Adds a parent scope TraversalEdgeBehavior and fixes modal route to no… ( #130841 )
...
…t trap the focus
fixes https://github.com/flutter/flutter/issues/112567
Several things I done:
1. add new enum `parentScope`
2. refactor _sortAllDescendants so that it doesn't recursively looking
into its descendant when it encounter a FocusScopeNode.
3. When the nextFocus try to focus into a FocusScopeNode, it will try to
find the first focusable FocusNode in traversal order and focus it
instead if it doesn't have a first focus.
4. Change the default in Navigator to always be `parentScope`
5. Only the root navigator will use `leaveFlutterView` if platform is
web.
Previously 2 and 3 are not needed because once a focusscope trapped the
focus, there isn't a chance where the parent focusscope have to deal
with next focus.
If we don't do 2 and 3 after the change, it will cause it to stuck in
the current scope again. Because once the focus leave the current scope,
it needs to also remove the first focus in that scope (so that it can
start fresh when focus traversal back to the scope in the future). At
this point the current scope will have the primary focus without the
first focus. The parent scope will then try to find the next focus, and
it will place the focus to the first traversal child in the current
scope again.
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-09-01 08:37:38 -07:00
Mark O'Sullivan
1b1c8a1607
Fixed PaginatedDataTable not using dataRowMinHeight and dataRowMaxHeight from Theme ( #133634 )
...
`PaginatedDataTable` will now make use of `dataRowMinHeight` and `dataRowMaxHeight` from the Theme
*List which issues are fixed by this PR. You must list at least one issue.*
Resolves #133633
2023-09-01 15:36:48 +00:00
Bruno Leroux
e326199923
Add more documentation for SystemChannels.keyboard getKeyboardState ( #133663 )
...
## Description
This PR adds some documentation to SystemChannels.keyboard getKeyboardState.
This method was added in https://github.com/flutter/flutter/pull/122885 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132938 .
## Tests
Documentation only.
2023-09-01 09:24:33 +00:00
Bruno Leroux
510ecaa4e7
Fix MaterialState.pressed is missing when pressing button with keyboard ( #133558 )
...
## Description
This PR fixes changes how `InkWell` reacts to keyboard activation.
**Before**: the activation started a splash and immediately terminated it which did not let time for widgets that resolve material state properties to react (visually it also mean the splash does not have time to expand).
**After**: the activation starts and terminates after a delay (I arbitrary choose 200ms for the moment).
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132377 .
## Tests
Adds one test.
2023-09-01 09:08:21 +00:00
Andrea Cioni
400702d1d6
Add an example for InputChip generated by user input ( #130645 )
...
New example for `InputChip` that demonstrate how to create/delete them based on user text inputs.
The sample application shows a custom text area where user can enter text. After the user has typed and hits _Enter_ the text will be replaced with an `InputChip` that contains that text. Is it possible to continue typing and add more chips in this way. All of them will be placed in a scrollable horizontal row. Also is it possible to have suggestion displayed below the text input field in case the typed text match some of the available suggestions.
Issue I'm trying to solve:
- https://github.com/flutter/flutter/issues/128247
**Code structure:**
The example app is composed of 2 main components that find places inside `MainScreen`:
- `ChipsInput`
- `ListView`
`ChipsInput` emulates a `TextField` where you can enter text. This text field accepts also a list of values of generic type T (`Topping` in my example), that gets rendered as `InputChip` inside the text field, before the text inserted by the user. This widgets is basically an `InputDecorator` widget that implements `TextInputClient` to get `TextEditingValue` events from the user keyboard. At the end of the input field there is another component, the `TextCursor`, that is displayed just when the user give the focus to the field and emulates the carrets that `TextField` has.
There are also some available callbacks that the user can use to capture events in the `ChipsInput` field like: `onChanged`, `onChipTapped`, `onSubmitted` and `onTextChanged`. This last callback is used to build a list of suggestion that will be placed just below the `ChipsInput` field inside the `ListView`.
2023-09-01 00:02:04 +00:00
Kate Lovett
cf051e7db2
Fix clipBehavior ignored in Scrollable of SingleChildScrollView ( #133696 )
...
Fixes https://github.com/flutter/flutter/issues/133330
The clipBehavior was not passed to the underlying Scrollable, which informs things like the clip on the StretchingOverscrollIndicator.
2023-08-31 23:50:39 +00:00
Polina Cherkasova
956999a4b9
Make Route dispatching memory events. ( #133721 )
2023-08-31 16:23:44 -07:00
Christopher Fujino
33210218ba
[flutter_tools] Fix flutter upgrade not finding git tags ( #133778 )
...
Fixes https://github.com/flutter/flutter/issues/133441
2023-08-31 22:01:10 +00:00
chunhtai
0b3b8cd551
Removes ios universal link vmservices and let xcodeproject to dump js… ( #133709 )
...
â¦on file
The deeplink validation tool will become an static app so it can't no longer access vm services.
The goal will be then to turn them into flutter analyze command similar to `flutter analyze --android --[options]` that static app can use on.
This pr only removes vm services and turn the api to dump a output file instead of printing everything to stdout.
2023-08-31 21:50:54 +00:00
yaakovschectman
e6e44de33c
Add MacOS AppKitView class. ( #132583 )
...
Add derived classes from the Darwin platform view base classes for
MacOS. Functionality is largely the same as the `UiKitView`, but the two
are decoupled and and can further diverge in the future as needed. Some
unit tests remain skipped for now as the gesture recognizers for MacOS
are not yet implemented.
https://github.com/flutter/flutter/issues/128519
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
---------
Co-authored-by: Chris Bracken <chris@bracken.jp>
2023-08-31 17:48:12 -04:00
Loïc Sharma
b4753c328d
Improve doctor output on incomplete Visual Studio installation ( #133390 )
...
Flutter doctor warns if the user is updating Visual Studio or has paused
a Visual Studio update. The current output recommends reinstalling
Visual Studio. This is unnecessary as the user should be able to use the
Visual Studio Installer app to complete the installation:
This message is covered by this existing test:
229b74d987/packages/flutter_tools/test/general.shard/windows/visual_studio_validator_test.dart (L68-L81)https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-31 14:37:46 -07:00
Christopher Fujino
1519553bed
[flutter_tools] print out the unzipping method used by update_dart_sdk.ps1 ( #133364 )
...
in case there are future issues with unzipping the dart sdk, such as https://github.com/flutter/flutter/issues/132592 , we should log out what tool we are using to try to extract the archive.
2023-08-31 21:06:47 +00:00
Renzo Olivares
acdcbae78a
Revert "Fixing memory leak in EditableTextState" ( #133804 )
...
Reverts flutter/flutter#131377
reverting because of internal google testing failures b/298310760
2023-08-31 20:42:52 +00:00
Taha Tesser
f32b6fed24
Fix cursorColor with an opacity is not respected ( #133548 )
...
fixes [`cursorColor` with an opacity is not respected](https://github.com/flutter/flutter/issues/132886 )
<details>
<summary>expand to view the code sample</summary>
```dart
import "package:flutter/material.dart";
// import "package:flutter/scheduler.dart";
// final color = Colors.red;
const color = Color(0x55ff0000);
void main() {
// timeDilation = 4;
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return const MaterialApp(
debugShowCheckedModeBanner: false,
home: Example(),
);
}
}
class Example extends StatefulWidget {
const Example({super.key});
@override
State<Example> createState() => _ExampleState();
}
class _ExampleState extends State<Example> {
late FocusNode _focusNode;
late TextEditingController _controller;
@override
void initState() {
super.initState();
_focusNode = FocusNode();
_controller = TextEditingController(text: 'Hello World');
}
@override
void dispose() {
_focusNode.dispose();
_controller.dispose();
super.dispose();
}
@override
Widget build(BuildContext context) {
const bool cursorOpacityAnimates = false;
double cursorWidth = 6;
return Scaffold(
body: Center(
child: Padding(
padding: const EdgeInsets.symmetric(
horizontal: 16,
),
child: Column(
children: <Widget>[
const Spacer(),
const Text('EditableText'),
const SizedBox(height: 8),
InputDecorator(
decoration: InputDecoration(
border: OutlineInputBorder(
borderRadius: BorderRadius.circular(8),
),
),
child: EditableText(
cursorColor: color,
cursorWidth: cursorWidth,
cursorOpacityAnimates: cursorOpacityAnimates,
focusNode: _focusNode,
controller: _controller,
style: Theme.of(context).textTheme.bodyLarge!,
backgroundCursorColor: Colors.amber,
onSubmitted: (String value) {
// Add your code here.
},
),
),
const Spacer(),
const Text('TextField'),
const SizedBox(height: 8),
TextField(
cursorColor: color,
cursorWidth: cursorWidth,
cursorOpacityAnimates: cursorOpacityAnimates,
controller: _controller,
focusNode: _focusNode,
onSubmitted: (String value) {
// Add your code here.
},
),
const Spacer(),
],
),
),
),
);
}
}
```
</details>
### Before
### After
2023-08-31 19:49:06 +00:00
Polina Cherkasova
127b90e1de
Test cover more tests with leak tracking. ( #133712 )
2023-08-31 10:19:13 -07:00
Polina Cherkasova
c1256d5353
_FocusTraversalGroupNode should communicate creation in constructor. ( #133717 )
2023-08-31 10:18:19 -07:00
Polina Cherkasova
54402ae375
_ResetNotifier should communicate creation in constructor. ( #133716 )
2023-08-31 10:18:04 -07:00
Victoria Ashworth
c57e4e79a2
Revert "Cover some test/widgets tests with leak tracking" ( #133779 )
...
Reverts flutter/flutter#133767
Causing failures to Mac framework_tests_widgets and Linux framework_tests_widgets
2023-08-31 16:46:02 +00:00
Pierrick Bouvier
792e26df95
[Windows] Add target architecture to build path ( #131843 )
...
To implement windows-arm64 support, it is needed to add architecture as a subdirectory (https://github.com/flutter/flutter/issues/129805 ).
In short, when performing a flutter windows build, we have:
- Before: build/windows/runner/Release/gallery.exe
- After: build/windows/x64/runner/Release/gallery.exe
This convention follows what flutter linux build does.
Addresses: https://github.com/flutter/flutter/issues/129805
Addresses: https://github.com/flutter/flutter/issues/116196
Design doc: [flutter.dev/go/windows-arm64](https://flutter.dev/go/windows-arm64 )
2023-08-31 09:09:02 -07:00
Kostia Sokolovskyi
be06151e7d
Cover some test/widgets tests with leak tracking ( #133767 )
2023-08-31 09:02:49 -07:00
Kostia Sokolovskyi
414bff1403
ScrollController creation dispatching for memory leaks tracking ( #133759 )
2023-08-31 08:52:06 -07:00
Delwin Mathew
dd1ee24fc2
InputDecorationTheme.isCollapsed doesn't work if InputDecoration.isCollapsed is not provided. (#133189 )
...
`appleDefault` method didn't include setting values for non-null (here `isCollapsed`) parameters initially, which has been updated and documented in this commit.
Existing and new tests are passing.
Fixes #133144
2023-08-31 13:29:18 +00:00
Jonah Williams
a0862f1c3f
[framework] use ImageFilter for stretch overscroll. ( #133613 )
...
Rather than changing the size of the child elements (relaying out text
and potentially changing glyph shape and position due to pixel
snapping), apply the stretch effect as a compositing effect - render the
children to a texture and stretch the texture. If we end up using an
image shader to apply an custom shader we'll need to do this anyway.
Fixes https://github.com/flutter/flutter/issues/129528
### Before
https://github.com/flutter/flutter/assets/8975114/16e9eb57-f864-4093-b4a4-461082b89b43
### After
https://github.com/flutter/flutter/assets/8975114/14cf0167-8922-4876-a325-e3bc154b084f
2023-08-30 18:58:42 -07:00
Polina Cherkasova
be3e64abf1
Mark leak in _DraggableScrollableSheetState. ( #133693 )
2023-08-30 17:09:09 -07:00
Polina Cherkasova
2bc4c7a888
Mark routing test as leaking. ( #133697 )
2023-08-30 16:25:18 -07:00
Polina Cherkasova
95e197ba69
_RawAutocompleteState should dispose _highlightedOptionIndex. ( #133700 )
2023-08-30 16:07:35 -07:00
Matan Lurey
31600c829e
Forward-fix a test that will break with an engine roll. ( #133619 )
...
See https://github.com/flutter/engine/pull/44705 where it fails a framework smoke test.
Partial work towards https://github.com/flutter/flutter/issues/112498 .
2023-08-30 22:29:05 +00:00
Taha Tesser
d7a3a68275
Fix cancelButtonStyle & confirmButtonStyle properties from TimePickerTheme aren't working ( #132843 )
...
fixes [`TimePickerThemeData` action buttons styles aren't working](https://github.com/flutter/flutter/issues/132760 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
timePickerTheme: TimePickerThemeData(
cancelButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4)),
side: BorderSide(color: Colors.red),
),
backgroundColor: Colors.white,
foregroundColor: Colors.red,
elevation: 3,
shadowColor: Colors.red,
),
confirmButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(4)),
),
backgroundColor: Colors.green[700],
foregroundColor: Colors.white,
elevation: 3,
shadowColor: Colors.green[700],
),
),
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: TimePickerDialog(initialTime: TimeOfDay.now()),
),
);
}
}
```
</details>
### Before (action buttons don't use the style from the `TimePickerTheme`)
### After (action buttons use the style from the `TimePickerTheme`)
2023-08-30 22:21:29 +00:00
Taha Tesser
1e770c3808
Add cancelButtonStyle & confirmButtonStyle to the DatePickerThemeData ( #132847 )
...
fixes [Unable to adjust the color for "Cancel" and "Ok" button in datePicker dialog](https://github.com/flutter/flutter/issues/127739 )
### Code sample
<details>
<summary>expand to view the code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
debugShowCheckedModeBanner: false,
theme: ThemeData(
useMaterial3: true,
datePickerTheme: DatePickerThemeData(
cancelButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(16)),
side: BorderSide(color: Colors.red),
),
backgroundColor: Colors.white,
foregroundColor: Colors.red,
elevation: 3,
shadowColor: Colors.red,
),
confirmButtonStyle: TextButton.styleFrom(
shape: const RoundedRectangleBorder(
borderRadius: BorderRadius.all(Radius.circular(16)),
),
backgroundColor: Colors.green[700],
foregroundColor: Colors.white,
elevation: 3,
shadowColor: Colors.green[700],
),
),
),
home: const Example(),
);
}
}
class Example extends StatelessWidget {
const Example({super.key});
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: DatePickerDialog(
initialDate: DateTime.now(),
firstDate: DateTime(2020),
lastDate: DateTime(2030),
),
),
);
}
}
```
</details>
### Before
Not possible to customize action buttons from the `DatePickerThemeData`.
### After
2023-08-30 21:16:13 +00:00
Renzo Olivares
4b89fce108
Fixing memory leak in EditableTextState ( #131377 )
2023-08-30 12:49:56 -07:00
Bruno Leroux
b23105276f
Expose barrierDismissible in PageRoute constructor ( #133659 )
...
## Description
This PR exposes `barrierDismissible` in `PageRoute`, `MaterialPageRoute` and `CupertinoPageRoute` constructors.
Setting this property to true will enable the escape key binding.
## Related Issue
Fixes https://github.com/flutter/flutter/issues/132138 .
## Tests
Adds one test.
2023-08-30 19:02:06 +00:00
LongCatIsLooong
7f3abea35a
Reland "Remove ImageProvider.load, DecoderCallback and PaintingBinding.instantiateImageCodec ( #132679 ) (reverted in #133482 ) ( #133605 )
...
Relanding the commit per
https://github.com/flutter/flutter/pull/133482#issuecomment-1698030976
## Pre-launch Checklist
- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-08-30 11:28:10 -07:00
Taha Tesser
994aab4c78
Update & improve TabBar.labelColor tests ( #133668 )
...
fixes [Improve `TabBar.labelColor` tests](https://github.com/flutter/flutter/issues/133665 )
While working on a fix for https://github.com/flutter/flutter/issues/109484 , I found the existing test could use some improvement first.
2023-08-30 16:40:59 +00:00
Zachary Anderson
44a9b36461
Bump gradle heap size limits in templates ( #133671 )
...
For https://github.com/flutter/flutter/issues/133639
2023-08-30 15:40:14 +00:00
Bruno Leroux
1fe24956ac
Update SelectableRegion test for M3 ( #129627 )
...
## Description
This PR fixes one selectable region test failure when switching to M3.
The failure is somewhat tricky because it is related to the M3 typography (line height set to 1.43).
## Related Issue
fixes https://github.com/flutter/flutter/issues/129626
## Tests
Updates 1 test.
2023-08-30 13:25:35 +00:00
Xilai Zhang
6fd42536b7
[flutter roll] Revert "Fix Chip.shape's side is not used when provided in Material 3" ( #133615 )
...
Reverts flutter/flutter#132941
context: b/298110031
The rounded rectangle borders don't appear in some of the internal
golden image tests.
2023-08-29 19:59:02 -07:00
Parker Lougheed
670d011b71
No longer include .packages in created .gitignore files ( #133484 )
...
The `.packages` file was deprecated in Dart 2.8 and slowly discontinued until support being fully removed in Dart 2.19. The file will no longer be created, so it can be safely dropped from the generated `.gitignore` files.
2023-08-30 00:40:01 +00:00
Polina Cherkasova
4736cd3d37
Fix one notDisposed leak and mark another. ( #133595 )
2023-08-29 23:08:48 +00:00
Polina Cherkasova
67f9d77177
Upgrade packages. ( #133593 )
2023-08-29 15:18:12 -07:00
Polina Cherkasova
fb5abe45b8
Cover more tests with leak tracking. ( #133596 )
2023-08-29 14:23:10 -07:00
Hans Muller
4022864c65
Added DropdownMenuEntry.labelWidget ( #133491 )
2023-08-29 13:01:49 -07:00
Ian Hickson
89310edaa2
Use a fake stopwatch to remove flakiness. ( #133229 )
...
Fixes https://github.com/flutter/flutter/issues/133215
2023-08-29 12:49:33 -07:00
