2792 Commits

Author SHA1 Message Date
Martin Kustermann
6fae89c8b5
Update package:stack_trace dependency to 1.10.0-nullsafety.4 (#68132) 2020-10-16 16:35:20 +02:00
Jonah Williams
35c364053b
Fix screenshotting code (#68261) 2020-10-15 19:03:28 -07:00
Jonah Williams
d7f80fcdd3
[flutter_tools] configure screenshot on failure for all tasks (#68260) 2020-10-15 18:53:00 -07:00
Alexandre Ardhuin
73301a35a2
Sync lints (#68136) 2020-10-15 15:37:04 -07:00
Jonah Williams
ef205f7ebf
[devicelab] mark catalina not flaky and list iproxy processes before tet (#68239) 2020-10-15 14:21:40 -07:00
Dan Field
12f54e17f4
reland List queue search optimization (#68214)
* Revert "Revert "Improve performance of collectAllElements (#68065)" (#68207)"

This reverts commit 46ff57d6f19360da1da5fbdf0db70c49a716734a.

* use fewer elements for benchmark
2020-10-15 13:46:50 -07:00
Jonah Williams
0f88644883
[devicelab] allow the devicelab to take a screenshot if the iOS connection fails with FLUTTER_IOS_SCREENSHOT_ON_CONNECTION_FAILURE (#68156)
More attempts to remote diagnose the issues in the iOS devicelab
2020-10-15 13:13:28 -07:00
Jenn Magder
25857ce513
Use --device-timeout instead of deprecated --timeout in devicelab (#68230) 2020-10-15 12:45:59 -07:00
Jonah Williams
f5608f2b33
[devicelab] track any leaked processes (#68218) 2020-10-15 10:54:31 -07:00
Jonah Williams
2321b72dfb
[flutter_tools] move gradle download failure handling into tool (#68140)
This crash affects anyone using flutter, so move it into the tool where it can be tested and documented. Ensure it works on windows devicelab too.
2020-10-15 09:20:52 -07:00
Jonah Williams
46ff57d6f1
Revert "Improve performance of collectAllElements (#68065)" (#68207)
This reverts commit 8ba5732c4c874f08d853f30b10f1912efc992cc3.
2020-10-15 08:04:59 -07:00
Dan Field
8ba5732c4c
Improve performance of collectAllElements (#68065) 2020-10-14 21:32:04 -07:00
Jonah Williams
83e99f75c6
[devicelab] move test from flaky (#68141) 2020-10-14 14:47:41 -07:00
Jonah Williams
c11a64e944
[devicelab] turn down android X migration gradle tests (#68110)
These androidx migration tests require downloading firebase, which is a large library with a number of dependencies - this causes frequent enough flakes.

AndroidX migration is ~2 years in the past, and while it would be nice to confirm this still works, ideally that would be done in a reduced manner.
2020-10-14 13:24:22 -07:00
Kate Lovett
cd60da784f
Migrate Scaffold SnackBars in the framework to ScaffoldMessenger (#67946) 2020-10-14 13:12:03 -07:00
Jonah Williams
33903c17e1
[devicelab] delete disabled or not useful benchmarks (#68107)
- run_without_leak_tests: have been disabled for months
- build_benchmark: the tooling work here is mostly done and we're not tracking further improvements, free up more devicelab capacity
- system_debug_ios: does not work post iOS13
- mac_enable_twc: not adding more mac tests to devicelab
- hello_world_start_up: disabled

Any tests that we think will be valuable in the future can be resurrected from the git history.
2020-10-14 10:30:10 -07:00
Jonah Williams
06722679da
[devicelab] mark ios catalina as flaky (#68109) 2020-10-14 08:52:28 -07:00
Jonah Williams
751459df24
[flutter_tool] support --use-application-binary in flutter drive (#68060)
--use-application-binary allows running with an already built APK. This can be useful for speeding up CI test cases, or in our case eventually supporting some sort of build server. Demonstrate that this works by updating the old gallery test to use it. Fixes #56604

Co-authored-by: Jenn Magder <magder@google.com>
2020-10-13 19:27:30 -07:00
godofredoc
f8f6963cd1
Fix docset generation. (#67025)
* Fix docset generation.

* Remove checks to be able to test.

* More logging

* More logging

* More logging.

* more logging.

* More logging.

* Add flags to firebase command.

* Re-enable docset generation.

* Disable firebase step.

* Comment docset to speed up validations.

* Re-enable docset.

* Add back condition to prevent uploading docs from PRs.
2020-10-13 17:06:49 -07:00
Jonah Williams
eb24393efe
remove missing argument (#67974) 2020-10-12 17:18:09 -07:00
Jonah Williams
5dfe7e6d51
[flutter_tools] attempt to stabilize hot restart benchmark the old fashioned way (#67971)
A change which sped up hot restart locally caused many of the devicelab measures to regress. I think this is because we do not measure when the isolate is actually "ready", so starting a reload or restart prematurely can cause time spent doing initialization to be registered as part of the reload operation.

A fix for this would be to have the framework include some sort of "initialization complete" event ... but it is not clear what the correct trigger would be. Perhaps after the first frame is successfully registered?

(9a3a0dc caused the benchmark regression - possibly since we spend less time syncing files now so we start the restart earlier)
2020-10-12 17:00:26 -07:00
Shi-Hao Hong
244f5ab598
Expose date symbols and patterns for en_US in framework (#67900)
* Expose date symbols and patterns for en_US in framework
2020-10-13 07:56:10 +08:00
nturgut
fda735cf31
add links missed in the first pr (#67780) 2020-10-12 11:23:34 -07:00
Sam Rawlins
23c7ee9deb
Bump meta to 1.3.0-nullsafety.4 (#67744) 2020-10-12 09:50:30 -07:00
nturgut
0bc87a5816
make the new e2e tests blocker (#67788) 2020-10-12 09:48:24 -07:00
keyonghan
2639ac1d2e
Enable build_gallery tests in try/prod builders (#67749) 2020-10-09 15:57:04 -07:00
Jonah Williams
5fa801718f
[flutter_tools] remove train and inject-plugins command (#67766)
The train command does nothing and was originally added to provide a no-output default for generating app-jit snapshots. The inject-plugins command is only for a repo-only analysis check, which is not necessary since we regenerate during pub get.

#29805
2020-10-09 15:43:39 -07:00
Jonah Williams
e53bb74694
Revert "Revert "Delete fast start unit test (#67757)" (#67763)" (#67765)
This reverts commit b33bfcef0ffbeea36c8a846c54aaeeaf73bf1f87.
2020-10-09 13:04:20 -07:00
Jonah Williams
b33bfcef0f
Revert "Delete fast start unit test (#67757)" (#67763)
This reverts commit 3eb2335a4e62aecf706628795850b61c2f5ee01b.
2020-10-09 13:01:42 -07:00
Jonah Williams
3eb2335a4e
Delete fast start unit test (#67757)
Now that fast-start syncs assets by default, this isn't testing anything. Retire the test
2020-10-09 12:41:32 -07:00
nturgut
a755c03819
Add web e2e to the flutter/flutter repo (#67693)
* adding tests that uses integration_test (e2e) package to flutter

* change the package name for the import

* fix licenses. fix README commands. add links

* adding dependency change auto generated by the tool

* more analyzer error fixes
2020-10-09 12:24:36 -07:00
Jenn Magder
98aeef2d98
Build xcarchive command (#67598) 2020-10-08 19:51:35 -07:00
Yuqian Li
98d1ad0195
Purge persistent cache for perf test runs (#67697) 2020-10-08 19:17:02 -07:00
Mouad Debbar
ffcf419136
[web] Support custom url strategies (#59797) 2020-10-08 17:57:02 -07:00
Greg Spencer
58287aceef
Convert services tests to NNBD (#62694)
This converts the packages/flutter/test/services directory to NNBD, now that the services package is converted.

I changed the signature of checkMessageHandler and checkMockMessageHandler on BinaryMessenger to take a nullable handler, since the tests wanted to check to make sure a handler wasn't set, and that functionality no longer works if the handler is non-nullable.
2020-10-08 13:46:44 -07:00
Jonah Williams
0cd380f5d2
[flutter_tools] always run build tests on presubmit (#67654) 2020-10-08 12:28:20 -07:00
Yuqian Li
e1e12fa658
Mark nonflaky tests as such (#67592) 2020-10-08 12:20:14 -07:00
Kate Lovett
72696f77dd
Remove Cirrus support for Gold (#67468) 2020-10-08 14:19:42 -05:00
Yuqian Li
684449a841
Remove measureIosCpuGpu (#67363) 2020-10-08 12:02:03 -07:00
Yegor
0b78110b26
Work around the glibc bug that causes rare Chrome crashes (#67466)
Work around the glibc bug that causes rare Chrome crashes
2020-10-07 19:29:47 -07:00
Casey Hillers
9e206a0c93
Refactor devicelab logic to use TaskResult instead of JSON (#67550) 2020-10-07 16:37:09 -07:00
Michael Goderbauer
52d3bef017
Reland removal of examples/catalog (#67545) 2020-10-07 13:17:08 -07:00
Janice Collins
e9a9a6104c
Update dartdoc to 0.35.0 (#67432) 2020-10-07 08:47:05 -07:00
Hans Muller
ab9373bf48
Removed remaining obsolete button widget references (#67440) 2020-10-07 08:45:41 -07:00
Justin McCandless
896c19a292
Characters docs (#67361) 2020-10-06 17:02:04 -07:00
Jonah Williams
ef6c720d40
[flutter_test] handle breaking change to test main (#67425)
* [flutter_test] handle breaking change to test main . Fixes #67382
2020-10-06 16:52:23 -07:00
Hans Muller
1a08ce7400
Updated the remaining obsolete button references in flutter_gallery (#67437) 2020-10-06 13:21:08 -07:00
Jenn Magder
e5131fa31b
Increase device discovery timeout in devicelab health check (#67337) 2020-10-06 12:23:02 -07:00
keyonghan
74c3ea4d41
Remove deployment to play store for linux case in deploy_gallery test (#67349) 2020-10-05 19:12:02 -07:00
Ming Lyu (CareF)
277a72e3fe
move resampler to handlePointerEvent and fix complex_layout_android__scroll_smoothness with PointerEvent (#66745) 2020-10-05 17:17:03 -07:00