10910 Commits

Author SHA1 Message Date
Kate Lovett
6ff212b328
Comparing pixels instead of bytes with GoldenFileComparator (#38473) 2019-08-19 09:06:22 -07:00
Michael Thomsen
79d8967500
Fix publish cmd (#38490) 2019-08-19 08:02:13 +01:00
stuartmorgan
69acc0f545
Update the macOS Podfile template platform version (#38651)
Change the target macOS version from 10.13 to 10.11, per decision on
target platform.

Part of #33200
2019-08-16 18:49:57 -07:00
Todd Volkert
c22ce95e15
Change from using defaults to plutil for Plist parsing (#38662)
We were using the `defaults` command-line utility to parse
Plist files, but it was never supported by Apple, and it
appears that in an upcoming OS release, it will be less likely
to work:

> WARNING: The defaults command will be changed in an upcoming
> major release to only operate on preferences domains. General
> plist manipulation utilities will be folded into a different
> command-line program.

Fixes https://github.com/flutter/flutter/issues/37701
2019-08-16 17:10:07 -07:00
Greg Spencer
d6938c56d9
Adds canRequestFocus toggle to FocusNode (#38704)
* Add an 'unfocusable' focus node to allow developers to indicate when they don't want a Focus widget to be active

* more unfocusable changes. not working.

* Switch to focusable attribute

* Rename to canRequestFocus

* Turn off debug output

* Update docs

* Removed unused import
2019-08-16 15:27:49 -07:00
Yegor
34c692659e
Teach render objects to reuse engine layers (#36402)
Teach Layer and its implementations, RenderObject and its implementations, and PaintingContext to reuse engine layers. The idea is that a concrete RenderObject creates a Layer and holds on to it as long as it needs it (i.e. when it is composited, and the layer type does not change). In return, each Layer object holds on to an EngineLayer and reports it to the engine via addRetained and oldLayer. This allows the Web engine to reuse DOM elements across frames. Without it, each frame drops all previously rendered HTML and regenerates it from scratch.
2019-08-16 15:27:12 -07:00
Michel Feinstein
1a5e4a5d7f Adds the arrowColor option to UserAccountsDrawerHeader (#38608) (#38636)
Changes a hard-coded value to a controllable parameter.
2019-08-16 15:14:14 -07:00
Chris Yang
09f6515b73
PlatformViewLink: Rename CreatePlatformViewController to CreatePlatformViewCallback (#38710) 2019-08-16 14:24:01 -07:00
Kate Lovett
cac8fa5da0
Re-land 'Adding physicalDepth to MediaQueryData & TestWindow' (#38546) 2019-08-16 13:34:23 -07:00
Nurhan Turgut
c2e2f093ec
Navigator change backup (#38494)
* Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route

* Broadcasting popRoute and pushRoute methods via SystemChannels.navigation. These messages will be used in flutter_web to detect the route

* Reverting all unrelated formatting changes.

* Adding unit tests. Adding more comments.

* Changing string method names with constant strings.

* Fixing a constant strings.

* Fixing analyzer error.

* Fixing more white space.

* Changing the method names. Adding comments to the SystemChannels

* Comment and code name fixes

* replacing the comment with reviewer suggestion.

* addinf systemchannels.navigation mock to test bindings

* Adding a new class for sending route change notrifications. The nottifications are only sent on web. This should fix breaking android/ios

* using new class RouteNotificationMessages in navigator

* Fixing analyzer issues.

* fixing cycle dependency

* fixing github analyze error

* dartfmt two new classes. trying to fix anayze errors

* Update route_notification_messages.dart

* trying to fix white space errors
2019-08-16 13:17:45 -07:00
Chris Yang
0b087a898a
PlatformViewLink: update cached surface to be Widget type (#38639) 2019-08-16 11:23:21 -07:00
Shi-Hao Hong
ff0eca6463
Toggle buttons docs (#38635)
* Add toggle buttons assets

* Reorder video location, reduce height of videos

* Reduce height of toggle buttons assets
2019-08-16 14:19:54 -04:00
brandondiamond
c161ac898c Fix typos / errors in doc comments (#38558) 2019-08-16 11:18:39 -07:00
Greg Spencer
a11d73148c
Automatic focus highlight mode for FocusManager (#37825)
This adds a FocusHighlightMode to the FocusManager that switches based on the type of input that has recently been received. The initial value is based on the platform, but is updated as soon as user input is received. There is also a FocusHighlightStrategy enum so that the developer can change the strategy to a fixed value if needed.

The default is to automatically detect the mode based on the last type of user input. If they use a mouse or keyboard, it shows the focus highlights. If they use a touch interface, then the highlights disappear. This is consistent with the way that Android and Chrome work. The controls still receive focus, only the display of the highlight changes.

Text fields show the focus highlight regardless of the focus highlight mode.
2019-08-16 10:40:08 -07:00
Tom Robinson
1d03459fdb
Fix getOffsetToReveal for growthDirection reversed and AxisDirection down or right (#38441)
* Take growth direction into account when computing value for getOffsetForReveal in AxisDirection.right and .up conditions.

* Add alignment 1.0 test to left - reverse growth

* Add Reverse List showOnScreen test

* Formatting fix.
2019-08-16 13:38:23 -04:00
Dan Field
a3221667de
Kill dead code (#38652) 2019-08-16 10:10:23 -07:00
rami-a
13844aa62a
[Material] Create theme for Dividers to enable customization of thickness (#38621) 2019-08-16 13:09:36 -04:00
Andri Jasinski
267b858561 Disable xcode indexing in CI via COMPILER_INDEX_STORE_ENABLE=NO argument (#37378) 2019-08-16 08:29:45 -07:00
LongCatIsLooong
0ba8c2cdb1
Fix text scale factor for non-content components of Cupertino scaffolds (#38593) 2019-08-15 20:02:04 -07:00
Todd Volkert
1d8deb1bb8
Handle case of a connected unpaired iOS device (#38629)
Fixes https://github.com/flutter/flutter/issues/36789
Fixes https://github.com/flutter/flutter/issues/37000

https://github.com/flutter/flutter/issues/36524
https://github.com/flutter/flutter/issues/24600
2019-08-15 17:59:37 -07:00
Tom Robinson
0b3f2f61a2
Change RenderObject.getTransformTo to include ancestor. (#37652)
getTransformTo now includes ancestor in the transform it returns, except
for if ancestor is the root view, ensuring that the transform remains in
logical pixel space.
2019-08-15 20:52:15 -04:00
Jonah Williams
1df165ea13
Rename iOS arch for macOS release mode (macOS release mode 2 of 3) (#38645) 2019-08-15 17:38:35 -07:00
Jonah Williams
01feddbece
Support for macOS release mode (1 of 3) (#37425) 2019-08-15 16:36:45 -07:00
Zachary Anderson
0566971d29
[flutter_tool] Throw tool exit on malformed storage url override (#38637) 2019-08-15 14:59:46 -07:00
liyuqian
77aa495eff
Update shader warm-up for recent Skia changes (#37955)
The update is copied from an update we made to a Google-internal
client: cl/260202900

The update will save 1 shader compilation.

This should help solve our regression:
https://github.com/flutter/flutter/issues/31203

More regressions on iOS might be introduced later by
https://github.com/flutter/engine/pull/9813#issuecomment-520039890

Unfortunately, we didn't rebase our benchmarks so such regressions
were not detected.

Hence to fully solve https://github.com/flutter/flutter/issues/31203,
we might need to revert some change in
https://github.com/flutter/engine/pull/9813 to make iOS shader warm-up
happen on the GPU thread again.
2019-08-15 13:04:22 -07:00
Greg Spencer
a24bfed0e7
Add autofocus parameter to widgets which use Focus widget internally (#37809)
Add an autofocus parameter to widgets which use Focus widget internally, and update related docs.

This will allow developers to request that a particular widget be automatically focused when shown.
2019-08-15 12:30:19 -07:00
Chris Yang
5acf63d35a
PlatformViewLink, handling creation of the PlatformViewSurface and dispose PlatformViewController (#37703)
* link

* review fixes

* review fixes

* remove extra line
2019-08-15 12:16:38 -07:00
Zachary Anderson
e24a27d374
[flutter_tool] Flip create language defaults to swift and kotlin (#38339) 2019-08-15 12:13:28 -07:00
Jonah Williams
8d6dc620d6
fix rpc exception for real (#38575) 2019-08-15 12:13:12 -07:00
Zachary Anderson
a40ab895cf
[flutter_tool] Observatory connection error handling cleanup (#38353) 2019-08-15 12:13:03 -07:00
Alexander Aprelev
f5dcbdab3a Increase pattern that matches operation duration. (#36392)
On Flutter HHH buildbot some operations that over a second: 4 digits for milliseconds, rather than 3 that are currently allowed.
2019-08-15 10:16:30 -07:00
Ingo Reinhart
ed88d28d52 use common emulator/device list (#38296) 2019-08-15 10:13:18 -07:00
MH Johnson
1033155fb9
[Material] Add splashColor to FAB and FAB ThemeData (#38467)
* [Material] Add splashColor param to FAB and FAB ThemeData
2019-08-15 13:12:21 -04:00
Jonah Williams
5ec039dd45
Don't reload if compilation has errors (#38586) 2019-08-15 09:08:19 -07:00
Dan Field
07f079a932
Improve bitcode check (#38587) 2019-08-14 23:30:26 -07:00
Jonah Williams
64add554d7
handle unexpected exit from frontend server (#38497) 2019-08-14 19:00:31 -07:00
Jonah Williams
388d69eb9b
Catch errors thrown into the Zone by json_rpc (#38486) 2019-08-14 13:10:41 -07:00
Jonah Williams
ec41ef5bf8
update build_runner and configure libraries (#38499) 2019-08-14 10:00:42 -07:00
Jason Simmons
fe5651b846
Do not construct arguments to _focusDebug when running in non-debug modes (#38463)
The time required to call FocusNode.toString and build _focusDebug messages
was showing up in some performance benchmarks.
2019-08-14 09:46:20 -07:00
Zachary Anderson
d220631eca
[flutter_tool] Fix bug in manifest yaml validation (#38472) 2019-08-14 07:57:30 -07:00
Francisco Magdaleno
760635e6db
[linux] Receives the unmodified characters obtained from GLFW (#34752) 2019-08-13 18:14:36 -07:00
Christopher Fujino
cd1e55b58a
refactor flutter upgrade to be 2 part, with the second part re-entrant (#38325) 2019-08-13 15:53:54 -07:00
David Shuckerow
9615eb99aa
Tests for flutter test [some_directory] (#36866)
* Add a test for a directory instead of a single test.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Add test data to a child directory to test the command.

* Correct test.
2019-08-13 14:57:43 -07:00
MH Johnson
17ddfb1b42
make RawChip.selected non-nullable (#37556) 2019-08-13 17:36:44 -04:00
Jonah Williams
ca5411e3aa
Fix type error hidden by implicit downcasts (#38102) 2019-08-12 15:21:28 -07:00
Shi-Hao Hong
2003432cd8
Drawer edge drag width improvements (#37492)
* Added customizable drawer edge drag width parameter to Drawer and Scaffold

* Fix Drawer drag area width for notched devices

* Update Drawer tests to reflect necessary LTR and RTL Drawer edge widths
2019-08-12 18:20:35 -04:00
Shi-Hao Hong
0f3919e539
Adds DefaultTextStyle ancestor to Tooltip Overlay (#37877)
* Add DefaultTextStyle parent widget to Tooltip Overlay

* Add test against fallback DefaultTextStyle
2019-08-12 17:24:51 -04:00
Jonah Williams
aa758a3f02
remove bsdiff BUILD.ng (#38342) 2019-08-12 13:04:10 -07:00
Greg Spencer
aa5cc40368
Focus Manager debug output improvements. (#37891)
This improves the ability to debug focus manager issues. It's not meant to be used by developers unless they're debugging problems with the focus manager itself.
2019-08-12 13:02:49 -07:00
Justin McCandless
19d113b0e7
resizeToAvoidBottomInset Cupertino without NavBar (#37319)
Fix a bug in CupertinoTextField where resizeToAvoidBottomInset didn't work.
2019-08-12 12:56:19 -07:00