Matan Lurey
72ee26e314
Initialize Flutter Beta (flutter-3.32-candidate.0) ( #166783 )
...
Closes https://github.com/flutter/flutter/issues/166811 .
```sh
$ dev/conductor/bin/conductor start \
--candidate-branch=flutter-3.32-candidate.0 \
--release-channel=beta \
--github-username=matanlurey \
--dart-revision=0d6811928830b87e36a0f49eb7fe554c308d3699
```
2025-04-09 22:57:49 +00:00
Matan Lurey
4a3d13eb17
Enable a swath of bringup: true builds that were forgotten to the void. ( #166757 )
2025-04-08 17:14:10 +00:00
auto-submit[bot]
e5cd67b6fc
Reverts "Reverts "Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )" ( #166700 )" ( #166711 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166700
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: bkonyi
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: breakage fixed in
https://github.com/flutter/flutter/pull/166701
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: auto-submit[bot]
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {fluttergithubbot}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166687
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke postsubmit ("... not up to date")
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718230395584699185/+/u/run_test.dart_for_tool_tests_shard_and_subshard_widget_preview_scaffold/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
New shard seems to be stable and passing consistently.
<!-- end_revert_body -->
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-04-07 19:05:47 +00:00
auto-submit[bot]
208b2b1a9f
Reverts "Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )" ( #166700 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#166687
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: matanlurey
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Broke postsubmit ("... not up to date")
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8718230395584699185/+/u/run_test.dart_for_tool_tests_shard_and_subshard_widget_preview_scaffold/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: bkonyi
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {matanlurey}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
New shard seems to be stable and passing consistently.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-04-07 17:06:47 +00:00
Ben Konyi
a333757dcf
Remove bringup:true from Linux tool_tests_widget_preview_scaffold ( #166687 )
...
New shard seems to be stable and passing consistently.
2025-04-07 16:15:55 +00:00
Ben Konyi
d6c0d6fee7
[ Widget Previews ] Add widget_preview_scaffold.shard to test the widget_preview_scaffold template contents ( #166358 )
...
Adds a new `widget_preview_scaffold.shard` directory which contains a
hydrated `widget_preview_scaffold` template. This will allow for us to
write widget tests against the widgets defined in the templates.
This PR doesn't add any widget tests and is only adding the ability to
run these tests in follow up changes.
Fixes https://github.com/flutter/flutter/issues/166416
2025-04-04 18:43:52 +00:00
jesswrd
b4543b7bf2
Updated to latest AVD to Support Android 16 (API 36) ( #165926 )
...
Updated test targets to depend on the latest AVD version that supports
Android 16(API 36) for framework. Updated to a 36 emulator at
`linux_android_emu_unstable` only to experiment and monitor potential
flakiness. After confirmed stability (~200 commits), I will update other
targets to depend on a 36 emulator in framework, packages, and engine.
Partially Addresses #165922
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-31 18:46:45 +00:00
Flutter GitHub Bot
53d93da57a
Marks Linux_mokey new_gallery__crane_perf to be flaky ( #165964 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux_mokey new_gallery__crane_perf"
}
-->
Issue link: https://github.com/flutter/flutter/issues/165963
2025-03-31 17:41:07 +00:00
Mitchell Goodwin
9f1e7eda61
Remove bringup flag for customer tests ( #166161 )
...
Fixes #166160 by reverting #166103 .
Customer tests were not finishing due to errors in devtools, caused by
package:vm_service_protos being upgraded to 1.1.0 and desyncing with
package:protobuf. [package:vm_service_protos
](https://pub.dev/packages/vm_service_protos )has been rolled back to
1.0.0, and the [devtool checks are passing
again](https://github.com/flutter/devtools/actions/workflows/build.yaml ),
so marking the customer tests as unflaky again.
2025-03-28 21:21:04 +00:00
Zachary Anderson
d30c767656
Mark Linux coverage as bringup ( #166144 )
...
For https://github.com/flutter/flutter/issues/164591
2025-03-28 16:59:52 +00:00
Mitchell Goodwin
6816e6dbba
Mark Linux customer tests as flaky ( #166103 )
...
Marks tests as flaky to unblock tree. Related to #166102
2025-03-27 22:49:36 +00:00
jesswrd
807ccd7f9d
Update Java Versions to 21 on CI ( #165210 )
...
Updated java versions to 21 on CI. Monitor to see if anything breaks.
Fixes https://github.com/flutter/flutter/issues/163158
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: Gray Mackall <34871572+gmackall@users.noreply.github.com>
2025-03-24 22:43:22 +00:00
Jonah Williams
31ff6497f1
Reland: [Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165622 )
...
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
---------
Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-03-22 01:34:05 +00:00
auto-submit[bot]
0158281d6e
Reverts "[Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165261 )" ( #165619 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#165261
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jonahwilliams
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: bork the tree
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jonahwilliams
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {gaaclarke}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-03-21 00:17:47 +00:00
Jonah Williams
cab4fe33c3
[Impeller] add a configuration option that allows defering all PSO construction until needed. ( #165261 )
...
The cost of bootstapping the initial PSOs can regress cold startup time
for customer money. As an experiment, attempt to defer PSO construction
to skia like.
---------
Co-authored-by: Aaron Clarke <aaclarke@google.com>
Co-authored-by: gaaclarke <30870216+gaaclarke@users.noreply.github.com>
2025-03-20 21:06:09 +00:00
Flutter GitHub Bot
a780f85f2c
Marks Linux tool_integration_tests_4_7 to be unflaky ( #165475 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux tool_integration_tests_4_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_4_7%22 ).
This test can be marked as unflaky.
2025-03-19 13:03:58 +00:00
Flutter GitHub Bot
59d00e6fed
Marks Linux tool_integration_tests_6_7 to be unflaky ( #165477 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux tool_integration_tests_6_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_6_7%22 ).
This test can be marked as unflaky.
2025-03-19 12:54:47 +00:00
Flutter GitHub Bot
f87f0de96f
Marks Linux tool_integration_tests_5_7 to be unflaky ( #165476 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Linux tool_integration_tests_5_7"
}
-->
The test has been passing for [50 consecutive
runs](https://data.corp.google.com/sites/flutter_infra_metrics_datasite/flutter_check_test_flakiness_status_dashboard/?p=BUILDER_NAME:%22Linux%20tool_integration_tests_5_7%22 ).
This test can be marked as unflaky.
2025-03-19 12:54:47 +00:00
Victoria Ashworth
425d1bd258
Update tests to use Xcode 16.2 and iOS 18.2 Simulator ( #165318 )
...
Runs tests on Xcode 16.2 and iOS 18.2. Also updates engine scenario
golden files to iOS 18.2 and removes non-impeller (Skia) test files that
we no longer use.
All framework tests passing:
https://github.com/flutter/flutter/issues/148899#issuecomment-2701465612
All engine tests passing:
https://github.com/flutter/flutter/issues/148906#issuecomment-2702112378
Fixes https://github.com/flutter/flutter/issues/148907 and
https://github.com/flutter/flutter/issues/148957 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-18 14:13:26 +00:00
Harri Kirik
eef31a1c2b
Update Mac_mokey microbenchmarks with issue to the bringup: true in ci config for easier discovery ( #164694 )
...
Update the comment in .ci.yaml with the issue link for easier discovery.
Related issue: #156506
Related discussion: https://github.com/flutter/flutter/pull/162000
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-03-12 14:04:10 +00:00
Andrew Kolos
d212ca3cb3
increase Linux tool_integration_tests* subsharding ( #164935 )
...
The last subshard of Linux tool_integration_test is timing out again:
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20tool_integration_tests_6_6
This increases the subsharding to get the tree to a healthy state
<details>
<summary> Pre-launch checklist </summary>
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
</details>
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-10 22:49:15 +00:00
Victoria Ashworth
eb07c51230
Add lldb init file ( #164344 )
...
Adds an .lldbinit file to iOS app xcscheme.
Adding to scheme files can be error prone since a developer may be using
custom schemes (flavors). If we can't add it to the scheme, we print an
error without failing.
Since it is part of the scheme, it will be added to the project and will
be used on every run regardless of the device type/version. The Dart
side handles limiting to specific devices. If needed, we can alter the
.lldbinit file during `flutter assemble` to rewrite it since it doesn't
read the file until launch time (therefore it can be changed during
build time).
During `flutter assemble`, if the project doesn't have an LLDB Init File
set for any schemes, it'll throw an error if running in debug mode with
an iOS 18.4+ device.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-06 21:21:52 +00:00
Reid Baker
2578d97f32
Revert "Skip Xcode install on mac_mokey Android tests ( #163685 )" ( #164581 )
...
This reverts commit 2a6b0158b229fce6f79bd1af6134181600d18b6f.
Revert "Skip Xcode install on mac_mokey Android tests (#163685 )"
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-03-04 22:53:26 +00:00
auto-submit[bot]
f86d556d1e
Reverts "Run run_debug_test_android and run_release_test in prod ( #164231 )" ( #164512 )
...
<!-- start_original_pr_link -->
Reverts: flutter/flutter#164231
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: jmagman
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Passed a few times but is continuing to fail in
prod
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8721388050458438721/+/u/run_run_release_test/stdout
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: jmagman
<!-- end_original_pr_author -->
<!-- start_reviewers -->
Reviewed By: {reidbaker}
<!-- end_reviewers -->
<!-- start_revert_body -->
This change reverts the following previous change:
`run_debug_test_android` and `run_release_test` were both consistently
failing because of stray stderr logging that Xcode simctl (simulator
command line tool) wasn't installed.
https://github.com/flutter/flutter/pull/163895 removed that logging, and
these tests are now passing:
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_debug_test_android/1373/overview
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_release_test/3467/overview
They were originally marked bringup because they were flaky (like 10%)
but while in bringup went to 100% failure due to the Xcode install
issue. It looks like they really weren't flaky any more before the Xcode
install issues, but erroneously the flaky issue was closed but the test
wasn't marked unflaky
https://github.com/flutter/flutter/issues/153830#issuecomment-2314768260 .
Moving out of bringup.
Fixes https://github.com/flutter/flutter/issues/161655
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
<!-- end_revert_body -->
Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
2025-03-03 20:52:47 +00:00
Reid Baker
7ea4ac53f2
Update ktlint to 1.5 ( #164409 )
...
Fixes https://github.com/flutter/flutter/issues/164408
Ready for review
~I think this pr is blocked by
https://github.com/flutter/cocoon/pull/4275 uploading a new artifact.~
then someone with cipd-writers access running `cipd set-ref
flutter/ktlint/linux-amd64 -ref version_1_5_0 -version <TBD ID>`
where id comes from
https://chrome-infra-packages.appspot.com/p/flutter/ktlint/linux-amd64
To check if I had writer permissions I ran `cipd acl-check
flutter/android/sdk/all/ -writer`
To request permissions use go/flutter-cipd-write (googler only)
Successful run of linux analyze
https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/96415/overview
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-03-03 19:39:23 +00:00
Jenn Magder
3bb5bf4d43
Run run_debug_test_android and run_release_test in prod ( #164231 )
...
`run_debug_test_android` and `run_release_test` were both consistently
failing because of stray stderr logging that Xcode simctl (simulator
command line tool) wasn't installed.
https://github.com/flutter/flutter/pull/163895 removed that logging, and
these tests are now passing:
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_debug_test_android/1373/overview
https://ci.chromium.org/ui/p/flutter/builders/staging/Mac_mokey%20run_release_test/3467/overview
They were originally marked bringup because they were flaky (like 10%)
but while in bringup went to 100% failure due to the Xcode install
issue. It looks like they really weren't flaky any more before the Xcode
install issues, but erroneously the flaky issue was closed but the test
wasn't marked unflaky
https://github.com/flutter/flutter/issues/153830#issuecomment-2314768260 .
Moving out of bringup.
Fixes https://github.com/flutter/flutter/issues/161655
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-03-03 18:03:11 +00:00
Loïc Sharma
796400744f
Increase customer test timeout to 60 minutes ( #164239 )
...
Customer test timeouts are a frequent source of tree closures.
This change should be reverted once
https://github.com/flutter/flutter/issues/164140 is completed.
2025-02-27 01:09:22 +00:00
Zachary Anderson
092be76124
Run new gallery transition perf benchmark on Galaxy S24 ( #163665 )
...
There are now many S24 devices in the prod pool.
2025-02-26 02:55:38 +00:00
Jenn Magder
ad8718644c
Revert "Marks Linux_pixel_7pro service_extensions_test to be flaky" ( #163882 )
...
Reverts flutter/flutter#157853
Should have fixed https://github.com/flutter/flutter/issues/157852 but
that was closed.
2025-02-25 22:24:50 +00:00
Jason Simmons
b199cba0da
Increase the timeout for Mac web_tool_tests to 45 minutes ( #164118 )
...
This job seems to be timing out often when it is scheduled on a slower
x64 machine.
2025-02-25 20:07:52 +00:00
Jason Simmons
a4a5a33cfa
Roll .ci.yaml changes into the LUCI configuration only when the master branch is updated ( #163897 )
...
The .ci.yaml on a release branch may be missing builders that are active
on the latest master version of .ci.yaml. If a configuration based on
the release branch is pushed to LUCI, then CI will fail to schedule
those builders when run for a master branch PR.
2025-02-24 20:54:51 +00:00
Jenn Magder
57c13944e6
Revert "Marks Mac_benchmark basic_material_app_macos__compile to be flaky" ( #163878 )
...
Reverts flutter/flutter#162365
The timeouts looked like infra issues, but it's no longer flaking.
Fixes https://github.com/flutter/flutter/issues/162364
2025-02-21 21:41:56 +00:00
Jenn Magder
1586b35c21
Revert "Marks Mac_benchmark flutter_view_macos__start_up to be flaky" ( #163880 )
...
Reverts flutter/flutter#159541
This is no longer flaking.
Fixes https://github.com/flutter/flutter/issues/159540
2025-02-21 21:41:56 +00:00
Jenn Magder
b1f94c66b8
Revert "Marks Windows_mokey native_assets_android to be flaky" ( #163881 )
...
Reverts flutter/flutter#156064
Should have marked https://github.com/flutter/flutter/issues/156063
fixed but it was already closed.
2025-02-21 21:31:52 +00:00
Jenn Magder
93aca4d43f
Mark platform_views_hcpp_scroll_perf__timeline_summary out of bringup ( #163883 )
...
platform_views_hcpp_scroll_perf__timeline_summary is happily passing
https://ci.chromium.org/ui/p/flutter/builders/staging/Linux_pixel_7pro%20platform_views_hcpp_scroll_perf__timeline_summary/255/overview
Introduced in https://github.com/flutter/flutter/pull/163018 .
2025-02-21 21:30:14 +00:00
Matan Lurey
0f586af401
Ensure exclude_dev_dependencies_test runs if flutter_tools changes. ( #163768 )
...
Caused the breakage mentioned in
https://github.com/flutter/flutter/issues/163767 .
2025-02-21 00:06:04 +00:00
Jenn Magder
2a6b0158b2
Skip Xcode install on mac_mokey Android tests ( #163685 )
...
These tests are failing on querying Xcode for simulator devices when
running Android tests. Ideally recipes wouldn't try to install Xcode
unless requested via `"sdk_version": "[xcode version number]"` property,
[but they do](https://github.com/flutter/flutter/issues/163670 ). Since
the recipe[ mapping of macOS version to Xcode
version](https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#22 )
is out of date, it's falling back to an old version of Xcode when none
are specified.
Stop installing Xcode on these builder configurations. If this works
I'll follow up and add it to `mac_pixel_7pro`, `mac_arm64_android`, etc.
First step of https://github.com/flutter/flutter/issues/161655 . If this
works `bringup` can be removed.
Fixes https://github.com/flutter/flutter/issues/163309
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-20 17:31:44 +00:00
Zachary Anderson
41d3fa7dc9
Add a test to run on Galaxy S24 ( #163357 )
...
S24 is only hooked up in the try pool at the moment, so this will fail
in the staging pool after landing, following which we can run the test
in a second PR in presubmit by changing `presubmit` to `true`.
For https://github.com/flutter/flutter/issues/162639
2025-02-19 20:05:05 +00:00
Flutter GitHub Bot
39b4951f8f
Marks Windows_arm64 plugin_test_windows to be flaky ( #163123 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Windows_arm64 plugin_test_windows"
}
-->
Issue link: https://github.com/flutter/flutter/issues/163122
2025-02-18 21:42:53 +00:00
Reid Baker
a55471aef5
Remove bringup for android_display_cutout ( #163312 )
...
fixes #162615
Evidance of passing.
https://flutter-dashboard.appspot.com/#/build?taskFilter=cut&showBringup=true&repo=flutter&branch=master&showMac=false&showWindows=false&showiOS=false&showLinux=false
One failure is an unrelated tooling failure #163311
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-18 17:00:54 +00:00
Jonah Williams
89311b7600
remove frame policy benchmark. ( #163245 )
...
This benchmark is a benchmark of the integration test binding which IMO
is not that important given that we continue to rely on flutter_driver
for actual performance metrics.
2025-02-13 20:26:04 +00:00
Reid Baker
d8c92a445c
Remove android 34 redundant emulator tests ( #163227 )
...
b/371020223
linux_android_emu and linux_android_emu_34 ran 2 different sets of
dependencies because the adoption of 35 was unstable. The reasons why
wound up being incompatible/bad versions of the build tool dependencies
like the graphics engine chosen was unstable on 35. This was fixed with
dependency changes.
Introduce an unstable linux android emulator configuration that can be
used to prove a dependency set as stable.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-13 18:30:08 +00:00
Jim Graham
16b7ab69dc
Increase timeout for Windows build_android_host_app_with_module_aar ( #163161 )
...
Windows is taking just longer than 30 minutes to finish this task. 45
minutes will keep us informed if it gets much longer without causing
lots of CI flakes. Mac and Linux versions of these tasks are finishing
well under 30 minutes so their timeouts are being left at the default.
2025-02-12 22:35:50 +00:00
Jenn Magder
3011859512
Revert "Marks Mac_benchmark flutter_gallery_macos__compile to be flaky" ( #162039 )
...
Reverts flutter/flutter#160496
This is no longer flaky.
Closes https://github.com/flutter/flutter/issues/160495
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-02-12 20:00:47 +00:00
Reid Baker
0f5d669acb
Trigger display_cutout_rotation flutter driver test in ci. ( #162641 )
...
Fixes https://github.com/flutter/flutter/issues/162615
Can test 2 different ways.
On a mac (or linux machine) with adb on the path (or android sdk set in
ANDROID_HOME) and an emulator running (or physical device attached) that
is api 30 or higher.
```
cd dev/devicelab
dart bin/test_runner.dart test -t android_display_cutout
```
OR
```
dev/integration_tests/display_cutout_rotation
flutter drive integration_test/display_cutout_test.dart
```
Proof the test ran successfully
```
[2025-02-12 08:08:22.069817] [STDOUT] Removing Synthetic notch...
[2025-02-12 08:08:22.071147] [STDOUT] Executing "/b/s/w/ir/cache/android/sdk/platform-tools/adb -s emulator-5554 shell cmd overlay disable com.android.internal.display.cutout.emulation.tall" in "/b/s/w/ir/x/w/rc/tmpk3k3yhhp/flutter sdk/dev/integration_tests/display_cutout_rotation/" with environment {BOT: true, LANG: en_US.UTF-8}
[2025-02-12 08:08:22.862219] [STDOUT] Checking for reboot
[android_defines_test] Process terminated with exit code 0.
Task result:
{
"success": true,
"data": null,
"detailFiles": [],
"benchmarkScoreKeys": [],
"reason": "success"
}
```
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8723125792202374961/+/u/run_android_defines_test/stdout
All checks passed
https://github.com/flutter/flutter/pull/162641/checks?check_run_id=36991537539
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
2025-02-12 19:42:39 +00:00
Flutter GitHub Bot
c5a144435a
Marks Mac_benchmark basic_material_app_macos__compile to be flaky ( #162365 )
...
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
"name": "Mac_benchmark basic_material_app_macos__compile"
}
-->
Issue link: https://github.com/flutter/flutter/issues/162364
Co-authored-by: Chris Bracken <chris@bracken.jp>
2025-02-11 23:52:30 +00:00
Jonah Williams
6291a51ce2
[Android] add HCPP platform views benchmark and integration test. ( #163018 )
...
Adds a benchmark and integration test of HCPP using a Pixel 7.
2025-02-11 02:12:49 +00:00
Matan Lurey
7afc8557a4
Try golden-testing on a Mokey (bringup: true), retry on an emulator ( #163029 )
...
Towards https://github.com/flutter/flutter/issues/162362 (see if retries
help VD on an emulator).
Towards https://github.com/flutter/flutter/issues/163025 (see if we can
golden-test on a device).
May the odds be in our favor.
2025-02-11 01:46:24 +00:00
Matan Lurey
8ca08577a5
Enable *_module_test_ios tests that are skipped on presubmit. ( #162892 )
...
@vashworth fixed the underlying issue in
https://github.com/flutter/flutter/issues/150642 .
There doesn't seem to be anything specific to iOS/macOS that is
regularly failing:
-
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64%20module_test_ios
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Mac_arm64%20build_ios_framework_module_test
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Linux%20build_aar_module_test
-
https://ci.chromium.org/ui/p/flutter/builders/luci.flutter.prod/Mac%20build_ios_framework_module_test
2025-02-07 20:37:58 +00:00
Victoria Ashworth
0781d2efc8
Run Mac_arm64 framework_tests_misc on Mac-14 with Xcode 16 ( #162670 )
...
This test was failing on macOS 14, but [may pass if used with Xcode
16](https://github.com/flutter/flutter/issues/150008#issuecomment-2368846893 ).
Let's force it to run with Xcode 16.
Fixes https://github.com/flutter/flutter/issues/150008 .
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
2025-02-05 20:45:38 +00:00
