* b99d94f39 Roll Skia from 1c823674d957 to 2d2f82c00aeb (13 revisions) (flutter/engine#22015)
* c2c74ed70 Roll Dart SDK from 8be6a08153cc to 86242db30c23 (2 revisions) (flutter/engine#22018)
* Fix null safety error in inspector service extensions taking variable numbers of args.
Fixes https://github.com/flutter/flutter/issues/68627.
Also fix all inspector tests that do not rely on golden image functionality
so that they run with --enable-experiment=non-nullable. This verifies there
is test coverage to ensure there isn't a regression.
* Remove uses of dynamic.
* 3edc16ca4 Roll Dart SDK from 5c59a47beda7 to 902538ea56d5 (2 revisions) (flutter/engine#21978)
* 0747f2f4b [web] Fix 3d transforms for html backend (flutter/engine#21499)
* fa11ee6e2 Fix native constructor of list of zircon handles and remove unused list factory specializations. (flutter/engine#21980)
* 2dc43eee1 Roll Fuchsia Mac SDK from MR_bRfe8I... to pZ9FgVZTK... (flutter/engine#21982)
* 149ef7083 [web] Implement sweep gradient (flutter/engine#21873)
* 79879802e [web] Fix image gap due to svg element without position attribute (flutter/engine#21939)
* 727a9283a Roll Skia from 27f7fe32f49b to ac1ded033136 (15 revisions) (flutter/engine#21984)
* 326157ee7 [null-safety] fix Scene.toImage declaration (flutter/engine#21983)
* 2ef0f4228 Revert "[web] Fix image gap due to svg element without position attribute (#21939)" (flutter/engine#21986)
* e78e405e6 Enable lazy-async-stacks by-default in all modes (Take 4) (flutter/engine#21802)
* 91c81ebfa Fix linking issue (missing wayland-client library) (flutter/engine#21408)
* 40784a061 Roll Fuchsia Linux SDK from dcMRY8S12... to lPMs_KwnU... (flutter/engine#21988)
* 85104696e Roll Skia from ac1ded033136 to a25c0619b5ef (2 revisions) (flutter/engine#21989)
* 7b72ce796 Roll Skia from a25c0619b5ef to 4964300530d3 (2 revisions) (flutter/engine#21990)
* 564bd09cd Roll Skia from 4964300530d3 to 51dc28505fb9 (5 revisions) (flutter/engine#21993)
* eb6f7f874 Roll Dart SDK from 902538ea56d5 to fc82eeed7df3 (1 revision) (flutter/engine#21981)
* 6ce33dd4a [null-safety] fix soundness of Paragraph._addPlaceholder (flutter/engine#21994)
* 3cd70f2cf Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (flutter/engine#21979)
* a82e917dc [iOS] Fixes leaks of presses key message (flutter/engine#21987)
* 5d4727d68 Roll Skia from 51dc28505fb9 to 1c823674d957 (8 revisions) (flutter/engine#21995)
* 3658bd7ea Revert "Reland: Use dispatchKeyEventPreIme, and handle keys sent to InputConnection.sendKeyEvent on Android (#21979)" (flutter/engine#22004)
* ed53ff19e Roll Dart SDK from fc82eeed7df3 to 8be6a08153cc (1 revision) (flutter/engine#22002)
* 6fdcdd99c Forward font collection APIs to the SkParagraph font collection (flutter/engine#21734)
* 25d8fa5a7 Define SK_VULKAN for clang-tidy runs (flutter/engine#21927)
* 0c7c47724 Revert "[ios] Refactor IOSSurface factory and unify surface creation (#21877)" (flutter/engine#21970)
* ea2aea1c6 Roll Fuchsia Linux SDK from ZJHmp3INU... to dcMRY8S12... (flutter/engine#21976)
* eba7a1c90 Roll Dart SDK from e655b9a3839e to b58cfe5ab24e (1 revision) (flutter/engine#21919)
* 512154980 Roll Dart SDK from e655b9a3839e to b58cfe5ab24e (1 revision) (flutter/engine#21920)
* 977537b03 Roll Skia from 418eda2c599a to f9c7b2803461 (3 revisions) (flutter/engine#21923)
* 5bd7260a1 Enable loading snapshots with sound null safety enabled. (flutter/engine#21820)
* 787b9c537 Break the reference cycle between the surface factory and the external view embedder (flutter/engine#21918)
* 9b752790f Revert "[fuchsia] External view embedder will be shared with platform view (#21850)" (flutter/engine#21924)
* 04bf8791f Add plumbing to grab dart entrypoint args on macOS (flutter/engine#21789)
* b8fd0013a Update FLUTTER_NOLINT uses to include issue link (flutter/engine#21921)
* 869d3c8c7 Set strokeCap, strokeJoin, and strokeMiter when resurrecting Paint (flutter/engine#21926)
* 18357a858 Roll Skia from f9c7b2803461 to f60a76e2ac01 (4 revisions) (flutter/engine#21929)
* 49c35b617 Eliminate unnecessary linter opt-outs (flutter/engine#21935)
* 2df836f6e Require that FLUTTER_NOLINT include issue link (flutter/engine#21922)
* f6b8a50ab Roll Skia from f60a76e2ac01 to be8004d2fb6c (1 revision) (flutter/engine#21936)
* 34832cb78 Roll the process_runner package used by the formatter script (flutter/engine#21937)
* 2874fccbb Roll Dart SDK from b58cfe5ab24e to aaab579579be (1 revision) (flutter/engine#21938)
* cac04c4cf Add FML_UNREACHABLE to declare points in code that should never be reached. (flutter/engine#21941)
* fabcc2de2 Roll Fuchsia Mac SDK from _FaRRt69Z... to XZSNobQCT... (flutter/engine#21944)
* 20d3a0764 Collect logs in the background. (flutter/engine#21828)
* 815a1f386 Roll Dart SDK from aaab579579be to 42a0bf548ea3 (1 revision) (flutter/engine#21946)
* 890f01620 [web] Implement ClipOp.difference (flutter/engine#21901)
* 3ea02776e Roll Dart SDK from 42a0bf548ea3 to 675c7165c071 (1 revision) (flutter/engine#21948)
* 56d3da33b Roll Fuchsia Mac SDK from XZSNobQCT... to 9mMCqUXkF... (flutter/engine#21950)
* 1c35cc641 [null-safety] fix type declaration of Picutre._toImage (flutter/engine#21942)
* e9a43c15b Roll Dart SDK from 675c7165c071 to 5c59a47beda7 (1 revision) (flutter/engine#21952)
* 499a70f5e Restore missing call to RuntimeDelegate.OnRootIsolateCreated (flutter/engine#21953)
* f7da9d687 Roll Fuchsia Mac SDK from 9mMCqUXkF... to MR_bRfe8I... (flutter/engine#21955)
* e66e3f535 Roll Skia from be8004d2fb6c to 27f7fe32f49b (1 revision) (flutter/engine#21956)
* d4ac8e6cb Temporarily disabled tests that were using latin and arabic characters (flutter/engine#21971)
* f854cbbfa Specify the Noto Naskh Arabic font to get consistent results in tests using Arabic characters (flutter/engine#21974)
* 43b618e4b Added keyEvent support for iOS 13.4+ (flutter/engine#20972)
* a6857802b Fix the initialization of AndroidSurfaceFactoryImpl (flutter/engine#21977)
* 895940081 [null-safety] fix types of layer code (flutter/engine#21959)
* 9946be45a FlTextInputPlugin: fix memory leaks (flutter/engine#21879)
* bcc557f1b Add multi-step input method support for Linux (flutter/engine#21897)
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.
The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5
Uninstall the app after each run so temp storage does not fill up.
These devicelab tests are incredibly flaky. Currently they will build & install the same application 15 times. This causes the temp storage to fill up on android, and has a good chance of flaking on iOS due to install issues.
The change from 3 to 15 increased total test time for 2 -> 12 minutes on iOS, or roughly 5 more test equivalents for every single iOS test. Reduce the iteration count back to 5
Uninstall the app after each run so temp storage does not fill up.
Fixes#67370
By running most of these executions through flutter, we get the benefit of the flutter error handling and precaching. IN the test where this is not feasible, call pre-cache directly.
- - When I added notification of key events before processing them as text, it made it so that shortcut key bindings like the spacebar would prevent spaces from being inserted into text fields, which is obviously not desirable (and so that change was reverted). At the same time, we do want to make it possible to override key events so that they can do things like intercept a tab key or arrow keys that change the focus.
This PR changes the behavior of the Shortcuts widget so that if it has a shortcut defined, but no action is bound to the intent, then instead of responding that the key is "handled", it responds as if nothing handled it. This allows the engine to continue to process the key as text entry.
This PR includes:
- Modification of the callback type for key handlers to return a KeyEventResult instead of a bool, so that we can return more information (i.e. the extra state of "stop propagation").
- Modification of the ActionDispatcher.invokeAction contract to require that Action.isEnabled return true before calling it. It will now assert if the action isn't enabled when invokeAction is called. This is to allow optimization of the number of calls to isEnabled, since the shortcuts widget now wants to know if the action was enabled before deciding to either handle the key or to return ignored.
- Modification to ShortcutManager.handleKeypress to return KeyEventResult.ignored for keys which don't have an enabled action associated with them.
- Adds an attribute to DoNothingAction that allows it to mark a key as not handled, even though it does have an action associated with it. This will allow disabling of a shortcut for a subtree.
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
Remove devicelab specific code for shutting down gradle daemon, add --android-gradle-daemon option to build/run/drive`. Avoids need for un-tested devicelab specific handler. There are also some feature requests for this, so 2 birds one stone.
Example:
flutter build apk --no-android-gradle-daemon will pass --no-daemon on to gradle
This PR suggests improving the IntelliJ plugin "jar" detection logic.
Previously:
The IntelliJ Flutter plugin was contained flutter-intellij.jar.
Currently:
It is named flutter-intellij-X.Y.Z.jar and does not contain META-INF/plugin.xml.
META-INF/plugin.xml is included in flutter-idea-X.Y.Z.jar.
So this PR changes the rules for searching the plugin's jar file.
Concretely, it looks for the jar file containing META-INF/plugin.xml in the plugin's package directory and reads the package version from its META-INF/plugin.xml.
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
