firka/flutter
firka/flutter
4
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
12,572 Commits 1 Branch 0 Tags
Commit Graph

9089 Commits

Author SHA1 Message Date
jslavitz
743960df27
Cupertino picker null color fix (#24529) 
*null fix and test
 2018-11-19 12:00:21 -08:00
Jonah Williams
9d81c67a3f
Pass correct physics instance to Scrollable semantics (#24416) 2018-11-19 10:31:02 -08:00
Todd Volkert
c793d43ee0
Slight doc change (#24526) 2018-11-19 09:11:40 -08:00
Alexandre Ardhuin
79b5e5bc8a
Add missing lints (#24381) 
* update lint list

* enable sort_pub_dependencies

* enable avoid_returning_null_for_void

* enable flutter_style_todos
 2018-11-19 10:37:55 +01:00
Danny Tuppeny
15e3df25c5
Refactor Test Driver in preparation for flutter test integration tests (#24060) 
* Refactor Test Driver in preperation for `flutter test` integration tests

* Fix indent
 2018-11-19 08:25:42 +00:00
Danny Tuppeny
113f8f1a8d
Make FlutterTestDriver.stop() safe to call if it didn't spawn a process (#24393) 
This means we can just always add it to test teardowns without having to add try/catches if there are any tests that don't spawn a process.
 2018-11-19 07:16:32 +00:00
Danny Tuppeny
08e7f26510
Remove timeout waiting for app to start (#24336) 2018-11-19 07:15:52 +00:00
jslavitz
5385132c6b
Separate keep alive logic from SliverMultiBox classes (#24192) 
* sliver separation and test
 2018-11-16 16:53:59 -08:00
Justin McCandless
a8552ca7ec
Switch list tile adaptive (#24437) 
* SwitchListTile.adaptive for wrapping an adaptive Switch

* Test SwitchListTile.adaptive same as Switch.adaptive

* Remove TODO

* Comment and switch statement cleanup
 2018-11-16 14:50:17 -08:00
jslavitz
265485033b
Fixes navigation page back drag area for iPhone X (#24375) 
* nav fix and test
 2018-11-16 12:47:50 -08:00
jslavitz
b3d9fb4dee
Scaffold Drawer pull out area fix for notched devices (#24367) 
* Adds fix and test
 2018-11-16 12:47:34 -08:00
Justin McCandless
c8ff617fd8
Text field border radius bug fix (#24414) 
* Fix radius glitch by carrying over border when lerping outline borders

* Test that border doesn't change

* Regression comment
 2018-11-16 09:32:24 -08:00
xster
988bfc166d
iOS tap handling on CupertinoTextField (#24034) 2018-11-15 18:07:17 -08:00
Dan Field
77237c0ed1
add missing entry to material_mr.arb (#24410) 
* add missing entry to material_mr.arb
 2018-11-15 16:37:14 -08:00
Dan Field
78c5bb2a8e
Make progress indicators accessible (#24275) 
* Make progress indicators accessible
 2018-11-15 15:54:56 -08:00
Justin McCandless
f9bccb0280
Handle a missing ListView separator as an error (#24312) 
* Handle a missing ListView separator as an error

* Handle missing item, and errors in itemBuilder and separatorBuilder

* CR fixes and move error handling into sliver.dart to handle all ListView constructors

* Only show an error for null separatorBuilder value in debug mode
 2018-11-15 14:40:13 -08:00
Jonah Williams
938dd5a4aa
Revert "Update driver script to execute test through test_core" (#24401) 
* Revert "Add dashing config file for generating docset from flutter docs (#24374)"

This reverts commit ec8ca8606c9eec8b1ecc965f5045fd29130a7e16.

* Revert "Update driver script to execute test through test_core (#24168)"

This reverts commit 6c62cf337fb662684bb206e89018792eb68eb10a.
 2018-11-15 11:17:00 -08:00
Jonah Williams
6c62cf337f
Update driver script to execute test through test_core (#24168) 2018-11-15 10:50:25 -08:00
Diego Tori
9447be7370 Added support for passing in velocity and offset into Draggable.onDragCompleted (#22267) 
* Added support for passing in velocity and offset into Draggable.onDragCompleted.

* Fixed documentation of DragCompletedCallback.

* Spun off previous onDragCompleted breaking changes into new callback called Draggable.onDragEnd.

* Revert "Fixed documentation of DragCompletedCallback."

This reverts commit 069051f5be0d4ec6a1f4b3f072e535ca87e5d740.

* Revert "Added support for passing in velocity and offset into Draggable.onDragCompleted."

This reverts commit 7ef744aa5645429b7bc92527226203ee8bff68ec.

* DraggableDetails constructor is now declared first as per Flutter code style.

* Draggable.onDragEnd will only call back if its widget is currently mounted to the tree.

* Moved "});" in DraggableDetails constructor to new line, vertically aligned with the constructor name, as per Flutter code style.

* Added space between if statement in drag_target.dart.

* widget.onDragEnd call is now formated as per flutter code style.

* Added more details to DraggableDetails documentation.

* Added brackets to if statement block as per Flutter code style.

* Fixed minor nits in DraggableDetails documentation.

* Made DraggableDetails constructor public. Also added documentation for its constructor.
 2018-11-15 09:11:04 -08:00
Dan Field
091b73ab6f
fix variable check in xcode_backend.sh (#24368) 
* fix test in xcode_backend.sh

* -n

* fix devicelab test

* uncomment good code, check for \"\"
 2018-11-14 18:54:51 -08:00
Alexander Aprelev
64a8d44764
Fix test so it doesn't leak frontend_server process (#24360) 
* Fix test so it doesn't leak frontend_server process

* Stop FlutterTestDriver even if expectation is not met
 2018-11-14 18:50:18 -08:00
Yegor
9c3754d92f
FlutterDriver: allow customizing timeouts using a multiplier (#24066) 
FlutterDriver: allow customizing timeouts using a multiplier
 2018-11-14 17:15:00 -08:00
Greg Spencer
eb35f8923b
Reland: Make the 'time to update' message depend up on the channel. (#24173) (#24321) 
Fixes #24158
Re-lands #24173
 2018-11-14 16:51:12 -08:00
S McDowall
87156df6d9 Optionally show the text field length but not the max (#24183) 
If maxLength is set to TextField.noMaxLength then continue to show the character counter but do not display the max input length value.
 2018-11-14 16:04:39 -08:00
Hans Muller
70d83cc7ac
Add support for the Marathi language, locale mr_IN (#24353) 2018-11-14 15:42:51 -08:00
liyuqian
ba635a643a
Add golden tests for Opacity with offset (#24253) 
See https://github.com/flutter/flutter/issues/23890
 2018-11-14 15:00:39 -08:00
James D. Lin
91cfc1fe31
Fix a few typos in comments (#24249) 2018-11-14 14:25:05 -08:00
Michael Goderbauer
e71eb9a474
Make Link clickable in DartDocs (#24358) 2018-11-14 14:08:04 -08:00
Jason Simmons
9f28aefa9c
Call BorderRadiusGeometry.lerp where applicable in ShapeBorder subclasses (#24262) 
Fixes https://github.com/flutter/flutter/issues/24257
 2018-11-14 13:47:48 -08:00
stevemessick
ff25edd3ad
Update idea template files (#24311) 
* Update IntelliJ project template files

* Add ignored file

* Fix test

* Restore comma
 2018-11-14 13:45:07 -08:00
Alexander Aprelev
0b940a4473
Flush write to disk with intent of reducing flakiness of the test. (#24144) 2018-11-14 13:26:24 -08:00
Alexander Aprelev
3b7942c444
Fix multi-step build handling process. (#24310) 
* Fix multi-step build handling process.

Stop listening for new step updates after 'all done.' log message. Make sure that we don't delete file too soon, until listener had a chance to process the 'all done' message.

Fixes https://github.com/flutter/flutter/issues/18750

* Emit 'all output' explicitly when build process is done.
 2018-11-14 08:54:13 -08:00
Brian Wilkerson
29d5210d8b Use constant durations in more places (#24306) 2018-11-14 08:16:12 -08:00
Michael Goderbauer
e5f0457261
Another typo fix (#24316) 2018-11-13 23:03:11 -08:00
Greg Spencer
a2ed3ecb64
Revert "Make the 'time to update' message depend up on the channel. (#24173)" (#24320) 
This reverts commit 97e03104a0913886a666a36f5d11ab5763d45e6e.

Landing on red to hopefully make less red on the board.

TBR=@goderbauer
 2018-11-13 17:18:06 -08:00
Michael Goderbauer
f4af41e20e
type fix (#24297) 2018-11-13 10:31:22 -08:00
Greg Spencer
97e03104a0
Make the 'time to update' message depend up on the channel. (#24173) 
Fixes #24158
 2018-11-13 09:53:56 -08:00
Justin McCandless
1fde4d0366
Docs clarification for how RTL/LTR locale affects ButtonBar (#24264) 2018-11-13 09:46:04 -08:00
Jonah Williams
aa65fa2fa1
Remove await for syntax from fuchsia log scanner (#24263) 2018-11-12 23:47:16 -08:00
Jonah Williams
2e33d08dae
communicate fuchsia error states to developers (#24191) 2018-11-12 23:46:14 -08:00
jslavitz
931c037919
Release Candidate (#24248) 2018-11-12 10:35:11 -08:00
Greg Spencer
665fff00c7
Update Scaffold docs and example code (#24159) 
Upgraded Scaffold example to an application example.
 2018-11-12 08:54:08 -08:00
Jonah Williams
70c6fb1fbb
Remove package:collection dependency usage from flutter_goldens (#24218) 2018-11-11 10:57:41 -08:00
Gary Qian
f16a569e24
Supported locales docs to explain proper scriptCode usage. (#24184) 2018-11-11 03:43:16 -08:00
Jonah Williams
5839710859
Throw a better error when old test versions are loaded. (#24217) 2018-11-10 19:32:35 -08:00
Jonah Williams
a871d59164
Apply basic log filtering and formatting to fuchsia logs. (#24143) 2018-11-10 17:02:32 -08:00
Amir Hardon
72bf075e8d
Escape objective c method brackets in dartdoc (#24199) 2018-11-09 20:36:17 -08:00
Dan Field
2729385758
Make host app test actually test host app (#24131) 
* Make host app test actually test host app

* mark updated test as flaky
 2018-11-09 19:09:56 -08:00
Amir Hardon
563ceac8d4
Remove the WIP comment for UiKitView. (#24170) 
Adds a note mentioning that this is still a release preview.
 2018-11-09 16:14:44 -08:00
jslavitz
6a8c393f4c
Allows for the CupertinoPicker to have a non white background color (#24085) 
* fixes wheel gradient and adds test
 2018-11-09 15:58:21 -08:00