Chris Bracken
753fd42815
[iOS] Bundle dSYM packages in Flutter.xcframework ( flutter/engine#54414 )
...
As of Xcode 16, App Store validation requires dSYMs for frameworks in app archives. Bundling dSYMs also significantly simplifies stack trace symbolification, so we should be doing this regardless.
This adds both framework and simulator framework dSYMs to the Flutter.xcframework bundle.
Issue: https://github.com/flutter/flutter/issues/116493
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-08 16:25:17 +00:00
skia-flutter-autoroll
eb8c2bba08
Roll Dart SDK from 0131aabd8631 to 067c7cfcbc8c (1 revision) ( flutter/engine#54437 )
...
https://dart.googlesource.com/sdk.git/+log/0131aabd8631..067c7cfcbc8c
2024-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-129.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-08 14:01:23 +00:00
skia-flutter-autoroll
c11d5799a7
Roll Dart SDK from 76b463dbecc3 to 0131aabd8631 (1 revision) ( flutter/engine#54430 )
...
https://dart.googlesource.com/sdk.git/+log/76b463dbecc3..0131aabd8631
2024-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-128.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-08 08:27:19 +00:00
skia-flutter-autoroll
c491ec187c
Roll Dart SDK from 2e1b99aa1fa2 to 76b463dbecc3 (1 revision) ( flutter/engine#54423 )
...
https://dart.googlesource.com/sdk.git/+log/2e1b99aa1fa2..76b463dbecc3
2024-08-08 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-127.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-08 03:10:22 +00:00
Jonah Williams
95edf0d8db
[android] workaround for HC bug. ( flutter/engine#54408 )
...
Testing
FYI @jason-simmons
"Fixes" https://github.com/flutter/flutter/issues/152691
2024-08-08 00:06:58 +00:00
Jason Simmons
f0f2dd5a14
Directly include the Skia header that defines GrVkImageInfo ( flutter/engine#54417 )
...
See https://skia.googlesource.com/skia/+/5fb01f00262bbbef99571953fb5a987b0bed4d45
2024-08-08 00:05:38 +00:00
skia-flutter-autoroll
359d68d7ac
Roll Dart SDK from f5d136899082 to 2e1b99aa1fa2 (4 revisions) ( flutter/engine#54411 )
...
https://dart.googlesource.com/sdk.git/+log/f5d136899082..2e1b99aa1fa2
2024-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-126.0.dev
2024-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-125.0.dev
2024-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-124.0.dev
2024-08-07 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-123.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-07 21:57:23 +00:00
Chinmay Garde
ddefa92e24
[Impeller] Make stage compatibility checker work with stages that have no inputs or outputs. ( flutter/engine#54406 )
...
Also removes the workarounds and updates the docstring to talk about the PowerVR hack. I came across this while fixing https://github.com/flutter/engine/pull/54375 .
Fixes https://github.com/flutter/flutter/issues/146852
2024-08-07 20:35:14 +00:00
gaaclarke
3d0a4eb772
[Impeller] made Vector3 naming match Vector2 naming. ( flutter/engine#54396 )
...
Vector2 has `GetLength()` but Vector3 had `Length()`. This unifies the naming.
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-07 17:33:51 +00:00
Jonah Williams
5ce93cf905
[Impeller] bulk update fresh glyph atlas. ( flutter/engine#54379 )
...
Fixes https://github.com/flutter/flutter/issues/152977
When creating a new glyph atlas texture, write glyphs in bulk. Additionally uses this operation to clear the glyph atlas, removing the need for the other blit pass.
2024-08-07 17:31:49 +00:00
Matej Knopp
a02e474f1b
Reland: Partial repaint platform views ( flutter/engine#54231 )
...
Relands https://github.com/flutter/engine/pull/54219 reverted in
https://github.com/flutter/engine/pull/54230 .
The tracked area of `PlatformViewLayer` now covers entire frame ensuring
full repaint when platform view is removed.
Added `FullRepaintAfterRemovingLayer` test.
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-07 18:14:13 +02:00
skia-flutter-autoroll
0389447de6
Roll Skia from 968a00456bc5 to a0e775f706cd (3 revisions) ( flutter/engine#54386 )
...
https://skia.googlesource.com/skia.git/+log/968a00456bc5..a0e775f706cd
2024-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 6177e0e75569 to b1312e5ef74f
2024-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from c6b336984953 to 6177e0e75569 (6 revisions)
2024-08-07 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from b0c9611bdf79 to d07d6ba280ba (18 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-07 07:52:23 +00:00
Chinmay Garde
0662b4f46a
[Impeller] Statically check stage interfaces for precision mismatches. ( flutter/engine#54375 )
...
Fixes https://github.com/flutter/flutter/issues/147078
2024-08-07 00:36:17 +00:00
skia-flutter-autoroll
bab67188e6
Roll Skia from f04ba9cd0e4b to 968a00456bc5 (4 revisions) ( flutter/engine#54378 )
...
https://skia.googlesource.com/skia.git/+log/f04ba9cd0e4b..968a00456bc5
2024-08-06 kjlubick@google.com Refactor sk_app and other test code to be more Bazel friendly
2024-08-06 kjlubick@google.com [bazel] Add graphite rules for native vulkan backend
2024-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 9335f3149740 to 699b3c2a0349 (2 revisions)
2024-08-06 brianosman@google.com Disallow SkSL when deserializing drawables in custom typefaces
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-07 00:21:20 +00:00
skia-flutter-autoroll
bfcd785a82
Roll Dart SDK from dedfa3393296 to f5d136899082 (5 revisions) ( flutter/engine#54376 )
...
https://dart.googlesource.com/sdk.git/+log/dedfa3393296..f5d136899082
2024-08-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-122.0.dev
2024-08-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-121.0.dev
2024-08-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-120.0.dev
2024-08-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-119.0.dev
2024-08-06 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-118.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jsimmons@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 23:27:14 +00:00
Chinmay Garde
29bfaddaeb
[Impeller] Reorder pipeline construction in content context. ( flutter/engine#54373 )
...
Fixes the regression to the first-frame time on the Mokey.
Also add a trace that should allow for easier identification of problematic pipelines.
A more involved job-queue that allows construction jobs to skip the queue was written in https://github.com/flutter/engine/pull/54355 . But the Mokey case is not important enough for the additional complexity. See the context in the linked patch.
<img width="2137" alt="Screenshot 2024-08-06 at 1 20 26â¯PM" src="https://github.com/user-attachments/assets/aed671c1-b7f7-4c9f-8553-485f8c0dd35e ">
[start_up_timeline.json.zip](https://github.com/user-attachments/files/16515389/start_up_timeline.json.zip )
2024-08-06 21:51:46 +00:00
Jonah Williams
54bfbb4509
[iOS] clean ups to platform view controller ( flutter/engine#54335 )
...
Splits FlutterPlatformViews.mm into the primarily C++ class FlutterPlatformViewsController/Pool/Overlay and all of the touch interceptor / gesture stuff.
Renames FlutterPlatformViewsController to PlatformViewsController, because, you know.
Renames FlutterPlatformViewLayer and FlutterPlatformViewLayerPool to OverlayLayer and OverlayLayerPool
2024-08-06 21:33:55 +00:00
Jonah Williams
fed98ff528
[Impeller] ensure precision matches for buggy vulkan drivers. ( flutter/engine#54372 )
...
This is another precision mismatch bug - WHICH IS NOT AN ERROR AT ALL BUT THE PowerVR Drivers ARE BUGGY BUGGY BUGGY
Fixes https://github.com/flutter/flutter/issues/152951
2024-08-06 21:33:52 +00:00
Matej Knopp
e3794a82e0
macOS: Update platform node when AXNodeData role changes ( flutter/engine#54364 )
...
Fixes https://github.com/flutter/flutter/issues/151428
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-06 21:51:36 +02:00
skia-flutter-autoroll
31f50610c0
Roll Skia from 690c8d946e03 to f04ba9cd0e4b (2 revisions) ( flutter/engine#54370 )
...
https://skia.googlesource.com/skia.git/+log/690c8d946e03..f04ba9cd0e4b
2024-08-06 kjlubick@google.com [bazel] Add graphite modules for native Metal backend
2024-08-06 kjlubick@google.com Add Mac arm64 versions of binaries needed for k8s-config's presubmit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 19:50:10 +00:00
skia-flutter-autoroll
2d1989f7d1
Roll Dart SDK from 71e84a69ce6d to dedfa3393296 (1 revision) ( flutter/engine#54354 )
...
https://dart.googlesource.com/sdk.git/+log/71e84a69ce6d..dedfa3393296
2024-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-117.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 19:17:55 +00:00
skia-flutter-autoroll
d0e0f93497
Roll Skia from a15e5cfe046c to 690c8d946e03 (1 revision) ( flutter/engine#54369 )
...
https://skia.googlesource.com/skia.git/+log/a15e5cfe046c..690c8d946e03
2024-08-06 brianosman@google.com CircleOp: Require an actual stroke to activate round caps
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 18:32:14 +00:00
skia-flutter-autoroll
10e531cafd
Roll Skia from 7e9580cfeb65 to a15e5cfe046c (1 revision) ( flutter/engine#54367 )
...
https://skia.googlesource.com/skia.git/+log/7e9580cfeb65..a15e5cfe046c
2024-08-06 brianosman@google.com Revert "Add SkPath::addOpenOval"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 17:11:14 +00:00
Brandon DeRosier
95a478b360
Update Flutter-GPU.md ( flutter/engine#54366 )
...
Remove outdated information and point to useful resources.
2024-08-06 09:38:54 -07:00
skia-flutter-autoroll
3067ceb890
Roll Skia from e8fed3f105c5 to 7e9580cfeb65 (1 revision) ( flutter/engine#54365 )
...
https://skia.googlesource.com/skia.git/+log/e8fed3f105c5..7e9580cfeb65
2024-08-06 brianosman@google.com Revert "Add isArc to SkPath"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 15:53:17 +00:00
skia-flutter-autoroll
9a322e1302
Roll Skia from c586d81b096e to e8fed3f105c5 (1 revision) ( flutter/engine#54363 )
...
https://skia.googlesource.com/skia.git/+log/c586d81b096e..e8fed3f105c5
2024-08-06 drott@chromium.org [Fontations-backend] Roll Fontations, Skrifa to 0.20
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jsimmons@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 14:35:30 +00:00
Michael Thomsen
7e52a7c53b
Update pubspec.yaml for package:flutter_gpu ( flutter/engine#54345 )
...
Update readme for package:flutter_gpu to have an appropriate description
and, fill out the pub [repo
field](https://dart.dev/tools/pub/pubspec#repository ).
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-06 12:21:38 +02:00
skia-flutter-autoroll
90819b9de3
Roll Skia from 4cdacdae8be0 to 3dc4cd65a110 (4 revisions) ( flutter/engine#54361 )
...
https://skia.googlesource.com/skia.git/+log/4cdacdae8be0..3dc4cd65a110
2024-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 8f2aebbc4ae5 to 9335f3149740 (3 revisions)
2024-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from c6b336984953 to 15df59cc38c7
2024-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 7e62f1428813 to c6b336984953 (7 revisions)
2024-08-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from f72761e86766 to 65157d32945d (1 revision)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 07:58:30 +00:00
skia-flutter-autoroll
e6b7bc40e5
Roll Fuchsia Linux SDK from Wc4GjkNVQkbGEBpOb... to 2LTVy4Gv76DcMpz4V... ( flutter/engine#54357 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 05:29:23 +00:00
skia-flutter-autoroll
feb1b50aec
Roll Skia from 8b706494a21b to 81942362276a (2 revisions) ( flutter/engine#54356 )
...
https://skia.googlesource.com/skia.git/+log/8b706494a21b..81942362276a
2024-08-05 sunnyps@chromium.org Revert "[graphite] Move bindgroup cache from DawnResourceProvider to DawnTexture"
2024-08-05 michaelludwig@google.com Reland "[skif] Implement raster SkBlurEngine"
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-06 00:07:17 +00:00
skia-flutter-autoroll
2c631ecf0b
Roll Skia from fed87fbbe49e to 8b706494a21b (1 revision) ( flutter/engine#54353 )
...
https://skia.googlesource.com/skia.git/+log/fed87fbbe49e..8b706494a21b
2024-08-05 jmbetancourt@google.com [skottie] add child shader support for custom SkSL effects
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-05 22:47:05 +00:00
skia-flutter-autoroll
8dbe8a4974
Roll Dart SDK from bdeaec130e8e to 71e84a69ce6d (1 revision) ( flutter/engine#54349 )
...
https://dart.googlesource.com/sdk.git/+log/bdeaec130e8e..71e84a69ce6d
2024-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-116.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-05 19:08:25 +00:00
skia-flutter-autoroll
e038600636
Roll Skia from 938b8b8efdfa to c908f20dc0b1 (1 revision) ( flutter/engine#54347 )
...
https://skia.googlesource.com/skia.git/+log/938b8b8efdfa..c908f20dc0b1
2024-08-05 kjlubick@google.com Remove #ifdef SK_DAWN from Graphite's Context
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-05 17:40:45 +00:00
Camille Simon
d10544383b
Update docs to use new Gradle version in the engine ( flutter/engine#53964 )
...
Updates/corrects steps to update Gradle version used in the engine based on what @gmackall and I did to update the engine's Gradle version in https://github.com/flutter/engine/pull/53574 .
[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
2024-08-05 17:37:16 +00:00
skia-flutter-autoroll
630a1905a6
Roll Dart SDK from d4a2c6a52b4a to bdeaec130e8e (1 revision) ( flutter/engine#54344 )
...
https://dart.googlesource.com/sdk.git/+log/d4a2c6a52b4a..bdeaec130e8e
2024-08-05 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-115.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-05 15:03:44 +00:00
Michael Ludwig
fb50de5779
Add SK_USE_LEGACY_BLUR_RASTER staging flag ( flutter/engine#54314 )
...
Skia's CPU-based blur implementation is inaccurate for sigma < 2, but
the Dart imagefilter test uses a case with sigma = 1.
In https://skia-review.googlesource.com/c/skia/+/885107 , the algorithm
is updated to be more accurate when sigma < 2, so the output is more
accurate. In order to roll into flutter, the expected color values in
the tests will need to be updated with the removal of this staging flag.
*If you had to change anything in the [flutter/tests] repo, include a
link to the migration guide as per the [breaking change policy].*
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide] and the [C++,
Objective-C, Java style guides].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I added new tests to check the change I am making or feature I am
adding, or the PR is [test-exempt]. See [testing the engine] for
instructions on writing and running engine tests.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I signed the [CLA].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[C++, Objective-C, Java style guides]:
https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
[testing the engine]:
https://github.com/flutter/flutter/wiki/Testing-the-engine
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2024-08-05 08:58:34 -04:00
skia-flutter-autoroll
171785e1f0
Roll Skia from cbd9bc6f4a7e to 6723859a3212 (2 revisions) ( flutter/engine#54342 )
...
https://skia.googlesource.com/skia.git/+log/cbd9bc6f4a7e..6723859a3212
2024-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SK Tool from 7e62f1428813 to a8b5ec73069a
2024-08-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra from 4c3759b8afef to 7e62f1428813 (4 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-05 07:50:23 +00:00
skia-flutter-autoroll
46f8a14bfb
Roll Fuchsia Linux SDK from kNaYSiTeLcsVNOSDa... to PPYewhTaxl-9Sh1Zb... ( flutter/engine#54338 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-04 01:03:24 +00:00
Zachary Anderson
93323c6d97
Don't use intel clang on arm64 macs ( flutter/engine#54291 )
...
Since gen_snapshot is lipo'd everywhere now, it should be safe to both
build with either arm64 or intel macs, and to use the arm64 native clang
toolchain on arm64 macs instead of the intel toolchain under Rosetta.
Related to https://github.com/flutter/flutter/issues/103386
2024-08-03 16:08:24 -07:00
skia-flutter-autoroll
788263f826
Roll Skia from 8f0e1486b887 to 80ef0f91fb7b (2 revisions) ( flutter/engine#54336 )
...
https://skia.googlesource.com/skia.git/+log/8f0e1486b887..80ef0f91fb7b
2024-08-03 brianosman@google.com Add missing vulkan include
2024-08-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from b070881de5eb to 06f8d6301c60 (7 revisions)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 21:03:24 +00:00
Jim Graham
a4fe2c0ac5
[DisplayList] benchmark DisplayList dispatch method ( flutter/engine#54324 )
...
We will be updating the DisplayList dispatching to support random access iteration through the records so we need a benchmark to set a baseline to track any impact on the default way to dispatch a DisplayList.
2024-08-03 20:07:54 +00:00
Brandon DeRosier
19be57ca3e
Revert "[Impeller] Reland 2: Implement draw order optimization. ( #54268 ) ( flutter/engine#54325 )
...
Manual revert of https://github.com/flutter/engine/pull/54268 , since the time expired for automatic reverting.
@jason-simmons found this patch to be causing a regression in a downstream app. Some draws are getting clipped away, and disabling the scissor fixes it. So there is likely still a case not being handled correctly with the clip replay or subpass draw deferral behavior.
2024-08-03 19:00:35 +00:00
skia-flutter-autoroll
04daca08f7
Roll Dart SDK from 3a0b4143fe47 to d4a2c6a52b4a (1 revision) ( flutter/engine#54334 )
...
https://dart.googlesource.com/sdk.git/+log/3a0b4143fe47..d4a2c6a52b4a
2024-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-114.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 13:47:30 +00:00
skia-flutter-autoroll
02520a2b83
Roll Dart SDK from c4c9a84c3532 to 3a0b4143fe47 (1 revision) ( flutter/engine#54333 )
...
https://dart.googlesource.com/sdk.git/+log/c4c9a84c3532..3a0b4143fe47
2024-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-113.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 08:03:19 +00:00
skia-flutter-autoroll
5adc49fde1
Roll Dart SDK from ff56a84f7661 to c4c9a84c3532 (1 revision) ( flutter/engine#54332 )
...
https://dart.googlesource.com/sdk.git/+log/ff56a84f7661..c4c9a84c3532
2024-08-03 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-112.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-03 03:53:22 +00:00
Chinmay Garde
e83e23a6c5
Delete //flutter/fml/compiler_specific.h ( flutter/engine#54330 )
...
There were two macros for doing identical things and you can do the thing using standard C++17.
2024-08-03 01:47:49 +00:00
Chinmay Garde
ab4b4835be
[Impeller] Use the typed allocation sizes in impeller::Allocation. ( flutter/engine#54327 )
2024-08-02 23:53:04 +00:00
skia-flutter-autoroll
596c0f7649
Roll Fuchsia Linux SDK from vpJQheqicAUK_qjD-... to kNaYSiTeLcsVNOSDa... ( flutter/engine#54328 )
...
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine
Please CC jacksongardner@google.com ,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 23:47:39 +00:00
skia-flutter-autoroll
05071e7eef
Roll Dart SDK from 46bcc8466168 to ff56a84f7661 (2 revisions) ( flutter/engine#54326 )
...
https://dart.googlesource.com/sdk.git/+log/46bcc8466168..ff56a84f7661
2024-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-111.0.dev
2024-08-02 dart-internal-merge@dart-ci-internal.iam.gserviceaccount.com Version 3.6.0-110.0.dev
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dart-sdk-flutter-engine
Please CC dart-vm-team@google.com ,jacksongardner@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 23:33:19 +00:00
skia-flutter-autoroll
3339649321
Roll Skia from 88449344d36d to 60c660ecdf0a (1 revision) ( flutter/engine#54323 )
...
https://skia.googlesource.com/skia.git/+log/88449344d36d..60c660ecdf0a
2024-08-02 danieldilan@google.com This is my first commit
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC brianosman@google.com ,jacksongardner@google.com,johnstiles@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2024-08-02 21:29:19 +00:00
