Taha Tesser
12659f2a7b
Fix MultiChildLayoutDelegate.hasChild
doc ( #126433 )
...
fixes https://github.com/flutter/flutter/issues/115898
`hasChild` checks `_idToChild` map. `_idToChild` is not assigned until `_callPerformLayout` is called.
So `hasChild` shouldn't be called in `getSize`.
df789c9e76/packages/flutter/lib/src/rendering/custom_layout.dart (L400-L404)
Updated docs and example class names.
2023-05-11 14:59:07 +00:00
Michael Goderbauer
58454e9e31
Remove dead code ( #126266 )
...
Dead code was flagged by `unreachable_from_main` lint, which is still experimental and not ready to be enabled yet.
2023-05-09 15:47:16 +00:00
Yu
e11a2213e2
[Refactor] Fix style in example ( #126191 )
...
Replaces #125616
I just fixed "IMAGES" to "images" in examples/image_list.
Currently, "PREFER uses the lower case of the constant name ".
2023-05-08 18:57:06 +00:00
Pierre-Louis
65dfb555c0
Update packages ( #126140 )
...
In particular, update pin for `material_color_utilities` to `0.5.0`.
2023-05-08 09:51:28 +02:00
Loïc Sharma
a47a754539
Add Windows and Linux support to the 'layers' example ( #126105 )
...
Enables running the `layers` example on Linux and Windows.
Part of https://github.com/flutter/flutter/issues/126033
2023-05-06 00:45:19 +00:00
Istiak Ahmed
042eaf6b90
Add sample code for SliverAppBar ( #125785 )
...
This PR adds an another example for SliverAppBar, showing the use of stretch and onStretchTrigger
https://user-images.githubusercontent.com/68919043/235420973-2bfb9871-9e05-4d87-9538-941d43178c76.mp4
Fixes #125651
### Adds sample code for SliverAppBar [stretch, onStretchTrigger]
This PR adds an another simple and easily understandable example code for SliverAppBar.
2023-05-05 18:09:25 +00:00
Bruno Leroux
de2615462c
Add a ReorderableListView example with cards + cleanup existing tests ( #126155 )
...
## Description
This PR adds one `ReorderableListView` example to demonstrate how `proxyDecorator` can be used to animate cards elevation.
https://user-images.githubusercontent.com/840911/236468570-d2b33ab3-6b6d-4f8d-90de-778dcf1ad8ce.mp4
For motivation, see https://github.com/flutter/flutter/issues/124729#issuecomment-1521524190 .
## Related Issue
Fixes https://github.com/flutter/flutter/issues/124729
## Tests
Adds 1 tests.
This PR also moves some misplaced example tests from `examples/api/test/reorderable_list` to `examples/api/test/material/reorderable_list` (and replaces two existing ones).
2023-05-05 16:39:11 +00:00
Yu
ce32282c0c
Fix typo in README.md ( #126053 )
2023-05-04 14:58:17 +02:00
Jenn Magder
1861ac470a
Migrate Xcode projects last version checks to Xcode 14.3 ( #125827 )
...
1. Add iOS and macOS migration to mark "last upgraded" Xcode version to 14.3 to prevent `Update to recommended settings` warning.
2. Update iOS and macOS templates to same.
3. Update iOS template to set `BuildIndependentTargetsInParallel` to YES as suggested. I didn't add a migration for this since it seems like a minor optimization and I don't think it's worth a potentially botched/corrupted migration.
4. Run all example/integration test project to see migrator work.
5. Add some missing test projects to the build shard since I noticed they were missing and I had to build those manually outside `SHARD=build_tests`.
Fixes https://github.com/flutter/flutter/issues/125817
See https://github.com/flutter/flutter/pull/90304 for Xcode 13 example.
2023-05-02 00:06:33 +00:00
Tae Hyung Kim
1a0b03cb25
Sliver Cross Axis Group ( #123862 )
...
This widget implements the ability to place slivers side by side in a single ScrollView so that they scroll together. The design document for `SliverCrossAxisGroup` can be found [here](https://docs.google.com/document/d/1e2bdLSYV_Dq2h8aHpF8mda67aOmZocPiMyjCcTTZhTg/edit?resourcekey=0-Xj2X2XA3CAFae22Sv3hAiA ).
Fixes #56756 .
2023-04-28 23:41:58 +00:00
yaakovschectman
7d37f2a616
Opt into CMake policy CMP0135 ( #125502 )
...
~Update the windows app template and migration to use `CMP0135` when
cmake version is >= 3.24.~
Update app templates' and examples' CMakeLists.txt to use
`cmake_policy(VERSION`. https://github.com/flutter/packages/pull/3828
should obviate the need for a migration.
Addresses https://github.com/flutter/flutter/issues/116866
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-28 17:49:54 -04:00
Flutter GitHub Bot
73a343f191
Roll pub packages ( #125698 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 19:30:06 +00:00
Flutter GitHub Bot
888b208d62
Roll pub packages ( #125447 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-28 17:31:45 +00:00
Tae Hyung Kim
482d1aaf13
Sliver Constrained Cross Axis ( #125239 )
...
Reimplements what we reverted here: #125233 .
2023-04-24 23:17:36 +00:00
Nate Bosch
dcfd35f8a7
Remove uses of deprecated test_api imports ( #124732 )
...
Most of these imports were never appropriate. The `test_api` package was never intended for use in `_test.dart` files.
Where possible move imports to `matcher`, otherwise move them to `test` or `flutter_test`.
Leave uses of `test_api` from `flutter_test` library code.
2023-04-20 20:55:28 +00:00
Tae Hyung Kim
9caabdd220
Revert "Sliver Constrained Cross Axis" ( #125233 )
...
Going to make some changes to the implementation so I'll revert in the meantime.
Reverts flutter/flutter#124337
2023-04-20 18:47:50 +00:00
Flutter GitHub Bot
d85e2fb810
Roll pub packages ( #125225 )
...
This PR was generated by `flutter update-packages --force-upgrade`.
2023-04-20 18:28:10 +00:00
Bartek Pacia
51251f2e57
Refactor Flutter Gradle Plugin so it can be applied using the declarative plugins {}
block ( #123511 )
...
This PR aims to resolve #121552 .
Resources used:
- [Developing Plugins](https://docs.gradle.org/current/userguide/custom_plugins.html )
- [Using Gradle Plugins](https://docs.gradle.org/current/userguide/plugins.html#sec:plugins_block )
- [Composite Builds Plugin Development Sample](https://docs.gradle.org/current/samples/sample_composite_builds_plugin_development.html )
This PR also paves way for #121541 , because apps will no longer have:
```groovy
apply from: "$flutterRoot/packages/flutter_tools/gradle/flutter.gradle"
```
hardcoded. Instead, they'll use:
```groovy
plugins {
// ...
id "dev.flutter.flutter-gradle-plugin" // the exact name is tentative
}
```
2023-04-19 17:56:22 +00:00
Mitchell Goodwin
bd2617ecb9
Adaptive alert dialog ( #124336 )
...
Fixes #102811 . Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog.
<img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png ">
<img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png ">
2023-04-18 23:00:03 +00:00
htoor3
cb90ae4d97
[web] - Clean up skipped tests ( #124981 )
...
Fixes https://github.com/flutter/flutter/issues/124174
Fixes https://github.com/flutter/flutter/issues/124980
2023-04-18 19:31:18 +00:00
Qun Cheng
6e85113418
Add an example for SearchBar ( #124992 )
...
This PR is to:
* Update API doc for `SearchBar`.
* Add an example to show how to use a `SearchBar` as the builder of the `SearchAnchor`.
2023-04-17 23:23:57 +00:00
chunhtai
cc9ffd3f3b
SelectionContainer's listeners can remove itself during listener call… ( #124624 )
...
When swapping out delegate of selectioncontainer, if the newly passed in delegate doesn't have any selectable content(which is usually the case), the selectioncontainerstate will notify all of the listeners. One of the listener would be SelectionRegistrant._updateSelectionRegistrarSubscription, and since it doesn't have content, it would remove itself from the listener which causes concurrent modification
2023-04-17 23:19:11 +00:00
Flutter GitHub Bot
d300b86e80
Roll pub packages ( #124709 )
...
Roll pub packages
2023-04-13 20:54:52 +00:00
Zachary Anderson
cc2a045c5a
Revert "[integration_test] upgrade androidx test to 1.4.0" ( #124644 )
...
Reverts flutter/flutter#122437
This is causing several Android devicelab tests to fail on the first
attempt, causing them to be marked flaky. The cause appears to be
unexpected output on stderr. See:
https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_arm64_android%20run_release_test/5390/overview
2023-04-11 18:54:59 -07:00
Micael Cid
4a83fa0fe9
[integration_test] upgrade androidx test to 1.4.0 ( #122437 )
...
[integration_test] upgrade androidx test to 1.4.0
2023-04-11 22:22:03 +00:00
Tae Hyung Kim
3c18f57480
Sliver Constrained Cross Axis ( #124337 )
...
Sliver Constrained Cross Axis
2023-04-10 21:15:48 +00:00
Eilidh Southren
0f5e513ba8
Update MCU version ( #124512 )
...
Update MCU version
2023-04-10 16:44:26 +00:00
Flutter GitHub Bot
cc4b455521
Roll pub packages ( #124364 )
...
Roll pub packages
2023-04-07 17:19:24 +00:00
Ian Hickson
806c1f8186
Deprecate these old APIs ( #116793 )
...
Deprecate these old APIs
2023-04-06 19:53:50 +00:00
htoor3
68ed603bf2
[web] Skip temporarily broken test ( #124160 )
...
[web] Skip temporarily broken test
2023-04-05 22:58:56 +00:00
Loïc Sharma
6058e95919
Add CallbackShortcuts example ( #123944 )
...
Add CallbackShortcuts example
2023-04-05 22:17:59 +00:00
Chris Bracken
e5fc6f65b9
[macOS] Remigrate principal class to NSApplication ( #124173 )
...
In #122336 we migrated the principal class from NSApplication to
FlutterApplication in the app Info.plist. We removed the need for
FlutterApplication in https://github.com/flutter/engine/pull/40929 . This
reverses the migration for anyone who previously upgraded on the Flutter
master branch.
Issue: https://github.com/flutter/flutter/issues/30735
## Pre-launch Checklist
- [X] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [X] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [X] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [X] I signed the [CLA].
- [X] I listed at least one issue that this PR fixes in the description
above.
- [X] I updated/added relevant documentation (doc comments with `///`).
- [X] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [X] All existing and new tests are passing.
If you need help, consider asking for advice on the #hackers-new channel
on [Discord].
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
2023-04-05 09:05:37 -07:00
Greg Spencer
e3bc8efd39
Rename Sample classes ( #124080 )
...
Rename Sample classes
2023-04-04 20:34:29 +00:00
Flutter GitHub Bot
0046a25e39
Roll pub packages ( #123899 )
...
Roll pub packages
2023-04-03 16:56:56 +00:00
Kate Lovett
dd7d4b9521
Fix docs and error messages for scroll directions + sample code ( #123819 )
...
Fix docs and error messages for scroll directions + sample code
2023-03-31 23:46:59 +00:00
Danny Tuppeny
a5fc8b2bd4
Roll pub packages ( #123854 )
...
Roll pub packages
2023-03-31 16:41:18 +00:00
Mitchell Goodwin
84078c856f
Create CupertinoRadio Widget ( #123296 )
...
Create CupertinoRadio Widget
2023-03-30 15:43:36 +00:00
Greg Spencer
c26d1de4a0
Remove the networked image from the example ( #123728 )
2023-03-29 18:58:25 -07:00
Vinny
f44064991d
Modified TextField docs - Replaced 'labelText' to 'hintText' in code snippet ( #94128 )
...
Modified TextField docs - Replaced 'labelText' to 'hintText' in code snippet
2023-03-29 20:02:33 +00:00
Simon Binder
c71f1dd76b
Treat hidden IndexedStack
children as offstage for test finder ( #123129 )
...
Treat hidden `IndexedStack` children as offstage for test finder
2023-03-29 19:58:58 +00:00
Michael Goderbauer
42f61b32c5
Check cc files ( #123704 )
...
Check cc files
2023-03-29 18:40:58 +00:00
Bartek Pacia
b915f68d7a
Fix warning in flutter create
d project ("package attribute is deprecated" in AndroidManifest) ( #123426 )
...
Fix warning in `flutter create`d project ("package attribute is deprecated" in AndroidManifest)
2023-03-29 04:21:03 +00:00
Qun Cheng
0300cfa603
Create SearchAnchor
and SearchViewTheme
Widget ( #123256 )
2023-03-27 23:31:11 -07:00
Chris Bracken
99146c2050
[macOS] platform_channel sample style cleanups ( #123569 )
...
[macOS] platform_channel sample style cleanups
2023-03-28 01:36:47 +00:00
Chris Bracken
b0ad7c456e
[macOS] Eliminate explicit main window init() ( #123571 )
...
[macOS] Eliminate explicit main window init()
2023-03-28 01:35:00 +00:00
Hans Muller
59c9d4e845
Added ExpansionTileController ( #123298 )
...
Added ExpansionTileController
2023-03-24 00:51:06 +00:00
Pierre-Louis
02d5c7595b
Add support for secondary tab bar ( #122756 )
...
Add support for secondary tab bar
2023-03-23 22:49:59 +00:00
Chris Bracken
ce68d97983
[macOS] Battery check in platform_channel sample ( #123354 )
...
Adds a check for the case where a device has no battery present. The
devicelab test expects the text "No battery." in the case where a device
has no battery. This is triggered by returning an error with a
NO_BATTERY error code.
Also applies some cosmetic fixes:
* Amends a copyright notice to Flutter instead of com.example
* Deletes an unused test.
Issue: https://github.com/flutter/flutter/issues/79204
2023-03-23 15:19:10 -07:00
Flutter GitHub Bot
7b7af9f34c
roll packages ( #123339 )
...
Roll pub packages
2023-03-23 19:03:57 +00:00
Chris Bracken
674ff1573f
[macOS] Add platform_channel sample/test ( #123141 )
...
Adds a macOS implementation of the platform_channel example,
demonstrating method channels and event channels with a battery power
plugin.
Adds platform_channel_sample_test_macos macOS host test to verify the
sample works.
Issue: https://github.com/flutter/flutter/issues/79204
2023-03-23 11:56:23 -07:00