Jonah Williams
096a8ac40a
handle format error from vswhere ( #43402 )
2019-10-24 10:07:05 -07:00
Andrey Gordeev
2b272f8151
Indent Kotlin code with 4 spaces ( #43080 )
...
As stated in Kotlin Coding Conventions. Closes #42212
2019-10-24 10:06:43 -07:00
Jonah Williams
9e7b6f9500
Catch version and option skew errors from build_daemon ( #43403 )
2019-10-24 09:06:45 -07:00
Jonah Williams
2237451711
Don't eagerly call runMain when --start-paused is provided to web application ( #42144 )
2019-10-24 07:57:52 -07:00
Daniel
4c2c17986a
CupertinoDialogAction is missing super call ( #42924 )
2019-10-23 19:30:01 -07:00
Jonah Williams
c9ec26ee29
Revert "[Chip] Make sure InkResponse is in the foreground on delete for chips with background color ( #41463 )" ( #43391 )
...
This reverts commit 588275e179379c957c4b7acf5cea1d2d1f2d6ce0.
2019-10-23 18:11:47 -07:00
Per Classon
588275e179
[Chip] Make sure InkResponse is in the foreground on delete for chips with background color ( #41463 )
...
* Make sure InkResponse is visible on delete for chips with background color set
* Override computeDistanceToActualBaseline in layout builder
2019-10-23 17:55:46 -07:00
Jonah Williams
3c59e00c7a
update packages --force-upgrade ( #43366 )
2019-10-23 17:28:20 -07:00
Jonah Williams
ed36fe5ddd
Revert "Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. ( #43213 )" ( #43367 )
...
This reverts commit 900067207e50622c119639e103f77ea6e2da68ad.
2019-10-23 12:29:58 -07:00
Greg Spencer
900067207e
Add focus nodes, hover, and shortcuts to switches, checkboxes, and radio buttons. ( #43213 )
...
In order to enable keyboard navigation to more controls, I've added focus nodes to switches, checkboxes, and radio buttons. In addition, this change enables mouse hover over these controls.
- Added tests for focus, hover, and shortcut activation for Checkbox, Radio, and Switch.
2019-10-23 11:22:22 -07:00
Tianguang
320a933d9e
Fix chip ripple bug — No longer two ripples ( #42779 )
...
* Fixed chip ripple.
* Fixed chip ripple. All tests passed.
* Fix one minor detail.
* Fixed reference box.
* Playing around 2.
* Added tests for chip ripple.
* Reverting print-debugging statements
* Remove extra blank line.
* Fixed chip ripple.
* Remove commented code.
* Reconciles with upstream/master.
* Remove print-debugging statement.
* Remove empty line.
* Edit comments.
* Edit style and comments.
* Edit style.
* Fix style and capitalization.
* Return bool.
* Edit style.
* Use getMaterialBox instead of Material.of(...).
* Experiment 3.
* Revert.
* Using tester.pump instead of pumpFrames
* Delete pumpFrames.
* Edit comments.
2019-10-23 11:21:45 -07:00
Jonah Williams
4c677e4148
Extra defensive programming for pub modification time assert ( #43315 )
2019-10-22 22:05:00 -07:00
James D. Lin
83704b1d91
Make ProjectFileInvalidator.findInvalidated able to use the async FileStat.stat ( #42028 )
...
Empirical measurements indicate on the network file system we use
internally, using `FileStat.stat` on thousands of files is much
faster than using `FileStat.statSync`. (It can be slower for files
on a local SSD, however.)
Add a flag to `ProjectFileInvalidator.findInvalidated` to let it
use `FileStat.stat` instead of `FileStat.statSync` when scanning for
modified files. This can be enabled by overriding `HotRunnerConfig`.
I considered creating a separate, asynchronous version of
`findInvalidated`, but that led to more code duplication than I
liked, and it would be harder to avoid drift between the versions.
2019-10-22 20:48:23 -07:00
Taufiq Rahman
35adf72c7f
Add smallestScreenSize to android:configChanges in the Android manifest template ( #43245 )
2019-10-22 20:46:18 -07:00
Jonah Williams
016ca1a0f1
Catch io.StdinException from failure to set stdin echo/line mode ( #43225 )
2019-10-22 20:35:43 -07:00
Jonah Williams
79a985f9fd
Add compiler configuration to support dartdevc target ( #43281 )
2019-10-22 20:35:05 -07:00
Jonah Williams
c896ab74a6
skip failing web test to make build green( #43296 )
2019-10-22 16:55:48 -07:00
Albertus Angga Raharja
6c04a2a1bd
Properly throw error when CupertinoPageRoute builder returns null ( #42602 )
2019-10-22 14:24:29 -07:00
Jonah Williams
8cac409d90
Clarify hot restart behavior on the web ( #42931 )
2019-10-22 12:36:56 -07:00
Shi-Hao Hong
56f9c950d8
ButtonBar aligns in column when it overflows horizontally ( #43193 )
...
* Custom layout for ButtonBar column when it overflows horizontally
2019-10-22 12:12:10 -07:00
Shi-Hao Hong
547b86a91f
[Android 10] Activity zoom transition ( #41935 )
...
* Android 10 zoom transition
2019-10-22 12:09:03 -07:00
Jonah Williams
46ea99122b
Revert "Extra defensive programming for pub modification time assert ( #42491 )" ( #43235 )
...
This reverts commit 3597bae6a0b15c446afd291679b0221340a1a7e2.
2019-10-21 20:54:02 -07:00
Ian Hickson
3597bae6a0
Extra defensive programming for pub modification time assert ( #42491 )
2019-10-21 20:15:20 -07:00
Kate Lovett
3a3939a7fa
Revert "Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )" ( #43227 )
...
This reverts commit 8df0d6556dd5ce5931fe79c8b177d7930d188c1f.
2019-10-21 17:31:54 -07:00
Emmanuel Garcia
e82ddc4c7a
Ensure android.enableR8 is appended to a new line ( #43187 )
2019-10-21 16:52:30 -07:00
Jonah Williams
27105cba2f
switch dart2js build to depfile, remove Source.function ( #42977 )
2019-10-21 16:46:44 -07:00
Jonah Williams
6c91a13731
Adding missing break in plugin validation check ( #43180 )
2019-10-21 16:46:07 -07:00
Kate Lovett
8df0d6556d
Skia Gold Support for Local & PreSubmit Testing in package:flutter ( #40710 )
2019-10-21 16:45:56 -07:00
Jonah Williams
31a4ff80c7
add samsungexynos7570 to list of known physical devices ( #43042 )
2019-10-21 16:45:48 -07:00
Kate Lovett
83878683c0
Re-landing SliverAnimatedList ( #42485 )
2019-10-21 16:44:55 -07:00
Jonah Williams
6db4c44da8
remove period from URL so that it opens correctly in vscode ( #43200 )
2019-10-21 16:43:11 -07:00
Tong Mu
1c535de7e0
Soften layer breakage ( #42953 )
...
* Replace hard break of Layer.find/All with findAllAnnotations
* Deprecate findAll
2019-10-18 16:40:42 -07:00
Ian Hickson
124dc6617f
Clean up test infrastructure ( #43030 )
...
See #41880 for history.
2019-10-18 16:35:39 -07:00
Edman P. Anjos
faa514fc24
Quick fix on material dialog docs ( #42968 )
2019-10-18 15:43:04 -07:00
Aditya Sharma
b6c865ff9c
Fix typo ( #42922 )
2019-10-18 15:42:28 -07:00
Jonah Williams
39e4d9d152
Expand scope of rethrown gradle errors ( #42966 )
2019-10-18 14:56:39 -07:00
Jonah Williams
6fc99e98ad
rename headless server to web server ( #42970 )
2019-10-18 12:41:47 -07:00
Jonah Williams
21be8372c9
implement debugTogglePlatform for the web ( #42951 )
2019-10-18 12:41:15 -07:00
Jonah Williams
e67f9a3f6c
ensure we can disable --track-widget-creation in debug mode ( #43016 )
2019-10-18 12:40:50 -07:00
Erick (CptBlackPixel)
12b7b08da5
Reading deviceId for RawKeyEventDataAndroid event ( #42235 )
...
This PR adds a new property on RawKeyEventDataAndroid to hold the deviceId from which that event was generated. The deviceId is been sent from the engine on the changes from this PR: flutter/engine#12958
With this, we will be able to identify from where the event came from, adding the ability to support local multiplayer games, with multiple gamepads.
2019-10-18 12:32:21 -07:00
Greg Spencer
560873af92
Wire up canRequestFocus and skipTraversal in FocusScopeNode ( #43013 )
...
This adds a canRequestFocus and skipTraversal argument to FocusScope and FocusScopeNode, so that a scope can prevent being traversed.
This allows a fix for a problem in the gallery where the focus while traversing the list of items would sometimes appear to disappear, since it would be focusing things that were in the backdrop that were part of the tree, but were not visible.
Related Issues
Fixes #42955
2019-10-18 12:31:15 -07:00
Greg Spencer
df76354488
Add a Focus node to the DropdownButton, and adds an activation action for it. ( #42811 )
...
This adds a Focus node to the DropdownButton widget, allowing it to receive keyboard focus, and to show a focus highlight. In addition, I added the ability to activate the dropdown using the "enter" key binding (which is bound to ActivateAction in the WidgetsApp).
Related Issues
Fixes #42646
Fixes #43008
Fixes #42511
2019-10-18 12:30:40 -07:00
Jonah Williams
1982a5c3ec
Revert "Clean up test infrastructure ( #41880 )" ( #42982 )
...
This reverts commit 1781d5c9bbb4a1b408e40bd40e433c3541bb68fc.
2019-10-17 19:47:16 -07:00
Ian Hickson
1781d5c9bb
Clean up test infrastructure ( #41880 )
2019-10-17 19:22:47 -07:00
Jonah Williams
863fb2f2cc
Remove linux-x64 unpack logic ( #42962 )
2019-10-17 19:22:03 -07:00
Jonah Williams
f53b32eb23
refactor depfile usage and update linux rule ( #42487 )
2019-10-17 17:42:40 -07:00
Ryan Macnak
315471bfb0
Do not produce an error when encountering a new type in a service response. ( #42972 )
...
Flutter tool's service client library tries to "upgrade" sub-components of service responses with higher level model objects. It does this for all members of the response, rather than only those documented in the version it targets, and it errors out when encountering a new type. This causes it to fail when a new field is introduced with a new typed. Clients are required to ignore this.
2019-10-17 16:56:57 -07:00
Michael Goderbauer
ddca78b4b7
Fix memory leak in TransitionRoute ( #42777 )
2019-10-17 15:51:45 -07:00
Jaumard
1faf6a9a89
create gesture recognizers on attach and dispose on detach to avoid leaks ( #42076 )
2019-10-17 15:48:20 -07:00
Jenn Magder
b194f93541
Remove use_modular_headers from Podfiles using libraries ( #42872 )
...
* Remove use_modular_headers from Podfiles using libraries
* Remove @imports
2019-10-17 15:26:10 -07:00
