firka/flutter
firka/flutter
5
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
43,316 Commits 1 Branch 0 Tags
Commit Graph

43316 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matan Lurey
a0f2154419
Allow devDependencies to be omitted and not cause a tool crash. (#158518) 
Closes https://github.com/flutter/flutter/issues/158441.
 2024-11-13 01:04:01 +00:00
Matan Lurey
72fc9b4b37
Explain how to use flutter channel. (#158533) 
Closes https://github.com/flutter/flutter/issues/152274.

I ran into https://github.com/flutter/flutter/issues/152274 myself, so seemed like an easy fix.
 2024-11-13 00:42:00 +00:00
Jenn Magder
ee586d45ad
Clean up dependabot config, add github-action group (#158408) 
1. Delete bundler and docker, these directories no longer exist and we have no Docker or Gemfiles any more.
2. Update outdated reviewer list which was blocking any reviewers from being added. https://github.com/flutter/flutter/pull/157473#issuecomment-2433542624
3. Change github action update from daily to weekly
4. Add a `group` so all github action dependencies are updated in the same PR, instead of one-per-dependency. The PR will look like:
__________

<img width="400" alt="Screenshot 2024-11-08 at 11 08 52 AM" src="https://github.com/user-attachments/assets/eebedf69-3fae-409b-9c88-c3afc8036c52">

__________

See also https://github.com/flutter/packages/pull/8044
 2024-11-13 00:38:16 +00:00
Reid Baker
638331b133
Update test to include more complete instructions for how to run tests locally, add example to andoid 11 tests as well (#158528) 
Follow @matanlurey's example and include how to run a test at the top of the test file.
 2024-11-12 22:07:55 +00:00
Christopher Fujino
8e5bd5af86
force Linux plugin_test to run on Ubuntu 20.04 (#158529) 
Work around propagation from https://github.com/flutter/flutter/issues/158521
 2024-11-12 21:22:56 +00:00
Hannah Jin
9992e9bc5c
Support materialTapTargetSize in PopupMenuButton (#158357) 
fix https://github.com/flutter/flutter/issues/128697 

PopupMenuButton can take customized child, in that case if `
widgt.style.tapTargetSize` is set to `padded`, PopupMenuButton should
support it.

if child is null, default child is an iconButton, which is already
48x48.


## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-12 12:19:46 -08:00
Loïc Sharma
003135e2d0
[SwiftPM] Update .flutter-plugin-dependencies format (#158138) 
In the future, it will be possible for Swift Package Manager to be enabled on one but not all platforms (see https://github.com/flutter/flutter/issues/151567#issuecomment-2455941279).

This updates the `.flutter-plugin-dependencies` file format to separate iOS's and macOS's SwiftPM enablement. For now, these platforms will always have the same value.

This `.flutter-plugin-dependencies` file is read by our CocoaPods scripts to determine whether we should use CocoaPods or not to inject plugins.

Part of https://github.com/flutter/flutter/issues/151567
 2024-11-12 20:01:26 +00:00
Andrew Kolos
37d80ce25f
add filesystem error handling to systemTempDirectory (#158481) 
Fixes https://github.com/flutter/flutter/issues/153777.

To summarize that issue, `ErrorHandlingFileSystem.systemTempDirectory` calls [`LocalFileSystem.systemTempDirectory`](45c8881eb2/packages/flutter_tools/lib/src/base/file_system.dart (L229)), which makes a `Directory.createSync` call, which can throw exceptions that _should_ be handled and result in a graceful tool exit (e.g. insufficient storage). However, we aren't catching those, hence this issue. 

All we need to do is wrap that call with the `FileSystemException`-handling logic we already have in the tool. See the diff.

I don't think I'll be cherry-picking this since 1) it's not an extremely common crash and 2) users can probably pick apart the crash message and figure out that they need to clear some storage space to proceed.

<details>

<summary> Pre-launch checklist </summary> 

</details>
 2024-11-12 18:14:45 +00:00
Jiten Patel
9a2e249025
Made Cupertino dialog more like a native dialog in dark mode (#157218) 
This PR addresses an issue where the `CupertinoAlertDialog` was not fully visible in dark mode. The dialog now adapts better to dark mode themes, ensuring proper contrast and readability across different UI elements. 

Fixes: #80921
 2024-11-12 17:59:48 +00:00
engine-flutter-autoroll
19411b638b
Roll Flutter Engine from b0a4ca92c49e to 877abb9ad6ff (2 revisions) (#158506) 
b0a4ca92c4...877abb9ad6

2024-11-12 skia-flutter-autoroll@skia.org Roll Skia from 75230dbc93e6 to aa099ff91e2f (3 revisions) (flutter/engine#56525)
2024-11-12 chinmaygarde@google.com [Impeller] Add OpenGL debugging utilities. (flutter/engine#56515)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jimgraham@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 16:36:54 +00:00
Taha Tesser
148be5f894
Fix NavigationBar label style customization on the widget level (#158510) 
Fixes [`NavigationBar` only allows `labelTextStyle` from `NavigationBarTheme` ](https://github.com/flutter/flutter/issues/158508)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    const TextStyle selectedTextStyle =
        TextStyle(fontSize: 15, color: Color(0xFF00FF00));
    const TextStyle unselectedTextStyle =
        TextStyle(fontSize: 15, color: Color(0xFF0000FF));
    const TextStyle disabledTextStyle =
        TextStyle(fontSize: 16, color: Color(0xFFFF0000));

    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
          navigationBarTheme: NavigationBarThemeData(
        labelTextStyle: WidgetStatePropertyAll(
          TextStyle(
            fontSize: 14,
            fontWeight: FontWeight.bold,
            color: Theme.of(context).colorScheme.primary,
          ),
        ),
      )),
      home: Scaffold(
        appBar: AppBar(
          title: const Text('NavigationBar Sample'),
        ),
        body: Center(
          child: Padding(
            padding: const EdgeInsets.all(16.0),
            child: Text(
              "NavigationBar labels are customized using NavigationBar.labelTextStyle",
              style: Theme.of(context).textTheme.headlineSmall,
              textAlign: TextAlign.center,
            ),
          ),
        ),
        bottomNavigationBar: NavigationBar(
          labelTextStyle: const WidgetStateProperty<TextStyle?>.fromMap(
            <WidgetStatesConstraint, TextStyle?>{
              WidgetState.disabled: disabledTextStyle,
              WidgetState.selected: selectedTextStyle,
              WidgetState.any: unselectedTextStyle,
            },
          ),
          onDestinationSelected: null,
          destinations: const <Widget>[
            NavigationDestination(
              icon: Icon(Icons.home),
              label: 'Home',
            ),
            NavigationDestination(
              icon: Icon(Icons.favorite_rounded),
              label: 'Favorites',
            ),
            NavigationDestination(
              enabled: false,
              icon: Icon(Icons.settings),
              label: 'Settings',
            ),
          ],
        ),
      ),
    );
  }
}
```

</details>

### Preview

<img width="719" alt="Screenshot 2024-11-12 at 17 18 00" src="https://github.com/user-attachments/assets/2b489bfa-78a3-4766-bc22-9273d76eadcd">
 2024-11-12 16:33:51 +00:00
auto-submit[bot]
423aa2ac74
Reverts "Add test for dynamic_content_color.0.dart (#158309)" (#158511) 
Reverts: flutter/flutter#158309
Initiated by: bleroux
Reason for reverting: added test is failing on CI

Original PR Author: ValentinVignal

Reviewed By: {bleroux}

This change reverts the following previous change:
Fixes https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`
 2024-11-12 16:05:17 +00:00
Valentin Vignal
95a9b97f88
Add test for dynamic_content_color.0.dart (#158309) 
Fixes https://github.com/flutter/flutter/issues/130459

It adds a test for
- `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`
 2024-11-12 11:49:24 +00:00
engine-flutter-autoroll
3770a10180
Roll Flutter Engine from a672f971c659 to b0a4ca92c49e (2 revisions) (#158488) 
a672f971c6...b0a4ca92c4

2024-11-12 robert.ancell@canonical.com Add FlPointerManager to process pointer events from GTK in a form suitable for Flutter. (flutter/engine#56443)
2024-11-12 skia-flutter-autoroll@skia.org Roll Skia from 11046fd10394 to 75230dbc93e6 (1 revision) (flutter/engine#56517)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 03:16:33 +00:00
engine-flutter-autoroll
9ba6e944d2
Roll Flutter Engine from 35041f118744 to a672f971c659 (1 revision) (#158487) 
35041f1187...a672f971c6

2024-11-11 magder@google.com Add dependabot github-actions group (flutter/engine#56468)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 02:13:10 +00:00
engine-flutter-autoroll
722c395dcb
Roll Flutter Engine from 7b3eacd20eb6 to 35041f118744 (9 revisions) (#158485) 
7b3eacd20e...35041f1187

2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from a393f3ed040a to 69170fac244c (1 revision) (flutter/engine#56513)
2024-11-11 chris@bracken.jp iOS,macOS: Refactor TestMetalContext for ARC (flutter/engine#56510)
2024-11-11 jonahwilliams@google.com [Impeller] geometry changes to support line/point style. (flutter/engine#56340)
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from af6a4f9a85ee to 11046fd10394 (9 revisions) (flutter/engine#56508)
2024-11-11 jonahwilliams@google.com [Impeller] dont unnecessarily copy point data out of display list. (flutter/engine#56492)
2024-11-11 jonahwilliams@google.com [Impeller] fix line/polygon depth and GLES scissor state. (flutter/engine#56494)
2024-11-11 jason-simmons@users.noreply.github.com Do not stop flutter_tester if microtasks are still pending (flutter/engine#56432)
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 261316c10484 to af6a4f9a85ee (5 revisions) (flutter/engine#56505)
2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from 4ea43aa234a4 to a393f3ed040a (1 revision) (flutter/engine#56506)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-12 01:16:42 +00:00
Loïc Sharma
563fb0c743
[SwiftPM] Simplify logic that determines if CocoaPods is used (#158409) 
This is a refactoring with no semantic changes. I will get a text exemption.

Part of https://github.com/flutter/flutter/issues/151567
 2024-11-11 21:03:30 +00:00
Taha Tesser
68fa653e59
Fix Chip draws InkWell.hoverColor is drawn on top of the provided background color with hovered state (#158454) 
Fixes [Setting hoverColor on ThemeData breaks Chip hover functionality](https://github.com/flutter/flutter/issues/157622)

### Description

The bug is caused by `InkWell.hoverColor`. When `ThemeData.hoverColor` is provided, its drawn on top. To fix this, we can override `InkWell.hoverColor` when Chip state color is provided.

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() => runApp(const MyApp());

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
        hoverColor: const Color(0xFFFF0000),
      ),
      home: Scaffold(
        body: Center(
            child: RawChip(
          color: WidgetStateProperty.resolveWith((states) {
            if (states.contains(WidgetState.hovered)) {
              return const Color(0xFF00fF00);
            }

            return const Color(0xFF0000FF);
          }),
          label: const Text('RawChip'),
          onPressed: () {},
        )),
      ),
    );
  }
}
```

</details>

### Before

https://github.com/user-attachments/assets/f8974af6-5af3-4d7d-9dbe-65bf170d5fa3

### After

https://github.com/user-attachments/assets/89a5315c-c7bd-4456-8594-e2092e43952d
 2024-11-11 19:48:32 +00:00
engine-flutter-autoroll
c36ad608da
Roll Flutter Engine from 3cb6f4de89b6 to 7b3eacd20eb6 (1 revision) (#158464) 
3cb6f4de89...7b3eacd20e

2024-11-11 robert.ancell@canonical.com Remove unused FlMockTextInputHandler (flutter/engine#56495)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 19:16:23 +00:00
engine-flutter-autoroll
14e0e580b4
Roll Packages from bb5a25815cae to 72356fda4684 (8 revisions) (#158378) 
bb5a25815c...72356fda46

2024-11-08 stuartmorgan@google.com [various] Update example app minSdkVersions (flutter/packages#8035)
2024-11-07 32538273+ValentinVignal@users.noreply.github.com [go_router] Activate leak testing (flutter/packages#7546)
2024-11-07 louisehsu@google.com [in_app_purchase_storekit] Add restore purchases and receipts (flutter/packages#7964)
2024-11-07 10687576+bparrishMines@users.noreply.github.com [interactive_media_ads] Adds remaining methods for internal wrapper of the Android native `BaseManager` (flutter/packages#7943)
2024-11-07 58529443+srujzs@users.noreply.github.com [google_sign_in/google_identity_services] Clear-up documentation of callbacks in various APIs and uses of those APIs (flutter/packages#8029)
2024-11-07 alex@mariuti.com [flutter_svg] wasm compatibility (flutter/packages#8014)
2024-11-06 jessiewong401@gmail.com Applied Gradle Plugins Declaratively for Multiple Plugin Example Apps (Part 2) (flutter/packages#8019)
2024-11-06 engine-flutter-autoroll@skia.org Roll Flutter from 29d40f7f6826 to 73546b3b71a7 (20 revisions) (flutter/packages#8028)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 18:44:16 +00:00
engine-flutter-autoroll
4152ca43c2
Roll Flutter Engine from e9a44820f302 to 3cb6f4de89b6 (3 revisions) (#158456) 
e9a44820f3...3cb6f4de89

2024-11-11 mdebbar@google.com [web] Bump Firefox version to 132.0 (flutter/engine#56435)
2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from cde0e0dc084a to 4ea43aa234a4 (1 revision) (flutter/engine#56502)
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 676b3b1a41be to 261316c10484 (1 revision) (flutter/engine#56503)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 16:45:30 +00:00
Ben Konyi
d89e65d516
Replace custom RPCErrorCodes with RPCErrorKind from package:vm_service (#158379) 
Removes duplicated constants and ensures consistency by using package:vm_service as a source of truth for RPC error codes for requests made with package:vm_service.
 2024-11-11 15:18:09 +00:00
engine-flutter-autoroll
232706616a
Roll Flutter Engine from d90e9f4718b8 to e9a44820f302 (1 revision) (#158453) 
d90e9f4718...e9a44820f3

2024-11-11 skia-flutter-autoroll@skia.org Roll Dart SDK from ed9a5b1110ae to cde0e0dc084a (6 revisions) (flutter/engine#56500)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 14:36:26 +00:00
engine-flutter-autoroll
461ad0d3e0
Roll Flutter Engine from 01c76e42c20f to d90e9f4718b8 (1 revision) (#158443) 
01c76e42c2...d90e9f4718

2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 3333292a62c1 to 676b3b1a41be (2 revisions) (flutter/engine#56499)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 09:44:04 +00:00
engine-flutter-autoroll
5fd650f68b
Roll Flutter Engine from 9b4c3b3d5518 to 01c76e42c20f (3 revisions) (#158438) 
9b4c3b3d55...01c76e42c2

2024-11-11 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from TZVo85tD5mpzhcafg... to BajfrJuYeyWvnBhuM... (flutter/engine#56497)
2024-11-11 skia-flutter-autoroll@skia.org Roll Skia from 778b21720a61 to 3333292a62c1 (7 revisions) (flutter/engine#56496)
2024-11-10 chris@bracken.jp fml: Improve CFTest.SupportsCustomRetainRelease test (flutter/engine#56480)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from TZVo85tD5mpz to BajfrJuYeyWv

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-11 04:02:25 +00:00
Younghan Kim
18071ec0a8
Remove block and line comments when detecting '.flutter-plugins' in settings.gradle(.kts) (#155488) 
**PR Title:**

Remove block and line comments when detecting `'.flutter-plugins'` in `settings.gradle`

---

**Description:**

This PR modifies the `configureLegacyPluginEachProjects` function to remove block (`/* ... */`) and line (`// ...`) comments from the `settings.gradle` or `settings.gradle.kts` file content before checking for the presence of the `'.flutter-plugins'` string. This ensures that only uncommented, meaningful code is considered during the detection, preventing false positives when the string appears within comments.

**Why is this change necessary?**

In some cases, the `'.flutter-plugins'` string may be present inside comments in the `settings.gradle` file. The existing implementation does not account for this and may incorrectly detect the string even when it's commented out. This can lead to unintended behavior, such as configuring plugin projects when it is not necessary.

By removing comments before performing the check, we prevent false positives and ensure that the detection logic is accurate, only acting when the `'.flutter-plugins'` string is present in active code.

**Changes Made:**

- **Added comment removal logic:**
  - Removed block comments (`/* ... */`) using the regular expression `/(?s)\/\*.*?\*\//`.
    - The `(?s)` flag enables dot-all mode, allowing `.` to match newline characters.
  - Removed line comments (`// ...`) using the regular expression `/(?m)\/\/.*$`.
    - The `(?m)` flag enables multi-line mode, so `^` and `$` match the start and end of each line.
  - Combined both comment removal steps into a single chain for efficiency.

- **Updated the string detection:**
  - The check for `'.flutter-plugins'` is now performed on the uncommented content of the `settings.gradle` file.
  - This ensures that only meaningful, uncommented code is considered during detection.

**Issue Fixed:**

- Fixes [#155484](https://github.com/flutter/flutter/issues/155484)

---

---

If you need any further assistance or have questions, feel free to reach out!

---

**Links:**

- [Contributor Guide]
- [Tree Hygiene]
- [Flutter Style Guide]
- [Features we expect every widget to implement]
- [CLA]
- [flutter/tests]
- [breaking change policy]
- [Discord]
- [Data Driven Fixes]
 2024-11-11 02:47:32 +00:00
Nate Wilson
1eaf1f9525
Add SafeArea DartPad sample (#158019) 
Follow-up from #157228
 2024-11-11 01:00:21 +00:00
Flutter GitHub Bot
f04b0f4b9e
Marks Linux analyzer_benchmark to be flaky (#158244) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Linux analyzer_benchmark"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158243
 2024-11-10 22:30:39 +00:00
Andrew Kolos
c9eb4ae9cc
remove bringup status for recently re-subsharded targets (#158217) 
Cleans up https://github.com/flutter/flutter/pull/158196 and https://github.com/flutter/flutter/pull/158146

<details>

<summary> Pre-launch checklist </summary> 

</details>
 2024-11-10 21:49:24 +00:00
engine-flutter-autoroll
286eb1303c
Roll Flutter Engine from 690cdfd09beb to 9b4c3b3d5518 (1 revision) (#158418) 
690cdfd09b...9b4c3b3d55

2024-11-09 jason-simmons@users.noreply.github.com Remove the unsafe_html analysis rule (flutter/engine#56479)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 22:03:26 +00:00
Flutter GitHub Bot
893a0c8fcd
Marks Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary to be flaky (#158252) 
<!-- meta-tags: To be used by the automation script only, DO NOT MODIFY.
{
  "name": "Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary"
}
-->
Issue link: https://github.com/flutter/flutter/issues/158251
 2024-11-09 19:45:40 +00:00
engine-flutter-autoroll
fca4f88b95
Roll Flutter Engine from ca6f5110d9d3 to 690cdfd09beb (1 revision) (#158414) 
ca6f5110d9...690cdfd09b

2024-11-09 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from aLUsXLv5iMZFOgcAS... to TZVo85tD5mpzhcafg... (flutter/engine#56478)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from aLUsXLv5iMZF to TZVo85tD5mpz

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 16:09:23 +00:00
engine-flutter-autoroll
995ff31bbd
Roll Flutter Engine from 2f097cfd3d2d to ca6f5110d9d3 (3 revisions) (#158411) 
2f097cfd3d...ca6f5110d9

2024-11-09 chris@bracken.jp iOS: Use fml::CFRef in place of Scoped (flutter/engine#56463)
2024-11-09 skia-flutter-autoroll@skia.org Roll Dart SDK from 307869c696e8 to ed9a5b1110ae (2 revisions) (flutter/engine#56465)
2024-11-08 chris@bracken.jp fml: delete unused scoped_policy (flutter/engine#56462)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 03:07:32 +00:00
engine-flutter-autoroll
bf1fac785e
Roll Flutter Engine from 54df0b8a4784 to 2f097cfd3d2d (1 revision) (#158407) 
54df0b8a47...2f097cfd3d

2024-11-08 a-siva@users.noreply.github.com Manual roll Dart SDK from cfa1826c3df1 to 307869c696e8 (1 revision) (flutter/engine#56460)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-09 00:16:06 +00:00
engine-flutter-autoroll
d8334d53d7
Roll Flutter Engine from b7134d373ef8 to 54df0b8a4784 (2 revisions) (#158405) 
b7134d373e...54df0b8a47

2024-11-08 rosscomputerguy@protonmail.com [Linux] Replace deprecated macros in fl_application_test.cc (flutter/engine#56257)
2024-11-08 jonahwilliams@google.com [iOS] fix tracking of previous platform views. (flutter/engine#56461)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 23:22:12 +00:00
engine-flutter-autoroll
fdbfbca12a
Roll Flutter Engine from 6b77347edfc5 to b7134d373ef8 (3 revisions) (#158402) 
6b77347edf...b7134d373e

2024-11-08 chris@bracken.jp fml: Use CFRef where possible and add docs (flutter/engine#56436)
2024-11-08 mdebbar@google.com [web] Split all 1MB+ fallback fonts (including CJK) (flutter/engine#56388)
2024-11-08 chris@bracken.jp yapf: Add more detailed error message and TODO (flutter/engine#56458)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 22:28:24 +00:00
engine-flutter-autoroll
d6918a48d3
Roll Flutter Engine from 1b567e80386e to 6b77347edfc5 (4 revisions) (#158398) 
1b567e8038...6b77347edf

2024-11-08 chris@bracken.jp Add FlutterTaskRunnerDescription.destruction_callback (flutter/engine#56445)
2024-11-08 skia-flutter-autoroll@skia.org Roll Skia from d0ee80612f86 to 778b21720a61 (5 revisions) (flutter/engine#56457)
2024-11-08 skia-flutter-autoroll@skia.org Manual roll Dart SDK from 50c620224f27 to cfa1826c3df1 (2 revisions) (flutter/engine#56456)
2024-11-08 flar@google.com [Impeller] Switch to uniform arrays for gradient data on non-SSBO hardware (flutter/engine#56441)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 21:43:05 +00:00
engine-flutter-autoroll
2efdc74792
Roll Flutter Engine from a08bd5a07c2a to 1b567e80386e (1 revision) (#158393) 
a08bd5a07c...1b567e8038

2024-11-08 jason-simmons@users.noreply.github.com In the embedder Impeller render target, use a multisample texture for the depth buffer only if MSAA is supported (flutter/engine#56444)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 19:55:12 +00:00
André Stein
1511370a92
[TextInput] Add TextInputType.webSearch (#15762) (#158323) 
This PR  adds `TextInputType.webSearch` that allows to show a keyboard with ready access to a "." key on iOS. On Android this is re-mapped to `url` which shows the same behaviour as `webSearch` on iOS. This fixes issue #157562.

There also is a [corresponding *engine* PR](https://github.com/flutter/engine/pull/56428).

Screenshot from iOS demo app:

![image](https://github.com/user-attachments/assets/94d48752-4cfe-4113-acf9-b3a981952dc7)
 2024-11-08 18:26:05 +00:00
Phil Quitslund
e222381e29
remove redundant arguments (#158349) 
An upcoming fix to the analyzer will (correctly) catch these args as
redundant
(https://dart-review.googlesource.com/c/sdk/+/394004/2/pkg/analyzer/lib/src/dart/ast/ast.dart).

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
 2024-11-08 09:30:26 -08:00
engine-flutter-autoroll
c8510f29cc
Roll Flutter Engine from 44d788f4651b to a08bd5a07c2a (3 revisions) (#158375) 
44d788f465...a08bd5a07c

2024-11-08 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from pG2aukmcwvp71aKuS... to aLUsXLv5iMZFOgcAS... (flutter/engine#56450)
2024-11-08 skia-flutter-autoroll@skia.org Roll Skia from 7ae36ecfe93d to d0ee80612f86 (2 revisions) (flutter/engine#56448)
2024-11-08 codefu@google.com Move off deprecated upload-artifactv3 (flutter/engine#56439)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from pG2aukmcwvp7 to aLUsXLv5iMZF

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 15:32:29 +00:00
Taha Tesser
7abb083ae2
Add ability to override NavigationDestination.label padding for NavigationBar (#158260) 
Fixes [Long NavigationBar tab titles can't be padded from the sides of the screen](https://github.com/flutter/flutter/issues/158130)

### Code sample

<details>
<summary>expand to view the code sample</summary> 

```dart
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      debugShowCheckedModeBanner: false,
      theme: ThemeData(
          navigationBarTheme: const NavigationBarThemeData(
        labelTextStyle:
            WidgetStatePropertyAll(TextStyle(overflow: TextOverflow.ellipsis)),
        labelPadding: EdgeInsets.symmetric(horizontal: 16, vertical: 4),
      )),
      home: Scaffold(
        body: Center(
          child: Text(
            'Custom NavigationBar label padding',
            style: Theme.of(context).textTheme.titleMedium,
          ),
        ),
        bottomNavigationBar: NavigationBar(
          destinations: const [
            NavigationDestination(
              icon: Icon(Icons.favorite_rounded),
              label: 'Long Label Text',
            ),
            NavigationDestination(
              // icon: SizedBox.shrink(),
              icon: Icon(Icons.favorite_rounded),
              label: 'Long Label Text',
            ),
            NavigationDestination(
              icon: Icon(Icons.favorite_rounded),
              label: 'Long Label Text',
            ),
          ],
        ),
      ),
    );
  }
}

```

</details>

### Default `NavigationDestination.label` padding  with long label

<img width="458" alt="Screenshot 2024-11-06 at 14 30 52" src="https://github.com/user-attachments/assets/637e5e66-e05f-49fa-a4ae-72083b6ff884">

### Custom `NavigationDestination.label` padding with long label

<img width="458" alt="Screenshot 2024-11-06 at 14 32 02" src="https://github.com/user-attachments/assets/23ebf715-30d3-433c-92cd-c8f0fdb1571b">
 2024-11-08 14:19:18 +00:00
stuartmorgan
2afadc2cdf
Add flutter/package code generation instructions (#158326) 
Adds general instructions for updating generated code in
flutter/packages, covering the common cases of Pigeon and Mockito
generation.

Fixes https://github.com/flutter/flutter/issues/158321
 2024-11-08 08:17:07 -05:00
engine-flutter-autoroll
0059575b18
Roll Flutter Engine from 8e19915c19fc to 44d788f4651b (3 revisions) (#158362) 
8e19915c19...44d788f465

2024-11-08 jonahwilliams@google.com [Impeller] Add support for ImageFilter.shader (flutter/engine#53490)
2024-11-07 skia-flutter-autoroll@skia.org Roll Skia from 2ed9606702f1 to 7ae36ecfe93d (4 revisions) (flutter/engine#56442)
2024-11-07 skia-flutter-autoroll@skia.org Roll Dart SDK from 6a3684b96121 to 50c620224f27 (1 revision) (flutter/engine#56438)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 02:47:31 +00:00
engine-flutter-autoroll
710fe2bdf4
Roll Flutter Engine from bcb281cde579 to 8e19915c19fc (4 revisions) (#158354) 
bcb281cde5...8e19915c19

2024-11-07 skia-flutter-autoroll@skia.org Roll Skia from e9a7546ef3d9 to 2ed9606702f1 (1 revision) (flutter/engine#56434)
2024-11-07 jason-simmons@users.noreply.github.com [Impeller] Use Matrix::MakeTranslateScale to compute the source-to-destination mapping in DrawImageRect (flutter/engine#56433)
2024-11-07 chris@bracken.jp iOS: Eliminate ScopedBlock, ScopedTypeRef, ScopedPolicy (flutter/engine#56410)
2024-11-07 jacksongardner@google.com [skwasm] Make sure to include the transfer list when using postMessage. (flutter/engine#56431)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
 2024-11-08 00:26:24 +00:00
Renzo Olivares
97eef6afc5
Make _SelectableRegionSelectionContainerDelegate public (#147080) 
This change makes `_SelectableRegionContainerDelegate` public so it can be reused and extended by users of `SelectionContainer`. Extending `MultiSelectableRegionContainerDelegate` does not by default provide selection managing across multiple selectables, so often users will copy the implementation found in `_SelectableRegionContainerDelegate`.

`_SelectableRegionContainerDelegate` -> `StaticSelectionContainerDelegate`.
 2024-11-07 23:00:52 +00:00
Jason Simmons
8461ceea43
Manual roll Flutter Engine from 371c86fb6b49 to bcb281cde579 (#158346) 
Includes changes required by the new Dart formatter.
 2024-11-07 22:39:19 +00:00
Kate Lovett
777ce1b0da
Add clarification on review timelines in PR template (#158345) 
Adds a reference to tree hygiene to help clarify expectations for review timelines.
 2024-11-07 22:13:46 +00:00
Ben Konyi
998f42a3f0
Increase Java heap limit to 8GB for plugin integration tests using deferred components (#158330) 
Should help resolve https://github.com/flutter/flutter/issues/156953
 2024-11-07 15:24:25 -05:00
flutter-pub-roller-bot
dff06fde60
Roll pub packages (#158337) 
This PR was generated by `flutter update-packages --force-upgrade`.
 2024-11-07 20:15:01 +00:00